From nobody Thu Apr 2 22:09:03 2026 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D53243375AE for ; Thu, 12 Feb 2026 23:14:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770938081; cv=none; b=GKjv5bzsXCmNvp2lklTiXqTpn+ADkTM5f4a4dgoHj9vxwX6PmQbCyKE9Vt7gqM7305oErLJjKg6+FmBzh5Zzq3i5GLSs93notPV6iIHBSmv0L+LeUSGLCf2JdswMq7g3Yn3PtQAaLTnbOkID+PELPGEI5DyR3qqNI+A7rVwge4E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770938081; c=relaxed/simple; bh=8PzBjb1BC5IXRuE5/L3hohJrpfpYHnZMV57JAQRQuYc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IXYlwyEtaZshBzfnYZr4nqdIhE0W/w8d7hL8xFln4zzF+cb0oJ9Q9fzFt1z3TcRImH13YGnVVAoSwFZgP5/v88EZGzzJwFKR4dFR9K5NA2l6BADv3kd3Rhe2YpvOV8FKE4+heJVE/AL+tmpd7OK9nnosiw05/zwPiqaC+rQvnto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=zetier.com; spf=pass smtp.mailfrom=zetier.com; dkim=pass (2048-bit key) header.d=zetier.com header.i=@zetier.com header.b=VJjlENBy; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=zetier.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zetier.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=zetier.com header.i=@zetier.com header.b="VJjlENBy" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-8c70ce93afaso45505885a.0 for ; Thu, 12 Feb 2026 15:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zetier.com; s=gm; t=1770938079; x=1771542879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=25FG61RMxEgfldkZ2mHU1yb2uvHGCvudsNE5iAmhPxI=; b=VJjlENByO95814WM0MIiXALYOGMla1uaAap0cb6ewbpuj3EhDK6C/SAim7vzBb7s8S x7AvOx0ohz660XtPBT4JrLMBKkLyc8Njk3qr+Nmp5F8Q3jy7u4YP6yb2c7YUA6CVCq72 9XkNmXoqBLxUfKrROwMfGuqZFHC/Kdo4qk6mMFFf56c/ZWvKXRarT0KGQ/2OxDFH4GBa layX9Gh2yz3gtp8fDgw5nnhdKTe0YF/x+d6WiEfHU5kEg4FwgSRtotwCrqbRxWnz11gh IqWu+swSpc1kWhWulYH5aiu3i1qXBgLvj74VBLgcTJyqzgvs+Tp0sQHDqBkrzzG/6DcI spAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770938079; x=1771542879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=25FG61RMxEgfldkZ2mHU1yb2uvHGCvudsNE5iAmhPxI=; b=QE9QsueXnPyKwYc4F30DhG3Lm5MuADC05/5DwgzzC7SQTSZGSn5lgy/dIvOMqHbRqp xqsThIrf3wd0rxnayzeq2L2NRdjn86c3JtMw9B2vZ4bosjr3+hNrnEolisyB/becV0gg 2DKw36uDWMTjW1D7oP164xRzfMRXYBlZH1tk2f8qzDaPBAtAOqZFtVljbWOAGg7bzPWl MDgBUvE0MbDHSJVoSalIShquzdO21bsIS9+Qliwhuerif6fX1XASLZnjp3EcG9zdQYUR Q7LNkog35BLwMHeLeOMFnua1XCzEik17yxNl27r2SJOQ26V7Mz/Cb8jh6ZT+1gQrEhmj WHfw== X-Forwarded-Encrypted: i=1; AJvYcCW1KtjbMSOGMqrDLPFJ4y4UEs5/u1bWBCB0lbyUQQ3+Ay4qEKQoHp4LO9qdQ8Oo7AerzyDrMJBR/5OH+vo=@vger.kernel.org X-Gm-Message-State: AOJu0YwajLza9oB40uqXc7apjn/qGWqZnTbfgHQW2+bQ483zl/xAPv6N Y+GPWbeluJqstng1AQPQrqs+2cJqMOPShabYtggvmoMnOxBKFei5JbmKN8xXYhR9kqU= X-Gm-Gg: AZuq6aLXydrV2noQfgJnk57ZmMaf8PTNwZJQFJqlpNqlpxuCSsYtauyuTVK1DMP1+2X C2hQ8yikjXY8mlmkRAbddTNso5Li3XGQk8dQwyMKK5Z5oz4PLvlb0Y/Os5ZGqOdVgXkN/gd3ayk qc9Kts0hHjb6n3KqgaACAiETqAvJZAcqDbpIqd4vsvpFBY8UBhjlY6+qQ6MwYYGwIWG/o/6tfVM muk72YIXEGqZRPkcwoUtwW7uPoZM9ry57nYqOofEcuOw2hhPRuh+qInjc5jDvEF+D4X7jsd0ybv 6FHFX5U1R8iqH8zNRu53Ktg8nKBmO3zjjT4LMHaNnZ6d/zESHq3WcFiW62Naduae+rocdGcTWTO mdwLpnRdtFomEK/dSGEqBXBT6cW2Pxk5NvjNzwFKyjwDVUPMKXMR4TxV4XAuzBpFM7Hmb+EKIpi vNf5fTYG8XwX7dAlU+5aNVy2rXSBv593H7kKDcdgxXt6hfGboGTQVWGamMYsE1i/3Yq7nq7rGSm Bw= X-Received: by 2002:a05:620a:1aa1:b0:8b2:2066:ffd3 with SMTP id af79cd13be357-8cb4091c0cbmr78529485a.81.1770938078773; Thu, 12 Feb 2026 15:14:38 -0800 (PST) Received: from warpstation.incus (243.69.21.34.bc.googleusercontent.com. [34.21.69.243]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cb2b1c8505sm441165385a.25.2026.02.12.15.14.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 15:14:38 -0800 (PST) From: Ethan Ferguson To: luisbg@kernel.org, salah.triki@gmail.com Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Ferguson Subject: [PATCH 2/2] befs: Add FS_IOC_SETFSLABEL ioctl Date: Thu, 12 Feb 2026 18:13:39 -0500 Message-ID: <20260212231339.644714-3-ethan.ferguson@zetier.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260212231339.644714-1-ethan.ferguson@zetier.com> References: <20260212231339.644714-1-ethan.ferguson@zetier.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add the FS_IOC_SETFSLABEL ioctl to the befs filesystem. Signed-off-by: Ethan Ferguson --- fs/befs/linuxvfs.c | 64 ++++++++++++++++++++++++++++++++++++---------- 1 file changed, 51 insertions(+), 13 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 4850295e5fe0..4425ae5b6ed0 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -753,6 +753,23 @@ static int befs_show_options(struct seq_file *m, struc= t dentry *root) return 0; } =20 +static befs_super_block *befs_get_disk_sb(struct super_block *sb, + struct buffer_head *bh) +{ + const off_t x86_sb_off =3D 512; + befs_super_block *ret =3D (befs_super_block *) bh->b_data; + + if ((ret->magic1 =3D=3D BEFS_SUPER_MAGIC1_LE) || + (ret->magic1 =3D=3D BEFS_SUPER_MAGIC1_BE)) { + befs_debug(sb, "Using PPC superblock location"); + } else { + befs_debug(sb, "Using x86 superblock location"); + ret =3D (befs_super_block *) ((void *) bh->b_data + x86_sb_off); + } + + return ret; +} + /* This function has the responsibiltiy of getting the * filesystem ready for unmounting. * Basically, we free everything that we allocated in @@ -761,9 +778,21 @@ static int befs_show_options(struct seq_file *m, struc= t dentry *root) static void befs_put_super(struct super_block *sb) { - kfree(BEFS_SB(sb)->mount_opts.iocharset); - BEFS_SB(sb)->mount_opts.iocharset =3D NULL; - unload_nls(BEFS_SB(sb)->nls); + struct befs_sb_info *befs_sb =3D BEFS_SB(sb); + struct buffer_head *bh =3D NULL; + befs_super_block *disk_sb; + + bh =3D sb_bread(sb, 0); + if (bh) { + disk_sb =3D befs_get_disk_sb(sb, bh); + memcpy(disk_sb->name, befs_sb->name, B_OS_NAME_LENGTH); + mark_buffer_dirty(bh); + brelse(bh); + } + + kfree(befs_sb->mount_opts.iocharset); + befs_sb->mount_opts.iocharset =3D NULL; + unload_nls(befs_sb->nls); kfree(sb->s_fs_info); sb->s_fs_info =3D NULL; } @@ -798,7 +827,6 @@ befs_fill_super(struct super_block *sb, struct fs_conte= xt *fc) struct inode *root; long ret =3D -EINVAL; const unsigned long sb_block =3D 0; - const off_t x86_sb_off =3D 512; int blocksize; struct befs_mount_options *parsed_opts =3D fc->fs_private; int silent =3D fc->sb_flags & SB_SILENT; @@ -842,15 +870,7 @@ befs_fill_super(struct super_block *sb, struct fs_cont= ext *fc) } =20 /* account for offset of super block on x86 */ - disk_sb =3D (befs_super_block *) bh->b_data; - if ((disk_sb->magic1 =3D=3D BEFS_SUPER_MAGIC1_LE) || - (disk_sb->magic1 =3D=3D BEFS_SUPER_MAGIC1_BE)) { - befs_debug(sb, "Using PPC superblock location"); - } else { - befs_debug(sb, "Using x86 superblock location"); - disk_sb =3D - (befs_super_block *) ((void *) bh->b_data + x86_sb_off); - } + disk_sb =3D befs_get_disk_sb(sb, bh); =20 if ((befs_load_sb(sb, disk_sb) !=3D BEFS_OK) || (befs_check_sb(sb) !=3D BEFS_OK)) @@ -963,6 +983,22 @@ static int befs_ioctl_get_volume_label(struct super_bl= ock *sb, char __user *arg) return 0; } =20 +static int befs_ioctl_set_volume_label(struct super_block *sb, char __user= *arg) +{ + struct befs_sb_info *sbi =3D BEFS_SB(sb); + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + if (sb_rdonly(sb)) + return -EROFS; + + if (copy_from_user(sbi->name, arg, B_OS_NAME_LENGTH)) + return -EFAULT; + + return 0; +} + static long befs_generic_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) { @@ -972,6 +1008,8 @@ static long befs_generic_ioctl(struct file *filp, unsi= gned int cmd, switch (cmd) { case FS_IOC_GETFSLABEL: return befs_ioctl_get_volume_label(inode->i_sb, user); + case FS_IOC_SETFSLABEL: + return befs_ioctl_set_volume_label(inode->i_sb, user); default: return -ENOTTY; } --=20 2.43.0