From nobody Fri Apr 17 23:04:37 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFB6927E049 for ; Thu, 12 Feb 2026 18:20:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770920426; cv=none; b=E3hwU1fnv5plJ7B057F0FSyXRoKQeFeYd+fxqJ5PH/Wv2UJV7gjBZh8iwbStvCbkohURw4uymC9Eaj83+8GhTJkmC+zgaGjM0mkHIC7FbGvL5Tp80uEe1+6SBtzd2YFWfEvnn7DR032jHb7hH5jJQaqfk/FNoNkLeFdtFTiCeBs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770920426; c=relaxed/simple; bh=cih/c/q4/7Hg68boWh+HLVoGUUsEO5l70x0eaBfgVYo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tlU+3eR5d2wuKz/JUmpN6gW3XhOXL977kpnw/whC1iHiAt+nUqE4vOSDNgB3S5Agn/eC7+E+98Q73h+7lDXeFfRY0PX1d5U6PIWynPeR37kZXHlBnOcat4c5VrVoi+/tdiEHB9S6BWrWmrBVRdQp3ekFV54UTHMnkrLaQjpw728= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AGxv24LH; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AGxv24LH" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48068127f00so1102145e9.3 for ; Thu, 12 Feb 2026 10:20:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770920423; x=1771525223; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Bprsrllva8d7VsynFvqVLjqVpekx6Ne+uNmXQ1YCZFo=; b=AGxv24LHx2yj5QQEV7TS74Wl5bLLTLONGJhZr4awWP3v5sdhvNkEnCGzkxpTkG0BtN Dv3V+XE/MZaVrLsd4i40PnWAtDZsM4UUFFCmIJfAndP1jcW/1fFv4VcgGt/dXH+nUda5 xqM2eDMDdnUnKiFCglfPbAnCe72KE/Eo7uAM4vMkuZUj/ezuRfl+Oz31QXUhlbmnnXH3 Ao6hSnwdYRUbKK7pMBzwTrRX9gwNvrNGElzpJEJMv9rHwNr6IOLJZQEWpqlghqca+L5W 2zmlJfl6jG3b2H5lgUoFP8MExzX3Y/9609RUxtU2b9GU4eW8nL4FMrDv5SAYvrcQ/oPG N+5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770920423; x=1771525223; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Bprsrllva8d7VsynFvqVLjqVpekx6Ne+uNmXQ1YCZFo=; b=ma0v0ncKuwMpvGiKlOaKD7SjL1H6QspEjq6j/JFNXV5GDyd/Ogfh0A9Wj8IcOUPe0o +JhzyvHPJRiCM5Y0OGe5drMWiPKt9EjG8uRXzcpYT7tfJachRh4eMqt17YkWzmD9eWx7 0bOEuv8EojpZwxjfafIb8BoWj5bOyIYigEUiqblJpVUt3BYnN9JvpSWmMyrWU+meoggM bLTpBVuqsiChV65R0INOxMv3Skco+79wvDL9cCpnnYzhEanRfrZR4kJo0bk1ovwgrUP0 26oxY9YUNfxA2hVHiixf0D1X87rnvHDJVGlVER6qRw0MiMtqvWPsbQpTVYl9eDx2QeEk iz4Q== X-Forwarded-Encrypted: i=1; AJvYcCXyn/sXfJo1cpFd6fto2CT/VKGyB8Jch6MfO8+kTDBFVeZF5xTKVsO+2fx2I5pMhxWtd+w0suxqXdovUvI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmm8lzRJqux8O9xCUdgSkD8W7LdNxUyfSekxtm213nn9xZZjeI ifc8of6DAzZJk1KtJsuKZz4LjZlcRnBvuBqUz9Msfw2FZ4BOPhFPkwZk X-Gm-Gg: AZuq6aLNhxwQ9shNXAGgk/m3Ry16W32Q/F3GUoQQ5KPCZJ/wXOq08NjeCnLQOLFzlv6 Uo7RtDjdIm23yJfpzkzXYDKe76s+ann8pK94KABFNFAVdxAIw9prMti65JpRtk2/XzqMz/fQAsu Ip9RCJqdnNaZYXHLib2jrpi7mVy/ob8FFHWpBxByNmIHZZfw/oDi7TrNRRcCPPBYIVxwrqQiD18 5UwH15sfAeFuZLBGeo4hjbnFE2gzsaDLoxiGjyPTFR90RJxEhSy+dfruSHNFATUnVNdiptBC1In M7QcUYAH70UfskS7sjKU4DVBrmLK7/8QWPCuRewypcOuvXNFONYMQdg730eegprBgjE2rd0GOw4 9ysHRIOma9ppAqSbMPfC1kQ+yD47I5XtsPJ9mn4AAyArcKOu1ix0JWe/pA9AfW6UHhTRnoNfr8E TD1jzCxJXUqPQNaY15gC3jJ9eNZmydbjDkTZutwKCyWjcd+1V/6H/S4H0/FA2siee7 X-Received: by 2002:a05:600c:6792:b0:477:b642:9dc1 with SMTP id 5b1f17b1804b1-483710368cdmr371995e9.20.1770920422733; Thu, 12 Feb 2026 10:20:22 -0800 (PST) Received: from db07.UM6P.local ([196.200.180.25]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783dfc2b0sm13239933f8f.21.2026.02.12.10.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 10:20:22 -0800 (PST) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mentees@lists.linuxfoundation.org, me@brighamcampbell.com, skhan@linuxfoundation.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v1 1/2] dt-bindings: iio: dac: ad5504: add output-range and missing gpios Date: Thu, 12 Feb 2026 19:19:54 +0100 Message-ID: <20260212181955.42724-2-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260212181955.42724-1-0rayn.dev@gmail.com> References: <20260212181955.42724-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The AD5504 output range (0-30V or 0-60V) is determined by the R_SEL pin. Add `adi,output-range-volts` and `adi,output-range-gpios` to describe this hardware state, using `allOf` to enforce mutual exclusivity. Also add `vlogic-supply`, `clear-gpios`, and `ldac-gpios` to complete the hardware description. Suggested-by: David Lechner Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- .../bindings/iio/dac/adi,ad5504.yaml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml b/Do= cumentation/devicetree/bindings/iio/dac/adi,ad5504.yaml index 9c2c038683b4..3e832e501b0e 100644 --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5504.yaml @@ -27,12 +27,50 @@ properties: maxItems: 1 =20 vcc-supply: true + vlogic-supply: true + + adi,output-range-volts: + description: + Hard-wired /R_SEL pin state. 30 V when pin is high and 60 V when + pin is low. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [30, 60] + default: 60 + + adi,output-range-gpios: + description: + GPIO connected to the R_SEL pin to select the output voltage range. + maxItems: 1 + + clear-gpios: + description: GPIO that controls the /CLR pin (active low). + maxItems: 1 + + ldac-gpios: + description: GPIO that controls the /LDAC pin (active low). + maxItems: 1 =20 additionalProperties: false =20 required: - compatible - reg + - vcc-supply + +allOf: + - if: + required: + - adi,output-range-gpios + then: + properties: + adi,output-range-volts: false + + - if: + required: + - adi,output-range-volts + then: + properties: + adi,output-range-gpios: false =20 examples: - | --=20 2.47.3 From nobody Fri Apr 17 23:04:37 2026 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87775285058 for ; Thu, 12 Feb 2026 18:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770920428; cv=none; b=IVVbEMrusw+yodntgKB605r2Vik+cAJgL5Qtn/ns4Lve2MBmxk72fqAsBbb3kwqh6E5UcSwpa1EhGwZT6S2O491Xa09adtOnx3/uKJN70tsMp79+9FGs1D4UI45rKbZBY9ADWzin39Ef0B5++hDVjRwNpdJWVzrllpDfFlG/6WA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770920428; c=relaxed/simple; bh=j7w5W5n+1tnAj9tyIzUZDSwh/ga/Vo6JWcfZq1R2EOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M3dyrRmXfBXlTrPRyeYSjsKwpjLY5JxNEr1/LA/Uy0i1tjH9jjPSNshBjRo0qjEZTgmRP1ayu6veMpFN8Ex54KtGSNrNI50k6lP3kG8+FBspxwEXtfqQEPs36/qrmWLI0VAGK0Wj0ORRzunrcTo87gl2dPllhty57f/++QvGAsM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eP37YKbL; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eP37YKbL" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-436356740e6so161859f8f.2 for ; Thu, 12 Feb 2026 10:20:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770920425; x=1771525225; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YJKm78yJdUZ0qsK3Qh4mVjVC+cGTgJke+yjUKqEIW6U=; b=eP37YKbLcXwbqsBS55aAyL5g40PkfHB5KgNca2CmAW9OweLh9uD2D8TH14n4NKSovb 3mCb5SN/rT0gtUSoz69WXYtQ8snZMjx6Qjttk6MZnhydxYKBDw+vKKP/z/sthfK0S7Ot T1Tsp22Rjwg+0pm/F1PgVRps0Z2Ujrug5Gq+wg4knZJhyRQ/U+hnDgc1eJYEd8lfGrz2 nQD1FuVyuoIoRcJJDyaWh0FF9AA3RJXPnEMzoc0f8OaLPhmVAS4WbBDFM8nqSsaZpDP6 CgWFAqXzIMt8znVZeEqUFSqI3WVIFN4oZvwFMq4SRju0ZLUWdF/US8s5x722JmSmMr7x jEzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770920425; x=1771525225; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YJKm78yJdUZ0qsK3Qh4mVjVC+cGTgJke+yjUKqEIW6U=; b=PEc/HNkpUBSIBYB5gG3e2fei2uwLrBSxZwHn39BuBc1EF6uZcGo0+g6gZnpNQKx+Sj ygftbAXdEfBlyL3u9R044p+9xhyQf1G+9BHbI2o2iG3TSflEVVI50dB9fBLy29/ur0KK 4oHLBCvjVCooYnRdIH8CL4Ich2R9rck0CpSv0+p2DiQjB4nv6H7ec2tKapy0is1XCnfO VQdAT0/L0Hq31yk/Jv+9FG9W+XAA3rboPVeFc0VY6VO0TXV3CzJZ5vBSA6YVuULBZxuf txrHI2g6Lhxoe6aKPe4BLRoyHVUbXuC0SYbZLoAB/b9I6BPD6RktM9T9zvITi6EljshQ OoYQ== X-Forwarded-Encrypted: i=1; AJvYcCVUyLGXhuI04TuVthYHwiX4wDVApWEaTu6pm8m+cBxBzZMOkNTBYqQT0OwiOYA6GHx4qV6imJsgw8b2IHw=@vger.kernel.org X-Gm-Message-State: AOJu0YzQZE6Plvzkk0E2GJM6fhQNpCou9a7g3HM0h00fCEbbQ4bLL/25 J9C/HulT3dk6jXcwUFsf7kg2laAVbumpA0dUdf1YOZyoybxALX1/PRv+ X-Gm-Gg: AZuq6aK6JfLj40GIDyefs190TafYfXIDw5AU3q8Zco3puEA4q7qlkcV7o4Ti34HxKI4 Gr5oZM0vkT8w5a2+almPJMzjqiQuCUA5zRll0Yfyfk6yGBr+dcm3bR1fpPEGVItA1sNpbIHWVvc L+HBTo/eMKeIlRPFy0tmk6KcNZq9SLx+LIbh2thHKFwlZyK3nY2+ool7sJuQYbrE+GADVni1B5J RFA0/TCd2RwAQYkot75HarfSm3hTVvxEPrWHVhYV8x1Aqwa1Mr1RTumu/1e2G0wPHcXteF4HYfu yCQLLMEflatOpvj5p0OfwUgvQppSDwnzFuZeHgvq5kvcApS48+o6pFeItNVJYyV563m4iZKr6/5 GskSRd2TW5CGEY1O5flj54Bn74Ab41xsKDmoL8xsy12H1lBPRjyAwc8MCkzTqC9OnrfV+V8vcPh ap/eIbEkjkAls64cxMJr+h0orocpeqDKqCwpKa/dzO5ZjYW2HLI88Cs7R81LeGku0I X-Received: by 2002:a05:6000:178f:b0:431:656:c73a with SMTP id ffacd0b85a97d-4378ac7e289mr6007987f8f.31.1770920424821; Thu, 12 Feb 2026 10:20:24 -0800 (PST) Received: from db07.UM6P.local ([196.200.180.25]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783dfc2b0sm13239933f8f.21.2026.02.12.10.20.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 10:20:24 -0800 (PST) From: Taha Ed-Dafili <0rayn.dev@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mentees@lists.linuxfoundation.org, me@brighamcampbell.com, skhan@linuxfoundation.org, Taha Ed-Dafili <0rayn.dev@gmail.com> Subject: [PATCH v1 2/2] iio: dac: ad5504: use adi,output-range-volts for scale calculation Date: Thu, 12 Feb 2026 19:19:55 +0100 Message-ID: <20260212181955.42724-3-0rayn.dev@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260212181955.42724-1-0rayn.dev@gmail.com> References: <20260212181955.42724-1-0rayn.dev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The driver previously used VCC to calculate the scale, but the datasheet states the output range is fixed by the R_SEL pin (0-30V or 0-60V). Update probe to read `adi,output-range-volts` for the scale. Default to the 60V range if the property is missing, while keeping the VCC regulator enable for power. Suggested-by: David Lechner Signed-off-by: Taha Ed-Dafili <0rayn.dev@gmail.com> --- drivers/iio/dac/ad5504.c | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c index 355bcb6a8ba0..1796a9b1e750 100644 --- a/drivers/iio/dac/ad5504.c +++ b/drivers/iio/dac/ad5504.c @@ -15,6 +15,7 @@ #include #include #include +#include =20 #include #include @@ -274,6 +275,7 @@ static int ad5504_probe(struct spi_device *spi) struct iio_dev *indio_dev; struct ad5504_state *st; int ret; + u32 val; =20 indio_dev =3D devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) @@ -281,17 +283,21 @@ static int ad5504_probe(struct spi_device *spi) =20 st =3D iio_priv(indio_dev); =20 - ret =3D devm_regulator_get_enable_read_voltage(&spi->dev, "vcc"); - if (ret < 0 && ret !=3D -ENODEV) + ret =3D devm_regulator_get_enable(&spi->dev, "vcc"); + if (ret) return ret; - if (ret =3D=3D -ENODEV) { - if (pdata->vref_mv) - st->vref_mv =3D pdata->vref_mv; - else - dev_warn(&spi->dev, "reference voltage unspecified\n"); - } else { - st->vref_mv =3D ret / 1000; - } + + ret =3D device_property_read_u32(&spi->dev, "adi,output-range-volts", &va= l); + if (ret) + val =3D 60; + + if (val =3D=3D 60) + st->vref_mv =3D 60000; + else + st->vref_mv =3D 30000; + + if (pdata && pdata->vref_mv) + st->vref_mv =3D pdata->vref_mv; =20 st->spi =3D spi; indio_dev->name =3D spi_get_device_id(st->spi)->name; --=20 2.47.3