From nobody Thu Apr 2 18:47:38 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0C48211A28 for ; Thu, 12 Feb 2026 18:04:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770919455; cv=none; b=IxO8yyHz3N2JpS92Y/mQnOkESw59IDWuzZQHqxd7IPhoQqosOSFEEeTgPqd2Ci4wsiJS0ASPyOP5kPqQeQiIds5yG2N/KYuksqwAbeKgYC3iaC05zMcqpI6xlpHkIA3mEGPxv2HXHq33SuFgY0iN6fu0eLimEfpQB2lUzL0SiB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770919455; c=relaxed/simple; bh=TEU5ACtBivSpOWfnK6Sn/cIxkKLzyBH/+2XoKUoppMg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=kYuGplaDt3VzLQvCdSR+91jbNSh/dlCnGS+bbv0fNWthtsrfkMjmMQs142wz8Qm3znHb7M30wA4Mfy6plBkcMzBbBpIhE8X7YXE/luRzXpd6s0Zf74j6SiQJ8WSD0mZPW+BeesljwEu/M2rMql7hdoatx3LKc0/tzmGvOGK7VKM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HCe8G9Zg; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HCe8G9Zg" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4806b88d8c9so115595e9.2 for ; Thu, 12 Feb 2026 10:04:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770919452; x=1771524252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=h0wk2xsCrS3DaAr/gCoCsMedTcrkDGhrxiWMWwsv91w=; b=HCe8G9ZghgKQtNsUaRD3cd+vu3/ew9aGclsewE4AkGAgRXqdu0+WN2ZQLHg0nEc3Y4 +weHumGz8PLDsw2f+cZo+ZDopUhvWHM1viIdsxbyBVbvVTZq4+N+wbDL45L7FW/0ft1I I97qZR3/z6LW3J+pk7VG+7CgF87XK9a3c7uv8W7i5XF8umWmTOMXgAi/QPyYHCPxdSpI mcGG1X7gKeXi7q1vCzGOABJNIIJSsOEHCLnxYLC5vM6Lahx8v/fabw1FCoYQmahoqGzl y+uA492htLYUP5Gelwx/wM6qJJzyPmz5yIh12yC8r24ao0GMsYwbMArLEbXEWyuhQKYr mKHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770919452; x=1771524252; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=h0wk2xsCrS3DaAr/gCoCsMedTcrkDGhrxiWMWwsv91w=; b=DNCZ9PDVBxhQfVEHc9CH2ocklLLBu92NgGW365QI5kZetWYFIr9MwufaQf+HUPpq4P qenCSEkqoM7dmAXUwShdcZvOCD9M1o5zWdQpSr/buR5FLO4nAs/shXJK4RNYjyLACEcM cVZsZmI8nTPN/KtSGdiZapDZ6KoOEOXB8KiL1DGhpHuJNwsHe0J70rv03UDNaqsk4dzI nX0QtZx2BWPi/FY64nb653XV5xxtgd28B0vWEL05B+KxyINSpcqO9Z8jVe2tvhhcdhlC /tf/gUcnSD+pL3PJpvt4KeEuOW77kQPWz1u9EvFugc/1Ty25p3vPyA7MT1Y8jz/GQq2r 6ZsA== X-Forwarded-Encrypted: i=1; AJvYcCW2MAgrikG1+FKzIKPfyOS1u33IbRsF0mcEilBHPY/qhWSpg4b8bgtao5+wfhc+KxuVlUSdo4e8swRIY3c=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2Ny4ktfQBiYPVGNH2mjYW9oG8iNq1/AsKKHB+YKSwApxzhHGw +KKzGUHtFMjIM9fICrRyLrqsqPJz7YPpBUogybyP89BEG1vKDy5BkyelN8QTu+29 X-Gm-Gg: AZuq6aLWPLPvZZ+jHm0Hds0zaS4tROj7tnMqjtIlKpYNxi+r7jgTKY1CiVF4RjDOZHi qylxXw/QBPgnunyskEqPzzex4j6oLpL/XsaVPX4QLLWe2yJSYycBKj01NAB9b76Kl+fiTQae+y8 8TNF0e9R+UeCye+sQHdr1NVSKFGbS4knkEgnQKRYnURAjScHuu5pLPnr21qOz6y3qCMW2E6m6Zo 2cNPsYVnMn2kSpkWYJM4E/E0sKjs5aqAYGyPhRTB7opjfW4OEc9JsTF8cbvgFmD0oLCPlnXaXIc nosjiz/IsXvYrkxRukEjx6Y3b/Dn2UIXTFPpZq5ZSG8o3eeF01lAapcKBDAfPpqoglJ5in/rDPI p6uBCJhe6s4Yl+/S5sETIdc5snx7qg5QHjQD6GQmSDt4yCaFUMWolmHooswjkQAxbmpI1rDvS+b A0gFoPmD92+x7Q5huo0je4ypux5P8NrcqNoxUvqHIYt645CJKefwxcjb9sdi1xm6fNynVWTgoOx SlPiEVYCBtdxw== X-Received: by 2002:a05:600c:474a:b0:477:7b16:5f97 with SMTP id 5b1f17b1804b1-48370cce47cmr111215e9.0.1770919452101; Thu, 12 Feb 2026 10:04:12 -0800 (PST) Received: from rachel-VM.. ([31.44.137.237]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783d34657sm15932004f8f.6.2026.02.12.10.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 10:04:11 -0800 (PST) From: RachelOvrani To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, RachelOvrani Subject: [PATCH v4] staging: sm750fb: Rename nDirection to new_direction Date: Thu, 12 Feb 2026 20:04:02 +0200 Message-ID: <20260212180402.69356-1-rachel.ovrani@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename the variable 'nDirection' to 'new_direction' to fix the warning reported by checkpatch.pl Signed-off-by: RachelOvrani --- v3 -> v4 : Directly rename from nDirection to new_direction v2 -> v3 : Change the commit message more appropriately v1 -> v2 : Renaming n_direction to new_direction=20 drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index 046b9282b..c796d410c 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int width, unsigned int height, unsigned int rop2) { - unsigned int nDirection, de_ctrl; + unsigned int new_direction, de_ctrl; =20 - nDirection =3D LEFT_TO_RIGHT; + new_direction =3D LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 =3D Left to Right, (-1) =3D Right to Le= ft */ de_ctrl =3D 0; =20 @@ -173,7 +173,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ =20 - nDirection =3D BOTTOM_TO_TOP; + new_direction =3D BOTTOM_TO_TOP; } else if (sy > dy) { /* +----------+ * |D | @@ -185,7 +185,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ =20 - nDirection =3D TOP_TO_BOTTOM; + new_direction =3D TOP_TO_BOTTOM; } else { /* sy =3D=3D dy */ =20 @@ -198,7 +198,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ =20 - nDirection =3D RIGHT_TO_LEFT; + new_direction =3D RIGHT_TO_LEFT; } else { /* sx > dx */ =20 @@ -210,12 +210,12 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ =20 - nDirection =3D LEFT_TO_RIGHT; + new_direction =3D LEFT_TO_RIGHT; } } } =20 - if ((nDirection =3D=3D BOTTOM_TO_TOP) || (nDirection =3D=3D RIGHT_TO_LEFT= )) { + if ((new_direction =3D=3D BOTTOM_TO_TOP) || (new_direction =3D=3D RIGHT_T= O_LEFT)) { sx +=3D width - 1; sy +=3D height - 1; dx +=3D width - 1; @@ -277,7 +277,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ =20 de_ctrl =3D (rop2 & DE_CONTROL_ROP_MASK) | DE_CONTROL_ROP_SELECT | - ((nDirection =3D=3D RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | + ((new_direction =3D=3D RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS; write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */ =20 --=20 2.43.0