From nobody Sat Apr 18 00:21:23 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9868D134AB for ; Thu, 12 Feb 2026 17:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770916765; cv=none; b=Tl5uX5xusikjVYy+uHJgcd+npgwno36c6TKvJEoAlzaEWI8BYDpRT9PsH3GC24uWamVbrOW2IBPsrk49z+KxvqKdkRAd1p7Xq9LxR+6XcM5FhAubMaQsY+XK/tjiTIQfYPy8O0vHBzDVQLh6jysnTpf3vSjAmTzBewP6eJO2WeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770916765; c=relaxed/simple; bh=CrQpbEV5IPnUNL0QPZBCTdajYkmOm0/i00kO26QPOrY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TxtXUlHFJ2XiGirgTk+s1PnFi76c8oN1ebLXKdzv2vQH0tGcwLOYG+78XRibVs7nYXhJvvz+FcTSC1y+675biwmlxCjAzaSH53hTzgVWmCC6OaA+g3SLTLtIQvAF+m1mZtoRbM4w3YEoMw8JJswJkROZk77O9sKpzJ4I1jZyZZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a7NII5yK; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a7NII5yK" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a8a7269547so637955ad.0 for ; Thu, 12 Feb 2026 09:19:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770916764; x=1771521564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4Dk12s/kv9fkKYCcNYFIar28stlOTl1HDBawH5eqWR8=; b=a7NII5yKCuzYomIkzF072T/huO4U1QNsksXsUlMLWU9nc2v/DYijoqWdDz0SOvWtml Bo49TxCAt0382NZL71ok9noPQ5gSjb+K5HVOmrgePENPySCKYNY3hd/AdzXbKbF6a4vi OXe6NeFIH+CREzog20el/VSJ5rnwNSAng+1H2lQ2h68W+7y60p6YUGY8v5ftzfyN4xw6 JPlLFj2BBtMcko7Fbbi2xGZJ6p8AkJcOtip5DXtLhZRadBCZ5ZtEjeLXfSZOXvtOJUN3 42DNQa9aHT1eOyIVvROzbDl8oUElRgFvY2OuehyusGDO9l5Bo9NhetYJmxeWehf+n/cj 2tHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770916764; x=1771521564; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Dk12s/kv9fkKYCcNYFIar28stlOTl1HDBawH5eqWR8=; b=mvHgvnA4rnupMk9gQeMInjJ8P0Nwk3GF/G8SCK7Fnpg5lE/sjZuFh7kEAUVifx6DmH k1xzEthTEJAqJ5ZrRGYDZWZMJq1x0TlwchragAbEfU0g6sHJ8q0uK+to+/SgP2a+2XoA PfoA8Iwjv+z0sZmsgQG6aBf4JbzT+iH+23Cq9PZ/zyjtOSTDnotPcH3zhjeSDZK62fMc Qmxdcha14xL5fTZgl9Vsr2FF47BuITjpV5F3hZLYRaCFLBBw+4Ds0UsEVJ+krtOqaWpV vIFyoQ1mtwqucawJ/enUTDszlYF0E7RYdFpOEfNJvGIXnqY/4VjcBEyUK8XLClfuPc3e E9DA== X-Forwarded-Encrypted: i=1; AJvYcCXA3x6vt6CYnAs3OB/qJoJk6qVI5uSm+IQu0NPgfU5grgzqJnntFrJX5vu3Sh5V7V67/wHkR8ihKZqNI8E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1hTWNQVBXWD5M8gjB2isTs9aWe/Wot88BYs46wCIDkJcxJL0e l+EbUZsn/T0SYynrG4rOrsIPDdLtJkewjU4EZQCNywEv/nGymMbxKRXy X-Gm-Gg: AZuq6aIkGjmZ0G4C03ec2HnESTXrOxjaHXwpUeJSd+u9M2CQoeMbDQh8bgnTZUkZoAL MJu5az8bHUxlC8nr7bTfFZC4MF7+I7YudHa7Oe4cge59VQzg0YGWtlHXxMkmyhfTrriQM3NwWlB e2EU78m6LvdxBZGSXmQL7okAjb96rcCirfCqCrXZp1Dc3gN9cPC/SVvoF3fuAObPM684siBBa/W 6Wzv326k5mU+05m7XTrgLyhOu4ZZbBCTwOd7PnDrOjMp66DoUjkNIoPKFdMjzwvaQpwo4Wo3WUM rSRnl8Si+NtTK7j4rOMO4ukTLofTWV2zbXfE+lENLR8Cm8CXqipz292lvhKIJVgZQvvJWSxv4Pb A7iZ6wVR9odfVNI7pwJYba977xuCJDk6lowFBlMxoyZ4vWdJYcqCAWS8AB78y/mIlNr/V7Lkr4k FFo3bsJ1QtgAvv5MBKjdJMMRMNcV6gAcRTslyPa7KsDzz3YWLJ+d1LdO1NOFQ2mhY7snY4N2HKc n2Muq2b/mV0swZzRWmWQVbsFcUniFrbWr14Wak0UByKgn56vRuE467ZSg== X-Received: by 2002:a17:902:dac2:b0:2a9:5b48:2b50 with SMTP id d9443c01a7336-2ab396684fdmr36675425ad.3.1770916763679; Thu, 12 Feb 2026 09:19:23 -0800 (PST) Received: from ThinkPad-E14-Gen-6.. ([220.158.168.165]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ab2984ac8fsm67571585ad.10.2026.02.12.09.19.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 09:19:23 -0800 (PST) From: Yuvraj Singh Chauhan To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Yuvraj Singh Chauhan Subject: [PATCH] staging: octeon: fix free_irq dev_id mismatch in cvm_oct_rx_shutdown Date: Thu, 12 Feb 2026 22:49:03 +0530 Message-ID: <20260212171903.1417804-1-ysinghcin@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In cvm_oct_rx_initialize(), request_irq() is called with &oct_rx_group[i].napi as the dev_id: request_irq(oct_rx_group[i].irq, cvm_oct_do_interrupt, 0, "Ethernet", &oct_rx_group[i].napi); However, cvm_oct_rx_shutdown() passes cvm_oct_device (an array of struct net_device pointers) as the dev_id to free_irq(): free_irq(oct_rx_group[i].irq, cvm_oct_device); Since __free_irq() matches the action to remove by comparing dev_id pointers, the mismatched cookie means the IRQ handler is never found, triggering a WARN and leaving the IRQ line permanently allocated. This prevents proper driver cleanup on module removal. Fix the mismatch by passing &oct_rx_group[i].napi as the dev_id to free_irq(), matching what was used during request_irq(). Signed-off-by: Yuvraj Singh Chauhan --- drivers/staging/octeon/ethernet-rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/= ethernet-rx.c index 965330eec80a..d0b43d50b83c 100644 --- a/drivers/staging/octeon/ethernet-rx.c +++ b/drivers/staging/octeon/ethernet-rx.c @@ -535,7 +535,7 @@ void cvm_oct_rx_shutdown(void) cvmx_write_csr(CVMX_POW_WQ_INT_THRX(i), 0); =20 /* Free the interrupt handler */ - free_irq(oct_rx_group[i].irq, cvm_oct_device); + free_irq(oct_rx_group[i].irq, &oct_rx_group[i].napi); =20 netif_napi_del(&oct_rx_group[i].napi); } --=20 2.43.0