From nobody Thu Apr 2 15:35:54 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41F7B225775 for ; Thu, 12 Feb 2026 14:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770906161; cv=none; b=VaT3kOSnPgIGyzRySWU/c/ztjaiv/WX6BFBLsyV0VZTPBb01MXiKawMeOR8Dv0VuOIx8RnYNjF6puGZus/Qe8wZAmriNI0BNMTWqFi8pYAdjWIWSHTa4YYlV6p/qLhvfsTPhdOx9BrYJ0mAoRDMlikxlPJs97ueAE/0e44Wz4Vw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770906161; c=relaxed/simple; bh=j8JekCs3ZS/rkajeaMMNoCV05t83c2Wl2Q0wPoZEIKc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=t1nsAE2Y0N8Ety0proMkOSoatrgkGGGUaXXvecB77T5oOQmEiCwwLs60ofrpSurEXhQJoYazJ2W0QydrgpGAEevoKtUf5LNRjk87SVhRBkvd4uA76/ZAepC5ZXijzeIgSUkS1HlcJwVSPF68KBUwqA2C+E4X2tI9ItMQN9P2H4U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nJskeIGN; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nJskeIGN" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-82361bcbd8fso3417520b3a.0 for ; Thu, 12 Feb 2026 06:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770906159; x=1771510959; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d2exHcZToZu2EpbdASl4Yzi0O0TQLUdMunWgD/Yezv4=; b=nJskeIGNjOd3auGsRxjFOl3M7PA+GZH3B0/3RPBJd4Cnwv0aPuP0DCrMaYVXligM8J uca8objgaYy+MV1Eq6vKWcKiich+7XhXUjxqe2ir2ChQBikgl4uygV0Xh3myJbEwc1qk eUq6yqOZxCFKp3kzeSIIn6W9qwFKR9wMfilpHniUciGuxMgT4jM9btLcRTm5NIEMTTmH 4la0Soe6AvDn4Yf1531BNmxg8MIDsnuzb08EC3ihejmv8xnfL7feRN8EK80Ms85CM6gJ LCdASZHLoE4fvefX0rynum77Xcpr4O7C9DQ+p3yTL8U1+lY+oeFS2ibZgAf0FYhLsRWX 8E7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770906159; x=1771510959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d2exHcZToZu2EpbdASl4Yzi0O0TQLUdMunWgD/Yezv4=; b=D77dptULJ7TsVDu0eEPObW7Z6MgT9v3KuRmif3IvRDcc8KIH1klZZjiiNsKhdLZZVQ ldWgIwgDEXe3hRQgAxU1NgXqGHHY02wKVSmLpS5K4+TTuzAMWFOzJiNMj3bgJj7ud8d0 +qEWG8C4QK56IjTAGAxeyxfoS40gg0swygecXiY8YihRjthD1y/ccqE5+/lX7Wa20ZGV 3WffmlZeptYoUQdr9HY57PWNdEQPJVbgTUsaOqSGnrixufsxDggnXl4VLH6A87MTzwhb kBehvIjZ1DT7HNP80ldiD3DWL2m3eDyWXsprzvG60CSiYMVEe2foN2+XC8ERfxNSuppY RTig== X-Forwarded-Encrypted: i=1; AJvYcCX37nSju9ATo7EXNn9YYFMKMAxLVaa/OYOKy2NosZUScECODcNQYjH/JbM7GxMb5eehV+yYcriXVwI6mV4=@vger.kernel.org X-Gm-Message-State: AOJu0YwZYrop/5MsgC53uRCUoqnnUD0SaPmhAteTFHJ1bpJKwxDaSL0g 04xF6/psE9MEBLQecI9yjnm/aLV/6bnd700JJXukRaisR0bPIwHor/zj X-Gm-Gg: AZuq6aIr5BrAbhDNCvyTTHBrdXgMLomZ4SiDVrUxtxGQ6Y9mcgD5XVpwgJNs5thlN50 Ax/dwOjzbNOshLLN0te63cY52V4UDiFJ9rQg2q13rpyU2H5JdXxz9qkoheD5sepPwTajyB32MG7 1bdv/BDyUjS6vWQcnIGv07VZ0adfgZEbAqWu14R1JRgsXN+xV1Mvn37/4iAtk6XNZRjYcofw2tP 0ZdC0tAALNNbkTIyEbs6p4vjmZoP2a1fZ8FItM6F0njZyymhYjc1CrqOT1UTZLE0KN2P53tT7ZD Zs+ti5eOH54Wi15AO/RVcCic984ZUXdAvP3XHGeKmSULOIcg97ZsVEaDI4ks5SbRmwKn5CN/yGK Uez5rATQQOPUDf5LnQRBqCHLcBPDmU2Tn0uF45Q+uqGfVcSm1aTaUg0wwu2Hbdh5TLJOFENlQk4 H+DKiWtVL0R1c3hI9k2V8qTVdw9WBe7hX4Z8hiqdNE X-Received: by 2002:a05:6a00:1a14:b0:81f:99cd:faf8 with SMTP id d2e1a72fcca58-824b03f25ffmr2199591b3a.8.1770906159483; Thu, 12 Feb 2026 06:22:39 -0800 (PST) Received: from snowman ([2401:4900:647d:9ae6:881d:5895:580d:d8e5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8249e366b82sm5336631b3a.1.2026.02.12.06.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 06:22:38 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, ethantidmore06@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH v7 6/7] staging: rtl8723bs: simplify boolean expressions Date: Thu, 12 Feb 2026 19:51:30 +0530 Message-ID: <20260212142131.28131-7-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260212142131.28131-1-khushalchitturi@gmail.com> References: <20260212142131.28131-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove redundant comparisons with true/false and simplify boolean conditions. Signed-off-by: Khushal Chitturi --- Changelog: v6 -> v7: new patch applying boolean simplifications to renamed code. drivers/staging/rtl8723bs/core/rtw_cmd.c | 9 ++++++--- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 13 +++++-------- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index c50a3a2997e2..f322a7f89b42 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1150,7 +1150,8 @@ bool traffic_status_watchdog(struct adapter *padapter= , bool from_timer) pmlmepriv->link_detect_info.num_tx_ok_in_period > busy_threshold) { busy_traffic =3D true; =20 - if (pmlmepriv->link_detect_info.num_rx_ok_in_period > pmlmepriv->link_d= etect_info.num_tx_ok_in_period) + if (pmlmepriv->link_detect_info.num_rx_ok_in_period > + pmlmepriv->link_detect_info.num_tx_ok_in_period) rx_busy_traffic =3D true; else tx_busy_traffic =3D true; @@ -1161,14 +1162,16 @@ bool traffic_status_watchdog(struct adapter *padapt= er, bool from_timer) pmlmepriv->link_detect_info.num_tx_ok_in_period > 4000) { higher_busy_traffic =3D true; =20 - if (pmlmepriv->link_detect_info.num_rx_ok_in_period > pmlmepriv->link_d= etect_info.num_tx_ok_in_period) + if (pmlmepriv->link_detect_info.num_rx_ok_in_period > + pmlmepriv->link_detect_info.num_tx_ok_in_period) higher_busy_rx_traffic =3D true; else higher_busy_tx_traffic =3D true; } =20 /* check traffic for powersaving. */ - if (((pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period + pmlmepri= v->link_detect_info.num_tx_ok_in_period) > 8) || + if (((pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period + + pmlmepriv->link_detect_info.num_tx_ok_in_period) > 8) || (pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period > 2)) { should_enter_ps =3D false; =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/stagi= ng/rtl8723bs/core/rtw_ioctl_set.c index c41595d03c08..d92ec9949d00 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -61,9 +61,7 @@ u8 rtw_do_join(struct adapter *padapter) /* when set_ssid/set_bssid for rtw_do_join(), but scanning queue is empt= y */ /* we try to issue sitesurvey firstly */ =20 - if (pmlmepriv->link_detect_info.busy_traffic =3D=3D false - || rtw_to_roam(padapter) > 0 - ) { + if (!pmlmepriv->link_detect_info.busy_traffic || rtw_to_roam(padapter) >= 0) { /* submit site_survey_cmd */ ret =3D rtw_sitesurvey_cmd(padapter, &pmlmepriv->assoc_ssid, 1, NULL, 0= ); if (ret !=3D _SUCCESS) @@ -113,9 +111,8 @@ u8 rtw_do_join(struct adapter *padapter) =20 /* when set_ssid/set_bssid for rtw_do_join(), but there are no desired= bss in scanning queue */ /* we try to issue sitesurvey firstly */ - if (pmlmepriv->link_detect_info.busy_traffic =3D=3D false - || rtw_to_roam(padapter) > 0 - ) { + if (!pmlmepriv->link_detect_info.busy_traffic || + rtw_to_roam(padapter) > 0) { ret =3D rtw_sitesurvey_cmd(padapter, &pmlmepriv->assoc_ssid, 1, NULL,= 0); if (ret !=3D _SUCCESS) pmlmepriv->to_join =3D false; @@ -379,8 +376,8 @@ u8 rtw_set_802_11_bssid_list_scan(struct adapter *padap= ter, struct ndis_802_11_s goto exit; } =20 - if ((check_fwstate(pmlmepriv, _FW_UNDER_SURVEY|_FW_UNDER_LINKING) =3D=3D = true) || - (pmlmepriv->link_detect_info.busy_traffic =3D=3D true)) { + if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY | _FW_UNDER_LINKING) || + pmlmepriv->link_detect_info.busy_traffic) { /* Scan or linking is in progress, do nothing. */ res =3D true; =20 diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/st= aging/rtl8723bs/os_dep/ioctl_cfg80211.c index 983669189d41..f0e423cf7627 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -1231,7 +1231,7 @@ static int cfg80211_rtw_scan(struct wiphy *wiphy goto check_need_indicate_scan_done; } =20 - if (pmlmepriv->link_detect_info.busy_traffic =3D=3D true) { + if (pmlmepriv->link_detect_info.busy_traffic) { static unsigned long lastscantime; unsigned long passtime; =20 --=20 2.52.0