From nobody Thu Apr 2 15:35:54 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FCE627453 for ; Thu, 12 Feb 2026 14:22:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770906142; cv=none; b=J4gcF3RQe3Z+LAeCKNczVF6s5d/jDcPVrByK4raSXrNxWSYjHuIcubXwC9smBoeoCpptG3yHdsrHcDpTNLtf34M0AKczvC6Hd8dw6YBWnZHukNHS/Mw98Co7mPaL0k+FjAjBR5R0uGSADQT0tItB3F7IRRPVDNyqWQSH7cMiY58= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770906142; c=relaxed/simple; bh=7B1dKLBC4ssIMb9u6OjRe5vsnTw2YsIbmli5+ekYoOo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cHn2aK3kO3RWNXuELg7gaWbN+3rc9KhR0yyDBD8lv/ySZN5eyIMeJUh3RpR6BoGKSINBXYyhGUsGy6IqRtCQCZOyzadeRUeU+l2zT7SR4AaAm48AeSe/1wp3es5ALg1vJxPoV4lopwDCCEgi9l5pxGRtmPJwa5ccSEa2eWnQxR8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TFFdr+J8; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TFFdr+J8" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-824b05d2786so682035b3a.2 for ; Thu, 12 Feb 2026 06:22:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770906141; x=1771510941; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7YV6OK6ql/86N7Aeb4DVq+IwqTnAgt8zgYIHnXIV/C8=; b=TFFdr+J8OjX21qhHJw7eaAXkR/M5Ez7rSRM5RVa+nFF/jqoYjabJ528l5XtSHWhUbC QCCZYqpU2sKbrCY1V01U6PGWFNtvthT2x8/pgaSP4f71aywUYIXQ19KvEeAJMuA8Q8ly 5IHxYLewBSz83Va3MdjP5NCu51hMLtIYwr3A1RQxfQbUjiKNZOfGZdbz7u1Yfa/ab5jZ UppcuFlnIAaIDmvOFtzRnbI/H9Z2x5UOF1TQ4UeJQkcIo3qCPjQ3FAr2RBlJe2FaztcK 1g1GjCStBd5bQPnfrKzgA56E5nuGj5pd5BXAT0Ijes9h7cqJXkMrYkMybXvpHKfZJ5uG t8gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770906141; x=1771510941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7YV6OK6ql/86N7Aeb4DVq+IwqTnAgt8zgYIHnXIV/C8=; b=MMZdyneC7EorzM6Xc4nYuuOyyQxfgOIpsT2YO5OOylYyo/fCDxzoUi8FVACW4/1/+Q EiD32RgYGGe6aCfEfM9xVySPf/vVQDqjm9HCc7AipN1E2M7ecyDzeN9si/ByjUSUpLqe HXfXEh3PcVAxhk4MoY/SUv+5XquT6luNwx9arCIU9Uqy3b5k1m5xwW++qYuaApZ6watJ XWDRAbrDMJLDo+bqEC3qvBQrkk8gjROEym2MfLh3agKkuUXaQRZpI3ivhoTfwvUHw7hV 7fsgmHpvvXWfzI12lhGaHphd6n7ykdmWjRWfPGh+xBVV/AOVnm/AAZJzZw77RkpVBvc/ 9RGA== X-Forwarded-Encrypted: i=1; AJvYcCXR3WlcfyajlqwQ6i8hI5u6mH2wkPXpFGqjsiT2gxUkDlJXHK480qIWKKeTYNgA3mSRyRM/eCHOfz4qGU0=@vger.kernel.org X-Gm-Message-State: AOJu0YwXWNd2+KbBClZTZU2iHyI3h6gLKgR08biaK00XQU778VlV3QuG UCcEIoBWbXal1rnDPYABvAPkm3zJpCqCJTNNy0bRDNuQr5DWTwqtAy0n X-Gm-Gg: AZuq6aJLbzJSlQo7bZw62Pu6IsL9XXT1vQqx3VVN6pflqR++8pBjrYZBWW6WnVRT9Ln ldM4cSJJ+wyexMAGntm6AQftHMgoQHUBjVnqgucIxkXPBMtsVPLpx2ReAHcUbX7Om3LX4vVXnoA 4GKp9/Pf7FgtkzIZ4saSr2UHABl32T0quP3Fna76cc9Ws5Zg6WTqvF7DFd/FypAMpeQRNWaJBIG BJuJqMr2Pj9vgOresK0X+t2saUycM8Ux8e65ELnuGo92q49SXMxOG4RkLbNIY8bBUGqekIgXnmo eQUuH8TKgITOyVKlFEBC+bMQdVlWSaj27htqjhHyQLVrlqiQ7OzzET3NYqLJ6PodG3JC+2K6dij A0CKk2Fnp59cXJ4jMtjzmBGKPm6sy8pRkPM4iGVoya2VzRrGbnXqYKOt40O1IvbHRj9/Vxzcnf4 6Nf+Q7MLspg9TXA+5KBxgLhC47YgMWig== X-Received: by 2002:a05:6a00:438b:b0:81f:3c34:fa78 with SMTP id d2e1a72fcca58-824b2e0a407mr2334691b3a.25.1770906140741; Thu, 12 Feb 2026 06:22:20 -0800 (PST) Received: from snowman ([2401:4900:647d:9ae6:881d:5895:580d:d8e5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8249e366b82sm5336631b3a.1.2026.02.12.06.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 06:22:20 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, ethantidmore06@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH v7 4/7] staging: rtl8723bs: remove stale commented code Date: Thu, 12 Feb 2026 19:51:28 +0530 Message-ID: <20260212142131.28131-5-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260212142131.28131-1-khushalchitturi@gmail.com> References: <20260212142131.28131-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Drop unused commented code left from older versions Signed-off-by: Khushal Chitturi --- Changelog: v6 -> v7: new patch. drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +- drivers/staging/rtl8723bs/core/rtw_mlme.c | 1 - drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 - drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 2 +- drivers/staging/rtl8723bs/include/rtw_mlme.h | 1 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 1 - 6 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index d6b486fb57ab..5cc11e6c7af6 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1178,7 +1178,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, = u8 from_timer) =20 pmlmepriv->link_detect_info.traffic_transition_count++; =20 - if (pmlmepriv->link_detect_info.traffic_transition_count > 30/*Traffic= TransitionLevel*/) + if (pmlmepriv->link_detect_info.traffic_transition_count > 30) pmlmepriv->link_detect_info.traffic_transition_count =3D 30; } } else { diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 45943f832e23..3c6278f9ae13 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -2504,7 +2504,6 @@ void rtw_issue_addbareq_cmd(struct adapter *padapter,= struct xmit_frame *pxmitfr struct pkt_attrib *pattrib =3D &pxmitframe->attrib; s32 bmcst =3D is_multicast_ether_addr(pattrib->ra); =20 - /* if (bmcst || (padapter->mlmepriv.link_detect_info.tx_busy_traffic =3D= =3D false)) */ if (bmcst || (padapter->mlmepriv.link_detect_info.num_tx_ok_in_period < 1= 00)) return; =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 6a85cf9cecfc..8fad375c6a5a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -4756,7 +4756,6 @@ static void rtw_mlmeext_disconnect(struct adapter *pa= dapter) =20 timer_delete_sync(&pmlmeext->link_timer); =20 - /* pmlmepriv->link_detect_info.TrafficBusyState =3D false; */ pmlmepriv->link_detect_info.traffic_transition_count =3D 0; pmlmepriv->link_detect_info.low_power_transition_count =3D 0; =20 diff --git a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c b/drivers/staging= /rtl8723bs/core/rtw_pwrctrl.c index 15657de5475e..666e241704d9 100644 --- a/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +++ b/drivers/staging/rtl8723bs/core/rtw_pwrctrl.c @@ -206,7 +206,7 @@ void traffic_check_for_leave_lps(struct adapter *padapt= er, u8 tx, u32 tx_packets } =20 } else { /* from rx path */ - if (pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period > 4/*2*/) { + if (pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period > 4) { if (adapter_to_pwrctl(padapter)->bLeisurePs && (adapter_to_pwrctl(padapter)->pwr_mode !=3D PS_MODE_ACTIVE) && !(hal_btcoex_IsBtControlLps(padapter))) diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme.h b/drivers/staging= /rtl8723bs/include/rtw_mlme.h index 66d522006dfb..65a9e4e9df55 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme.h @@ -102,7 +102,6 @@ struct rt_link_detect_t { bool higher_busy_traffic; /* For interrupt migration purpose. */ bool higher_busy_rx_traffic; /* We may disable Tx interrupt according = as Rx traffic. */ bool higher_busy_tx_traffic; /* We may disable Tx interrupt according = as Tx traffic. */ - /* u8 TrafficBusyState; */ u8 traffic_transition_count; u32 low_power_transition_count; }; diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/= rtl8723bs/os_dep/os_intfs.c index 953e29ad2c44..8b2e0330082b 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -620,7 +620,6 @@ void rtw_reset_drv_sw(struct adapter *padapter) =20 pmlmepriv->link_detect_info.busy_traffic =3D false; =20 - /* pmlmepriv->link_detect_info.TrafficBusyState =3D false; */ pmlmepriv->link_detect_info.traffic_transition_count =3D 0; pmlmepriv->link_detect_info.low_power_transition_count =3D 0; =20 --=20 2.52.0