From nobody Thu Apr 2 15:35:55 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9068635BDAA for ; Thu, 12 Feb 2026 14:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770906137; cv=none; b=MCs+BdDQ01FB12YL2TB3zO4AY9drOtO3N/nb7vlCIKIb+ZgdhxUdRQR3T7prIkOo5pITleZzm9QRHjsfNsso1g7Rj9xLqkakyZ0OL4kBDZIIVqDjAHdP2rMaIOstnrA0tnNYO0VbKVXPS9Tghd5YGS4Ypc+tX4UpfFwu6NlBtI4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770906137; c=relaxed/simple; bh=AVrSo12PevDCrsavSe2nODFjD/4AS0Ec0KkafXQfGv4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FxAib4jBxnln5i391+9D0/UgLOynXL51wzPzfNgKcyIbY9pWDl+1CMkxtJvUzGXYEv8+NMf2p/RDYA1ttqHvysqIcggQxhJp+G3WazNGsDagkpDa5d03yxZ5PIi+pS7LmA0hjk1vtIqtDYX7jjZjwsi0244pVcdrkHixmZMBfHE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=G8v5gsEr; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G8v5gsEr" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8249fc726e9so1169893b3a.2 for ; Thu, 12 Feb 2026 06:22:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770906135; x=1771510935; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+Dubv4xqureU0pvqUc34rSLT1aSAbaj46M3E5NdU8L4=; b=G8v5gsErS9qZIPd8xPjBy50nlOHHNyPeuEphzr+JcEDguNdVNUD5y+Xe0X7fgvqkS5 IMSN3PL0Kn4zOwmE1d/u2doi4dHHzVxRbtGEqhLqh0Ta0BmlC0YLhAHYV5dFVlKTWO6y cn1y/UN/9YaEJb4qDyd/X6QX2ZR1rkNEYorjRPKJii6S+SEs8ydI2tvfNjcq1Jrufc37 mHUNFwVuDHOaUQ6/zvweJh9AFXEHrNkAOtM5A4aHgSxDZHdKJ6O+dbuUTP5dBMw4hrk+ Hhaac5k5AQyOtic281SnckY7/XjZAyENm/Dwd+MJI5Ot+MFZI2TM8VeRzSJIwjA8wuaT d1YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770906135; x=1771510935; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=+Dubv4xqureU0pvqUc34rSLT1aSAbaj46M3E5NdU8L4=; b=gY8DSZJ6ntf75rq3qdvte2w/MyfnPjRszP5t3PCjtr7TEHMwy9hroTwJwmQ1Ufc09G fFaPwIsx2zhXZ3Kq+2XolWfay7R3diWvlKYLgxs5pPafnxhGODV4Vo/MDVI4nSExRDxX JrXc3gAIpfRcAp8PA0tqIkPur8tSsAH4+GRE55YOYPe1iyx2uLu2D6Um4IQMkTONB+/A UeJwAeZCmXdDnsmGBoq8sJPLwnkZFSxq+gCzemG7pc93uNQKZ8G47ZXmTRX0xEQlyuD3 rXSX1KrS9parD1s+kSlggSKNh6aO1HKENZE6PCdePafeYSN0Z6LMIZX5qlpFj61GwW6l tEyQ== X-Forwarded-Encrypted: i=1; AJvYcCVVu63d98iSQb0OUJ3s7cDWmH4ho+ohvxNLN3yLr7VxDsoc6kg1+CcO18VmKFg6V40Yu00Bbzj8eVFaAQU=@vger.kernel.org X-Gm-Message-State: AOJu0YzYgRfz5cmMJaPa1VtdsQRO6FfT4Oe+eqXwKkUpwmEmk5PuZSLM fbTcp5XpIXm0RoFpD0DAroJXD36qz3bQjZcMdxWY1de0E/7NOIBuvoeW1WbTLg== X-Gm-Gg: AZuq6aKFkuBngzefwCdUg7/ILHICoU5psg0SN5i/JkyLSU8xyaLFHbDyB/Sr7oxln1N CmOGIzPnkhIOSpMFY6hUnlFCk+22RMZ7r9kOoYsRS88JkJEFoMfmkSfHJU69NRypGWuBuGCB6fZ aRWIIknBx/wiA7KMnAVSeWmIgMUr121Sw5/UVes08o4fBZVlUQxF8A+QcjN5DXlP0gGP2zYw6Fd kcTW8d+cw5HZeXtceij9x1Ry1QGGqWdwrVCCoG9O7dIJRoTA0FVcPsgy0B9TiEYbDP90Ke2DkCB 9Z0DUpzgx43Ou6VboZ+nl0ub4AvlaHy3vayhFpcld1pPtoljjwYafs/7DFbWrhx55e90N7VOBxm gscHwzUvMnCvH4N9X6KElCnYxugZq9UCkhULhxy7As+XXRpegx65Z4NckfZvBo35XoFBazu5H01 B2ZgFZwtbU0cEDEgQ7jeGKQO0PpoRktQ== X-Received: by 2002:a05:6a00:1398:b0:81f:3f8a:4c37 with SMTP id d2e1a72fcca58-824b04dec34mr2880909b3a.38.1770906134686; Thu, 12 Feb 2026 06:22:14 -0800 (PST) Received: from snowman ([2401:4900:647d:9ae6:881d:5895:580d:d8e5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8249e366b82sm5336631b3a.1.2026.02.12.06.22.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 06:22:14 -0800 (PST) From: Khushal Chitturi To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, ethantidmore06@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Khushal Chitturi Subject: [PATCH v7 3/7] staging: rtl8723bs: convert traffic_status_watchdog() local variables to snake_case Date: Thu, 12 Feb 2026 19:51:27 +0530 Message-ID: <20260212142131.28131-4-khushalchitturi@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260212142131.28131-1-khushalchitturi@gmail.com> References: <20260212142131.28131-1-khushalchitturi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the local variable names in traffic_status_watchdog() to snake_case to follow naming conventions. Signed-off-by: Khushal Chitturi --- Changelog: v6 -> v7: Split from earlier patch. drivers/staging/rtl8723bs/core/rtw_cmd.c | 56 +++++++++++------------ drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 +-- 2 files changed, 31 insertions(+), 31 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl= 8723bs/core/rtw_cmd.c index b3fa54f7f7a9..d6b486fb57ab 100644 --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c @@ -1127,12 +1127,12 @@ static void collect_traffic_statistics(struct adapt= er *padapter) =20 u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer) { - u8 bEnterPS =3D false; - u16 BusyThresholdHigh =3D 25; - u16 BusyThresholdLow =3D 10; - u16 BusyThreshold =3D BusyThresholdHigh; - u8 bBusyTraffic =3D false, bTxBusyTraffic =3D false, bRxBusyTraffic =3D f= alse; - u8 bHigherBusyTraffic =3D false, bHigherBusyRxTraffic =3D false, bHigherB= usyTxTraffic =3D false; + u8 should_enter_ps =3D false; + u16 busy_threshold_high =3D 25; + u16 busy_threshold_low =3D 10; + u16 busy_threshold =3D busy_threshold_high; + u8 busy_traffic =3D false, tx_busy_traffic =3D false, rx_busy_traffic =3D= false; + u8 higher_busy_traffic =3D false, higher_busy_rx_traffic =3D false, highe= r_busy_tx_traffic =3D false; struct mlme_priv *pmlmepriv =3D &padapter->mlmepriv; =20 collect_traffic_statistics(padapter); @@ -1142,37 +1142,37 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) /* */ if ((check_fwstate(pmlmepriv, _FW_LINKED)) /*&& !MgntInitAdapterInProgress(pMgntInfo)*/) { - /* if we raise bBusyTraffic in last watchdog, using lower threshold. */ + /* if we raise busy_traffic in last watchdog, using lower threshold. */ if (pmlmepriv->link_detect_info.busy_traffic) - BusyThreshold =3D BusyThresholdLow; + busy_threshold =3D busy_threshold_low; =20 - if (pmlmepriv->link_detect_info.num_rx_ok_in_period > BusyThreshold || - pmlmepriv->link_detect_info.num_tx_ok_in_period > BusyThreshold) { - bBusyTraffic =3D true; + if (pmlmepriv->link_detect_info.num_rx_ok_in_period > busy_threshold || + pmlmepriv->link_detect_info.num_tx_ok_in_period > busy_threshold) { + busy_traffic =3D true; =20 if (pmlmepriv->link_detect_info.num_rx_ok_in_period > pmlmepriv->link_d= etect_info.num_tx_ok_in_period) - bRxBusyTraffic =3D true; + rx_busy_traffic =3D true; else - bTxBusyTraffic =3D true; + tx_busy_traffic =3D true; } =20 /* Higher Tx/Rx data. */ if (pmlmepriv->link_detect_info.num_rx_ok_in_period > 4000 || pmlmepriv->link_detect_info.num_tx_ok_in_period > 4000) { - bHigherBusyTraffic =3D true; + higher_busy_traffic =3D true; =20 if (pmlmepriv->link_detect_info.num_rx_ok_in_period > pmlmepriv->link_d= etect_info.num_tx_ok_in_period) - bHigherBusyRxTraffic =3D true; + higher_busy_rx_traffic =3D true; else - bHigherBusyTxTraffic =3D true; + higher_busy_tx_traffic =3D true; } =20 /* check traffic for powersaving. */ if (((pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period + pmlmepri= v->link_detect_info.num_tx_ok_in_period) > 8) || (pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period > 2)) { - bEnterPS =3D false; + should_enter_ps =3D false; =20 - if (bBusyTraffic) { + if (busy_traffic) { if (pmlmepriv->link_detect_info.traffic_transition_count <=3D 4) pmlmepriv->link_detect_info.traffic_transition_count =3D 4; =20 @@ -1188,11 +1188,11 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) pmlmepriv->link_detect_info.traffic_transition_count =3D 0; =20 if (pmlmepriv->link_detect_info.traffic_transition_count =3D=3D 0) - bEnterPS =3D true; + should_enter_ps =3D true; } =20 /* LeisurePS only work in infra mode. */ - if (bEnterPS) { + if (should_enter_ps) { if (!from_timer) LPS_Enter(padapter, "TRAFFIC_IDLE"); } else { @@ -1215,14 +1215,14 @@ u8 traffic_status_watchdog(struct adapter *padapter= , u8 from_timer) pmlmepriv->link_detect_info.num_rx_ok_in_period =3D 0; pmlmepriv->link_detect_info.num_tx_ok_in_period =3D 0; pmlmepriv->link_detect_info.num_rx_unicast_ok_in_period =3D 0; - pmlmepriv->link_detect_info.busy_traffic =3D bBusyTraffic; - pmlmepriv->link_detect_info.tx_busy_traffic =3D bTxBusyTraffic; - pmlmepriv->link_detect_info.rx_busy_traffic =3D bRxBusyTraffic; - pmlmepriv->link_detect_info.higher_busy_traffic =3D bHigherBusyTraffic; - pmlmepriv->link_detect_info.higher_busy_rx_traffic =3D bHigherBusyRxTraff= ic; - pmlmepriv->link_detect_info.higher_busy_tx_traffic =3D bHigherBusyTxTraff= ic; - - return bEnterPS; + pmlmepriv->link_detect_info.busy_traffic =3D busy_traffic; + pmlmepriv->link_detect_info.tx_busy_traffic =3D tx_busy_traffic; + pmlmepriv->link_detect_info.rx_busy_traffic =3D rx_busy_traffic; + pmlmepriv->link_detect_info.higher_busy_traffic =3D higher_busy_traffic; + pmlmepriv->link_detect_info.higher_busy_rx_traffic =3D higher_busy_rx_tra= ffic; + pmlmepriv->link_detect_info.higher_busy_tx_traffic =3D higher_busy_tx_tra= ffic; + + return should_enter_ps; } =20 static void dynamic_chk_wk_hdl(struct adapter *padapter) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 944f56b7acf5..45943f832e23 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1643,12 +1643,12 @@ void rtw_dynamic_check_timer_handler(struct adapter= *adapter) if ((adapter_to_pwrctl(adapter)->fw_current_in_ps_mode) && !(hal_btcoex_IsBtControlLps(adapter)) ) { - u8 bEnterPS; + u8 should_enter_ps; =20 linked_status_chk(adapter); =20 - bEnterPS =3D traffic_status_watchdog(adapter, 1); - if (bEnterPS) { + should_enter_ps =3D traffic_status_watchdog(adapter, 1); + if (should_enter_ps) { /* rtw_lps_ctrl_wk_cmd(adapter, LPS_CTRL_ENTER, 1); */ rtw_hal_dm_watchdog_in_lps(adapter); } else { --=20 2.52.0