From nobody Thu Apr 2 18:53:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90F7E35CB69; Thu, 12 Feb 2026 14:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905691; cv=none; b=sS8d/Tj+cKNhAKGVOW75M8dA0lsDu3wQkJyGQaFaNG/xsBzSh0bVXZVj4oDmFXKjTVP1pas5i4BQX5ohyrYda01fb+IYFxQsnV46KIZwHm7zZInGQVwYVo7tfmLOygeV9IPnZK+uMPiYQbdD5zuLWIrPQDAifrkh1EZTGlj0WkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905691; c=relaxed/simple; bh=RdzQsLETYKvlriLm/NMGW7KYXfnHS0fq0aSeOOeoJXM=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=Hha+tGHRoOjxV197JIAe5QNS+J7FNkP8d6LYeCyQNTOptIf6rDiKONaSjKMDshVltqGaql8ctv5xy0rLUwi/ZuieSTgIVj1QNqlTttdIinEWjCjZmRti5333jJtqXxzWG/ArCytY5XTWI/OZa3voHPSBUGHPHyttlmb4efGYDVI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U6+72HzA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U6+72HzA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42A82C16AAE; Thu, 12 Feb 2026 14:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770905691; bh=RdzQsLETYKvlriLm/NMGW7KYXfnHS0fq0aSeOOeoJXM=; h=Date:From:To:Cc:Subject:References:From; b=U6+72HzAW8FxFV6oUXlwSZk2p48eMlFl3nXeoy38Tj5xmoYh2SkIijLNBHo9lKnFC /nQhQSLw0DC9KoLy8ndz6ZAT8ms2208rxf4RnObv37l3QNmrEUpYQYfTLEvH4RxvmS myEitn3p35eyio47PqLzx5M9TMX7n+FdLRkhRjGpLYfjXW1NN8arvxmR8bKdtFcT9/ cdv51Kyoio1vOzu5v3V7sUH3C9DenPz+Gs8VQd5KG/hUg5XfnGzOM7ldH6Nc81Osuk IL+QkGMQZFRhwfdfDSGVO3/ANwUrO6ljO3n8ufFj/XRdb0+x40zcjq1BmAGqg1QnSV Z6ak7yDdnWhCQ== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1vqXT0-000000002lq-1q1L; Thu, 12 Feb 2026 09:14:50 -0500 Message-ID: <20260212141450.296763331@kernel.org> User-Agent: quilt/0.69 Date: Thu, 12 Feb 2026 09:14:34 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , stable@vger.kernel.org Subject: [for-next][PATCH 1/3] tracing: Fix to set write permission to per-cpu buffer_size_kb References: <20260212141433.849771751@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Masami Hiramatsu (Google)" Since the per-cpu buffer_size_kb file is writable for changing per-cpu ring buffer size, the file should have the write access permission. Cc: stable@vger.kernel.org Cc: Mathieu Desnoyers Link: https://patch.msgid.link/177071301597.2293046.11683339475076917920.st= git@mhiramat.tok.corp.google.com Fixes: 21ccc9cd7211 ("tracing: Disable "other" permission bits in the trace= fs files") Signed-off-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 845b8a165daf..fd470675809b 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -8613,7 +8613,7 @@ tracing_init_tracefs_percpu(struct trace_array *tr, l= ong cpu) trace_create_cpu_file("stats", TRACE_MODE_READ, d_cpu, tr, cpu, &tracing_stats_fops); =20 - trace_create_cpu_file("buffer_size_kb", TRACE_MODE_READ, d_cpu, + trace_create_cpu_file("buffer_size_kb", TRACE_MODE_WRITE, d_cpu, tr, cpu, &tracing_entries_fops); =20 if (tr->range_addr_start) --=20 2.51.0 From nobody Thu Apr 2 18:53:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90EA835B65E; Thu, 12 Feb 2026 14:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905691; cv=none; b=WflAsCslXjEe6GQz8rQ+tTm23sGvPCUg4ym3XL8xJoBDPzum2lYvukPHjyZkeEbXPu9deyrX41zhT4uJvKyYk+FzF5z2NlhoqbllcFKloOEn1S3dz0lKyGyhYW7iTFr1Lm5dNqkGZeTf8tT33MEHMU2V7VEkd4k8205HjA7JYss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905691; c=relaxed/simple; bh=5iN4Au8UeMri4/4aTlWwZL5atQwbRH8ebxaQUHqwz2s=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=K6QkPCH71eFlJvi57SjkTX6NmAq168amWQixxPJ18dt/5xoy3w2B4LH6E1jUwrr+sEAN75J0mxBholO1J+gIjt0eaig+iZ3Yzm12D4ZRObXvDbgceKmdcUijoMforUWgJ4+zss+ocT5Hb4eT9gYLjhWNNuBc5gmK6GoQ2voxMSw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qD++ga1E; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qD++ga1E" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F1A3C19425; Thu, 12 Feb 2026 14:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770905691; bh=5iN4Au8UeMri4/4aTlWwZL5atQwbRH8ebxaQUHqwz2s=; h=Date:From:To:Cc:Subject:References:From; b=qD++ga1EipNku49K9KDr4FwpMMGbM/xHHR98ZELglWNTXuOT/WecTQeGk6/H5BI5U Y0ZKPNWk8X1oH/sYfomyZNBbdId643Ce86MAkJYdQn9fXNQHMo7GKhUQYM4PZN7yqV qpRqCOuvr01xHgWXZ35EK0njz4r58qDEH74S3BiNwuhJvxKQSF+4uoNiu3Y2Kacyv6 97q46v+9M/h/vad5SGTcTv1XT7y2VhdvAsBn/OUbCWNAunpX5k043hJE/ubeUQLg7B DxpS+e7T74rLHcNCTone/XlxYwZXOr/6aBmfqxNwaFF+B4t+9MTuI6Jk7nMQp5Ch0C 704QwXX0xNKOA== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1vqXT0-000000002mM-2XMg; Thu, 12 Feb 2026 09:14:50 -0500 Message-ID: <20260212141450.462148762@kernel.org> User-Agent: quilt/0.69 Date: Thu, 12 Feb 2026 09:14:35 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , stable@vger.kernel.org Subject: [for-next][PATCH 2/3] tracing: Reset last_boot_info if ring buffer is reset References: <20260212141433.849771751@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Masami Hiramatsu (Google)" Commit 32dc0042528d ("tracing: Reset last-boot buffers when reading out all cpu buffers") resets the last_boot_info when user read out all data via trace_pipe* files. But it is not reset when user resets the buffer from other files. (e.g. write `trace` file) Reset it when the corresponding ring buffer is reset too. Cc: stable@vger.kernel.org Cc: Mathieu Desnoyers Link: https://patch.msgid.link/177071302364.2293046.17895165659153977720.st= git@mhiramat.tok.corp.google.com Fixes: 32dc0042528d ("tracing: Reset last-boot buffers when reading out all= cpu buffers") Signed-off-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index fd470675809b..e884d32b7895 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -4127,6 +4127,8 @@ static int tracing_single_release_tr(struct inode *in= ode, struct file *file) return single_release(inode, file); } =20 +static bool update_last_data_if_empty(struct trace_array *tr); + static int tracing_open(struct inode *inode, struct file *file) { struct trace_array *tr =3D inode->i_private; @@ -4151,6 +4153,8 @@ static int tracing_open(struct inode *inode, struct f= ile *file) tracing_reset_online_cpus(trace_buf); else tracing_reset_cpu(trace_buf, cpu); + + update_last_data_if_empty(tr); } =20 if (file->f_mode & FMODE_READ) { @@ -5215,6 +5219,7 @@ tracing_set_trace_read(struct file *filp, char __user= *ubuf, int tracer_init(struct tracer *t, struct trace_array *tr) { tracing_reset_online_cpus(&tr->array_buffer); + update_last_data_if_empty(tr); return t->init(tr); } =20 @@ -7028,6 +7033,7 @@ int tracing_set_clock(struct trace_array *tr, const c= har *clockstr) ring_buffer_set_clock(tr->snapshot_buffer.buffer, trace_clocks[i].func); tracing_reset_online_cpus(&tr->snapshot_buffer); #endif + update_last_data_if_empty(tr); =20 if (tr->scratch && !(tr->flags & TRACE_ARRAY_FL_LAST_BOOT)) { struct trace_scratch *tscratch =3D tr->scratch; --=20 2.51.0 From nobody Thu Apr 2 18:53:30 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0B7D35CB6A for ; Thu, 12 Feb 2026 14:14:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905691; cv=none; b=GmwLYc73ZCF96hzSWJKnowchL7L814ZV8R0rb4bAhc3GXJnad+jseHJN5FD1b7r5vadxGb2vpMKQpdNjHE1+iTZIyB2takGxPuJWIVicoXw+q8mOd7Ux9huF0dBbxBx/vF/RMP9KNaftKMUOiIKBUS0XVEb27uehnIcr1CvLX54= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770905691; c=relaxed/simple; bh=S25X8PIPlCAjt5zZS8X8m3Pitbbyrs/gtG56eV1alGw=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=ZHccbc/uVS3vldRZSBqtkBmmCKZKV1EUgMAZe3SiT8BVYCTMu/ZFYXxU90nAaKUqupbxPUAPG6Vje8ilQwsN7hq4StebOPcZxBUwK9yrfaJGIhqWAg/rwrCeMR1xpMScUcjwYhNsc3D7K+ul7RPsjk8svzxdqHRAG7SufGCv2w8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=leUQPU/x; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="leUQPU/x" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96ADDC19422; Thu, 12 Feb 2026 14:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770905691; bh=S25X8PIPlCAjt5zZS8X8m3Pitbbyrs/gtG56eV1alGw=; h=Date:From:To:Cc:Subject:References:From; b=leUQPU/x05Vakl7gUKznbu54Onp2xDrUUSKxz7txgkQUHgECCZArqkdXc+S+8gQGf e0N3/U1j0QKitRZmFq36VTrXKzxvjE07z2oyROFe9id3A1l2P+v9Xl7edkNlePSmf2 rrKYm++H4JVj9MBdT/hs6NJKOMtZTi/Q0+uWOPDKJ+ci8jLAGtFpJpw/9FYimD8BSA 2496vTtNU506j/U1zW002eN4z8shllxGUBw756sP42PwZOSAr5alEBI6Gps39rwl0s DziDEaE9PiskmBwFbJkDE59xwAlfGr3vKHIkvxEtlOPGF4U2EFfT6ye+8uo3b0TvM7 XT68xyiYeC/lA== Received: from rostedt by gandalf with local (Exim 4.99.1) (envelope-from ) id 1vqXT0-000000002mq-3CwK; Thu, 12 Feb 2026 09:14:50 -0500 Message-ID: <20260212141450.622648181@kernel.org> User-Agent: quilt/0.69 Date: Thu, 12 Feb 2026 09:14:36 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Haoyang LIU Subject: [for-next][PATCH 3/3] tracing: Fix indentation of return statement in print_trace_fmt() References: <20260212141433.849771751@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Haoyang LIU The return statement inside the nested if block in print_trace_fmt() is not properly indented, making the code structure unclear. This was flagged by smatch as a warning. Add proper indentation to the return statement to match the kernel coding style and improve readability. Cc: Mathieu Desnoyers Link: https://patch.msgid.link/20260210153903.8041-1-tttturtleruss@gmail.com Signed-off-by: Haoyang LIU Acked-by: Masami Hiramatsu (Google) Signed-off-by: Steven Rostedt (Google) --- kernel/trace/trace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index e884d32b7895..2f6fbf9e7caf 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -3537,7 +3537,7 @@ static enum print_line_t print_trace_fmt(struct trace= _iterator *iter) /* ftrace and system call events are still OK */ if ((event->type > __TRACE_LAST_TYPE) && !is_syscall_event(event)) - return print_event_fields(iter, event); + return print_event_fields(iter, event); } return event->funcs->trace(iter, sym_flags, event); } --=20 2.51.0