From nobody Thu Apr 2 18:53:28 2026 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB2E031690E for ; Thu, 12 Feb 2026 10:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770893543; cv=none; b=m4dR9miaEj5lKER16tekczxy6gwaRjjbJdIYs49cOxQL5U3KE/ey4ANh5vQdXQXLEGIZEvBaUfvaqUNnxMFPHDFYnhwZchHDBefXGacav4sw4sqoGKdttNRY3ZtLqWQFmhn3NaoyT31OmKlhVYU0YMcBIMkbLoBzziIwVdKZYcg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770893543; c=relaxed/simple; bh=M758VzHgotlN+kfEhAbWbWKyGxRbK2JrlTQD1v/8ieg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D00+NwjAxIyHnsja6jh8jfBeMkYoSZJUJ1pF/q/kLrRO420Tk5CMagAxTUbsiIGvLp2ZU3hrmI1KzPaL7F9xEvuJ7odzbcAJs9ifnVps5/THswSq5BPQY0c2NE6iN/xq2AVrxQcu6hkKlDiCBw4l0zuPl8n522/nhFjdDOxKcTQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Do51Kf/Q; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Do51Kf/Q" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43626796202so2572749f8f.3 for ; Thu, 12 Feb 2026 02:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770893539; x=1771498339; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aLX5DYLUxvDUfj3CKP+gBQBSQ0b6Y08NrMQKc5dZFp4=; b=Do51Kf/QlkK6b+nhxNLo+Gsw3dz9qaP9JLPEzrjRE/DLzY6XzYTK/vITcBd6bU1tS/ TozcgB80/dAN2oiQG8WMFoxRRFW7BfHS8bD89ZmoMkNWQY0Pon1okX9RzLTJCndTSsm7 7hn1So7yxnwadL1X1VjxZP9erT1kqLwaHM0rT+2Smlb4V9ZQjQb1VlMpd/0qT70hph30 ABRwvQSJJfXyMHTM+cvKkpG2TJSCvuJNZuSF4e2UdRoBUExwpxsVtLXXYeZI3+3o+i3V VJMc+CXRcdC6e0kKGswTUe8UBua9X38dBZl8VieHXcj/OWxUH67xWSxTWWQXTpG+ykws d//w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770893539; x=1771498339; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aLX5DYLUxvDUfj3CKP+gBQBSQ0b6Y08NrMQKc5dZFp4=; b=siJYozttuW3w1d6z0yHOOAZ3eN5Y63EPTOlp0F+cFJzpCd3BxYveTlhYyqfrCfeYAC Xv70lWmNFeekJ2apkvZ/0Ifx4d1M8DREAqqGWjeB/Nvsz28cBmQ7R3Yetn3L6Lno8ZPe RGeQzVfIHn9/MpahnydVTtFFWqMPQe6CsBmfLODFEUMtOpLznDx5EPIgpS9XyDSSGy3z 0rDW0PeFmkKqUp0LpJHumBrUH/wlDyLI0zc1/gpjl2dVLdEgbTI71i/0oIiOA8sbvaDo hQr+vD6bdRI99WKebPQjPKWG+7ZlPv7cCWZr2VxQQ5s+zSzRMTCmu5ykgGrkZCSksZEL K+2w== X-Forwarded-Encrypted: i=1; AJvYcCU1EgBMq8yvIBKI4SXgq4KQaaO3Y9zabJwk7NMo5NWpZXdq4XoATcIoNlIFbE6Y8/QBQS6V3S+VpzbQLx8=@vger.kernel.org X-Gm-Message-State: AOJu0YxYnQpGLDMvdDYvsh2xhYAleeJupE/MYnwNdwJAwawBCUDBVGl4 nyaNvR/myd9cp0GgY85lwYoZ5Ofw+QMa7dFXeoYDGKkomU2MxClyykSIiFQJ9cbu X-Gm-Gg: AZuq6aJSbbaAfhCl/BI38HqpnxJkIQ0BHioDCIL2IOkQfGiHmPvMGDiAEyoC4vRvLOk CLsXDVnGM/UNb2h8qtI1WQKNXpBOtmK8X447kz0p8PlE69AUxKuGOW4J/z8iaEauM5DaKxXumVs ufqPGU0bZWLdTu8yBbsLJvdre84WV/XvrXbGvcPVvpF8tlUznoKgZaJTBtDu6lo0lvM0vutyJVE 5Mv0k5xT/SsYlmL2217hOSwyoDJSGiuMotpi+eevAe7ZorvOA8QiGgEykckY6DPpE/luokgUliK keIlXKMUcW3kYVtEWijLMt6bmgiQr5UMiaKEJ1qdbJ+a3H9asF3MVagni6EfOyE7xKS3lFny6zn R83VHcNDa3YNSTXFK/pbepa7eRzZb9LGy7fnEsXw9nZx8Rk4ZIWelj4qH6auAQLW+JnREgKLb+u fAlrHKBsTO1sdfdJaph6HEPbD80+cy8OkGekSLV9kGerxeAGFpvGkbyjw= X-Received: by 2002:a5d:5f43:0:b0:437:6c2b:2f52 with SMTP id ffacd0b85a97d-4378f1465c8mr2594082f8f.14.1770893538869; Thu, 12 Feb 2026 02:52:18 -0800 (PST) Received: from fedora ([193.77.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783d46ec6sm11461652f8f.9.2026.02.12.02.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 02:52:18 -0800 (PST) From: Uros Bizjak To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Uros Bizjak , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Subject: [PATCH] x86/local: Remove trailing semicolon from _ASM_XADD in local_add_return() Date: Thu, 12 Feb 2026 11:51:02 +0100 Message-ID: <20260212105207.18510-1-ubizjak@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the trailing semicolon from the inline assembly statement in local_add_return(). The _ASM_XADD macro already expands to a complete instruction, making the extra semicolon unnecessary. More importantly, the stray semicolon causes GCC to treat the inline asm as containing multiple instructions, which can skew its internal instruction count estimation and affect optimization heuristics. No functional change intended. Signed-off-by: Uros Bizjak Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" --- arch/x86/include/asm/local.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/local.h b/arch/x86/include/asm/local.h index 59aa966dc212..4957018fef3e 100644 --- a/arch/x86/include/asm/local.h +++ b/arch/x86/include/asm/local.h @@ -106,7 +106,7 @@ static inline bool local_add_negative(long i, local_t *= l) static inline long local_add_return(long i, local_t *l) { long __i =3D i; - asm volatile(_ASM_XADD "%0, %1;" + asm volatile(_ASM_XADD "%0, %1" : "+r" (i), "+m" (l->a.counter) : : "memory"); return i + __i; --=20 2.53.0