From nobody Thu Apr 2 18:47:41 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AF412E543B for ; Thu, 12 Feb 2026 09:57:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770890248; cv=none; b=DoWuBpWQUhO4E7bjM3L2pKgnyRZOTjsl/TbnT5RmUGFaCOaC/cKCgJTWFnXiTnWfFFHaRXFdzNeDMtUj/+4NzpAgp79QzAnreqirhKriVSNTPexJJ7KRAgIS3PM/oA39M0jgF//KeVFzS4cMBoyAowOUhtO7FEBRghYe20OAM68= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770890248; c=relaxed/simple; bh=A5kxwkb9pyLuOZSYwAnJI78nrDm6G7P38RMcwSN8fek=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pzvd4j07wFRZuJJXclmu7MJDvBLM1inL08WhSFLXKK+23vakK0N3R0Xb64sZSjdmi/74TzClL22+fzOBNExqnABmsni8bPuSL+gL9mXcvyyb6Ip0tE2WUvY9y21i/3lznONnqRWINQEhN++7/VDIsPvnaD3Bn2HrpocLlE91UuM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UrhP+Gcp; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UrhP+Gcp" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4833460866bso1882375e9.1 for ; Thu, 12 Feb 2026 01:57:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770890246; x=1771495046; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ytyEs1/YnZxnv9lnNRonE6+DQR6UbuV0ywPhF1Dur1A=; b=UrhP+GcpIVYTCWwiDafI1AzRubUxe7lKA1dsE6DTjwwScS/2IRQvaNqggI7HHwubDf Gi14/XAJVrQX9ykJBuaaoO3BJa/+ZXwx91JTw8/pypp6wBaoydInzuKecUaolGOct8jA F/JlJnvqWMwTsQAZeMjRDdkPc52pq4qa/vVt1qZEtEn9NBgPYQ6+qICGqZJT2NMeuvYU VK7L8lS58A8VGOeiRcGwIztV431W4IivnQzLbX8UhJ+78/MJfdcIvRhBbdCJlhk98ZTv 5eOPAe+66X0gVoq3MGsI2P/LE0JJ5ZcAyBzR086PXOo2afiEq6TozInHXcScThWGuNKn v7Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770890246; x=1771495046; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ytyEs1/YnZxnv9lnNRonE6+DQR6UbuV0ywPhF1Dur1A=; b=LFc8fBl+AIID19lgYoQK3V2853N7cD02KO4/tGVKGBEZ9c1nMJ3LDgJTzLONcOKmMD qgiZCXc41lSl3vlRsUX+rZK8ppA1FJ9c580bPUAuKaJTFy9Fr+2w1lbng/5b/xqh3/4O X74kgSfsnSUuRK29CBm2KwHmwzNgXJiUmoXHcFpFMh9A3L0LyTHjlp/ntHXtn0bfhEhZ AbByowZcljAFEgyfiqdN+BkhBsPzMgtlGD22q66riNxeiFdJCspdDzxohpMOlDNNE9Ro HQxdIHEdm2mlxY34yCEiEtvebWRQrl9rlxHJ7GxjEiO3qKJRt9WnQLFdV/UIjT00gQd7 nUHg== X-Forwarded-Encrypted: i=1; AJvYcCUeu/Jv6lf3RG/oerkF2fCDeVwsWl8x2WBR43Q2t8S4JJb19RiZXLbxURm0qH6qmMKBpMcOssZckWfiRpk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4/J4FSFoQr4SEByOTS6LDUVZs7YKSR79j5wu96l+70c0yRy/3 MpAd8DSEanq9UIZyYObucTWO3sAkeUYg5k/VNSih6CjSv2Rc9qIn0RXE X-Gm-Gg: AZuq6aLKIIOKGe5YRxiMuBfWnoV8SycZJLtYJuMv8oeTysf0xjgl46MWuZeRuxKQd2R 68P2dvlZbqKbwzLhZ2RHZBPVIdQC1pOtO1hi2IYpgQaPg+Go+XNeF2qXcNhCH6D23wbAjRZrVRH xfW7DO4PLDpM/NzzlsxOChyumHVIQzORL62H66XdTKv7U8h6KaNebBMyihyscc1UX2dplDywaxJ QA/kEGuDWaGWGtenQARAbdgk8qlCpgjYIlJ5yTNiH9LuH8slT4rZQL8xqrDVqWL1py1rmxIOv0g UeF0Tx4GHYg5dIRjck3Y/uSoNBVL5TN6KLED3+DfQLajs7SfO3T2fqgWkqdpnAtIqnRGlv7WHGr tNX48eVqsj0oXw2epa7TO/oJfiG4M95DlqLeSw+SJCzMNC+EWLvH2/1bYAEJYntcmI7dcszEnWM Z09PRqC3vbn4nZN1hC9XPO+91czqhP6zVaYUI+Zy1+Rle2EqqZA+o0phCjQoCNUlfW/vTGOIfpN c0XjGuAxYskqg== X-Received: by 2002:a05:600c:4e91:b0:477:9c73:268a with SMTP id 5b1f17b1804b1-4836571e7d0mr19202025e9.6.1770890245776; Thu, 12 Feb 2026 01:57:25 -0800 (PST) Received: from rachel-VM.. ([31.44.137.237]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4836131d48fsm27902405e9.24.2026.02.12.01.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 01:57:25 -0800 (PST) From: RachelOvrani To: dan.carpenter@linaro.org Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, RachelOvrani Subject: [PATCH v2] staging: sm750fb: Rename nDirection to new_direction Date: Thu, 12 Feb 2026 11:57:15 +0200 Message-ID: <20260212095715.2844-1-rachel.ovrani@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the variable 'nDirection' to 'new_direction' in drivers/staging/sm750fb/sm750_accel.c to comply with Linux kernel coding style guidelines. The variable holds a newly calculated direction value, so 'new_direction' makes the intent clearer than 'n_direction'. Checked with checkpatch.pl --strict: no warnings, no errors Signed-off-by: RachelOvrani --- drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750f= b/sm750_accel.c index e1877e5d0..c796d410c 100644 --- a/drivers/staging/sm750fb/sm750_accel.c +++ b/drivers/staging/sm750fb/sm750_accel.c @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel, unsigned int width, unsigned int height, unsigned int rop2) { - unsigned int n_direction, de_ctrl; + unsigned int new_direction, de_ctrl; =20 - n_direction =3D LEFT_TO_RIGHT; + new_direction =3D LEFT_TO_RIGHT; /* Direction of ROP2 operation: 1 =3D Left to Right, (-1) =3D Right to Le= ft */ de_ctrl =3D 0; =20 @@ -173,7 +173,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ =20 - n_direction =3D BOTTOM_TO_TOP; + new_direction =3D BOTTOM_TO_TOP; } else if (sy > dy) { /* +----------+ * |D | @@ -185,7 +185,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +----------+ */ =20 - n_direction =3D TOP_TO_BOTTOM; + new_direction =3D TOP_TO_BOTTOM; } else { /* sy =3D=3D dy */ =20 @@ -198,7 +198,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ =20 - n_direction =3D RIGHT_TO_LEFT; + new_direction =3D RIGHT_TO_LEFT; } else { /* sx > dx */ =20 @@ -210,12 +210,12 @@ int sm750_hw_copyarea(struct lynx_accel *accel, * +------+---+------+ */ =20 - n_direction =3D LEFT_TO_RIGHT; + new_direction =3D LEFT_TO_RIGHT; } } } =20 - if ((n_direction =3D=3D BOTTOM_TO_TOP) || (n_direction =3D=3D RIGHT_TO_LE= FT)) { + if ((new_direction =3D=3D BOTTOM_TO_TOP) || (new_direction =3D=3D RIGHT_T= O_LEFT)) { sx +=3D width - 1; sy +=3D height - 1; dx +=3D width - 1; @@ -277,7 +277,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel, (height & DE_DIMENSION_Y_ET_MASK)); /* dpr08 */ =20 de_ctrl =3D (rop2 & DE_CONTROL_ROP_MASK) | DE_CONTROL_ROP_SELECT | - ((n_direction =3D=3D RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | + ((new_direction =3D=3D RIGHT_TO_LEFT) ? DE_CONTROL_DIRECTION : 0) | DE_CONTROL_COMMAND_BITBLT | DE_CONTROL_STATUS; write_dpr(accel, DE_CONTROL, de_ctrl); /* dpr0c */ =20 --=20 2.43.0