From nobody Sat Apr 18 01:58:27 2026 Received: from mx0a-0064b401.pphosted.com (mx0a-0064b401.pphosted.com [205.220.166.238]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB9C3FBA7 for ; Thu, 12 Feb 2026 04:00:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.166.238 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770868860; cv=fail; b=qVotkgOLuV2Ef3jvnXpHTtbSez43kBIsTNY95JzxW87R2F77u8ecyadYw8W4jdTKvx/JdttmaQvjbpmh32Ev9197gP8Jl0bxawTcOLkcJArcLHe/qzLqPzFmvRbxf7g3TVdtjKclNhk+fGThWSuaDr1Yrpk2b8Sl4lNjN+Wkovk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770868860; c=relaxed/simple; bh=GN7IyyTa4T1KUIjxmq2JGWsHUbMzc5mMTOYrLhfapM8=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=AYxAZGGsw5CvbvlHyjYfX5VQGisvHgEif8+nXKGThEINImCvJ98paVKfLR6fqBc7mLhgqDnguLcJOWxke5y2i4KvxtWEnfC5JUZzEaWA1Av2g/YsqEI2yNd7147ItE58D2VJVS+EouCj+Vc+yT4Axnt2DKYDExZWbw4aU0XPYKs= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com; spf=pass smtp.mailfrom=windriver.com; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b=UCqyKuys; arc=fail smtp.client-ip=205.220.166.238 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=windriver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=windriver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=windriver.com header.i=@windriver.com header.b="UCqyKuys" Received: from pps.filterd (m0250810.ppops.net [127.0.0.1]) by mx0a-0064b401.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61C3GCF02221869; Wed, 11 Feb 2026 20:00:52 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriver.com; h=cc:content-transfer-encoding:content-type:date:from :message-id:mime-version:subject:to; s=PPS06212021; bh=DOAiRm4I7 ANBrE7yPyLl4+GCBOy4xuOmC3yoVTqS7+I=; b=UCqyKuysJHPGuo8B6J6es8FqA MvKtOUpSVbx0vxTkqjxJ4XAVj5JougVuUdo6CEzMW+9c42sV/mV/r6IMulvzUh8s 8OFlm3rHObZD4ldHtrtkVYluNb++XQY/8rbqj1FAP2eT/0SuA3PyJ2UbNMKYN8sI J+W72aMhC1D9aHPzgB3LzAl8sgHMDJH6VE9/WQFlk5HWKT75VcChG4flM+iJYeg0 JEJIZjxqLnrmpFMerZ2wDthYo8xs4rWkPwkd0BOzcZGPdME6NKcI5l4iJUTh1sQy hZyAmOUZMqxX+F2BNhFahzwTpolESaZ3EU00dyD3NSvjkOuQiqRSj0JPaOr6Q== Received: from ph8pr06cu001.outbound.protection.outlook.com (mail-westus3azon11012007.outbound.protection.outlook.com [40.107.209.7]) by mx0a-0064b401.pphosted.com (PPS) with ESMTPS id 4c61j4wdct-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 11 Feb 2026 20:00:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t2q8oPJZxNeEyxqAlfhSjc0taHQeRLOvkqsNNCKw75wWPmRB7+BW5AZ31ZNOUy93CWKEB2BG/9Q/7Y1mW2ynpF87+ePdEivjPGrXBB620PmKf6nANAfoka/EPSK7giA2zLUIFLy45As18xjXwu96HyG2d1q2cMVEPXoRn7GuxZ+2bfJbTX31e8SgprSM1KHSmSUA1X20xg3hhGMdsw8LtgnA99/Pp1LqHZBJHYDOMlQ4mU+Ud2HpUZGzhiTdsY6OLzqTlchiOWYYibLaabM8PR0MN41RwrsNhXoy2I8m7aRLHiSuegAFqccuqcy0HlLRbeEoCzO8wP/e0dQeOyVqSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOAiRm4I7ANBrE7yPyLl4+GCBOy4xuOmC3yoVTqS7+I=; b=ZqmmQwZknsTwF3FTCP2Z/uWFh7luWh6QlXFmmlLf22q8rvUluFhIY3msT/aYQiZynnmU0f3yFK8AgPxLNoQtJSIVU4W1bwqKVGqLWkQT5MIcn2RaZVNmpoKmFesS226UpH0F9GiplUPXLEtDQNLnyzzEbZ0iyDefj67zeXqgF+ALgnivO+/iM6DkdP912ycqRvQrjYfxpKF2C9MuMVpXOxzYm4Or2/O7S7lgXrK9RnM2vQrNeL1LnE6h5VuDq32e/hPyRVmXzGW+yFW9Xn4bTiLbSwbJwmi9+hq5ZdHdKy7A8IMrjQxcQAvvssx/VlIf9DFFXJN3ZDOy8V+J2Gym3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none Received: from SN7PR11MB6971.namprd11.prod.outlook.com (2603:10b6:806:2ab::21) by MN0PR11MB6085.namprd11.prod.outlook.com (2603:10b6:208:3cf::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 04:00:49 +0000 Received: from SN7PR11MB6971.namprd11.prod.outlook.com ([fe80::ead3:517f:5eae:ecf1]) by SN7PR11MB6971.namprd11.prod.outlook.com ([fe80::ead3:517f:5eae:ecf1%4]) with mapi id 15.20.9611.008; Thu, 12 Feb 2026 04:00:49 +0000 From: Liwei Song To: dinguyen@kernel.org, mahesh.rao@altera.com, matthew.gerlach@altera.com Cc: linux-kernel@vger.kernel.org, liwei.song@windriver.com Subject: [PATCH] firmware: stratix10-rsu: Fix NULL pointer dereference when RSU is disabled Date: Thu, 12 Feb 2026 12:00:35 +0800 Message-Id: <20260212040035.3182294-1-liwei.song@windriver.com> X-Mailer: git-send-email 2.40.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: TYCP286CA0015.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:26c::19) To SN7PR11MB6971.namprd11.prod.outlook.com (2603:10b6:806:2ab::21) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN7PR11MB6971:EE_|MN0PR11MB6085:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fd770a4-3f2f-4951-96c7-08de69eb4ea1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|52116014|1800799024|366016|376014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?ygjQipVf3ApTeqW6eQEsLVn01WyP4i2nSIkoYPVm10eax4i65hqIFCB/ER99?= =?us-ascii?Q?y3SJyXVMesxYaVCKLhJXrOV3nTLYWV71mrNmoizB+WIoM40txRxBepfZXuzZ?= =?us-ascii?Q?3MrHZSgQ3nXonSiAOjmDJIEMJ4SXKpiNBHgcpVG1ImEoeV0pxkINreDCrPQ0?= =?us-ascii?Q?JLhyDpx3Uj42j/rZACMSsmcyQntAexdd9iROAPr/7SJcc3/hVcT7+NMF/qM4?= =?us-ascii?Q?tA9njlsFxMxvHuHjD19pxnZS6y5FgmpStqYTcsViWthsjoEm5QVIYYPezSos?= =?us-ascii?Q?h0hppEl4z76+8Qofdk1sMvqMtoa+A2eLvA6ynvUXgzqvIztEGDcYi2ZmCSDU?= =?us-ascii?Q?eEnp4eKAt/mEQwEClotxxGPABeCUMd/BgAQUxELUSllL7sSGJ6QYI12O9qoo?= =?us-ascii?Q?S+ybONy2eZq/8d91Hzp3awZz7rDkgw+fhrwJcwKZ7+dw8nl0yk8/r+EBUoJq?= =?us-ascii?Q?miA91D3gngAS/NiBKMNAXBPJoYQQj34zaLz7XQT3DlYn6pLYi+rk7eS2B2Y0?= =?us-ascii?Q?5A1i5IQb7k1mgST5YG7QeJLrcP6Xg76PZV29AowLjR42hnGY3B0WCiV2lrvF?= =?us-ascii?Q?2jUWhgAQxmieL2zQTMrSiM1DMD5sxt9/xRNmzMEtqrJneIksyxF/AGaX9Dgq?= =?us-ascii?Q?d6Rg7ICwISHOt/JNpAjCC6tiT/ktlHhGupgniQd15wfS8uuROqXjFIq7cJ25?= =?us-ascii?Q?zCquyh6vPQ7lPe+cQFZnqIFDDz1K3OadWoiq04PZ0v2g2qsCtuIEqckMW1Eg?= =?us-ascii?Q?F60VSy4cHEoqf6Q8Ptprf2I8JKnr2N/KSGGcnS5bXbVI4lA6GnPiHi93roIb?= =?us-ascii?Q?/OzzEhokd3KVFI/oelATewFon6BUhiQpGkdGvadZ7VONpZpOzXuAWfBW/nvx?= =?us-ascii?Q?+2t7aixwmQy9iriKeH5xb7+/8p1leDLnkyXNyWPKXuYIpk+XLwljVlffxIYc?= =?us-ascii?Q?qYy+GZgXOTq13wKM9KJIG1SgLMT9BGqGQekunTEgkeoGkYmjIQpnFk8NP44e?= =?us-ascii?Q?Dbdf2UuezYHN1jx+hygpnPqaAyn2mYZSzlqCoRdnvYh+Ad5hIKpNW9k4DJSU?= =?us-ascii?Q?bZKh/2IsKqO0o0P/EBGLIm0oFOv58FUne5Nxw77vYk7H0yQUHin+/E52/mDT?= =?us-ascii?Q?hxD2iXNjYoiK4SOgQMMNYEwJmZ5Q35k0QUDpOBVUcoyLvFZ9BWRx416L6riG?= =?us-ascii?Q?mv6qIuJhSWqM3Os1JQoWts8pYYHzuxPeL90YcZ+qu4aRpWQQoZhitBQaCUxk?= =?us-ascii?Q?0z/936msC2UMslgzGiNCs6mAHbaJHU+yw17UU25PpiynTqAn4enyLVpskUId?= =?us-ascii?Q?w1/7nHCV/+LFvED81amM0fJU2C8p+jlHSVYbhKKt2FTodo7tvKYEB72nEBis?= =?us-ascii?Q?NC6RBYg0Zl2Ko2KSwE+BWOKBFa+XPVtZbw2ueFO3mOYhQOnyh6AtnKU5CSSi?= =?us-ascii?Q?Cureimf55GxDLUVDmoe1UIlhWi125LC6eICF3kSs6nYM0pw23aFikBkmcgKk?= =?us-ascii?Q?vZyKt17xosCrqLf2yhXRshJMbBtCGiYXOubV62IUy3APo1DEKCO5VOxvwIeg?= =?us-ascii?Q?e2Z9fJnkX7rZ/AZSFvFriqmTEFKknyTtznX2Jw3KVcwVW0HJp1hGWJiNBD7F?= =?us-ascii?Q?saTROS/3T58MmB7UAghvHaQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN7PR11MB6971.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(52116014)(1800799024)(366016)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3Zvkh2V/wZwdC2tNK/+ildk9n/ZwOUmdEPKMFgqPuKBQaKbKBI3kUpaVgxm+?= =?us-ascii?Q?bZYa7LdyEp1RpoLVgiEc4nuKu50wrQcYQY+Q0qCatFwINN3gGujA4gTEqKXE?= =?us-ascii?Q?Y8lx/gRLuhKFcMWalR59oerC8OVsoyWqMlHAxkAA6XN286B6WchjFMnPc189?= =?us-ascii?Q?uf5jFVT0CwPheK6H5ucow08xvl/q7+KaBxck+VoRWT9+P88HMWGyhKOxKgPq?= =?us-ascii?Q?BuA8vehCOpm2rYj/kzHhmgVRINYlKBz62aKjI2mP+lH8g43IH+pyM5FXVstE?= =?us-ascii?Q?KlQ1EcQ8VyPRU9+cUEdAx0vz36id4WJfXpKiaWS7C4sp9qVDSz5Rrq2to4Dd?= =?us-ascii?Q?4SuIGb0wvprPw+mWtJoDXEW6BXMnSXoatb4GnrHhutX/vEfy9yHomaCfRbYr?= =?us-ascii?Q?UJfTPuAUYQoVce4x5TVzzW9j0N2fRpdHVS2aMaorWCDSP5VKcjxzcQj0ukCf?= =?us-ascii?Q?1oQeOM2HnPtDvsnEPFR3iixmn+DzORQOa4ws/LZhVAUssbh6+v1hVlzpYIdv?= =?us-ascii?Q?H1UlAazlhHcMM2TQjRBtSKaHFIb/FDnxRExBBIbHjv/aYVgv4jwFIHHyamYa?= =?us-ascii?Q?o5ZzD+BlNZWtNRWDyUa7c4a6F2fz44tlnktpavQrMrYCV+J8SwgHoOOnH5uH?= =?us-ascii?Q?VTHKj/pTfQNjMVgc2g4lK+xsAjFKaPC0UBc8xgcCAYOhLO9depxM9KKnQVNs?= =?us-ascii?Q?YCP5Fd7P3lHmZTgn0JH7Gf2tVjXOy0iaNeimUARVy7/dZJZugm5lL9tT8lja?= =?us-ascii?Q?ORwTwOWZW387KVPYcqDPiTJVwHpp+IbwfyXKsSIOtYCO3VpPIJamRAF27J1g?= =?us-ascii?Q?Pd8JjukIQ8wDYGaQ9CsSalPysAsUc1ACxD5BSXU0ix4qQvAlPIaN7JG2w7oz?= =?us-ascii?Q?UEZKx+kSbUNCNemauowF33M9j9hLvyP49Qy+4gs184k6cy8IDHp9ij727N5X?= =?us-ascii?Q?c6FCAGjO2oN1uXvSCLQXd5BdY1XocNbFblDVLYcVuqXIi7Mne1quYAxrzkBE?= =?us-ascii?Q?2B+ku1xdix5H1628gXwVFrmtLqWo4xELZNLpFWSjcDOvLT6Kl1V/CqaMg0k2?= =?us-ascii?Q?sNjqVA5YjxmQ/5oa4iGlot7pBS98GxebGmBdWDaBoTRe4dbgfSg9sGGA7rdL?= =?us-ascii?Q?ngenowBmRguZQf+bbtBmavEjW+MmIagFy0bVjvYYbd6NJHB6gp70aOMTyKmZ?= =?us-ascii?Q?fwe2eFcPpgPrEEFdnjITp97jHdHSqYBJ6AgwtlcDn5Q0Cxw5cGGMk9n9Qg4X?= =?us-ascii?Q?e0Xu9++YFH6/woC//O8iorKI1yv29Gsaw+PlhcMsUHYRQgLuxsL1N4LT9r6q?= =?us-ascii?Q?ek2IiG4PMthXlce9wumgCdj05r6AFZul+zE7HpH6vvUb/wG8KxsX6Fr4GSqr?= =?us-ascii?Q?GU+URIhkENymiywHgOtxFge6VjGaEaQeeP16Iukglh6mOAGcdnA3J9TupZde?= =?us-ascii?Q?FeLsHRAK8ClV6OTa7oRSnjkw267GkzhBfPTt3Nqp/k6u6Vc1hnL7ysib3r3O?= =?us-ascii?Q?bIM7EakX2NqH1MGqRiXlzBFivKM1lVTZDf+sTzpSM+yz0XEyRUk2VpEqwbQb?= =?us-ascii?Q?BVq5TSEow6UhwSVI4pXfnNOkGAFyhUlavq9q4S3YoQX2bkfnYLMfZUFyZQZ+?= =?us-ascii?Q?Hr6qiUQ32UCYxn2TDLDq3RWb1O5424HIrmZuW/Me8Oj2X47hL1zTKpcVRzZs?= =?us-ascii?Q?duBZgMr0kXYWMRImYIADB7szss1pN41aV8DUNkb9yKraswJt+OedxSxoaza7?= =?us-ascii?Q?DsXm9MEwjQ=3D=3D?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fd770a4-3f2f-4951-96c7-08de69eb4ea1 X-MS-Exchange-CrossTenant-AuthSource: SN7PR11MB6971.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 04:00:49.2588 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IdDITluWeE/t+iUNygJHy4mZbZnCOFU8+UlaXVoz62+TLndGr4DQCFPPfxZWfx9gjgZZMDRJUILUrPt7x7e4V47shvyACst3rmFx1UJDeXY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR11MB6085 X-Authority-Analysis: v=2.4 cv=Wb0BqkhX c=1 sm=1 tr=0 ts=698d5073 cx=c_pps a=OJmONvCW+i+0F2OUQkAdQg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=HzLeVaNsDn8A:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=t7CeM3EgAAAA:8 a=z78e26G6KZqfOvmJIgAA:9 a=FdTzh2GWekK77mhwV6Dw:22 X-Proofpoint-ORIG-GUID: W3TJL_Tei82asIXkKAD_xV-a8pmBCp6u X-Proofpoint-GUID: W3TJL_Tei82asIXkKAD_xV-a8pmBCp6u X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDAyNSBTYWx0ZWRfX7a/wCBwg1iNo qg6OHUdxyB7voggTI83wJqgHGCDa4KKeoY56DvJ73GfMCzgA/ltox76U/c4oP0Zz1jr6OOOHM1I x66V3VJNk7XN9LbphZCRUcI/Jjif8IEo8pjAzjrbnrSTNlUo3NoP3zc3THZENzkehQPVHy/qfCP 0nv8Eg0IsWJDqsvZ+2rmC4FTFJzYfmTmySRhzbwbjBic3ihSMn9wvQseOgYldUIrfyCaCOCG6AB KNSHA/DnM2CmIMZFxTnnHvoVoSO5PUHlQDs/lVx3wTqEipEH3Mct4JwOodmX+YBEJq68CsNeMul qGIbIhGBWNsVBgKwRDX7VA8+Q58UggbXGWUgRaB5q5fpCVMzIjoU1SlV6f8G22Hesn/SmCy47IN C/mVwvgYw5prUGTmdHSFoft/qyzPJQ+ct9DOriwY+HWb2DkE6ummVt85Wp0uoUMZ6S1vMMl9KX1 e9sXO9kukiQXPjC1Suw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_01,2026-02-11_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 clxscore=1011 suspectscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120025 Content-Type: text/plain; charset="utf-8" When the Remote System Update (RSU) isn't enabled in the First Stage Boot Loader (FSBL), the driver encounters a NULL pointer dereference when excute svc_normal_to_secure_thread() thread, resulting in a kernel panic: Unable to handle kernel NULL pointer dereference at virtual address 0000000= 000000008 Mem abort info: ... Data abort info: ... [0000000000000008] user address but active_mm is swapper Internal error: Oops: 0000000096000004 [#1] SMP Modules linked in: CPU: 0 UID: 0 PID: 79 Comm: svc_smc_hvc_thr Not tainted 6.19.0-rc8-yocto-st= andard+ #59 PREEMPT Hardware name: SoCFPGA Stratix 10 SoCDK (DT) pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) pc : svc_normal_to_secure_thread+0x38c/0x990 lr : svc_normal_to_secure_thread+0x144/0x990 ... Call trace: svc_normal_to_secure_thread+0x38c/0x990 (P) kthread+0x150/0x210 ret_from_fork+0x10/0x20 Code: 97cfc113 f9400260 aa1403e1 f9400400 (f9400402) ---[ end trace 0000000000000000 ]--- The issue occurs because rsu_send_async_msg() fails when RSU is not enabled in firmware, causing the channel to be freed via stratix10_svc_free_channel= (). However, the probe function continues execution and registers svc_normal_to_secure_thread(), which subsequently attempts to access the already-freed channel, triggering the NULL pointer dereference. Fix this by properly cleaning up the async client and returning early on failure, preventing the thread from being used with an invalid channel. Fixes: 15847537b623 ("firmware: stratix10-rsu: Migrate RSU driver to use st= ratix10 asynchronous framework.") Signed-off-by: Liwei Song --- drivers/firmware/stratix10-rsu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-= rsu.c index 41da07c445a6..e1912108a0fe 100644 --- a/drivers/firmware/stratix10-rsu.c +++ b/drivers/firmware/stratix10-rsu.c @@ -768,7 +768,9 @@ static int stratix10_rsu_probe(struct platform_device *= pdev) rsu_async_status_callback); if (ret) { dev_err(dev, "Error, getting RSU status %i\n", ret); + stratix10_svc_remove_async_client(priv->chan); stratix10_svc_free_channel(priv->chan); + return ret; } =20 /* get DCMF version from firmware */ --=20 2.40.0