From nobody Sat Apr 18 02:15:15 2026 Received: from mail-dy1-f193.google.com (mail-dy1-f193.google.com [74.125.82.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 747E42BE058 for ; Thu, 12 Feb 2026 07:27:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770881278; cv=none; b=J+RhUI0rSMu/Ip158rX7njdP015z3vYKRRN64/ufuyzHDCKCOyjKr4g0b712HYp6zu0tM6xXi3yx1sNFDqf1SUqpRa0OqNowTBTad9AYrRrqIK3ezvplFxoSwHwFLrgdEUeYiocV8yUxJ1Q/eR8RxTdIF5E6+r1mqlmLFy/erdc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770881278; c=relaxed/simple; bh=gYowE5qVtXWWpcGlm45C2lr3GYvE2Brc1oE4dmEsjgc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=JZWx1Yzhih6thBILqgxgnPyNNl/ojxgtes1QsD/8lkhuXBaWHQ5gBOxQPNLVf85le9bBIbnS2wgV+V9UZ+GCsxVSUk/A1slqpE6S87S1ZxvjazScahUDcAh4F5wYo/zocMrKgtz61Jt52JolLtynI3lX9teUK4QvEh0Ql1lPERU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cPE0qZaE; arc=none smtp.client-ip=74.125.82.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cPE0qZaE" Received: by mail-dy1-f193.google.com with SMTP id 5a478bee46e88-2baa098ffc6so1204706eec.0 for ; Wed, 11 Feb 2026 23:27:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770881276; x=1771486076; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=JvjQ6ERmtGGT/bQN0zFK0YTYG8Pns6F7R1sS65GLjRY=; b=cPE0qZaErbqboercwZJ9QTGJkBNnDSr+8tL66CT1RNFZ5m/B6xHv82FChkCIQSPzIg qndah4/RT5Go1HGIt/esuTcFHsrfe6acZyIN0dWvJe94xXWB+xPihCw5mPjV2G4boCRK Z8Y1kRywB8VRIy0BSs8erTuQfgRjOTppND5t8bmaUAb+PPpRGNjPULfMouCSErZsbzY7 A7xMFUXcejljd960iSVVQOhJ+pm71VkysDjB0Y1AxBFH1x1Q1ghd3FSp0FVgjlep13/0 nNCVwc79KA6dWz/d2HHLD8y6WjvNr3W90a8WHyZKw26XN+NaS/L+LFbrrwabDpLemRfb K9nA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770881276; x=1771486076; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JvjQ6ERmtGGT/bQN0zFK0YTYG8Pns6F7R1sS65GLjRY=; b=VYgta/OikvrkvpbKHfqXDUeRMAiXFemcGzfPzD2WIHb+wjKWe4Culoy0xYXd5ijT4r nKG+zfEnwx8Lw5hTYgCRUhAM2WiAZbC+A5DvpwK2XdbJvAI/G/zJ8prhMcWt6ab2Qznw 3DDE3mi/EFr/la768AM4SsLsMipXzTC7AMduSwuEkzPk7WTgbCgMtY+pFlWcbJ9+G6fs RfJZSnupAJb8yqFgjUNE+mRsoyNVuEd78KJiUwfhljWpxQnyDUJL/CJIMj9PK3/sBQZe k/V8gFnkeB6k2TUGuH9VfaPwkZqOlJvdrrGMBuELKsLvJDAnRGs+rMnLtjL6WhrXo5QP ia8w== X-Forwarded-Encrypted: i=1; AJvYcCUnommjUI1aTCVIhR5NQ/tY+PGU8qttqJo5nURrYUcYOyYwEl6dBYWmEE+8CKD8uz6yNQqQesfX9pBf2vA=@vger.kernel.org X-Gm-Message-State: AOJu0Yx763kTS91BgK7VCFD13FzIBUy2DEKbbQC/pa1Ti/Du/5iAs82N XTzY2C7OLYIwnGpneAkfsH014kGYpB87/yJacUKb2ZhMUluWV3R+2OE8 X-Gm-Gg: AZuq6aLaVCu9NZjoulz3GzQj2vMK+PJPFrB3xHezuvEyq+8HYLr9bzCZoP7kKBpUgyP hDowAlL3lGrpHck7R0UnCBQzY83oq8M1+TKGkMjp1nQrl1lyLyd6UpkKCeAuvXDqW++1mgJfOkG vtZ8P+zrKGyGqWy8eb2N1yG4UwqZ86mNPa9Zfs3Te9AEnd8opOSfcFe9UOZR9N6j9lHk6qFI0XV +xso55XVutGkBki2lDi/Yo7wGU1lFL05JEmBb/9RCBr3CHU7ix/VpHZE3xDT0Kq0c2BYsLy8nDI n0zXP2zbM3NwV8pNsl45kyprWCH4+XAeDLAJUR16YMyQiegmYCECr9T2ASsWrn1c5sQTX4n83qS 1cOvIWVguvam2m0mUZCtTypj6mymafz79nPcPiNOBAtEadQLorKW+ESZFJ9keNTShHecGu326Tz FDydrHbS8uEIr8MqQx X-Received: by 2002:a05:7300:d709:b0:2ba:6978:2b4 with SMTP id 5a478bee46e88-2baa804699amr734834eec.20.1770881276349; Wed, 11 Feb 2026 23:27:56 -0800 (PST) Received: from wujing. ([74.48.213.230]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ba9dcfb804sm3058378eec.28.2026.02.11.23.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 23:27:56 -0800 (PST) From: Qiliang Yuan Date: Thu, 12 Feb 2026 15:27:41 +0800 Subject: [PATCH RESEND v8] mm/page_alloc: boost watermarks on atomic allocation failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-wujing-mm-page_alloc-v8-v8-1-daba38990cd3@gmail.com> X-B4-Tracking: v=1; b=H4sIAOyAjWkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyLHQUlJIzE vPSU3UzU4B8JSMDIzMDIwMz3fLSrMy8dN3cXN2CxPTU+MScnPxk3TIL3bQkQ0tzy6TEZLO0VCW g7oKi1LTMCrDJ0UpBrsGufi5KsbW1AANjg49xAAAA To: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Axel Rasmussen , Yuanchu Xie , Wei Xu , Brendan Jackman , Johannes Weiner , Zi Yan , Lance Yang Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot , Qiliang Yuan , Qiliang Yuan X-Mailer: b4 0.13.0 Atomic allocations (GFP_ATOMIC) are prone to failure under heavy memory pressure as they cannot enter direct reclaim. This patch introduces a watermark boost mechanism to mitigate this issue. When a GFP_ATOMIC request enters the slowpath, the preferred zone's watermark_boost is increased under zone->lock protection. This triggers kswapd to proactively reclaim memory, creating a safety buffer for future atomic allocations. A 1-second debounce timer prevents excessive boosts during traffic bursts. This approach reuses existing watermark_boost infrastructure with minimal overhead and proper locking to ensure thread safety. Allocation failure logs: [38535644.718700] node 0: slabs: 1031, objs: 43328, free: 0 [38535644.725059] node 1: slabs: 339, objs: 17616, free: 317 [38535645.428345] SLUB: Unable to allocate memory on node -1, gfp=3D0x48002= 0(GFP_ATOMIC) [38535645.436888] cache: skbuff_head_cache, object size: 232, buffer size: = 256, default order: 2, min order: 0 [38535645.447664] node 0: slabs: 940, objs: 40864, free: 144 [38535645.454026] node 1: slabs: 322, objs: 19168, free: 383 [38535645.556122] SLUB: Unable to allocate memory on node -1, gfp=3D0x48002= 0(GFP_ATOMIC) [38535645.564576] cache: skbuff_head_cache, object size: 232, buffer size: = 256, default order: 2, min order: 0 [38535649.655523] warn_alloc: 59 callbacks suppressed [38535649.655527] swapper/100: page allocation failure: order:0, mode:0x480= 020(GFP_ATOMIC), nodemask=3D(null) [38535649.671692] swapper/100 cpuset=3D/ mems_allowed=3D0-1 Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-lkp/202601271341.5d24a59f-lkp@intel.com Signed-off-by: Qiliang Yuan Signed-off-by: Qiliang Yuan Acked-by: Vlastimil Babka --- v8: - Use spin_lock_irqsave() to prevent inconsistent lock state (softirq-on vs in-softirq) as reported by LKP. v7: - Use local variable for boost_amount to improve code readability - Add zone->lock protection in boost_zones_for_atomic() - Add lockdep assertion in boost_watermark() to prevent locking mistakes - Remove redundant boost call at fail label due to 1-second debounce - Link: https://lore.kernel.org/all/20260123064231.250767-1-realwujing@gm= ail.com/ v6: - Replace magic number ">> 10" with ATOMIC_BOOST_SCALE_SHIFT define - Add documentation explaining 0.1% zone size boost rationale v5: - Simplify to use native boost_watermark() instead of custom logic v4: - Add watermark_scale_boost and gradual decay via balance_pgdat v3: - Move debounce timer to per-zone; optimize zone selection v2: - Add debounce logic and zone-proportional boosting v1: - Initial: boost min_free_kbytes on GFP_ATOMIC failure --- include/linux/mmzone.h | 1 + mm/page_alloc.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++= -- 2 files changed, 47 insertions(+), 2 deletions(-) diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 75ef7c9f9307..8e37e4e6765b 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -882,6 +882,7 @@ struct zone { /* zone watermarks, access with *_wmark_pages(zone) macros */ unsigned long _watermark[NR_WMARK]; unsigned long watermark_boost; + unsigned long last_boost_jiffies; =20 unsigned long nr_reserved_highatomic; unsigned long nr_free_highatomic; diff --git a/mm/page_alloc.c b/mm/page_alloc.c index c380f063e8b7..7dc1e056a082 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -218,6 +218,13 @@ unsigned int pageblock_order __read_mostly; static void __free_pages_ok(struct page *page, unsigned int order, fpi_t fpi_flags); =20 +/* + * Boost watermarks by ~0.1% of zone size on atomic allocation pressure. + * This provides zone-proportional safety buffers: ~1MB per 1GB of zone si= ze. + * Larger zones under GFP_ATOMIC pressure need proportionally larger reser= ves. + */ +#define ATOMIC_BOOST_SCALE_SHIFT 10 + /* * results with 256, 32 in the lowmem_reserve sysctl: * 1G machine -> (16M dma, 800M-16M normal, 1G-800M high) @@ -2161,6 +2168,9 @@ bool pageblock_unisolate_and_move_free_pages(struct z= one *zone, struct page *pag static inline bool boost_watermark(struct zone *zone) { unsigned long max_boost; + unsigned long boost_amount; + + lockdep_assert_held(&zone->lock); =20 if (!watermark_boost_factor) return false; @@ -2189,12 +2199,42 @@ static inline bool boost_watermark(struct zone *zon= e) =20 max_boost =3D max(pageblock_nr_pages, max_boost); =20 - zone->watermark_boost =3D min(zone->watermark_boost + pageblock_nr_pages, - max_boost); + boost_amount =3D max(pageblock_nr_pages, + zone_managed_pages(zone) >> ATOMIC_BOOST_SCALE_SHIFT); + zone->watermark_boost =3D min(zone->watermark_boost + boost_amount, + max_boost); =20 return true; } =20 +static void boost_zones_for_atomic(struct alloc_context *ac, gfp_t gfp_mas= k) +{ + struct zoneref *z; + struct zone *zone; + unsigned long now =3D jiffies; + bool should_wake; + + for_each_zone_zonelist(zone, z, ac->zonelist, ac->highest_zoneidx) { + /* Rate-limit boosts to once per second per zone */ + if (time_after(now, zone->last_boost_jiffies + HZ)) { + unsigned long flags; + + zone->last_boost_jiffies =3D now; + + /* Modify watermark under lock, wake kswapd outside */ + spin_lock_irqsave(&zone->lock, flags); + should_wake =3D boost_watermark(zone); + spin_unlock_irqrestore(&zone->lock, flags); + + if (should_wake) + wakeup_kswapd(zone, gfp_mask, 0, ac->highest_zoneidx); + + /* Boost only the preferred zone */ + break; + } + } +} + /* * When we are falling back to another migratetype during allocation, shou= ld we * try to claim an entire block to satisfy further allocations, instead of @@ -4742,6 +4782,10 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int = order, if (page) goto got_pg; =20 + /* Boost watermarks for atomic requests entering slowpath */ + if ((gfp_mask & GFP_ATOMIC) && order =3D=3D 0) + boost_zones_for_atomic(ac, gfp_mask); + /* * For costly allocations, try direct compaction first, as it's likely * that we have enough base pages and don't need to reclaim. For non- --- base-commit: b54345928fa1dbde534e32ecaa138678fd5d2135 change-id: 20260206-wujing-mm-page_alloc-v8-fb1979bac6fe Best regards, --=20 Qiliang Yuan