From nobody Thu Apr 2 19:00:21 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1105E2EDD41 for ; Thu, 12 Feb 2026 10:39:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770892765; cv=none; b=PxTcKY2vAjaMluwJ0ipI9m4EhXi6BMqpM0gp7iXeAvJy+LyfP0i64jkBE6j4v//henM+ti2ORH3Ppl/3nIvpagBpBorIsJTZe1NQ54PZ21IHeadnJX8rhtS40MQEwL7VR7b9AwNHrFoSZk9de1Yv2LI+ksDg7lNWtGOGjkU0hzw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770892765; c=relaxed/simple; bh=6/iMBiNg4KZMz6h5i0Fc6mR89gpCa1LmmAVzXQEEuL8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=O3+MEAlwnf3tLOKc2ZiX2Rz10Wv8Ex1nDc8aIV/Ob08NmfbHCLdeJC9cIHookJZSMTg6pt3MGPOnpjMFrnjOgLPqKX/5VPgbt73YjjgSKw82E6s1t5S5rstkvcRbhJ1rVh8EJvnay0yW5hiGdvf0lZIx3bvdg/nqm+VAQyq1D9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YuKt8s/n; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YuKt8s/n" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-8231061d234so2065677b3a.1 for ; Thu, 12 Feb 2026 02:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770892763; x=1771497563; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=UbF954w8wC5OvhQmTKgj/xb2yuAyw1J3tUb8ytlw0Kg=; b=YuKt8s/nTz+uLUHnh0tu7GSe+LbMnmFDpHcqI29qOniYoaXORkCoY4S3qflAvcgBse 1ZEe8ECgWnqInI5pFibG/QF3UfjQq+vplySGRT4msCS165+8I1pDim1mnRRKB5qcxd0R zEQUrqnMamixlDqxQbxtJ1buBZ2AUQdRJsOsPWw+Db9t0jGXLVUC62qeeb8oKHDjG29N 23s2rwcFOMjxsv487f9sBvD0JAZF1/HGcvHp3JHE/ecp/rY02dZaYyfc5CQBw8x84nmt h6i8sGgXpK4AGC8DO8TYYCHxfOTaUdayOj9wRKuxCCJU0LqARJhZxQZmdeYHibDyJIND CXbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770892763; x=1771497563; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UbF954w8wC5OvhQmTKgj/xb2yuAyw1J3tUb8ytlw0Kg=; b=Tgk72VZJsedD8llXy4yPfGsKt53Th92vXqXrQxANlDb+Hdx5wXi9hHARpFmbFg5L1g zFIO8uMwS7wdy1OIxmvhSgQGIRbHI1ATFqOfHKkXn3/1/aTj1XjGHpGBAZB2Rd+us3wb wjhiN5zNNyTPYAZmqxIO/OJtXarUT/jIhPYNm3UdZv+QtdY9XEt9AiLXsX1CcIebPgYY pg5qJipM4qKAdHYiBJ1KKaxc0E1ZmLvofTOgTCzh17U71+0ehP4o+3XmF7qWJA9of/CF gHM/iWh25kwzIJrZTlPJkMz4AubISWTsIqUnkSxxb9VbD5VFyi1zedfYejGe5THE24m/ l5BQ== X-Forwarded-Encrypted: i=1; AJvYcCUQI6utV85DPG9U05ZbL9VApwEf27VeyKoGdEeVAU4FT3EFBrKSUBixw8cOE6DJNzfPWup5xq3G3vLH9o8=@vger.kernel.org X-Gm-Message-State: AOJu0YxOFq/Y0ddYUdzD8lD6yM+RKSzI2QvbAcHiBx6D8f/CPg3PYwYe 8LFgho74X4dLvyeVbCoUfDm88mPgkN+oJ6ch73QzqcZC6EwIiR/3pvHT X-Gm-Gg: AZuq6aLFeywj3DN1PwPZ4gXkV5GO//90w57wIUurH1PvAtLQ2mSNRSFHVehK7vKJ7J9 xCqM1OwvCz/a/pjnOFHHkezuHyv2JKMPd/BtmZr+XRdkxW2KucorhJHxnJhuEQ157skiaAtvC8n JBiT+PbbkVR9HkBy11kbqIMHdqCdHuy+GFk4gdkKkr+VSmKLysuu4gUFHm9rzx09gE5jc0m72M7 1orEkzzp3OT12E5ChgiClZ5/vATMHKcCiv41tRaoHy8MW6jsFnvb9+vhQCoHQqM6pkUIBjanQf4 P1dGCsMZruZdA6SDtgOiEy41VhGn8nB7fieTIyoj1ago3qK9TZszlp9ujtbBErXaCHyySjYvX+u shTqo5lIxD98liG8a3T8VEprV/NY2rHvmJASq4zrpHqEKRec8k+0m3UoNVHdOSPtoH7sGT/XYKj tc9ZWwU5K65PYMOfiqlAnMcfS/0ZBiSN+UmlI2W3AFaPLUod4= X-Received: by 2002:a05:6a00:1306:b0:823:1516:45e9 with SMTP id d2e1a72fcca58-824b3012beamr1632385b3a.48.1770892763363; Thu, 12 Feb 2026 02:39:23 -0800 (PST) Received: from junjungu-PC.localdomain ([2408:820c:9008:ba52:dc7:da9e:7bba:3b99]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8249e81976dsm5645698b3a.52.2026.02.12.02.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 02:39:23 -0800 (PST) From: Felix Gu Date: Thu, 12 Feb 2026 18:39:19 +0800 Subject: [PATCH v2] phy: ti: j721e-wiz: Fix device node reference leak in wiz_get_lane_phy_types() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-wiz-v2-1-6e8bd4cc7a4a@gmail.com> X-B4-Tracking: v=1; b=H4sIANatjWkC/y2Myw7CIBBFf6WZtZgZIPhY+R+mC1KgncQWAwYfT f9dJC7PzT1nhewT+wznboXkC2eOSwW562CY7DJ6wa4ySJQGJWrx5I84WXMwqC0qHaA+78kHfrX Kta88cX7E9G7RQr/17xM1v5AgEZxDOjqUQanLOFu+7Yc4Q79t2xedbCiTlgAAAA== X-Change-ID: 20260204-wiz-9a67604a034f To: Vinod Koul , Neil Armstrong , Kishon Vijay Abraham I , Jyri Sarha , Vladimir Oltean Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770892761; l=1492; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=6/iMBiNg4KZMz6h5i0Fc6mR89gpCa1LmmAVzXQEEuL8=; b=UCoUiP33+D6Y8NLDTyT8GoF3GlXFfOEEnjjptxlx/ozbana7KWtKrC3UH1fmklj4pU7hFjfn9 L7eVQZOu9awCOY//KDpujBvgwgtFA8Nol08TM/32QwSXPnDAwh9ZaG9 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= The serdes device_node is obtained using of_get_child_by_name(), which increments the reference count. However, it is never put, leading to a reference leak. Add the missing of_node_put() calls to ensure the reference count is properly balanced. Fixes: 7ae14cf581f2 ("phy: ti: j721e-wiz: Implement DisplayPort mode to the= wiz driver") Suggested-by: Vladimir Oltean Signed-off-by: Felix Gu Reviewed-by: Vladimir Oltean --- Changes in v2: - Use of_node_put() suggested by Vladimir Oltean. - Link to v1: https://lore.kernel.org/r/20260211-wiz-v1-1-fdd018d02f33@gmai= l.com --- drivers/phy/ti/phy-j721e-wiz.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index 12a19bf2875c..10110cc2115b 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -1428,6 +1428,7 @@ static int wiz_get_lane_phy_types(struct device *dev,= struct wiz *wiz) dev_err(dev, "%s: Reading \"reg\" from \"%s\" failed: %d\n", __func__, subnode->name, ret); + of_node_put(serdes); return ret; } of_property_read_u32(subnode, "cdns,num-lanes", &num_lanes); @@ -1442,6 +1443,7 @@ static int wiz_get_lane_phy_types(struct device *dev,= struct wiz *wiz) } } =20 + of_node_put(serdes); return 0; } =20 --- base-commit: 193579fe01389bc21aff0051d13f24e8ea95b47d change-id: 20260204-wiz-9a67604a034f Best regards, --=20 Felix Gu