From nobody Thu Apr 2 18:51:25 2026 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11012051.outbound.protection.outlook.com [52.101.66.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1830D2EFD8F; Thu, 12 Feb 2026 11:49:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770896964; cv=fail; b=IHkAonNJgVOYn/hAQ3BircS7SXla71xzlr+Co7kBViIw0lKAVYL4hes36jp3IbtNj3IhkuzvOriA4xon7H4gtFRNUhlNWUdXpFn9EshsDd4rklcK7GUOJXx9yuXCk+SXFZTRExXsEYPM4HaoIL7sxN8HXJX9V8XS5A7AfHsX92A= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770896964; c=relaxed/simple; bh=Fgs8ba3MC6vhbtdJI5kkM/9bhGrj6UvRzBwJqCc3ckg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:To:CC; b=VJAYZ+Y7rnXEIAHwksJSrmqkIFJhHvE5qlknRPk7LW7TgkkWsEZkcXo9ASTQuEPxZuAvUYNjPEWlSLnAFTVv8osHIX6fxJSexQn31Cf25pI9fxRfHR0itK5m6Cw9F67KWbekc9E+0K35XtZEHI5lR4HqLWe7M3T0CNKk0ui+KY4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=HE17Qd8F; arc=fail smtp.client-ip=52.101.66.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="HE17Qd8F" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PeRZCrMuCc/Lrz+qlx/nfyLEWzH/iiLwoM3DcuB1k+0DOxC+iYCpcSleSUM089RCC+fmFqoOOHYnzIOB7GCCyYDXQEbQ4XrFZYEZoQFudaQ+i3RWw5aAfXMExTl0MTQF6mABx/1IGu7o58yrJL0IebrZX9uhEZxVOEACX4nDadkhPMtSu0sJ+fGOr9gT/4f7F03MResKouj1Ptad8K+cysszadwMCsZwWjQjRUO2qfXIeYVB7errkLW8ebopw6JkFPedp14gwMXXzuS0/QLfDaBy0xKmXz1HzjFDIX3Hm879W4ZoOjj0u6SWzDIdxTjFuSGf8DyNiM4y/gts0z0w6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7OK1MTD8GPC4Un3XC11aYaSxxhliDI4UapgzBvNxaY=; b=Or8sCa+coqLa1s2OjOl81jHC6aOb8gaPq937XOI0YPpmggOgaIKGSvOT90SWZpqekCqoTwT1YKypM++s+TDNJEdadIFXep2Qo3qNjTBd7bKXVxBPZOE1Gvj+Z7mKC9IbhxmbJpefGLhKogy2sP/MHtwCzqKs+azBGIE+/MnVyyL+i+ZL+KdL/o2RVaT3JQmNNAqvFS5qL68Rt5KZ8eRsZm8jnSXtb6VoQ5Wpr4YDf0M6y6FPFTfJCNHpOMpJSi8olFHsHvE4rfhs023qq9gyfO+e5RHXV5Pto81o/Nd7WhzAP1o4X+5tgzrcbJSybx2t6rIefXub6pl6ZetDzGSUiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 164.130.1.59) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=foss.st.com; dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t7OK1MTD8GPC4Un3XC11aYaSxxhliDI4UapgzBvNxaY=; b=HE17Qd8Fx2Y84BHXLhtkDOW/7sBkd3UQPX73aRSg/vxHrkB5yx6i5B40UoULSOZGEeDU96taIqP0OB+1QIURhI8nNkrGqD2h6xelDOaLpDfyhS+WtYOgUqK6lsB2p0xu93M+1A0gJuTjiRWwp9MK8zFQVIMVVNC7COT5CXI5wtpI9GzwrlN7q3TQLkJ0f4p7TPvsoQGhyrLO/8LojDXOi5Ekfr/FoF4llbq4ueKHQ6+COB1QBPiCjkxcLlspOyfzxAGOZ/MZuirVHnGCme70Mj/hfFe+hPcYrWnbuyTGg8NBwwhQDMhFwWkDlEqhsN729PLQHdL0PbOYftJgY8FVsw== Received: from CWLP265CA0504.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:18b::23) by PR3PR10MB3881.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:42::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.11; Thu, 12 Feb 2026 11:49:18 +0000 Received: from AMS1EPF0000003F.eurprd04.prod.outlook.com (2603:10a6:400:18b:cafe::bd) by CWLP265CA0504.outlook.office365.com (2603:10a6:400:18b::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9611.11 via Frontend Transport; Thu, 12 Feb 2026 11:49:03 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 164.130.1.59) smtp.mailfrom=foss.st.com; dkim=none (message not signed) header.d=none;dmarc=fail action=none header.from=foss.st.com; Received-SPF: Fail (protection.outlook.com: domain of foss.st.com does not designate 164.130.1.59 as permitted sender) receiver=protection.outlook.com; client-ip=164.130.1.59; helo=smtpO365.st.com; Received: from smtpO365.st.com (164.130.1.59) by AMS1EPF0000003F.mail.protection.outlook.com (10.167.16.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8 via Frontend Transport; Thu, 12 Feb 2026 11:49:17 +0000 Received: from STKDAG1NODE2.st.com (10.75.128.133) by smtpo365.st.com (10.250.44.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 12 Feb 2026 12:51:08 +0100 Received: from localhost (10.252.1.111) by STKDAG1NODE2.st.com (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 12 Feb 2026 12:49:16 +0100 From: Alain Volmat Date: Thu, 12 Feb 2026 12:49:10 +0100 Subject: [PATCH] spi: stm32: fix rx DMA request error handling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID: <20260212-spi-stm32-fix-dma-rx-release-v1-1-53a37c31626b@foss.st.com> X-B4-Tracking: v=1; b=H4sIADW+jWkC/x3MSwqEMBBF0a1IjS0wsWnErYiDxDy7C/xRJSKIe zc4PHC5FxlUYNQWFykOMVmXDFcWNPzD8gNLyiZf+W/lnWPbhG2fa8+jnJzmwHqyYkIw8CfGOCY MaEKivNgUuXr3XX/fDz+uR0VuAAAA X-Change-ID: 20260211-spi-stm32-fix-dma-rx-release-4bbbfdece8ad To: Mark Brown , Maxime Coquelin , Alexandre Torgue CC: , , , , "Dan Carpenter" , Alain Volmat X-Mailer: b4 0.14.3 X-ClientProxiedBy: ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com (10.75.128.133) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS1EPF0000003F:EE_|PR3PR10MB3881:EE_ X-MS-Office365-Filtering-Correlation-Id: 2776bad2-0741-4faa-5948-08de6a2cc077 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?amlDQWl2UnZkekN3c0Z2aEI5Y3BFc2U3b0VPT3hOcWZMK0wvQVVoU2dmQUZ2?= =?utf-8?B?QXV3VkRnZjloL083VWJobTF4eFFBc05xUjFzR1pxY0RVSWJTU1A4OGxhb2pZ?= =?utf-8?B?WkJGajJVMzEyR01XLzMrbW85amZIaUlTcktwN1ZQRFFaYkJmdStSdkM2dGZr?= =?utf-8?B?UERrSVpWZWhzMkdPV1QrdURxUERrVW1XY2UycmtkWFpEVGFhQk1NU1dVSC9T?= =?utf-8?B?WlR5Y28zWnZGY0VGM3BSZkc4MW03TXU2Sm94RXdjMnZPUGg1VnNBUWt1dGNt?= =?utf-8?B?ZHI2RHpyV294Y1NjcjZ4OTBxTWVrTllGNEhUMmtwTWZ4NDBpa2czNnYrWWZC?= =?utf-8?B?YmNlcmdXN1N2cEpjQml6WnFYMTA5Q3pYVUVGT0RZK2w3VStCVDExR1hWenNK?= =?utf-8?B?OFV6QTUxa1RtVzZLS2ZRUjNPaVdDTVpmQkhsUEs5Q096ZFNpUFRtQlN6emhp?= =?utf-8?B?OHA5ZVRqUjFGQ2l5MkkyUGY2Z2xlbzVLUmZ2Y1lrNlFMWCtPZWljSUo0WUor?= =?utf-8?B?NnpDRjhveXBCblIwU0Zxb1dIK2FWTVROMTFsYnNJRmJWRnYwcmRPMFNUaUNt?= =?utf-8?B?Zi9sSXpvdmIvVHdjKzhOWDdJb3l1NlVxZzFNUXUxVmJSTDdaRUd2NGVwMjBs?= =?utf-8?B?Z3Q5ek1RQW4vNy9lL0M5aDQ3U0tHTDR3NXRCRnp1UllxYk9mSXRHK09KR1JE?= =?utf-8?B?NzFBT00rRzJQVFJobUdvbE5DOVQ0TEhCMmVpRDg2WkxiMCtRM25yZU9RMTh4?= =?utf-8?B?QTBhMlhBMmt4cnpzdWcxOEQvR0VlTjRDVjhxTkpyaldaZlZmWGt2NDV5bUp5?= =?utf-8?B?R094OFZkcnZnYW9XeDI0ZXBsUUV3MmtiaFJrQTJ1V1ZodlJiRDdNWjFGekwz?= =?utf-8?B?akNDc1BkY0c5RFAwSno0U29OTmNvVkRIZlZGZWdEK2hzSmlLWHZ0blFNQjR3?= =?utf-8?B?eHJ2bVVxMHRlM0w0M2gvbmJQbTZXZVB3dzc1RjlnTkljQ3ZvVWJoc01TMXZj?= =?utf-8?B?K1czekMvWWhXaFpGWEtKWDU4ZWx3WTZSMzRJYWR1d0t4UTh6TXkwMDh5NnV3?= =?utf-8?B?QWRhQStPNm9pTC84YjZaaHVHTlB2ZWZ6bmdkZWlyUlJyNUovZ24waVpHNUR0?= =?utf-8?B?SjM0dEVMb1FKQjFGU1pCYkhGRG9Sb05ncVhsUEp5OVlWMXozdHNOMmRuN2R0?= =?utf-8?B?ZXVQQXcyWUxJbEFBRUEzaFN5c3BTQzJOWjAwakRCMk8vZ1ZuMm9DckZYWW1T?= =?utf-8?B?S1Rmc3RJRTRBdzg1bkxJUHQwbVRENkpEUHBlZEVadHB1UFEyT2tXVTJibGhQ?= =?utf-8?B?RDcvL0Jza1dVSTBVb0Z3R3pLMm5ucndYS2QyT1FEajJGbEV0ZjNlcFI2ZUFz?= =?utf-8?B?VHlXd0NsMUJ5Y3hpTFJST2l1RlczdytnVFFUZUdIVGNrVUNlWitjeVNPcHJW?= =?utf-8?B?eklFNUpjei9icms3Mk5DR2t4MWh0NzNnNXdPM0d4QWNxTHAyMFV5QUV5OWQ0?= =?utf-8?B?T0o2anFxT0FoY1pPdmxXUGF6MTBsMk5laVdZWCtNZkdBMDdwb1V1eGJlcWFB?= =?utf-8?B?RTZqM3R2VzZRNzZQdlVsUFlZQ0pENklHdGxmRmZldExaOW5QakE1cFkveUUz?= =?utf-8?B?cFZSdHN6NG14K1lDYmc3ZHhOMnBPSGpndFRqNHU4ZDE2dHg2UklxcWJHQnAz?= =?utf-8?B?NWVWeEE1WTBtajVjR2IrTDV1bzRDUno5R3RBZVYvVWNxcHJFQnN5dmZ4NHE4?= =?utf-8?B?dFhiMVErZkRMaTJralh6bGlodVpmNWFvT21tYUVsUml6MmpRWTJkUE5aajU5?= =?utf-8?B?SVdrTExZa1hFZldONmRsNHZwRENmZ3JValcwYUh5SGF2VUVkREQra2ZOdWNa?= =?utf-8?B?anRhL0kyZnNIaTBxL0VkM0tLUUhBOXh3elBpV2ZPaHBLVjd5UitjU1lsOWZF?= =?utf-8?B?T3NDbFd5d09KK3lkNFB4SWIzWFFCT0tJRWNKYnZkUkgyV2ZIeVpKdURhbGlT?= =?utf-8?B?eGZ3NXlZa1ErUWY5WXpUeXY3UVcvRmFhNzJxdDcycnVCY3l3N2J2RTk3YUg1?= =?utf-8?B?RjcrT0oxV204SnNPVlpXNWRRL2dHREswZmJEL3dJL0s3Ukh0RUFOZjRhbis1?= =?utf-8?B?WEs0Mm9YbkhTWnAyOW16MnJjTG9zMXJ5bThiNGdLWDY2ajFJNWNobG1oVEQx?= =?utf-8?B?RnFreC83dGw1Vmo1K1dXUGNkWENXNmpXTk5XTmFUenU2clZZb3RjaXhIdkx3?= =?utf-8?Q?k5VQsENuWbdfpe9u3slhRC9zWH0aQfQEUBQaWPv228=3D?= X-Forefront-Antispam-Report: CIP:164.130.1.59;CTRY:IT;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:smtpO365.st.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: K/JMtL9F1D7OO5QHb5qW3Gh6FDPlc86AjIO8Ew5YC52R/W/4IX6J2Qw5pWCNA83H0nQQ0bgzMdCyVJh4OSDYDx3BLt+NSihJUGQdUJcPJUqzFOsOV6PkxbjQh0bc1CjfoNMMNM8kzm8esoyGs+jx1/SZy1rJ5Ximfvudlj7/l0NIUiISzKKPd0Y3mTKiELFiSzqdT2A6ujggBTOr9aDj7Xf5r5WLRHWwvpzDzydi18GXgip5sKO+d6jNrjRt54owh77Dujvcbyjxu0msLvDdKYCTr708s5Y7RsyEvzlc1XQzN6MWHOh6bYeQ+EcSVibwMgKxlCqaHHO/yPl6B1CvT9fBCv1Qi9EFeaQPPhGSBUfxeIa6kwSrMnR/dBRyQ8tojITO3UTNhJrwIxR/Pwj7m6MndU/efnCITsT6MG28D9oLRAYKj15j429nvSgLmK4s X-OriginatorOrg: foss.st.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 11:49:17.2542 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2776bad2-0741-4faa-5948-08de6a2cc077 X-MS-Exchange-CrossTenant-Id: 75e027c9-20d5-47d5-b82f-77d7cd041e8f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f;Ip=[164.130.1.59];Helo=[smtpO365.st.com] X-MS-Exchange-CrossTenant-AuthSource: AMS1EPF0000003F.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR10MB3881 Avoid trying to release the RX DMA channel when an error occurs during RX dma_request_chan() call. Instead, jump directly to release the TX channel, if applicable. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/linux-spi/aYXvY6NH7OlZ-OAF@stanley.mountain= /T/#u Signed-off-by: Alain Volmat Reviewed-by: Amelie Delaunay --- drivers/spi/spi-stm32.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index b99de8c4cc99..c9442326782c 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -2502,7 +2502,7 @@ static int stm32_spi_probe(struct platform_device *pd= ev) spi->dma_rx =3D NULL; } else { dev_err_probe(&pdev->dev, ret, "failed to request rx dma channel\n"); - goto err_dma_release; + goto err_dma_tx_release; } } else { ctrl->dma_rx =3D spi->dma_rx; @@ -2571,11 +2571,11 @@ static int stm32_spi_probe(struct platform_device *= pdev) if (spi->sram_pool) gen_pool_free(spi->sram_pool, (unsigned long)spi->sram_rx_buf, spi->sram_rx_buf_size); -err_dma_release: - if (spi->dma_tx) - dma_release_channel(spi->dma_tx); if (spi->dma_rx) dma_release_channel(spi->dma_rx); +err_dma_tx_release: + if (spi->dma_tx) + dma_release_channel(spi->dma_tx); err_clk_disable: clk_disable_unprepare(spi->clk); =20 --- base-commit: f921571df917408594a9039ed450859f3bf9cc2e change-id: 20260211-spi-stm32-fix-dma-rx-release-4bbbfdece8ad Best regards, --=20 Alain Volmat