From nobody Sat Apr 18 01:57:38 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010051.outbound.protection.outlook.com [52.101.201.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2987C28BAB9 for ; Thu, 12 Feb 2026 06:29:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.51 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877783; cv=fail; b=RJmbCpHdzaFj48zFWUj0To2FMMKIBjL2xZn6xZqdRnNNIyzQjahCHaCKhfagefBppc0hboRsev5N16ROoPmU2YMOsoL3dPIOXLfcivPTaqA07Dd6/RaJaxuNNSn40qPP/ysA7BZ3ujI7plJ3l+sVXpncdRgLFGm98CESSaqaHE8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877783; c=relaxed/simple; bh=bWq6jlLTzWIUjNfb5BMMPLLphgsG89wZ9F7pZUTIwf0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=JKbHXLOIugx2TlwKtnR5NOukRLKfapJOZddzKxj5lccP0LNTGdEd3d8rabjBy9xMq7pJ/P+MXd3/e9WOq+nP3NJIqHVFt1HDn99SagKkcFlEdqpUtT2d41a55E8pMBz03SAiexUTAfWgXl4XSCykelJZZkhEp/AyTN6qFSG2LvM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=a85gKUk0; arc=fail smtp.client-ip=52.101.201.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="a85gKUk0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DKaUgtgoLjar5AzEofeDH3l+2jDZJp9zCDtoTy7xLoA6enn2noIQP8E93mlmVGnZFody2LcjHbTULxMP+PHwFTaeVmp3nJVDPpaE7EYM1NXzvWZar9uUxDOnd8UMT76anwHZHMBe/aYhVVF5BW8JOwFK0nMydmZpfBJNjD4fpvXxkhWD/Yx67Rfl9PGgfDyPFOxPqD960kn2TOo8LdtX3jW9LXgnKsqab99HrSEMvA7j7HXZFHTEsJudS8VZ22yfy1ZNYjQBVZnF75ZaqmMqIa8tLWCd4S5efZbyJaXKM7+jfx3GKwsvANTS8dsPbsYK5fA9ntu4H58SLoSJqQBedQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2r9mfsQkvEOZSm9B6UApD4RQcJZeFBme2wIUp3EktFs=; b=ZeR/wrBGkoSeUgojo3y2S60y/Rx6pRnSxVBGwbLa+VNQ+Qz5GIw2jNtbxtshvhjwnouoUwrj6eJmE4WD4tGpe2MKo8DMrvttcr5Ky496QHdL3s7Rifae/vIZ5V5Hs/dgG3RgTFDhYI2AotNeZXVttI1E3o4Qn1e4bQfOshMtoF3sMghMU7+rqhNkwH2YXb0UeBOWeXsvlCH2d1H2RLuukqKFWL8vgAymOX4/UaCoNOknyUpkBY2054bH4fnjlxei40ChIIus/DQDEtOHxauBr7RV0tvk44o+/O5ls325Nz9LiKF5pDAPEmsMIyZaMJtHicHkTGMedLCqGrA1vtJlQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2r9mfsQkvEOZSm9B6UApD4RQcJZeFBme2wIUp3EktFs=; b=a85gKUk0EK9kLnmdBwJ2WUvRRTGQALMUX+fobvtI0pchWlTxdPuGWAFmi7EA7uDTzfTQVMr4BQ+HFnohqlQ88SX8iEWZpSueCu7NVAQE+1glP4U3qwjpaQAnFiJIIWve1jtr1Ky3evlhfRbBKquicYf2NCQso/SEA6WbJQ6boxIscVmgoL2GyjXibOmOdeB5RJUSgFo1KOJdce92o0/UzJLNezrR4QT7V4/GCuUjN03Hejh+pV28AtSkzfY88oEfLq4w8L4V4DStMNjlMUCfQFqXCqweKPujwCeTgFgEZ7e8gyZkGdSORNY4BCPSTuJpEdbrkEKzvQbZ10IRWXMGSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB6674.namprd12.prod.outlook.com (2603:10b6:510:1c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 06:29:38 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9587.016; Thu, 12 Feb 2026 06:29:38 +0000 From: Eliot Courtney Date: Thu, 12 Feb 2026 15:28:03 +0900 Subject: [PATCH 1/7] gpu: nova-core: gsp: sort MsgFunction variants alphabetically Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-cmdq-continuation-v1-1-73079ded55e6@nvidia.com> References: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYWP286CA0001.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:178::12) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: 7e58ed78-b9aa-4c5d-bdd7-08de6a0018a3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SkRSWFpOcmFxb2EvNk0xWXdWVGJnUjRtSVBpMm4vam12aFdIVE14b2JiK3Fu?= =?utf-8?B?eDJLOSs1NUNSaEs3ZFFvTm5TYW9uRjhNZC9rbHFsQnRqYmZadU5lZkhJWEE3?= =?utf-8?B?am9OM2FxSUlFUWhvbUxWYXRidlRhenRXVzUxbWRKNmt1VlEzNS9HSWJFc2NB?= =?utf-8?B?NDNDcy9MZjBYUlZaM0txTnZpMGxzcklHWnZaakNhWmtHZ2ZlRzc3MWQ5QzRM?= =?utf-8?B?MGh5WmNkQ3hYV2JscWxpTlZWWTNDVzFWaUdRaWtoLzdlc1pXamwzR0JaWUVi?= =?utf-8?B?ZkxMZ1p1ZTRMdXZLQjAyUXNOWnhHOFFaa1NXbjVxcmxuQU4vazlJWmUrbFNx?= =?utf-8?B?akVtZnIrWEEwdWV6ci9uYnVMck5mSlVXakRYSVlsNDhUaDdOMXozUlNsU25R?= =?utf-8?B?Y0tMcEpONUNzQXVMZUZRZU9meVVPUjRiM3REL2JheGNFNFI2eStnUVBGWkJm?= =?utf-8?B?WHRIOFMzNmxhSnB3aExwVU9qRVZleFB0Qm11bXVVNkxtd1RhYjB5d3VSQU5J?= =?utf-8?B?OUEzY2lTUTA0Rk5zUXZVMUlJSUdydDRTMnQyejN2WE9NUStzQkc5cmpHeFJ0?= =?utf-8?B?ZS9uNGJvSDF6TWhnYnB0dUMrZkJxQ3ZqZklCaTY5ZVEvOEV4YWlFQUV4K2Fo?= =?utf-8?B?cWNZS3Zrc2psdDZXS3Q3NDhnWFhSTDlXeWkwdFFmSk8yaEFkOVJBVjRuK25H?= =?utf-8?B?TTRNSmlNM0syTmxEWElBQXA0Y2JPWnMrVVdvNEgzUDNUbjc3YVBNYnJmTENN?= =?utf-8?B?YmwvTWZuRkJuelhTT2lpK3FUVzdIMXk2Vi85MjE2cUVSUVc2QzZBYXcvWDVJ?= =?utf-8?B?OTZQUzU1MklDV2Z6WjM5RE1CUEVHUVFGcUpzSUI5UEpCeDVlWFVvcUNVSFdV?= =?utf-8?B?SXJHZVp1R2ZTWmllRjgvS1l3UE1vcEdLRHZNZEFqQlQ2KzRUMlUySEdHRGJL?= =?utf-8?B?MmVtcVg2bmFSRmFvcDlhaHFDREY3V0xqbWFQRjh0NVJ1ait0dEJRUFNpUnMr?= =?utf-8?B?cEVNL1hXdWtwbjErRUEzZDZuLzUySW4wRG5iRTlocWowVUg0WHpMUHJYbXBU?= =?utf-8?B?bDAydzhWYVlqOHJKQUNWbjF5ZGt2bzkrM3VwazRyNG1HcHQ5bzdUVHZPV3Ny?= =?utf-8?B?dkFGY2NZU3lWajJ3NWordEhNYnk0VlpZNnl4Y3RYdkVzNGQ0MTBnQTQ5NHk1?= =?utf-8?B?M2Nucm91ZEpXSFkwYUhtZCsvNnptVlR6dkxCSmwwekFRNFYrazhYMkVST0ps?= =?utf-8?B?SHpCRGlSVkJWZGNYNEtXOFE5cmswR2tmNW1OT1o5eThjYWUvUWQ2Y3FFbE5v?= =?utf-8?B?QTI5a29IRHVUY3FQRzJRY3M3OTNsNVF3U2JqeE53OGxTNHRKN2dOTFZtcUZB?= =?utf-8?B?S3R0N2FNcXU5Y25iUitxOHJtSHROcWhaOStHRjh4N0tXWVJHQ0tQK3R4Y2du?= =?utf-8?B?M1l6N05rWnNGTkQvK2FCaThFRjVlSlAzK1B6VlQ0L2tyN01ncFc0MlMwQk9B?= =?utf-8?B?MXF1KzdNOEx3TWZvV2pTSVAzcTl5NE1UcTM5S0NPblBaQmVEZWpEOHRNOVRR?= =?utf-8?B?akwvUGtuM29ncW8xTGhJWFloV1hvM2U2TExuSHNHYTA2YjdFODFMelpiRWk4?= =?utf-8?B?bFJsYnBTZVVFckpkU3c4THpVWndIUkQySnA0LzJtdStSUDNnQ1ZmQzZBeXRo?= =?utf-8?B?M2pQczRnUFM0ZHVRRDdwOEYzbXFaQzBSUVgwR3cyMytnOWlSelVUT3B3b0pD?= =?utf-8?B?M2dvaWp2YURHNFRUc0xQMnhOZG1GTmVqejFhYlB1aFVpWDFGTWVSRHNzZmhN?= =?utf-8?B?VkM0a2pIUGRFRGNhZXJrRzIxMXlHd1VNS2lPVHkrck1Pc2QvTktsVkdBOXVl?= =?utf-8?B?VmR2cjNFMjUvZWt4bk5MbC9OZXgwL2RPcjNha3k0UjFMbG1Rd0pWaE1VT3Nl?= =?utf-8?B?Z2liTXYzUjI0U3NlbjJ5VmNqYTNjd0FxU05FVG5acjBacnV2RWI5YkRHMjZK?= =?utf-8?B?OExadExlMEJxQmY0RzhLWHBXUi9mT0ZXTFV0Mkp1c01kTklwZnkvaWY5Y0lN?= =?utf-8?B?OHQ3TEVCVlJpZmMydkN4RFBDNkR6aUJURHR5NnFXbnZmbHZCTFc2SzE5VlVR?= =?utf-8?Q?uOsA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eFNTZlhka3hhRnZKbitOVjlpRTV4ZGhRTmVmaFd0UDkzc1EyNGsrU1VBNk1N?= =?utf-8?B?eTJoaVUxcno2eTRZR0dtYlhzaFd2dURRdVI4S2xsMVdWbHNXQ3NyUWxMdnR5?= =?utf-8?B?TzRVVlVQMEVhaFluaUVtVER4RzRkWkRsbVhNcGdGU1lhL3FZeHBnVVVrNjF4?= =?utf-8?B?dzdXRE9rQi9MQXFGMnd3RnZyZ0EzVmJBSFRRVGlPNkZrdmpmU0RqOTlhcmdy?= =?utf-8?B?Z1ZKQ3FMOUp1TzR1ME5VeWlSK0F0aXF0SitnRk4zMmw5Q3h5MmZoc2JpaUxn?= =?utf-8?B?alhBRlVkeUZ5WEJiM3NhQUtMZ0FoZTN1RS9LV3g3SU0rRk1yTTlIT2dWY3VP?= =?utf-8?B?NlAzOW94UE9WbFVYWVA4VnhkLzRhY2UxUlFhRDRJL3ZrRHIvMktqdlptUUhJ?= =?utf-8?B?bHk1TDlCQllEclYwdlgvZGl6WmZLVElVZFBUK1dkWWZTNTR5TE1mUFBrSk1Q?= =?utf-8?B?UExEdWFOUWtXbGpyaTJhSzRIOUlPeXFvanlOZE9YMFBTK3JsS29yVTBaNkVY?= =?utf-8?B?cFdHd0k0R09qSUF5eVRNWWxmVXVvVU9Ka2tOYlZGbStBNml2T1JPYjdldzVF?= =?utf-8?B?VW5Ga2xUK3NzcXRrN0sxYVhvejJFQm90aEFYRlNBblpRVE4yTXVXOGlwVlhB?= =?utf-8?B?RTd0RC9EQ2tuaEFXQ1dtSWUvRExFdjloOHJoVHg2L1cybEVxN0dvaFlXckpZ?= =?utf-8?B?OE5VT3N3cUl5aFBkUE9KcnBzOUQxdjhwa2VTSVBOOWZUTWxCWWlBams1c2Ez?= =?utf-8?B?NlZqVUw1aUJlL0FrVnlWMVpXRjVRZFpOTGxiZy8yZXZ0eTlIb2E1RW1vRTZa?= =?utf-8?B?eUxXUFBhWnRqUkxKYVp6ZWVPOFI5ZFlpOXZqUnJsQmpsOTdIbzkxaUVwSjFy?= =?utf-8?B?cm43SzZDb2prOGNqQWtwT2FQUnoxTGZLOTRpZ2ZYK1pjK3JjanZNY3k1MTVr?= =?utf-8?B?MXVVRkVLemNLa3h2YXF5WFFaS1ZrdHd4YVJXRTVEb09DcktibW5uY2RpMzNu?= =?utf-8?B?aXNOZE9SREVGREpvYlN3QmdVT0JzMktxbkVDVGczdVdKRWhxMHJWeHVTNzFX?= =?utf-8?B?WVZDUWtZVThYcithUVhSemtNQTZJSEd5bklRb1JINjdtN1hYS0xUY0p3Yy95?= =?utf-8?B?MWVFNy9UMncvYVZEVC9PaXVVbUlVaWpqOERlUy9ZNlAvT3JtazhZVzZKbWZF?= =?utf-8?B?SVNKaTdTS0F1dWYrQUh6NkRhQWsyN1JFcVc5Ymt5OXlKUmV1ZDZBRkYrYWpw?= =?utf-8?B?WWpZWjZlR2x5ODV3TnBYMnRGajIwMmRnQnVORFpibjlJSTdiVERVdWw4MEtX?= =?utf-8?B?YkdPL2Fkb2pRdXZEUXVpZ3E3QkhpZUNQYkhSOGpHMGtOR2FWaGJKZXU3Mm1B?= =?utf-8?B?MVRHOCtyWlErMGFjdWg4ZnhSbEUzeHJrVkJ2cEdvZFVxTDdDRlNURHRKYVg2?= =?utf-8?B?Qy9yYmR4QnRnS1VueFRKRytYK1NZM0hIMTZpSW1YZ1k2QitjWDhvbTNzdVoz?= =?utf-8?B?S2NKKzF1Y0w3L1JjN2RvZzdTOHpIY1VqUHhMWGNUQlFuZVhFYzlQVXR1dmN5?= =?utf-8?B?K2lRYU5xSWJjc1JqQklxdk5uOGNxVWZHcldMNzc4MVNDUENWa1BaUmxFZ1dS?= =?utf-8?B?TXBBNDEwZjNMUTIyVzFwY3VHODJjbU1CdG9nMEltSTc2OEY4dWlmeWVVblRm?= =?utf-8?B?enJINnBxWWIyMkNBdE1QMjVaNWtDUmxrenRMTElFRSsrNnNmVGFEKythVURK?= =?utf-8?B?SFBNalB3dVlNMXRxaktINHIwRGNpOFRyblV3U2lINk5QZW1mSXFaZmF0TFpB?= =?utf-8?B?WllJOWF6WEVEd2t6bWVNeVl2cStRazArT2Rid0JwSDNlQWNlK1YyazN0em02?= =?utf-8?B?dFcrQ2VYdEtKOGtOTXJWU0ltUjdUTTJBSE1lWExRVmRPZWVEV3BQQXUxcThF?= =?utf-8?B?Y0g0STRSTENBRTRrUzVFenlNWTU1cVUvTVpacXpOK2RMNVFiZ3g0NUI4ckhv?= =?utf-8?B?WDZlQzRLMXZnVmJHRThyT0xMaUt1MWFiK3ZqdnU4SHB3RWdmTlFmYjhLczc2?= =?utf-8?B?Q0tiMjJyNkRwdXNNWElybUhLaC9oUnVrc3FvL3FyRkV3V3FNVTFZd24rd1hE?= =?utf-8?B?enJyL3dEOUZGR3ZmMy8vRnM4cllMRHc1ZTAwaG5iTE5sVS9UUG9ZSTRyb2Fz?= =?utf-8?B?SEFzQitGVm5jRGJoemJzbVhuYTRpQ3A1S0crMlVmVFFnZGYvZTAwZU5GSkNj?= =?utf-8?B?T2RHamd5NHRhdm9ETlF5dTYxQjNQNk84Q05BMUV3cmdnaWgrbDdXVGw4RDVJ?= =?utf-8?B?ODJHTWs3UXZOUUh3KythYXVwS29iWnJhOEY1aFREU3A4YWs2aVRheElXUDhD?= =?utf-8?Q?bmHOBmncoPKhGbD85zxdvDilpqP7vl1DuiXc0aDHAIdXd?= X-MS-Exchange-AntiSpam-MessageData-1: IEABgHF8BI1j+g== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e58ed78-b9aa-4c5d-bdd7-08de6a0018a3 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 06:29:38.0085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lp9QMZp2Am2uu/a8DH2aNV5bhZNise4sTR8x8ttfT0qZ5GrvDAuyCG8UN2tN59lMV5ji17YqBbyTTR+/PHqJnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6674 There is no particular order required here and keeping them alphabetical will help preventing future mistakes. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/fw.rs | 97 +++++++++++++++++++++----------------= ---- 1 file changed, 50 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 83ff91614e36..5b96f5e622a4 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -192,34 +192,34 @@ pub(crate) fn new(gsp_firmware: &GspFirmware, fb_layo= ut: &FbLayout) -> Self { #[repr(u32)] pub(crate) enum MsgFunction { // Common function codes - Nop =3D bindings::NV_VGPU_MSG_FUNCTION_NOP, - SetGuestSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM= _INFO, - AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, + AllocChannelDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA, + AllocCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA, AllocDevice =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_DEVICE, AllocMemory =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_MEMORY, - AllocCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA, - AllocChannelDma =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA, - MapMemory =3D bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY, - BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, AllocObject =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT, + AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, + BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, Free =3D bindings::NV_VGPU_MSG_FUNCTION_FREE, - Log =3D bindings::NV_VGPU_MSG_FUNCTION_LOG, GetGspStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INF= O, - SetRegistry =3D bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY, - GspSetSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INF= O, + GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, GspInitPostObjGpu =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_INIT_POST_OBJ= GPU, GspRmControl =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL, - GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, + GspSetSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INF= O, + Log =3D bindings::NV_VGPU_MSG_FUNCTION_LOG, + MapMemory =3D bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY, + Nop =3D bindings::NV_VGPU_MSG_FUNCTION_NOP, + SetGuestSystemInfo =3D bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM= _INFO, + SetRegistry =3D bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY, =20 // Event codes GspInitDone =3D bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE, + GspLockdownNotice =3D bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE, + GspPostNoCat =3D bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD, GspRunCpuSequencer =3D bindings::NV_VGPU_MSG_EVENT_GSP_RUN_CPU_SEQUENC= ER, - PostEvent =3D bindings::NV_VGPU_MSG_EVENT_POST_EVENT, - RcTriggered =3D bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED, MmuFaultQueued =3D bindings::NV_VGPU_MSG_EVENT_MMU_FAULT_QUEUED, OsErrorLog =3D bindings::NV_VGPU_MSG_EVENT_OS_ERROR_LOG, - GspPostNoCat =3D bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD, - GspLockdownNotice =3D bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE, + PostEvent =3D bindings::NV_VGPU_MSG_EVENT_POST_EVENT, + RcTriggered =3D bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED, UcodeLibOsPrint =3D bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT, } =20 @@ -227,34 +227,34 @@ impl fmt::Display for MsgFunction { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { match self { // Common function codes - MsgFunction::Nop =3D> write!(f, "NOP"), - MsgFunction::SetGuestSystemInfo =3D> write!(f, "SET_GUEST_SYST= EM_INFO"), - MsgFunction::AllocRoot =3D> write!(f, "ALLOC_ROOT"), + MsgFunction::AllocChannelDma =3D> write!(f, "ALLOC_CHANNEL_DMA= "), + MsgFunction::AllocCtxDma =3D> write!(f, "ALLOC_CTX_DMA"), MsgFunction::AllocDevice =3D> write!(f, "ALLOC_DEVICE"), MsgFunction::AllocMemory =3D> write!(f, "ALLOC_MEMORY"), - MsgFunction::AllocCtxDma =3D> write!(f, "ALLOC_CTX_DMA"), - MsgFunction::AllocChannelDma =3D> write!(f, "ALLOC_CHANNEL_DMA= "), - MsgFunction::MapMemory =3D> write!(f, "MAP_MEMORY"), - MsgFunction::BindCtxDma =3D> write!(f, "BIND_CTX_DMA"), MsgFunction::AllocObject =3D> write!(f, "ALLOC_OBJECT"), + MsgFunction::AllocRoot =3D> write!(f, "ALLOC_ROOT"), + MsgFunction::BindCtxDma =3D> write!(f, "BIND_CTX_DMA"), MsgFunction::Free =3D> write!(f, "FREE"), - MsgFunction::Log =3D> write!(f, "LOG"), MsgFunction::GetGspStaticInfo =3D> write!(f, "GET_GSP_STATIC_I= NFO"), - MsgFunction::SetRegistry =3D> write!(f, "SET_REGISTRY"), - MsgFunction::GspSetSystemInfo =3D> write!(f, "GSP_SET_SYSTEM_I= NFO"), + MsgFunction::GetStaticInfo =3D> write!(f, "GET_STATIC_INFO"), MsgFunction::GspInitPostObjGpu =3D> write!(f, "GSP_INIT_POST_O= BJGPU"), MsgFunction::GspRmControl =3D> write!(f, "GSP_RM_CONTROL"), - MsgFunction::GetStaticInfo =3D> write!(f, "GET_STATIC_INFO"), + MsgFunction::GspSetSystemInfo =3D> write!(f, "GSP_SET_SYSTEM_I= NFO"), + MsgFunction::Log =3D> write!(f, "LOG"), + MsgFunction::MapMemory =3D> write!(f, "MAP_MEMORY"), + MsgFunction::Nop =3D> write!(f, "NOP"), + MsgFunction::SetGuestSystemInfo =3D> write!(f, "SET_GUEST_SYST= EM_INFO"), + MsgFunction::SetRegistry =3D> write!(f, "SET_REGISTRY"), =20 // Event codes MsgFunction::GspInitDone =3D> write!(f, "INIT_DONE"), + MsgFunction::GspLockdownNotice =3D> write!(f, "LOCKDOWN_NOTICE= "), + MsgFunction::GspPostNoCat =3D> write!(f, "NOCAT"), MsgFunction::GspRunCpuSequencer =3D> write!(f, "RUN_CPU_SEQUEN= CER"), - MsgFunction::PostEvent =3D> write!(f, "POST_EVENT"), - MsgFunction::RcTriggered =3D> write!(f, "RC_TRIGGERED"), MsgFunction::MmuFaultQueued =3D> write!(f, "MMU_FAULT_QUEUED"), MsgFunction::OsErrorLog =3D> write!(f, "OS_ERROR_LOG"), - MsgFunction::GspPostNoCat =3D> write!(f, "NOCAT"), - MsgFunction::GspLockdownNotice =3D> write!(f, "LOCKDOWN_NOTICE= "), + MsgFunction::PostEvent =3D> write!(f, "POST_EVENT"), + MsgFunction::RcTriggered =3D> write!(f, "RC_TRIGGERED"), MsgFunction::UcodeLibOsPrint =3D> write!(f, "LIBOS_PRINT"), } } @@ -265,38 +265,41 @@ impl TryFrom for MsgFunction { =20 fn try_from(value: u32) -> Result { match value { - bindings::NV_VGPU_MSG_FUNCTION_NOP =3D> Ok(MsgFunction::Nop), - bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM_INFO =3D> { - Ok(MsgFunction::SetGuestSystemInfo) - } - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), + // Common function codes + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA =3D> Ok(MsgFu= nction::AllocChannelDma), + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA =3D> Ok(MsgFuncti= on::AllocCtxDma), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_DEVICE =3D> Ok(MsgFunctio= n::AllocDevice), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_MEMORY =3D> Ok(MsgFunctio= n::AllocMemory), - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CTX_DMA =3D> Ok(MsgFuncti= on::AllocCtxDma), - bindings::NV_VGPU_MSG_FUNCTION_ALLOC_CHANNEL_DMA =3D> Ok(MsgFu= nction::AllocChannelDma), - bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY =3D> Ok(MsgFunction:= :MapMemory), - bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT =3D> Ok(MsgFunctio= n::AllocObject), + bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), + bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), bindings::NV_VGPU_MSG_FUNCTION_FREE =3D> Ok(MsgFunction::Free), - bindings::NV_VGPU_MSG_FUNCTION_LOG =3D> Ok(MsgFunction::Log), bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INFO =3D> Ok(Msg= Function::GetGspStaticInfo), - bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY =3D> Ok(MsgFunctio= n::SetRegistry), - bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INFO =3D> Ok(Msg= Function::GspSetSystemInfo), + bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), bindings::NV_VGPU_MSG_FUNCTION_GSP_INIT_POST_OBJGPU =3D> { Ok(MsgFunction::GspInitPostObjGpu) } bindings::NV_VGPU_MSG_FUNCTION_GSP_RM_CONTROL =3D> Ok(MsgFunct= ion::GspRmControl), - bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), + bindings::NV_VGPU_MSG_FUNCTION_GSP_SET_SYSTEM_INFO =3D> Ok(Msg= Function::GspSetSystemInfo), + bindings::NV_VGPU_MSG_FUNCTION_LOG =3D> Ok(MsgFunction::Log), + bindings::NV_VGPU_MSG_FUNCTION_MAP_MEMORY =3D> Ok(MsgFunction:= :MapMemory), + bindings::NV_VGPU_MSG_FUNCTION_NOP =3D> Ok(MsgFunction::Nop), + bindings::NV_VGPU_MSG_FUNCTION_SET_GUEST_SYSTEM_INFO =3D> { + Ok(MsgFunction::SetGuestSystemInfo) + } + bindings::NV_VGPU_MSG_FUNCTION_SET_REGISTRY =3D> Ok(MsgFunctio= n::SetRegistry), + + // Event codes bindings::NV_VGPU_MSG_EVENT_GSP_INIT_DONE =3D> Ok(MsgFunction:= :GspInitDone), + bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE =3D> Ok(MsgFun= ction::GspLockdownNotice), + bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD =3D> Ok(MsgF= unction::GspPostNoCat), bindings::NV_VGPU_MSG_EVENT_GSP_RUN_CPU_SEQUENCER =3D> { Ok(MsgFunction::GspRunCpuSequencer) } - bindings::NV_VGPU_MSG_EVENT_POST_EVENT =3D> Ok(MsgFunction::Po= stEvent), - bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED =3D> Ok(MsgFunction::= RcTriggered), bindings::NV_VGPU_MSG_EVENT_MMU_FAULT_QUEUED =3D> Ok(MsgFuncti= on::MmuFaultQueued), bindings::NV_VGPU_MSG_EVENT_OS_ERROR_LOG =3D> Ok(MsgFunction::= OsErrorLog), - bindings::NV_VGPU_MSG_EVENT_GSP_POST_NOCAT_RECORD =3D> Ok(MsgF= unction::GspPostNoCat), - bindings::NV_VGPU_MSG_EVENT_GSP_LOCKDOWN_NOTICE =3D> Ok(MsgFun= ction::GspLockdownNotice), + bindings::NV_VGPU_MSG_EVENT_POST_EVENT =3D> Ok(MsgFunction::Po= stEvent), + bindings::NV_VGPU_MSG_EVENT_RC_TRIGGERED =3D> Ok(MsgFunction::= RcTriggered), bindings::NV_VGPU_MSG_EVENT_UCODE_LIBOS_PRINT =3D> Ok(MsgFunct= ion::UcodeLibOsPrint), _ =3D> Err(EINVAL), } --=20 2.53.0 From nobody Sat Apr 18 01:57:38 2026 Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012000.outbound.protection.outlook.com [52.101.48.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B684296BC5 for ; Thu, 12 Feb 2026 06:29:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.48.0 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877786; cv=fail; b=J++07bqcrDrXnfiFyC5VHSbJmsFRcljsrlJ5BXgi5uXo1JZxjO7hFw5Isyi/9HDl85rcZx0USiL15EOJbj02oBC1X+4vXoOnSLSjTdzUXSob5XTvxeAs4IpoR+8GY4N3NR8G9Im5b9DiMrRY4isWvL3C17jsbAcmKA/wCZlV0lA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877786; c=relaxed/simple; bh=afivRu8XN28F0MLVVBuNZWvplveEGEI3Qo002IQ0YcI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=WH9zTYYj8Er6XCagLIHg5LnCaLoppsFbU3z4oZtbT+YuzvmoM6OMCfk8/QdvuIHgggzLkIZiU6cynnerKdVj+Kko7NlzTct4N8V7fVD6Q32m/fm9tWeABYYhJE3fQclMk2GBc2pc/TvO+aIaiijiiHjag86o0Eo9x2Z0G6++CPo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=fwl7JPK0; arc=fail smtp.client-ip=52.101.48.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="fwl7JPK0" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q/1aebI4HBNWQJEIHgm0vfT4/u2VsUC2xxpLEItaeE/KLCUUQTqoxu0NtnNi1ky8zyQ72nvO/qVfjAQ8bFPM+h4tvwodrt/L5KQsLS2tEjs1hQYJLvgMFN5by/spDpwh4oKCZ/Pto68ii4pqI/fgksfCXob7waz5xGJIELgjb3pr0kSeN1LoWhDRW2R9zO8VimEph11H+hWn1JMd6lUY5EbXg/70bDMF5jcByi28/SNcGwyNuXxXe25O+5ah9msxX9bzt3aAmASklROHdhyJdPqmqT+zKRTjgZh9i+HTWuaQ2mMI4WPcuZpvP9rP3GRNKM7l+ADp/LwS1+/r6Jt00A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U4931nTDdgvE4qoduC52jv9onccczTBCKfZ64jeCJYA=; b=fJmMwJz7AqmsoyC4YXDwwlg2QxiBx+o6RjroFKCRhZGWfXQf4VDX/EBVrLiBJNl/jXOiMHdiph7CBmVd65mHYMxGKByuf+/9tRILMlk751Ooj5yI4kL/iOWiGN+ZXbNPWItgkD3Psad1cOET6IjrATPecSjjap3PTpfI7QFNYuutxrZhjYZ5oQ7D/6ikvQJxTpjiP2H0aFr2eUR8KoRLk8DideBXV9CnhSwY/u+bzFyOu6wX+PwHBu4sX0RIi8kMiqgeLiN7olJxY5vLxZtcOrLiKDrtHm4tQcqYl9ZCZONBajUag7wt/GiXot31eYKCUY01OBCGSqAlKh32MGKMWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4931nTDdgvE4qoduC52jv9onccczTBCKfZ64jeCJYA=; b=fwl7JPK04SHj23vQi17ReVUjepDkHZwFS3PJU3hL1Q3qc0AajD8u4sdMeWDSa2Q6B98mVW9tCQMmaYAbIbOb+ZLfA8h8dgTmBB5hAcN0MfvKBQRAMb1Dk2M6+p9zSbigL3VimNd7LjZqFwsM5h+WIWOTTxrSOwg66jLZQSf99yeEZny8LU0PsfeXgDwkh9an3RWGoygjOEbQfBnRM1ASIhSSQptOvXdwU1kmbvSoYuWFcGFeWBPGTb63CQpIp3XBbZFQSWl+vNdxirpP84HFIZjAsGvjn5NiZIFueUrWyOswpd/x8+K8zvt/YIFKCtkeGo5Q7AfTUpFnpAxc/GCpVQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB6674.namprd12.prod.outlook.com (2603:10b6:510:1c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 06:29:42 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9587.016; Thu, 12 Feb 2026 06:29:42 +0000 From: Eliot Courtney Date: Thu, 12 Feb 2026 15:28:04 +0900 Subject: [PATCH 2/7] gpu: nova-core: gsp: add mechanism to wait for space on command queue Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-cmdq-continuation-v1-2-73079ded55e6@nvidia.com> References: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0269.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:455::20) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: a2fb3d4b-57dd-4270-996a-08de6a001b00 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?M1dUaTJJWmM2b3FML01oUTFiQ3lCdHZCUmFOSVp4Vjd0M0crT1RBYXd3MXMx?= =?utf-8?B?SWtpZlFLMEdxSTFWaGhUZGJIdjRoYnVLcWgwRlg1ZTFNTGJNcjZTSEc0L2Qz?= =?utf-8?B?MThOVHZ3bVVwK29wOG1iVW5MaHVvOEJtVzlCVGVmdUF2UVRvNmlMK0VzL00x?= =?utf-8?B?Z3ZhY2xVUXU2ejBSay9wd3JwbU5aclkwRGhmSU9XVW1sRkpWU2R1dWN4SGRM?= =?utf-8?B?TkFrckJqLzdVMFdQdElsd3A5RHNmUnBrMkMwRkxwN3h6Y0Q5aUhEZ0lsUHEy?= =?utf-8?B?ZEYybGt1RlJuQ0pkbEhSQnYySkltc2pwcXd2ODhZREw0VVdwQkt2NndLbXUw?= =?utf-8?B?U3NUaHlMa2kwMDRINlpVUDk5UlB6Y2NNTjg1R2RBbVB5TDdMaDA4dk5Fb3Y3?= =?utf-8?B?UC9TcmxyWnhHcGxpUWo0NmhJR2FhTFgvN1gvR0ZacWdXTFZTNVNVUFpSWlov?= =?utf-8?B?Y3hsSUl3a1hzNWl3Q0VKVmpzSzNYVmhjOFozSFJwQkNJNUFyMWtyVm9aUytR?= =?utf-8?B?S2wyY1dMSEJ2L29OaXRGZllXcTFmbXVJdkhpcldGbmVsR3Y1VS9yOUxSNkM5?= =?utf-8?B?c3d5RE5RUHZGWm9jbXJENCtNM0Rhd1VTTVJELzM5OXdsYU1uQUJPYVJKY3Zr?= =?utf-8?B?QjE4azg5aWRHemRuLzlFYWlMN0UzTHdUUXpTZFhwdFZvakdTYzhWd01QZzcy?= =?utf-8?B?K3U1eVE3blhCUERxTUpGbHBzclZnR2dYVEFGSXdFTGd0TU5MS0hveDNFQXB4?= =?utf-8?B?NkxnYWlXa1JLU3NnN2w4NE1tb1ltZzdxd0ZvYUcvS3ZCRU1CVm9NQXpxcjZS?= =?utf-8?B?Q1QvRmhEV0g4N1JwbUtnSGNqNU9XMlV5ZGZELzgrMXN6ckV4U0tRYTliL1Iv?= =?utf-8?B?Z05CRFlPbnBBTzh5OEl6WUZ0aHMyV3J2SHVUaG43VnY1RFRBSE9LNW9MZkFs?= =?utf-8?B?SlV5TnZHLzB6eEdybEVVQ242dllsRmJvbnVsb3hMK2Y0UzdTbXRJTXNDbkJ4?= =?utf-8?B?dG9NNFE4RzdkYzh3WWUwZGwxNEVpWjlIaTZYdSs4U3ZCMWV0R1ZQbThJODdI?= =?utf-8?B?V25ldGVrZExsUjYvVXBKYkNnQlZIbitPNzNUT0orK1d5cGphM0FNUDhJSm5y?= =?utf-8?B?YTBBUkJ3WHNVZStwN21oZ2NBRXBsN2ZpNE1ScUk3ankwUllIYTFna1dqOTh4?= =?utf-8?B?WmRxbEFUQTYzU3M0RkJTSDdmT2tUL3JuRDU1UDZERE40d0d1NWVMTDlDR0Vk?= =?utf-8?B?ZzIrS3VlL0Z2YUtsWDFNbGgrcTlMWFdBQnZYbWhiZSt2L0JzSU82OG9Bb2Vz?= =?utf-8?B?VlhyQnQ5Wlk1U292M2tRVVF6QTRER0tLZ2xhS0I2clYyUlVFbVcrR1pzMkdT?= =?utf-8?B?ZE1WVTVLRUxmaFRSc0VraCtudFRQZjF0cHdCQTRWc2xpTTdCbjlHYTNsVkhx?= =?utf-8?B?a0syRlN4YWVGYXpkNHdvcGJlQVdya2w1LzMwOXZNRk9TOERHVDBhd0RkWDFr?= =?utf-8?B?VE5ZQkZtU0ZYdFVQQTlMVDhKcndESkM3K296elJxQ2hzZVdMSFk5ZTlGOXhi?= =?utf-8?B?djBuVnloZXp4VFRKYUcxVE5POVB0ejdlVk02SlQ4dUg5RWU3NGVydXNHNWVK?= =?utf-8?B?SGlxZG5CcUVHOGtJQWFBVE9OanRXdHNKMFprV0Y1eG9hUTEremtqQ2Rab0Ri?= =?utf-8?B?Vko2Q0lWNjZzMCt0NkFVeUo5cm13NEtUWjl2anZuRlNFQzl5Q1RkVXlBb1JC?= =?utf-8?B?V29VVkZMTnFNUHJ0NTFZTDJUTzhvSGRSaEF6cW5IRmFjUnU4WWpKblpFUjFY?= =?utf-8?B?bDJvMVJtRmhIdjlNbG9RcnNlMGxLMWJQWjZBNW5BS2RVZmxIU25TellUT0tI?= =?utf-8?B?VEtreEFod1k0M1lpelBqdE42NUVDbHUzWmZWYXVKY2lkbDRGSmdDeFR5YU5p?= =?utf-8?B?U25ITWhvcjVyWUdBTFcwdWpEd1ROTDZ0TUY2OFEwT3d1NHVmK0ttVlpqM0Jw?= =?utf-8?B?RFZERWpEUVpHRzd6aStRZTlsNXlFWEZwT1hHV2NXMTZqNDZDQnRlbUVpMmY3?= =?utf-8?B?MVRnajlNd2oyOVM5QnhLcDgyeUN3NENyMm1pRUtKRitvY1h5V2EvY08yc3BV?= =?utf-8?Q?D968=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVR2T2VmdGpEbitXSUx0Y2NKSnFQVFZSRDlGT1pobUpTTzJJUHFaMVFPZTVs?= =?utf-8?B?cHNiaHlFcEJaZ3JjSG0wT2VYM05CVFlvQjI0a3VaZ2RsSCtqQ2FuMlpWY1JF?= =?utf-8?B?d2N4TDNEazFsVkRDT1U5R0xkYWhhZDNaTHEzaDFINGVhdDNBUUJWYW9ydUY0?= =?utf-8?B?THlJN2VQdHJvcklsMXF1RDlZaWdDSVBzcE01M2ZzY1ZodlRmMUJUMWFnUnZS?= =?utf-8?B?SzF5NlJCRVpNR1poMVFneUxESkEzeFMyKzdnSC9MYk9QNncyUDRObFJDQUEy?= =?utf-8?B?ZGw2YWEzMGtIRm96T3ZMejc2RGFlWjM2VFUzV0pVemJoZk5SRDdvNVFFOHM2?= =?utf-8?B?Q1JYU09XRytXRGdrVDZFdVJsU3JlSnhvOUwrYnU3NDE3dkRMejZKV2VjdmU2?= =?utf-8?B?N3I1Ym50d1VXMkV0YkdiMXdtczhSYnFCZVd2VzBFajRQSjNneWp5eTZVM3kr?= =?utf-8?B?NzY3STN2U0Q3b2ErZkpMakluNTJmY1dBOVNpMG96R0txZDg3enZ0VGx5N3Vs?= =?utf-8?B?TW9iNUZSNDAxQnJkWG91WWlmR0x6RVd6UFM4RnFocmpzT1FvejlYVHkrUkxM?= =?utf-8?B?OGxRVjVEQjFYOXFCalowdzUrUDd0b3MveU1vaU1qZ1JiRUtUU3JLZmg5RDlY?= =?utf-8?B?cE56N1FucDdmVi92Y3JxVE5MV3pZWjR3YVpodFhqRi9ZU1Rwdkh3dWhHaU5u?= =?utf-8?B?dXZudkRmMGZ0aFZ2K2xFZVR3WUIwTFBSNzlJcjUrZGlCRnF6ZjdOdTQrTjJy?= =?utf-8?B?WG5TeG8vaUpiSkNQc2xvTzFma0RweWEzY0NpL3BLb0FuU2gzb2FNbCtIMXR3?= =?utf-8?B?d1ZGUWNlMWxiaXQrenBOSUhqNjNwWjY3dTBFRVRQdkYwVDY1eU9nQXdiSDND?= =?utf-8?B?d0Q2WTU4VEZXUjRZUnpURWROcmswaG5qMmlMNzAwTmhiSXRzSzh4MVhCdm9T?= =?utf-8?B?V3FVWkRQUlJUL3M3TjJNWEFNM1JVRHk0UWRmWk1tdjM0ejFobzR4QngzSDk1?= =?utf-8?B?T3R5czZMQ0owTVBQSTA5cmMxMnhzVmltbkg1UGExdU1VYzFVSGo2dkVmNTgx?= =?utf-8?B?dGtvV3ZFRGQra1lJQzU1eXN0Y2R0K1pmcThGcDUzS1E4VG5ZRVN6SkRGYk80?= =?utf-8?B?YThCOWNmWHIvNXJCbkdrVDErSndCYVZuRDFTZWNsei8xMnplVXB0SXNPN2Q4?= =?utf-8?B?eUxMMWN4Ymxxd0V5YitOVE9LRThwTndITmNYaVBnQ1VoRXdCZzVLYXJkMlQ0?= =?utf-8?B?eFNpVmplY2lZeStqTk5xS29rSTVVTDl5VEw1S3BOdExoUGwwUkV4VEVvaG4z?= =?utf-8?B?ZmFad1pPTm9NRW9mc0QzakZIbEFudSs5RDBFZFdUdmMreVZzYmRTRjVIbW1U?= =?utf-8?B?SGhkS1hrVHhVNUpURWJoakh4M1pBeUh5OUxiQi9Kdk9SUkE2UXBTOTFwSjgx?= =?utf-8?B?TjRPVkRHNllBM1hsWkplVnJJZTRneWdOZEtjVHNrazJGV2ZMVitlR1p2cDhz?= =?utf-8?B?SzRUNFkyY0dESGZ6N21VL29idTJyc1BHRm9MSTh6a3JZWDBkTVZjakdHWFBZ?= =?utf-8?B?d3l1eE1DOG82aTFESTIrZ2hiTTduUjJCd2lDYXlFZUJQa2RyNUswbEc2QUJF?= =?utf-8?B?bnJNVlI1RFlVU1Byb2VDRGZMd0ZWVWpncEpnZTgwTzhLQzNsSnVtTnZnaE5t?= =?utf-8?B?a0JkNUtDb21FS1VlZzloQUpqWHlkSlgyN3dvTUpESUlXd1lqakdweWFZdDB6?= =?utf-8?B?RHB3OVo2QStKaUt4YTNFNUZBYXl6ZUZ0RGQ1QlFYOWUzVVZ1OWlWUUNEcDJV?= =?utf-8?B?L0lUbkU4VGZEOVY0SWE3MW5FOW1vWS9xQXF1c0dlcDRJazZRTi8zRzg2Z1k2?= =?utf-8?B?MCtpeDJKdmM0STMvUElJOVBiUkp1aS9HYUN0cDdOV1MvUUJhWVhoUjRGUm83?= =?utf-8?B?YkhTdjQxSkRYU1A5Q1lrYUxxNHNMaEpZYTY5SmNKS1BCREtaWTFFVFFQbXRR?= =?utf-8?B?aXJQbEZaZkplY0lkbmVsTHYvK0VBa0E5cEZ4czZHSjNUck1NYVBxZmJiT0xC?= =?utf-8?B?dVcvd0pWMVI1ekh3WWFqNjhTVU9ScGJNWkVQNFdTdTFHVE5leTN3RWZNaGR5?= =?utf-8?B?V1NHd1RBdmVnUkhUaEE1NFhTY0tVTlhrTzhlclVQam8wZWVOV0pqMXZOTTgr?= =?utf-8?B?QkZRS0RDTDlQTkx2TWNrS3lXNFN4NlE4cHRlbDJBWGhlRVRvcHEwakVXaEdU?= =?utf-8?B?S2t6ZnJvN0lkODZrV1EvNGpTM1k2WThCYUZOK3o3ZC9QbllBbXUya3BKU21H?= =?utf-8?B?LzBsak9oOFJmeTVhS3U1QmhwRlNiWUgyWlZuK2FhMVlhdTdyZnN1SlJDaWp6?= =?utf-8?Q?bOfwiKavh1uWSPICPWHLikDRgKSTN2Sle3LYINX5V/wHD?= X-MS-Exchange-AntiSpam-MessageData-1: AvCWfEB4IsV6FQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2fb3d4b-57dd-4270-996a-08de6a001b00 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 06:29:41.9913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6xPrcuNHnmNHRrC/+Bba4ZdX+gAwcWv3QejPn734UvdqcP45nhQb/wG1nq12Bs+cfgZ7nCXNT3yuDnsBbLERSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6674 Add `allocate_command_with_timeout` which waits for space on the GSP command queue. It uses a similar timeout to nouveau. Let `send_command` wait for space to free up in the command queue by calling `allocate_command_with_timeout`. This is required to support continuation records which can fill up the queue. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 42 +++++++++++++++++++++++++++++++++++= +--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 46819a82a51a..baae06de0e09 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -243,6 +243,16 @@ fn new(dev: &device::Device) -> Result<= Self> { } } =20 + fn driver_bytes_available_to_write(&self) -> usize { + let tx =3D self.cpu_write_ptr(); + let rx =3D self.gsp_read_ptr(); + // `rx` and `tx` are both in `0..MSGQ_NUM_PAGES` per the invariant= s of `gsp_read_ptr` and + // `cpu_write_ptr`. The minimum value case is where `rx =3D=3D 0` = and `tx =3D=3D MSGQ_NUM_PAGES - + // 1`, which gives `0 + MSGQ_NUM_PAGES - (MSGQ_NUM_PAGES - 1) - 1 = =3D=3D 0`. + let slots =3D (rx + MSGQ_NUM_PAGES - tx - 1) % MSGQ_NUM_PAGES; + num::u32_as_usize(slots) * GSP_PAGE_SIZE + } + /// Returns the region of the GSP message queue that the driver is cur= rently allowed to read /// from. /// @@ -311,6 +321,25 @@ fn allocate_command(&mut self, size: usize) -> Result<= GspCommand<'_>> { }) } =20 + /// Allocates a region on the command queue that is large enough to se= nd a command of `size` + /// bytes, waiting for space to become available. + /// + /// This returns a [`GspCommand`] ready to be written to by the caller. + /// + /// # Errors + /// + /// - `ETIMEDOUT` if space does not become available within the timeou= t. + /// - `EIO` if the command header is not properly aligned. + fn allocate_command_with_timeout(&mut self, size: usize) -> Result> { + read_poll_timeout( + || Ok(self.driver_bytes_available_to_write()), + |available_bytes| *available_bytes >=3D size_of::() + size, + Delta::ZERO, + Delta::from_secs(1), + )?; + self.allocate_command(size) + } + // Returns the index of the memory page the GSP will write the next me= ssage to. // // # Invariants @@ -480,11 +509,18 @@ fn notify_gsp(bar: &Bar0) { .write(bar); } =20 + fn command_size(command: &M) -> usize + where + M: CommandToGsp, + { + size_of::() + command.variable_payload_len() + } + /// Sends `command` to the GSP. /// /// # Errors /// - /// - `EAGAIN` if there was not enough space in the command queue to s= end the command. + /// - `ETIMEDOUT` if space does not become available within the timeou= t. /// - `EIO` if the variable payload requested by the command has not b= een entirely /// written to by its [`CommandToGsp::init_variable_payload`] method. /// @@ -495,8 +531,8 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result // This allows all error types, including `Infallible`, to be used= for `M::InitError`. Error: From, { - let command_size =3D size_of::() + command.variable_pa= yload_len(); - let dst =3D self.gsp_mem.allocate_command(command_size)?; + let command_size =3D Self::command_size(&command); + let dst =3D self.gsp_mem.allocate_command_with_timeout(command_siz= e)?; =20 // Extract area for the command itself. let (cmd, payload_1) =3D M::Command::from_bytes_mut_prefix(dst.con= tents.0).ok_or(EIO)?; --=20 2.53.0 From nobody Sat Apr 18 01:57:38 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010021.outbound.protection.outlook.com [52.101.201.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C48F6299947 for ; Thu, 12 Feb 2026 06:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.21 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877790; cv=fail; b=F8xzOxOyJLo0EPTNcbD+dAXRtgtZyHRsaDh1msXUXTtzVD0hv5levOiSMEeyi+GWYQcr7o6AiU6MgoUnPpfj07T2V//bWn8qV5yMHZbzyuZgsE7LgHqC+3eSEBxi0A8UHSLqjk0N3PEhive/ORWfY9MHeNxWeczywC+cgVzpEqs= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877790; c=relaxed/simple; bh=opvq9BMLrVJJa3vWZS8k0+YDok+ZHnRnddVluoZ1NR0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=acRJDsznTpW4XnKrlNGI0LW9aQvOZJZfgKQiei0/rISAFaKPAzHoML9gC0INfa2Y9Kf1+4L2lEd6KXVBzKqoo29Qmt0wA4+LOThTLaqvi/31MOfdgZLdaEvIDI7CiPwgr1OhqjLSvCucM/3qAv27LQdYL1h5rtEckO92qrX5k84= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=uFYsKx4w; arc=fail smtp.client-ip=52.101.201.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="uFYsKx4w" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ko5PC3ayXud7Mv1mnxKMu8v8lIt9W4avsiJZ0kRLuv7GDFTksFU6VtNhCp9o77wW9hQ2MNZV1xI7U8iG6YJaYfYRUbx+sEc7B9WiVqqI9afgvNiSEaey6gPFS41WYJs5DsAZ2mSbpy/6ZHp7lEbpzvmvH1mWg5Xd0+vGH53Kv+O3yQjYmkTOAq7IDLDEcQDDugTA0nRpFsqBzYJWyTVbms0QV1Xyf+6bw4PZ4YcONPazG7BkQ0c17HFBohwnY1VGtpU8MXMDnlkULKPUQw9KUHApvjhEUaAgUykhOBOOogKyW7Hti4e8UbArD748+fQuHJz7LMYYBJ7ezH5aNNcMyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9NKdionLhfN8pC2qJu+ZMKpkfK0Ksiz7eKaedbhIWHo=; b=fYMDufYJJ+AoK21Vt4WjZQ2ttIBfDWe03VpmB+4LWm2t49K1MHnuaB+Ie2XlG6g64ZwchNDFhBNbZJ2zyTCurgH18kxrDY9d712NmFtnckEzkLptLbC87CdCsYKwk04dkTNLuvdw6Ci/e7m8wnffXFHrUHoXDtcOxdv79kyJTspH7+W6Vyh/ch5n41vpA+N4duq72gJ1cz4uWHFUEZg9qBo2bpd9igCD8D59uAPKW2+1pWudMVlIsCsY4bzSFl/9OKmoFiKbFzU4jgwDwW9UHX/A57Fn8zRX4GVHOBPSMXAJlJy1bjT5PU0ghFLjB3AjhkUIkpvx8Zq3KR2AVskkeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9NKdionLhfN8pC2qJu+ZMKpkfK0Ksiz7eKaedbhIWHo=; b=uFYsKx4wNtCcwYa4d73q8OFov2n2e9E8Z52TDiSAtW3NGJPwN6sfmiTLZfVC3tqTrQ1DaPNiU92EXIPHRsG2gRXFg5zpydWUCBqerDMUZl9e2IsD+QKpO0xTHTuHcrlASEETh6MHWscZ3J4CEy/cwi7D8/7KUV2Kdecx/KVt9JV/kMgpHJTsCy7ltyp3hIIeyrluLSmRyZAFX0FVIqZKP7cFN4SlAsbodnrpx0HyR6BmNbI77YOanur9Z5It+N6dt03FEHL7GktG/QICEPv96QGftqSlY/k82rdESGM1abB1C0xXzAeiJptVjlJT+/+ZqF5jzCMmXJYv/KMC2dtKIA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB6674.namprd12.prod.outlook.com (2603:10b6:510:1c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 06:29:45 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9587.016; Thu, 12 Feb 2026 06:29:45 +0000 From: Eliot Courtney Date: Thu, 12 Feb 2026 15:28:05 +0900 Subject: [PATCH 3/7] gpu: nova-core: gsp: add checking oversized commands Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-cmdq-continuation-v1-3-73079ded55e6@nvidia.com> References: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP301CA0036.JPNP301.PROD.OUTLOOK.COM (2603:1096:400:380::20) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: ad17e958-0588-43e4-3f08-08de6a001d28 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dk9KNVpmMTFuQTg1MVpOWVZwbHVvNVlvcDJ4bG9hdDU1TEhVaWxNVXJucjJP?= =?utf-8?B?ZkZkbCtsT0d2OWVVYmM2Zndla0gzWk11UUxQUENhQk1iSFBhNDB3UUZ3dDNB?= =?utf-8?B?dEtGWDNhNUdoV25heUYva2NJUHc0Y2Jtak50TmVKNmlubkkwaGNRb2lrSkor?= =?utf-8?B?MnRCYmUycitkTi9GYXN4VTZ3V1dNSmFhdlRjc1dKbGgvM2V2NlllbzBLdjRJ?= =?utf-8?B?OFVwbzdWN2tuMnFVci9vMW8xeWdtdmU0UE1GNDkrNFVPTjZqeDk3QUpGZXlW?= =?utf-8?B?UnMxYmw1V0U4eUNqU0lVcStCSXpNRGNQeFNPMExOSDBCQk5zam0xL090ZGdU?= =?utf-8?B?bkpZZzFLbk5CdnNtaE9YQmlSOTRoWmllbkg5MWI2MnBhWnhGUkxOenJOanZM?= =?utf-8?B?eW5STGo2MERKc01sS1hTZlpxMHFBdnBxd0ZQZER5eHNsektibThIaUV2VlVW?= =?utf-8?B?RE5GR2FRTVNKajNQZUJYUVo2OWxnZkEyWk5BQWpEdy80blVhdVVRVWNCc3Vr?= =?utf-8?B?MWlnNDlVK09aRFhMYVk5T0ttakRncEZPZzlhMGVFVmJ3cExxNWxRcTA2VVZp?= =?utf-8?B?VHo3eVFQb0FTZzZ5NkFjV0EzS3hKUU5WTnNTOG1kYnZqSEVwL0ZOL2pjS1Rt?= =?utf-8?B?d0VWOEZWQzI2cGFWZG1rN1p3ZFV5Nm1WcWxkUGNSVUhROEMzeFRwNjFTT09V?= =?utf-8?B?QUZpTUczNlhoVU44Z1I5RUc2a2dhNWhqRDdkQnJnNEUxSlY3MjJEMUFTTHRv?= =?utf-8?B?QlBQdUpnNUZ4RHo3bktpV091ek9mMmtpNUMrN2VkTVM4RVdyTDAvNzlkUDVv?= =?utf-8?B?a2ZnNlNNaGYvUXhka0IzUEpRZUVBbnJOTXprSzZoOFFrQW9HUDZEbDlyUFBJ?= =?utf-8?B?ZXZEQVVaVHdMa2VGSHBudmtiWGx0OGI3WjVkd09EbEJ4aDVOMXVObVlOM0la?= =?utf-8?B?UXhNMEp1aEwra3RPT3JCc1JtSDJ4QXBSQVJOQmwxd09IaGc5Zzc2Yi9Qd1Rs?= =?utf-8?B?S2FuMFZkM2x4SEVxZ1dVQjVQUUVQb1E3TGQvK2FHQk96YlVmcWtOc0tBM3Bp?= =?utf-8?B?RzlUbVFVdVpyYmcrUlFxbzdpQis5bzZRTllhWWZsT1lmWitycE12bGJsRUw1?= =?utf-8?B?ZjdySkc0ZFpwQlFsazNWZmlqc0pRU0hOSTZKWDNBSUVoYXRGamhZaER1bWl6?= =?utf-8?B?LzNQYW5VRUZxU0ZDQ0RqMENjdXZXanF2TUdpZHVGNTFVZ3Z1MjZ5ek1XSU5a?= =?utf-8?B?SGdZcmtKRjl0U25XTSs0eG8vRkU2aXRLamk4bTBSdGZjQVZPM0lxaFBvYklW?= =?utf-8?B?aWJJTys4VDduVzNMRDBMM2UrTDdmeU1vbTJvalV0TGcyY3Q2K3hHYWRucUVI?= =?utf-8?B?cTJSaGt0eUVjaDhNeUFUQjRsTnVYV0VJZW1lU3VjUlVHbTlkNTlFVENJZGtK?= =?utf-8?B?OGd2QWlnSWV2R2FqcDVoQk1xSUNWa05FcDlkT3JnVEZpemtsaUViSllWV1pk?= =?utf-8?B?dThLN1pzS2JqRTNxUGFLaHBrc05XQzBXR21SL3NYc0pMd1FWQ283RWJSaWx5?= =?utf-8?B?azQ5V0d2dGxOeGZFUXg1NGh5ekh1ZTZrdkpBbVdmaDVXU0ZqcnVlN3Z4WHBU?= =?utf-8?B?RnVJMUhDbXZDWlpJblFmd0JFbVlhenJrMGFZam1OUXJqWVVhQ1FxdXk4Q0tW?= =?utf-8?B?Tlo5bE5ONFNpeGNGelB3VGZ1cWc2UmRTZlpIbkpNZjlCZWo2MEt1SkJvWEJV?= =?utf-8?B?ZUZXWVdVRjdwbWFvSHpCVWhJZVRJSEpwWlhqN1dFZFR5N2NMNGdmWU1wbDYr?= =?utf-8?B?VHVrdXRwRXNFUHFHblgzOVZnZi9yS2h3akl2MEVOcEdET29FeThVQStPeTZP?= =?utf-8?B?Wi96ZmY3QnRiTWJueEs1T0lhUEJ2QXZLNmFQNGVIY2Urd2dhc1lXYzcwZW9E?= =?utf-8?B?clBLckk2LzBQb1hhTUNvakpPbVlHR29mVlVCYVVFWThNdjl0UmJBdGlJcEFB?= =?utf-8?B?aFdaNitNVlNkMzF0LzJVVVpmYnErbFpnQitsdlZqb1p1M1dDM0tYZlpIR0hE?= =?utf-8?B?UVQzVTFKSnEza3k2VXBJTXdmbWFteFJlZks1bVE2RDY5aHl1L0liWEIrRStG?= =?utf-8?Q?p8zY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFo4eWYxaExiQTh6ZFRZWVJCMjVnNXcxT0lxMDJtYnB0ZTlUdE5TYldWL0p4?= =?utf-8?B?NFNKZ2RLVFdTeVlqdWNiNkl5WEZRc3FvNmxoQnp2dWRJMG5TMzZrZjVEZElX?= =?utf-8?B?L09YUk42b0lPclpBR2NCOVI3Lzk3UkRlZXVZTU1sSk4wNU1OU05KN0FpZEdh?= =?utf-8?B?aWxsN29XSGV4cFl4OE5jVWZTeDdqVzJrUEhmM2tNcHVjUFlWWmlnbDBPejZV?= =?utf-8?B?ZFJJNUxVVmdVVVNUajJ3Sk1yVUJFQnlFd0NhVHdUU1BIclAyNVBhYVkxb1NP?= =?utf-8?B?UEUzeEVEak01bERDODZVVHZEUURCTjVuVGxQMUsyVzI1ZUdIRmRRaEtQZ2pC?= =?utf-8?B?SEswVXYrcWZUSW9LT2kzSWk5MHRnQ2ZNVzZTTzdWVEwzLzhHbHk1TVViMGVr?= =?utf-8?B?a2FQWlJEZ3dXYmRUY1BIN2N6YlJtZkJnc29rS2Y2R28zVG45ai9hUHk1Z1No?= =?utf-8?B?K2FSZFg2RVdVZnVRWk1aczRWMEY3RzBoa0k4L0pZK200RnREclV2ZXQxMi9B?= =?utf-8?B?cTIzV0cxMHo5WkdVWGRkSXRlb0FaVkJKZ29ITERDRUVGbUxGa1dyejg2VUxa?= =?utf-8?B?VzRVWDAwQnFDWWYyckN3UFJmUnZtb3JrZ3VkOVA0WXlKM21vQlNidGpxSFFp?= =?utf-8?B?alhhODcxSUNWL0dyeXpDdG5RTWhRei9SQWtxcktRMXBaSStOUHo0RkFHNmFk?= =?utf-8?B?VGNyajd5Y2p0elJraTZha09MdEd4eFpVd2htQzFBZ2pkaHMxVkRpT0t4VzFv?= =?utf-8?B?dHdNOUZhWXE5aVZFVmdtNXNocHhhbVdLTWVmamxoSkVTN2ZzSXpCbGpHcDkz?= =?utf-8?B?S2VGU1VudmpEZmY0L3hPbnFNU014b2FYdEVuOEFoN0NreEZlcFNacmdDTzVw?= =?utf-8?B?RWJzdDhOeWtGS3kwZFBoa1BjeXI0MGF0RUwrYkxRVWZ1UXRNc3dQL2NSbDJM?= =?utf-8?B?dVdWbWYwZCtBTy9icnZlUDVmRWpHNHV3MnN0QkFOQy9uNzNWNjRRWEtpZ1k0?= =?utf-8?B?eC85b01tOUNURzM5dW1Sc0pwbW0yYm92NVVGbHZwZ2syYXpuQmtSaU1aWVk5?= =?utf-8?B?N0E2Q3ZwU2FUTGxsVnpVR09nN0o2cmdNaStzcG1BUXduci9pZ0Fhcng4cldS?= =?utf-8?B?L1N1bXRsaTRXNUJnUUFGYzRHbGE3Q0xTKzZmSTA2V1VoejVxUXhVMUxLN0RS?= =?utf-8?B?UlkyeC93cHlpTWRETGlYRVR6R21TZTJheFcxbnlsTGVqZW9XK25TMHlkbWVF?= =?utf-8?B?N3kvUG4zN3l3Nkp2VUNEWkNYRS9VTm85NTZDWGFzQWlVY3FSRGdLTEtTRktv?= =?utf-8?B?WVBYZTJIdTJIaUs3Ykg5SWVmb2s4N1dOS0tKYUZTdHkvcG44aWc3UHZDa2p1?= =?utf-8?B?VThZQUlIKzUyMDcxNDRQQU5KTEtkRFJNZEFob2h1aXlCSUFpbHkyWGNHVDNz?= =?utf-8?B?S3ZIdDRteER2ZTFmUUhhTjUrYlBFWWFpOTFSTTM2QWRWdTAzMDFFV1l1MU5O?= =?utf-8?B?dU10bUVRbWFVQURSNnlUd0pIWElZSGphU2FmL3NoZHR6enNsMjd5aUxGUUxl?= =?utf-8?B?Q2k3b2p5M2h1bE9WQW01NHJLOG9malA0SDFIUXR3S1ExdUFBVFFBaVV0c0g1?= =?utf-8?B?azZoQTM0N3VzSVMyN24vR1Yvd2dxbDNrQWJNM3dJUmcweHJybUxlQk54a2x2?= =?utf-8?B?UnBOMlFXdmo5YUhPWWxIVUF2RjVoOHZoYzk0eEQ5b1VZcUNGcnBPVnBQbmk0?= =?utf-8?B?T1NZK2h4cy81aWg3UnltVXpLNEhjUkFOSytGRjFBc0hlUDc4VUZycDFtd3FD?= =?utf-8?B?N1BJdjZKZWUrLzcxYXQ4MEtodWhabVEzSUptNU0zTGZiTW1INUt1eS92Y3da?= =?utf-8?B?UXliclUvQkhZOThOTng4VG1uUVJhZTFRVkVMVVlmWFhLNXVQdURVZkhsbGpR?= =?utf-8?B?MVpHWjlDdG5YakliWE5DRlNzUkREWDlzcFJVVU5uNnZxSlgxcEV3d0hpTFVR?= =?utf-8?B?NEE5aGJpcDhqbHVIT29NVldOM01WeXg2OXJOMVk3b3NhRHZFODJ4dDdHaXQx?= =?utf-8?B?bys2L1hJeEE1UnhNK3JPcXhITU1FNURVMXdjQjhBeWhOeVQzakpITSt2RTdQ?= =?utf-8?B?dVY0ajlUeVE5bXk4ZnQ4c0piRElhd3F5T1FBaTRUODN1OU9PbTV5OU9XQk9V?= =?utf-8?B?eW1YWis5TnNKcWZrNFMwVDIxczM5dzF2NlJ5Z0pzWkRaQVhqbTdHM3o3MTN3?= =?utf-8?B?YVZEZ0s4am9lazUyZmdyS3NjbStWaWZKaG1GemExbTZtVWdBM2lpMm9lWlB4?= =?utf-8?B?aVQ4Unp6YTNLcjBlNVNSZFNaMWc2cHpZUnRQRmp5blliclNZem5vOG5TOHNq?= =?utf-8?Q?PJlYM7h9Ook4c4Pni8dTPYGmr+EQNwZf/70ZQDjqbeiM3?= X-MS-Exchange-AntiSpam-MessageData-1: B7m881Ga8eMT3w== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad17e958-0588-43e4-3f08-08de6a001d28 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 06:29:45.5666 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YUqi3IfIfDH7D+ViBaj8fwH27omlOn9DAbTWZkxTuWyuy7mwLQNbm49pZ+hY5Fej2CigenWNpyob4HcbloGH4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6674 The limit is 16 pages for a single command sent to the GSP. Return an error if `allocate_command` is called with a too large size. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index baae06de0e09..dbc9e95f1b17 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -122,6 +122,11 @@ fn read( /// Number of GSP pages making the [`Msgq`]. pub(crate) const MSGQ_NUM_PAGES: u32 =3D 0x3f; =20 +/// Maximum size of a single GSP command in bytes. +/// +/// A single command can span up to 16 GSP pages. +pub(crate) const MSGQ_MSG_SIZE_MAX: usize =3D GSP_PAGE_SIZE * 16; + /// Circular buffer of a [`Msgq`]. /// /// This area of memory is to be shared between the driver and the GSP to = exchange commands or @@ -329,8 +334,11 @@ fn allocate_command(&mut self, size: usize) -> Result<= GspCommand<'_>> { /// # Errors /// /// - `ETIMEDOUT` if space does not become available within the timeou= t. - /// - `EIO` if the command header is not properly aligned. + /// - `EIO` if the command header is not properly aligned or sizing is= impossible. fn allocate_command_with_timeout(&mut self, size: usize) -> Result> { + if size_of::() + size > MSGQ_MSG_SIZE_MAX { + return Err(EIO); + } read_poll_timeout( || Ok(self.driver_bytes_available_to_write()), |available_bytes| *available_bytes >=3D size_of::() + size, --=20 2.53.0 From nobody Sat Apr 18 01:57:38 2026 Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010008.outbound.protection.outlook.com [52.101.201.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1FA328BAB9 for ; Thu, 12 Feb 2026 06:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.201.8 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877793; cv=fail; b=KPUT5ZkA4zZtXIeVA+DEicYEijJNmJNtQn88Ph27JknVuyyzC3iGVkbkIr1JT8F2SZylqSy/UhMsCqrmqGUGEJVtfNw0vJOOuQF+gfaZNkmA9564okdDjrAs88kXtrbgXASIfWzhBoy2FZ43rRygWDjVV/RVcco8no/WySU05KE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877793; c=relaxed/simple; bh=QKI1+EQi400MtZKA0FicREprxbroN5u4OeMDDBXbQv4=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=BS9rKuXfGFmnfpNPNWPK67A458IGhUe6PbVAy1WPD1I0yNQsVI+3p2fJrhWurecrArDn3kD5d7Tn4fOI2PxihtccBXVYk/u7vwSyQ+p/dtltlt5i+TE59GJIQfbt1iw+ulPl1/LOA6q0DQhDUIzRtU19SEq0x09bpR1h7/yfK1c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qghApmAA; arc=fail smtp.client-ip=52.101.201.8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qghApmAA" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=UInRBus+Q733c0rAeFSWAQ8REnlIfNjy2cIVHzQSR1LpWZA0/0mP/SXBGeGJKCvkW1nOiK/5DBKpig1lceDQ+GVvnfccUY0lB/WUyIxduzMHUNHTQdEQXvjXmlMUKreSL9PAHPzppbjBZMc0kIAFgMZ60ThV5cH/sNd+FSiO9bsvasHGUeEpwC3Hznd0k0dWPJpQzL+uf2DSNuMSGTUyRKvWnmzWp4jMNWfpQHXd3IVQsTsiaNio9VNRV8il3gG8Jobd6fpoW8QwNPIjMd2P2eMflN6XIPNmclH5hD5eyGqmby+CyhYDBpt/RBaM5O8EU70O6DEzSTZoxEpHekN7xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S2T9IXFwUiYZTRMhp33CgPKcWN/I0lee7iqIsH8d9sU=; b=GiGNk59AdbQ1i5bO3AVNiKXVkg6V8RuhDH7Tih99M7IcrU4CROs6Bou18abNzYV08TJAUrfnnRuk09hXMYLj0Hc2+RpCwkUwRGRKzglaaQvmOLBQHB3iZLHqlF1V4pJ0VWcTuFJwJUmWYIVTQ9MG5G2T7DTSSdUx5C1T46nNgXcGClks4ddAemWC9oNJV4RbAZ5XnU8LJpTwdgk4adCZK6w08XK+1YT8nTRIGXLHeTWWwKWAu4WzgEARzCIxmXVZjwZ3+Oiupz1l8ItpvxzT0dhdXe3arIlgE4X/2I+jDhy4ppPX+6NLyshIJItU703n4IOYqBzOJc42Dbw+O/MvRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S2T9IXFwUiYZTRMhp33CgPKcWN/I0lee7iqIsH8d9sU=; b=qghApmAAqKmOGKlVEn/kcAf7FNmpQrlL38gQJXHcn96YfLqZ08k89yUpFVApIjFEFIg6lUNH5UPJRztW5fcZctEznEInCNBHRfELG6bv0JYWDHVd8nlgzFFX8BjZNck0H3+hNTQ5H8U5CT7cxvxISzP8F130SI7+nIXDQkURoS6E05Frbr5wQBQ0Hy60/J3nxXuzCndjNitqfC0b/y+Z9Dfg15BYumDzv4xoyJN7kCKEiqqhyjiXGWKHmAXA9/M5KPQHiUw7rfc53ZZ1UCQhUVEt8u03F5fjue2YWJMA1Kgmh9zHks+73QB+06/IkerzTP1xCY8qSp2uSRDUFjB/RA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB6674.namprd12.prod.outlook.com (2603:10b6:510:1c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 06:29:49 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9587.016; Thu, 12 Feb 2026 06:29:49 +0000 From: Eliot Courtney Date: Thu, 12 Feb 2026 15:28:06 +0900 Subject: [PATCH 4/7] gpu: nova-core: gsp: clarify invariant on command queue Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-cmdq-continuation-v1-4-73079ded55e6@nvidia.com> References: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4P301CA0085.JPNP301.PROD.OUTLOOK.COM (2603:1096:405:37a::15) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: 7eaccad5-9f50-4779-ce05-08de6a001f54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Z2FBMzhtVDNkcTdTcnc3MkJHWGhCNXdhRGQzeUg0L1ROZkk2YnlzVXNzTCtW?= =?utf-8?B?ekQ1TnkzRy90ckN0ckdmMHI5Wkl0RnI1cWQ0MjBWUGEwWlBhSnhMcFBiRGV2?= =?utf-8?B?L3A1cXVrYkMzOUZYSDlCUWRFV0Yzbnc0NXRwYkdIM3daOTZ2anlCY0hYV1R6?= =?utf-8?B?bUl4NXJSeWVTNmcxb2grMm9VU2lFaTNsTDRsQm1LWW11SmgvUlN3M3hNamlH?= =?utf-8?B?aG1uU1B6ZzMzbW00TUNQdzRHcmlNL1lqVGxodTNnSTM5NXZZYWRjLzh6U2dZ?= =?utf-8?B?d2phcFM1K3FWSHVLTmhEenVEQ0sxK3BzeE0weDRxdmhWdHEzN3NUbG5oQW93?= =?utf-8?B?Y3RJck40VW5HY3hhTzgrdndVblNNWWNBVW5HYmtqaG9kR0pDKy95QkFrTTVF?= =?utf-8?B?Mmo5cUdZaEtSQUdUZTlyb1Q0RE9DclVnOVRGWTZsOHhJWUhSTmxLTXhlTk1N?= =?utf-8?B?dE1Ocmo3bFVSKzB3Tk45bW1aVTR1eWhCNHZabElwQThTZWV2UHVRNGxIaWhP?= =?utf-8?B?STNtRlhQMnhPOEhPSm95WXlISmxQczdtOXdPcWIxOUVIK1Fkb0RnVlVnakYy?= =?utf-8?B?QnhjNHAzR3JiTTZiV0dKRlZHVTlCeEF0WEZKZ0NzRUVpY3I5R1JqLzF5TUZF?= =?utf-8?B?TzFPdThiM0xkdGdqazc5M2J4cEJRS3lwYnROWlg1dVNyUUhoWTA0VTZLUFZ0?= =?utf-8?B?ZE1BUGxLd3ZMU1J4ai9NQjhUSGdmUXF0ZGtuZXVsYmxjOFdNMGFYVGY0aS9J?= =?utf-8?B?S0NGM0ZuN2UxLytIdC9aKzJ0ZGlqSWRaaXlhNUhQRHc0K29PT0NwZGNoRm5l?= =?utf-8?B?VE8ycFZvME5JeDJ5cjhWcGRBNFY4VEw1U1BPRGd3aEZuVEdDTy9sSmNGWnhl?= =?utf-8?B?cEUxU1RSeDNxSExuZERuWTl2K2lwekJrcXZZUDFJMlJ2WGVzdUJmUGhRNzVB?= =?utf-8?B?N2lzc0dIR3NFNWVTajBpU3ZBL2xaQzZ2aEhkSGkwSitYUWxweXlXOHp5T214?= =?utf-8?B?ek9KYklWaGZ1YTREUERpQThqUDBmOCtRYlNNaml1WXFkSHduRzZabjhJUmxH?= =?utf-8?B?R0JwYVhsSU84elZuVjRxRlFhcjFQQXFLc3UxSEFIbGM2Z3l1dkxob1M3OGdr?= =?utf-8?B?c1UrZnI2ZTRlRGFvME82SjU2Wk1iSmd2UmUweUdsTVlxU0JuVjd5aUpxY1Vh?= =?utf-8?B?RlZYanBTTDN5ME56YVc5YXRVeVN2aGZTT295NzZOZm5CZXFSd3BzRFJmM2F6?= =?utf-8?B?NWFrVzAyV1BHc2FFWGxBaURHZXV2YmhtRUJGdytTeUtQTG02c2Nvak1rYUJZ?= =?utf-8?B?eCtrQUxOdDNsT1d5d0FxVFlZQi8vVkY0N2twc0ppNWJpdkV0YWZCRC84c3pp?= =?utf-8?B?RFpnU3lnb1U3NFNkbTdFODVYaXhLejhFTFE2eGJIMVNpN0x0REpvSEkrOExq?= =?utf-8?B?aWY2ZGtEZTArVzhCWHdmK3lKYkk1Ti91R0dTdFlJNzBIdk1lcGlsRExhWEVi?= =?utf-8?B?N1ZiZjF4Y3A3b01nNjVOa1FCRUtKbXBIemtiN1N5ZHRpc2syUUJNVUlRbmI0?= =?utf-8?B?cWI1VGFhVnVDS1BsZjkzdWRuN2RiNmwyd2c0a01OM3UxZEdrcHVaVmFDNkZx?= =?utf-8?B?Y0xQUzJhR3VwSEZvOUs0S2JxK2N1eXFqMlhab1ZpZStYWlNUNDFJZEFxVEZu?= =?utf-8?B?WmtVYjc3ZUZROTBLcHN5Wk5Hei9UL1lyV2N1d0tJclpOL1pUOXNuNE9UWi9Y?= =?utf-8?B?SVAzSHJ4SGsraVliRkdGZXBFN2VNN01odkRqOGYvSzJUeVBoOURsR1pIS0dU?= =?utf-8?B?cHhXN3ExVUxCV0lVa240MkZGL040UitCTWgvc1B3SW9uZkZ5cUdKanR2YUlu?= =?utf-8?B?bXFqaVNJa1dlWW9Rci9JL2FHSnlvb0I1Y2laUFB2a1VGTDYxaWcyeS91SWtq?= =?utf-8?B?ZVBzNUpyN2NaejBoZVhUenp6ZmxMamwyZWl6ZEJpT1hkdFFGSURCME5sTzE4?= =?utf-8?B?OXFKZDQxUUNDVmFsUUo0YndlSWoyMzJxL1ZpOUVuNFo2b2NYNGxBZlRhS29K?= =?utf-8?B?a0ZsU1NjTjJRdDBaemJLenJ2Si9uamFoWmhyVDFOSXdsYmQ3OWhUMHluYU5Q?= =?utf-8?Q?Z6Vs=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck10emljUVJRUzVqVXZnYnR3RDkyLy96U0dBQWR2S01yQlNtMzM1ODBhQTF0?= =?utf-8?B?Z2hPMGF4YUhXeFRKQ0xsYUNjWS9YRUJTZnpvOVc1VElGdHVFbCtzNnFjNXlB?= =?utf-8?B?enZIYzR6VTJycGxnMTRoV1ZrUVF0UlBkazlaelFWcXpncUxmV3RFbGo3RFRR?= =?utf-8?B?bkwzeE10OWlPK1hqWmlxeXFsMFZ3Q1NUUzJGcWV4Zmh3eTFxZjg0ajllc21y?= =?utf-8?B?Wk53MFdONllLRzlUQytiRnR3ZHpiWmVPaThKa2hveTBhWnlpOXJGOW13b3ha?= =?utf-8?B?OUNsU0h1SUFoSFZmbWFObXhFenMxY2ZhYUpLMVV5YllHTFo5bW5vcVZObG1W?= =?utf-8?B?aTg0NEpqanN2S1hlbS81bnMzOGwxbDYrUDgzVnhtNDUwKyt3d1VuNGNLZnNZ?= =?utf-8?B?ZWxFZWpONDNrS08ycmxzV3RlYkszclQ2NjBVTnpIbk41YWNCSGtSL1JQU21N?= =?utf-8?B?UUFYWWdwaXpWRGFLZjcxL3A5K1g2VTNhblBzZVkzZmJpRUQ1b1E1azhwQzBM?= =?utf-8?B?elJ5bVkvRzdTZ29rYkRWb0k2Y1dkOXk1YU1oWUNnOGZXR0hNRHkrTU4zbVJq?= =?utf-8?B?VnMyVHU2L2pGVWVzV01Xa3pRa1BpRGViV0htZVhyRmhnMzkwMDk0eFdadGlr?= =?utf-8?B?UmtyOERiN2VoU0VPL1ZDM0xMQ0xrOUxkUStZWlB3bW5UQS9RSi85SFZqdlFF?= =?utf-8?B?S0RBSHUvQWxPRDZlUlllQU1wSkVtNmZZMUhsL2Nod0p6NjlvN2ZiSGk0Z2tM?= =?utf-8?B?VWxYQVR2NVZHTnVuZm1YWGZtM3Noa1ppN3Z0VWtrK0ZraWw2bktHd1lFa3V3?= =?utf-8?B?a3YvZVdXUzFSNkdhSDBVc2lJVW9ZOGo0Rm52VGV0aHNSZ1RpNUI2Y1JzMUN1?= =?utf-8?B?RUtNYzBLWHhobWh6YU11NXpST1pWamZ0K0lWM3ZsRWpMQTRlMWY0SER3NFo2?= =?utf-8?B?R2k5MmRzU29ja3NkQ0ZlSzZxQmtWR1QvRzRYUlF0c0RBTzBCdURMdG5rdTRX?= =?utf-8?B?bEhNazlQTnVjakYrdzhoS3FlZjZPWjNZV1BQbG4rU0hhdnMxaCtndXVCRE1X?= =?utf-8?B?OEd3QWh2UjBpZ05NYUQzdE1PRHhFNUlPNzlpUi8vR0tUTkpZZUxHaEh3eEFp?= =?utf-8?B?TjBBN0hGZFBmckpvaGhNUTAyZTA4RzE4MlJlY3VXQlVGdmx0YVYrSnkzLzBV?= =?utf-8?B?ZjliN0pmQUxrcHNCbUtDNEx3UjZxaWdEVHFIdDJ6aHdzY3BCaURuMzZEWEZB?= =?utf-8?B?ODMzby9ZOXJMNEd4cHFqL1h2UlpHVHY0V211cERvOEYweklzZkFpcGVoRkp0?= =?utf-8?B?c0I1ekNxb2dSNnlOMEJ0dWtkT2x2eGpCb1dhV0hMTG8wQnQ2aDFZSm1OOW1M?= =?utf-8?B?S01RbGcwOFRLS0JsYmVUQkRUTGZRZFQ5a0hOU2t6VG00KzVOQUlhQlMwY2Jl?= =?utf-8?B?cTJMOHpyRThZMUVwSGJkbStqaWJmZlUzMDNYR1ltK1VGRXArSHQ5S2xhbmQv?= =?utf-8?B?Q3Q0VGhvbkVIdlE0U01WRnM1KzRkSmM0UXJhN2Z3VVJyTFNJMVpnZXRQdFEy?= =?utf-8?B?K2J6WGVESHo3ckJ3Q0xKd090clE0MFFYSUw4LzVncDdEdENSR1k2N05aaWZj?= =?utf-8?B?WkpTUkIwSXNib3VJQjdyOUt5NnZFVVJ0S3lPV1RCSERpR3kydXNEbC9xaWNu?= =?utf-8?B?LytVU2JFSDF6dkl0MFdBZzJndmd5ak5CSi90RE1DQmgzUWs1UXNtTGs4RXdN?= =?utf-8?B?NmVxdmkwMWFWdWl2Ti9OUHFOQmVSMGNzc2dhaUNLbVFXWm1xdVBiUG5vdUE4?= =?utf-8?B?QmJBNzNxaFJFSHdlVUVxWEVMSEpYamZxUGlWK1N0MFhHQ08wVkpqbG02TzdR?= =?utf-8?B?TndtVUE1SmZraFlneEdBTDVSTnorbE9XYmV3b1JQMS92THJsQjFMSHVKdVlK?= =?utf-8?B?SkpuNHJYeDd1UjUzZUJ6VlFZSXVvYk56QWw3RW4zKzBZdkxXTlJ3SGgwWDZV?= =?utf-8?B?anRMbDVRaXVZVkNXeEI2NW9kODFQazVZdXM5Q0ZFWU1IbFdqbmVmdXVXUFFD?= =?utf-8?B?L3p5ZFo5MTBvK254WEtVRDgvREdkeUhTR2dNTG9KcFJwb3BZRXVlZ2FxWmpV?= =?utf-8?B?YXVwamh3bkswTDQ2VHRmUDEyUExUYktoWS9tQWJuVERqaXpHQi91MzdCbHRz?= =?utf-8?B?K2dXMTJJU2ozTk9VdllhNUxYWlBFcEYrL094V1F0VGtBczUvOU1LMFRHVFVU?= =?utf-8?B?WEtwT3J5QXAzSTF6K3NzL2pGTDcvS2FCQnFUVE83bFdrWWwxb0d3aEdjSlh2?= =?utf-8?B?NktJeDFkZlg2Mm1TZ1BtVDhibDNmZmNLNVVVWCtLRDd1bUNDQ3NqUDJVM0t4?= =?utf-8?Q?8L6EAVLy+wrCcKDsQh0mKdw7X4H1QD+4O3UiLEXYCLjIV?= X-MS-Exchange-AntiSpam-MessageData-1: 7SRal+t1Kgcxdg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7eaccad5-9f50-4779-ce05-08de6a001f54 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 06:29:49.3985 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tvjNAVwuz9bYn7Fn/Lba784oKEKZD20WV3sdWr0Bzp9DZCIkDhD5Ug4bvi1plm35/tBhWdN/LkLO5xgxwfqAyA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6674 Clarify why using only the first returned slice from allocate_command for the message headers is okay. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index dbc9e95f1b17..78f0b1a0e30c 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -542,7 +542,9 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, co= mmand: M) -> Result let command_size =3D Self::command_size(&command); let dst =3D self.gsp_mem.allocate_command_with_timeout(command_siz= e)?; =20 - // Extract area for the command itself. + // Extract area for the command itself. The GSP message header and= the command header + // together are guaranteed to fit entirely into a single page, so = it's ok to only look + // at `dst.contents.0` here. let (cmd, payload_1) =3D M::Command::from_bytes_mut_prefix(dst.con= tents.0).ok_or(EIO)?; =20 // Fill the header and command in-place. --=20 2.53.0 From nobody Sat Apr 18 01:57:38 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012040.outbound.protection.outlook.com [40.107.200.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7FE7291C07 for ; Thu, 12 Feb 2026 06:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.40 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877801; cv=fail; b=LCjQKawoLYD365/cYVVR3bA9+EYHn44+LwsS2KdvPRzXTcok9wO0OxzNNAU6t8DeBwVMYM4K0PpT0wpRsfG2AgD6tvgl37nHCPIIhw2jFOfYddz9EbcovMK1mWDMqUBXVKEZyK4VBoif6j8JJAtglb0N1j2aagn9cG+6tI8VYts= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877801; c=relaxed/simple; bh=OEla7ECU0+BpoFRcrue0JBFSGZTbw9At7o+RWjo+otM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=HOzuJTPJJTQ8a973euBGx9hmV9mQWDNlN8VePl8sl4o+jJfX/deDqGPTjIZbPrhHzGphuK04cpBjD0zjPxyMysVjFvp7PPqZ2eUdzxlB44qB9Iio7wvHBtdWXNpT0tQcdK6t7gddgXDd9pEQiTVvLuAleTXU9QTxVAhIZFaEjw8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=m4SiPFIo; arc=fail smtp.client-ip=40.107.200.40 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="m4SiPFIo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oCHYAL2zPPZn3d/ka/5VGyzFssufrnREpF/VAR8Cyv+Ac7JTnvW/FhWM7sk3WMTh96ZxjCv/N/UcEz23bIOqwanTQpNB/RfIQoxAAxxlhAqW1SG4f0+35PLGEWLwL7zZ7tR8f9p57Z3OeGM6hELIhIwsNd/bAQJ9qb2p4OgsIP7plHo/I/QEj30E1wQbYDT2VUeLJlZt58XYRyVH7t820iDn9a949GRAp0TN5pwz5qku/9pBayx/wej7hTAvWqftx1M/cHk94ZeUSiCtZ+i8z6NMKdgR372CTqqN+9lc1yMM4kxno/PN3C8f34du8jnL/ZI4R23XC6KE/8n53bE0oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+MZCbry3xT9HH/Rjeide4E4Yup+crep9T/mOV3d3kbI=; b=qFxRctiyaKu3D+NMwGm75czto8KnDa9chJHsx8s6r03SBjDwb+Wgob9Dd8eqW4gDBP+ra/yYgGdI3i6aM9ridUOexrLA1pZj5jfAercVPiOGh6Q3jF/rHQHIxgmgX0Px5MrFs2fhmqnqTOSlseIwCsxVs7+LE/IbItmerq9pnpjSRmR/3nsIA1Z7NQpOCx9QLhLE2RumZrdUyuMnpJy9SEm8l7UjnjLvIVgrnt2JS6daK/5CQoGpNcqTBLV+Xa5GS4/7WbBXGXwxQH9q0ae2qOhSieCK+D8YdZxNca7LtLaq7yxbZ4sGHZEqR8bKESMHpAaPpUL8/deZLzl+w+xVNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+MZCbry3xT9HH/Rjeide4E4Yup+crep9T/mOV3d3kbI=; b=m4SiPFIoNx7JJYtr8/9uqakUmfehJVU5fuNz5T3AjyQWMoX3QTbX9p1zA6WdX4pXtfqKRKxAqiYlW8IFXrJuYREaZLY92Xb+Okb2C1scEeTunjTrTTOkCeCowb+19J+3GnRQ3q07wvHGGoDJFm4woBURZzMp2qxvtPP+jXvB4PaXAcQYL832nuDuPpK7Mlw5m6zK9LR43nHA8SjlgOt+esAIsr4bTG0zDG+DGS3oSDRGSu0IxK1tKDW1BJXhKSuEcj/3mTaXQbd6rUyNQ8101a4mLrIu9zq2Dhe7jPj2Kask3kcrOQ7eTX7dGXQQJjklKVFjAyzUijF/Q7gazeVEHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB6674.namprd12.prod.outlook.com (2603:10b6:510:1c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 06:29:53 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9587.016; Thu, 12 Feb 2026 06:29:53 +0000 From: Eliot Courtney Date: Thu, 12 Feb 2026 15:28:07 +0900 Subject: [PATCH 5/7] gpu: nova-core: gsp: unconditionally call variable payload handling Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-cmdq-continuation-v1-5-73079ded55e6@nvidia.com> References: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYCP286CA0149.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:31b::12) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c3279d0-a2b0-44f0-08f5-08de6a0021d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?OFBnL1U0S0grVDN1a3M3YnYvNUxqSFlJdE0xUjR0azFSdUVWMlJuNkZVUmFC?= =?utf-8?B?eUpjeHJuNUF3dmhiNlhzUm91cE5EdkxGS1pDMXlNNll2aDVJam1vaXlNeEdH?= =?utf-8?B?clBZalNkV1RjNEFWVEdMcWU5UG9aak04NHdIMlJNVTRwVHV4NmJzSkZPYkpJ?= =?utf-8?B?SS9QZytPY3RPeUFsVVE0Y3daclpVcDlVZkZLNWZiN28zWllra0QxdTN6WUlQ?= =?utf-8?B?ZTlFd0hoSU5wTzdBbVhteEtGVXRjSEY5L3U1eTJOWml1bTIzOU96WnlBeFVK?= =?utf-8?B?L2g5MkdHWUwyWHpPckZ5eEhUTzBXVzJPTzM4d29ubUFTMmhJQTErSnpXR3Jx?= =?utf-8?B?bW41NDc4Zk8wT3h3K0JXSFNPVWhqekVVSWpMTlpEZzRwazVLRm02VUxrNmVu?= =?utf-8?B?Y2lwNG5lZWkzcmJ3NHh3UmpyeWhCelRxeEE2S3F3cjVLcFdDWlJKMHdRbE5M?= =?utf-8?B?aXJYWjUwYkYzZEh2RVZ6UVFaSnZaZDNKQ2pmRysvSm8zSUwyNCtlVHAxODVB?= =?utf-8?B?SlRYa1dCbldhc1VYVUhjODVGN20vS0QxSkpoM3lKUlQvaUF6S1RKRTR6Ulpw?= =?utf-8?B?dzVHcW9JVERMSzRyc0xPRDdWMWV1dGNNbFVOZlZHWEw2MW5YalpFZko0L0N0?= =?utf-8?B?blhkazNTakUva2xCWnVrRGNIWlRzQWpxajVMMWcrTEdxYS9zMThjVDhIbDk1?= =?utf-8?B?Q2VWUkdKZUpoSElGT3phdGNnWGd0QjcxRk1pc21GdE9PNmtVMHQyUXB2Uy9O?= =?utf-8?B?SmhuN2tEZEpGQWpmMmlwYkhUNUEvcjNZT3B2c2RHQ2lwSGpEdUFtcFFMWlln?= =?utf-8?B?dlprODNaTGM0V3JFd2RBUEhJSGJ3bm5VcTlFMFN5QVZrOEVmM2E5SFlKWmFQ?= =?utf-8?B?M3lvNUJQS2dvODVTOTRSSmQ4cklhRE9sUENySjVHdUlOUmZqaHZ1emFicE5X?= =?utf-8?B?NXpCeHZDYURiMEN1S1VIRElTbURsUUR5RzFmSFMwSGh1anV3RkhjMmQvMW9I?= =?utf-8?B?V3lPd0RqY2ZEeThrZDZCY2VTNGJ5SitmaUgvRnpnOENaU0J2R0dMTVhvd0dI?= =?utf-8?B?Ui9KUitlMGNjNW5iUkJOa25XM29oYklFa0JRR3BTOStSNm10VFFUc1JmZ1NR?= =?utf-8?B?b0tjY2VhTWV2TEFlRkZ3WHRPR3NtaVpQVmszRWpzVlQzUVZIeGsya1lMSVdm?= =?utf-8?B?Zi9IYnZBY3ZBNXdFaGRmWnh4UlpheWF2TGl3eW01Mjc0YWtVYjBMcXFtSklV?= =?utf-8?B?dHdDTW9abHFUaWxRZjBKeEhKV0NXRWNDMjJlSjE3Zm9WNzJydml3MktIcFNY?= =?utf-8?B?OWZRNTJMV1JDaW1XdXVWNEJqaXdRcjUzNHRlRWVvRU1icHNnOG40aWxlb2Ix?= =?utf-8?B?STQrMHBUalRpSm16QUE5d0ZUM0NIeG1Cc241OGtkRkdZaG1Od3MzeDh4em5D?= =?utf-8?B?MWRjZ0NXeExiOEJFcWpjWGt3YWMyYm5YLzMzL1NiN1JrSkk0ZnZsSXp4RlN5?= =?utf-8?B?UVU1V3NDSitCenVvbnJjSkhYWHlnc1EvQXRHRVBnU0d2L3lpWUc1SWJGWXBI?= =?utf-8?B?c2E1N3oyM0JRNmtrNERMa29qOGZsWjR0blUrRkFBUjZDUzZCMXM4NEg1OWl3?= =?utf-8?B?b2NWSXpxaklYTm84MGVhYnlud3oxTHZISDlSSzJLVXlWbzc4bEdIZEE2TW41?= =?utf-8?B?c2VhYzFHV2NUc2xLQmIzMytJc00wTjhPQk0yejNNdEFrVXZrTC9Wall1VlhC?= =?utf-8?B?eW1YeWY4TnhMVHNTTjYwWERtOWdLTXVoeEMzVkNjbE1WMTI1dDdEUUJRSEhr?= =?utf-8?B?QTRiQ3FtYmMwcmt3UmxsVm4xQUw4emQvczhBak9NRlc5NE5SVnBRVDk5MmNl?= =?utf-8?B?NjJaRm5aKzNZcFFsS3pTNWV6R05WbHBRZXJER1IrKzBaSDFtTTlyNVg1bUNE?= =?utf-8?B?dUwwZWQ5NnVuVktaRHNrVmtLRnNDM25iOGhrK3Izdzd6YytJUzRIL0hySVV4?= =?utf-8?B?UVZObHJnbXN6a2VQME1OSW9mOVpUQ05YaE51K1gzWlAwMDFQdGttYzJNVXR3?= =?utf-8?B?aDlNKzd1aUkya2Z3ZldvVUh5QkUvK0hzUmhhVitFb1d0WURmc2hMMStKWnNB?= =?utf-8?Q?vX6I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDhtbE1IK0U3ZlVJbU5ESWNZTWFoM081STZEbGJpZDloZG5sdGQ5bVhjWEhq?= =?utf-8?B?cTN3T0c3czhnSkVmbHZrbURvTFFNUmx6a1BFeHIwM1E4cXYwVFVhbXZTaUJ0?= =?utf-8?B?MnVjd0t4UjVkek9iSzlWWWU3alBuQ3J1c2MzOXFqR3p1eWNWU0NvMENabHdF?= =?utf-8?B?dFFLVThBMDZtREVpd052bEp0RFNTWTZaaTViQ1FGSitCSlUwL21yc1BkY21Q?= =?utf-8?B?OENLSmhtY1d4WjVHZmY2QVJFWUFKUmswa29NU3loa2RITlZMbmZXZ3hOdjZk?= =?utf-8?B?Vm9vcGZCS0g2alFpMm1laTAxLzdQdUJCNHhHTDllUUhxbldialNQT0llazlz?= =?utf-8?B?cjNwS3V5UWMxUGRlZDc2S3pGVXNkRXdtU1VhRGdqMUhlYnNhdlJlWUJ2Ymtq?= =?utf-8?B?Y1JwV084M3U0bmxGZHlJdUpDZDdHdUlQbnFXWDRRN0pUZ0NMS1I0SW5pNWJ2?= =?utf-8?B?TVMyRktkSmh4ME11SHdFcnh3RjdxSVpqOXhJSFRJcC93Z3dtclpFOUtSa01G?= =?utf-8?B?NFJBc0ZwL0RlWThiK1ZXcE9xQmZlRmZWY1ZVYytIdUlMVElyK3A4VWZwUHJt?= =?utf-8?B?Z1BpdllnQUFWbjJPQkpOS0VXdHNwbWorbXRXZVU5OWNRazZ6eU5JZllKeGxz?= =?utf-8?B?djRXZ0R0RzNNTXo4Qm1BUHREeXJBL0NabzhIeEZMbENrMXljTEZ3NlNwcy9E?= =?utf-8?B?Yk9QL2R0RGhrMlFiaFdCemp1eU5hNjR2ZmRieXJkS0Z4bjgyZzduZG1zOHht?= =?utf-8?B?bDhaUWRBMndVSXNCWDRrRnNIU2tPaDlaN3FrcGdEUFA5c1JzeGo2Rkx4Nkpx?= =?utf-8?B?WnFxNnJBeHkxZUtUdWczaVB3RVhSQXJFTE5iMGlhMkFBUUtuSXFkSFd5c0FI?= =?utf-8?B?ZVZHNnVGQlRUaW81ck1qWWVydTNZM2dtZWwzTFAxbXU5Smlab2MvalIyN0Ey?= =?utf-8?B?ajZ0N2xGclpZbmVoejlkdHR2bm9VOENGbERvTmwxSzNQaUVTcUpFbTFrSUlj?= =?utf-8?B?c3ZTRFRucjdHSVN1STlkTEwxWkV4V05Nd0FpR2syd0VlVUFUU1B3YXpZTUpi?= =?utf-8?B?ZmdZbWNRR2VVSkR3TXZUNDJjT3lTUnpUTzhPYkdoY1JLcTBsWEZ3dU5CQ1ZL?= =?utf-8?B?ZStHczVoUmg2dE01VHh3V1drZDVGQXN2dzVnY01GeWovRUtNVHNWRkpKeEty?= =?utf-8?B?R2V6Rm5xcSt1WVdqV2o4Z241MUNQRTA5dkZvY0J4WFdvNCt6cEo5Qjd0d0NL?= =?utf-8?B?SzdOc1JPL1RUNDZKMnZWdzlKMG8yTWs5c3hpV3hkUkhaby93QWc4aWNFaGhO?= =?utf-8?B?RGdCTE9FeUd2cGI2SEhYT3FaUVkxT3I0SXpBaTVhOUZjTHRUTzRJN3RFdDNJ?= =?utf-8?B?MVViSlFwck1VOHZHY3cyMkNMSTloUnpUR2toY2ZUbXJENG9ENXFoUzFwRDFY?= =?utf-8?B?dTdJQTZnc0dEb3hYMmU2WUYyclp4ZmNkR0ptZGg1aHBuZVg4dkVINm14cnFp?= =?utf-8?B?TDBoK0h0elhXUVEvSFM3b1hiUEYzQ2wxMVIyKzNWdFY5bUkzZXRwakFJZmp2?= =?utf-8?B?N1lHbHgyNW03S2ZCVE9OSWQ3eHJwVTNrVGJTNm9yWjRBTE9CWUtUOWs5Ynhm?= =?utf-8?B?WDVwc2FsUkNaL3RWMWhPdlJxd3ZUNzlPRW1PU1pNNE0vK2x2aUJJRHM3bmti?= =?utf-8?B?WHd6Vm9KYTZmMFhNRzk1YzQveVVvWENiWkZRTjFkSnhGbDRSNFd3ME5HQWdQ?= =?utf-8?B?b0xEWEE5eHdxQ0pGV3hwU01MS3NkZG9INGlFU0hqZUVZbzJYQW1uamI1VE54?= =?utf-8?B?MFl4bEpKMkJhVXVFZm1xbWZDOUZMR0N3c05zN0Z1UzhucVhsb3FrL3cyWm1W?= =?utf-8?B?anp5U0dZazhYazJhSVBmd2FjTjdEaURSMVF5bE1qbDQxNHN2TGd2QnBqOVBk?= =?utf-8?B?ZktQbVdXanc5MzRSckNyS01LSkRCTzI1WW82d1YvS1RKa01qdTV5L2t6bXh6?= =?utf-8?B?MnEzRjhCUnZiOTlaaVRmZ21aNHhkeDhDQ3N5Tnl0N0g0c2dvTzRSbEk5SWFt?= =?utf-8?B?K1luc0tVUEpWVW5MRm0wSThRME9vNkw4WVJtWFNZR3huUlBjUWZyTHFRMDVL?= =?utf-8?B?RnhZMXN0UzBNaXROVTNlN1JkcGJTMVpvZU1scjhGZ0FqZzNBNi9ySWhRQUsx?= =?utf-8?B?czhVZnRTbGsvMC84OXJhdGJLMmt2bWNoOWgrYWJhV3ovaWRYbnEvSWRKb1lQ?= =?utf-8?B?NktDY1pYYnVnQmlFMjRaUmJhMVVZajY0a1RKeTRZd3N6T1lxcWF6SjZCd210?= =?utf-8?B?QnlmOEozVGVCMFhEQ09zUGQ2SHJPVndONGpoUi9WQ1AxOWxCdFFkWC93L0J2?= =?utf-8?Q?NlL8jKExZlZ92IcqOzXYHUsq8wQib9uw5AA7ZBbp09Ovt?= X-MS-Exchange-AntiSpam-MessageData-1: wvZkQmdv4YbW9Q== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c3279d0-a2b0-44f0-08f5-08de6a0021d2 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 06:29:53.3988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KcZlNqECGe97aUATkjKsg/9zfI7A/Aqc/uShiwHQVESij4avMWmuFHzDJXzoMc1ES+l6hF1AliGu8OdL1j0iDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6674 Unconditionally call the variable length payload code, which is a no-op if there is no such payload but could defensively catch some coding errors by e.g. checking that the allocated size is completely filled. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 78f0b1a0e30c..3e9f88eec7cc 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -556,16 +556,14 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, = command: M) -> Result command.init().__init(core::ptr::from_mut(cmd))?; } =20 - // Fill the variable-length payload. - if command_size > size_of::() { - let mut sbuffer =3D - SBufferIter::new_writer([&mut payload_1[..], &mut dst.cont= ents.1[..]]); - command.init_variable_payload(&mut sbuffer)?; - - if !sbuffer.is_empty() { - return Err(EIO); - } + // Fill the variable-length payload, which may be empty. + let mut sbuffer =3D SBufferIter::new_writer([&mut payload_1[..], &= mut dst.contents.1[..]]); + command.init_variable_payload(&mut sbuffer)?; + + if !sbuffer.is_empty() { + return Err(EIO); } + drop(sbuffer); =20 // Compute checksum now that the whole message is ready. dst.header --=20 2.53.0 From nobody Sat Apr 18 01:57:38 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012059.outbound.protection.outlook.com [40.107.200.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90220299947 for ; Thu, 12 Feb 2026 06:30:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877804; cv=fail; b=la89P3PoBZeLeE2u7ydtIjdvAgcKWHr5+ywvHyi4CH0LW/oIfErD0bfp6h4V85VuwyETK4e0blpt3DyobhMacFH9PV7Zk1iSeUx1W4gLQa8OztZwPvIDv3g4S0AQCfjh4WkKbWnD+y9MCYfBBdETI66F+Hyf3R9kyw6udmEoCiE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877804; c=relaxed/simple; bh=V4IFio5PlHLlC4xQ2Hy1u/GCfPTYxh13mdL2ZdHByIc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=goaaEAotT6c3GWNbZcNdGTvVlXgEME2o5YoGRjs079PFQNFk03dAL9TwK4BkakXlWZjy7EySq0IwaLVOZ3lWxHYSlHi9edvEZVYNNnfQqNID9kOUERN9eGlofj2ZnMa5FanvqqTl2kXOV7WI6J10H7uhN7xVcKBzjpTuqXKRuD8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=gW7MWNaf; arc=fail smtp.client-ip=40.107.200.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="gW7MWNaf" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SP41JL4MjhYUIo0e+YsSSDJt+QlkLZAX30Q8BEfgCbQp5w1YgWacMVpWTN/Rey/KF58EDA8gyZuOFiq+bSG82lDnpSlV5rKGdMy/yVhzhvkbWc0aOZPzRsya0nOoVCrihfbHiNBPYCYIBZF+cHzuc9kNhEJxGQSR33E6GjQNdepEBacf987XB6iwKBDoNoTpck2lxPehXnnURBUVoVpVoD9bq/8kgbpgQiJOvUWRd1zxyKfG4azP2SMl7a27Q1gYw+OROQiee0ci+3htQhvM6OnlJJT3iGLedn2sFOQbuI7n/mc/FriP6BlZX1XBlxW5bDG2kY5AoZ4PFikxJho/6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+W0nJYkWMBGIQOpk8qWFt7tnI6CZkkLsJmWJYTt0iy8=; b=R+P5bADZaAj/ybdlJuHCx7fd0c7YDs+U2ORcBT1euXJkP2uMisMlOSVjBVl9AWuJ2vAK6rNlIef+UJnLg1g8S9kvpasF0XtO+ikWuCvaHu5mtNgTqXMyV/cAHSYF3r+OF8G3SwY3ucUQvYNLYdUYLRNPQaxI5gnUXV9nc/HpPLezAommfzr+qYEdakDk/ajOQockM94doYJ1/UYlNV5hlCLEbJp2JiiaEGn2ioH4mdXlIxMQwoWXwoZ1oThtvfAegO2Hi4HPYGr+9UqPxN/lGDr+NF1CLrWecsys6+aSpl2otax/i1ppH1MgtoGnOcJxOVq2e5TnHx+0oY3Lscn62Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+W0nJYkWMBGIQOpk8qWFt7tnI6CZkkLsJmWJYTt0iy8=; b=gW7MWNaf4P0tHmYoGttSJcrBFWp2EcFxzGVf6M7erZjk3u+ts6dvZ3ryOlYGED5uazkEIeMBHwSG9k/Ff/cN1nwRHee87GIFtsgPEDm8A540NY/Nh6QbfirGYu/wn8BYQlNqfwknfZXuE5QdsqV8pD9iSPlZx5XotKtsUo5IvPSvtZSLrN/rz1eRSlfQJ5aogKHl9MAsFA023yQKu3nTJNyDOpEnyvDlnmUWMUaD0r/ZAmVojY5H5G/SwJuu4CIoHytBJR2Pfsbn3bAOOD09pl/vQwsG2pIMRxcRL4FoFzfES55QC5e9cgnGOaAw+NEhDwx3sKDIMQqcHqfLhypjjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB6674.namprd12.prod.outlook.com (2603:10b6:510:1c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 06:29:57 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9587.016; Thu, 12 Feb 2026 06:29:57 +0000 From: Eliot Courtney Date: Thu, 12 Feb 2026 15:28:08 +0900 Subject: [PATCH 6/7] gpu: nova-core: gsp: support large RPCs via continuation record Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-cmdq-continuation-v1-6-73079ded55e6@nvidia.com> References: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TYWP286CA0015.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:178::13) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: 0690cbe0-284d-4810-de28-08de6a002413 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dUpmUnJidGgwM1pSVCtkUmhhczlKMGRBc1dJK2NGZDRUalp0WnlhQlA5QnMr?= =?utf-8?B?RzBTdTNlKzQ3TmNnSzFKTllrZlBKcHFMK0pCQmgwUjZYOVdSaVE1eXdvazZI?= =?utf-8?B?cGw5Sy9BMFNZallEeVcwNXFmTzVmdjZXQVBPUktPOVk5Q0dvVnBqYzFXZnhZ?= =?utf-8?B?V1gyUk1ZRGtoZzZPeVRqTXdVM3VyMllUQVBNNzlmZUJHcmVIZVBOdlZTQnBG?= =?utf-8?B?M1dFd2pIelg1TDBaNVNucExzc0NFQlRmMy90WU9hV2hCYkpmVVBPMnlMZDUw?= =?utf-8?B?UmhqbE05RUpEclRvOVZheGJJQldZN0RyUXZFVFBUZ05zSllZNVBSaTFlOUd4?= =?utf-8?B?aHBvWGo4WEdKL1kzdWM0YURWQ2N0cVQ3UEVaaUduVy9NdWl2Yjh5WmlzU1ZE?= =?utf-8?B?bUo3Qi9GN0dWVHNLZDNQN29IUzk3SFZpZWlLQ3BUUXR5SWprYTRlejFvTWV4?= =?utf-8?B?bFNBQ2tnRmxyQnIxdkZKSlFTZHEyK3lJYWdPSk0xNnQzUEphb3BMdlEzRXY5?= =?utf-8?B?a01RV0N0S3FFU2U3bWlzMnpXUlhIbytPZkVta2F3Y0JSa1RjNmNvSld1RmtN?= =?utf-8?B?MVlSN1FCTmdadTNKaGUwVWFlUlpYeHhMNmtRQU9ueUtFbUd3ZmZPOVhZU1NV?= =?utf-8?B?Qk9WWTgycUNuS01DV0VqblFZNklkNUlCSWdsYzV3QS9tN25JVGFZWVE5WVZt?= =?utf-8?B?TDVkK0tzbFllQmp6SkFUZmlDdlljL25MVmtKRnlUaUp1Z05GNTJvQngwdDF6?= =?utf-8?B?c2cvRzlNdTlvUzZDUll6emJCZFRqMDFJcnMzYXZVcnFoYUdRQlVIT2hZakgv?= =?utf-8?B?eEl5WFFRTk0zY29vT0pUdmg4NHhvQmdManpRVmJvWW9vUXo0SngyY1kwcldr?= =?utf-8?B?d0pWQ0F5aEE2MzJOSnlmNDRoYkRYV0M0L0tNclVSQnlRK1IvcmxyNUpaUjZp?= =?utf-8?B?eTVLak5zeSs5T0NvZzRFQTFhUUFaMWk0TkF2MFZpNXN6NE5oeng0UmdaMGtY?= =?utf-8?B?MHQ1VTdJZjVDQXBmRk5LN1JaVmxOd3d3bnJPVkkwUE1XQVJTVnRUMzJWVW1i?= =?utf-8?B?T0dpdkJoM3V5QlluMUxZK282QUdkbUQweGx5ajM5WlE5TnUzSDVUYnU0aGxJ?= =?utf-8?B?ZmtscUNraW1BVGc3R3NYNk5ONysydytwRUZ1aDJwWTZpQnA0S21VTHNESEtG?= =?utf-8?B?SGpJTGwrUnlsenRJMVpNTDRkaVZDUTY2MzZ2ZlBqQXV4bkpyT3BEbG01Ty9z?= =?utf-8?B?UzIxaTVQUG5Ib0dLL0c3bFBoTXlXdTNiSEY5OXVTdkd5NXd0Z3B4NGZXeC92?= =?utf-8?B?aldyTmNaZlB0OU4rOG9aa1B1WmhJd1poUEJ1QXMzb0pJNm0rYUZEbXR3L0Q5?= =?utf-8?B?SkpVSkluNG5LNHRNVE8vOTdjSmhRZFYxNVdwNE1MMForOGczWWpxMG1QcWJa?= =?utf-8?B?NHpEalJ4d0hYSkNsb0xLSVVxU3NLdHhBaE5IcmlIVXpoT2wxbTNRTFVqMnIx?= =?utf-8?B?dFBGbVI1UUE0aVlXazc0b3FJVWZTMlNyQmlIc2lCWnZIZEh0R21ocnFGVVJW?= =?utf-8?B?Q0NMLzR0WEZ5L1R4RVlyTUhlWmMyMy84UUxCRG5IZHB2NHh5YzhkTDlCandu?= =?utf-8?B?azFrazFaN0NETTNqRXE5UThZUmF4ZkxTbjRrYWNCQnZrUmluZi85Yk8yVXli?= =?utf-8?B?RW1xSmwwYVE4OEM5K0V0WHgwLzFlMTFOTXVJUU40QW9udnNQWkQ3dmhOWm4z?= =?utf-8?B?cUd6N0h2aWxaa1RKL1FTenNVMStBY29iQVpZeVdPM3E3RzdIMmMxOTRuRHFa?= =?utf-8?B?OUZNaTY5VXd1NFhaeTdDWVd4K05FQXppTWN6bndGK1ZmQnBhdkdIUmxSTys0?= =?utf-8?B?Qnc1RWxDNHQ5OEI4OWJmNDcwSWx5OVlmSzVOUzBUVklNOUtLNHhGTEVScnJ6?= =?utf-8?B?NU81dXZnWTFFeThmbVhMNUZXcjlZRnpjNXRvOWNpSHFtbFlhV1Q2ZTZkUDRU?= =?utf-8?B?b2cyeTdMTjlIcmxQalpUZG1MMnpmNVdMcWJiZEwwd1hlK1VYQXdIRjBCNjE4?= =?utf-8?B?M0JOVUlJbnQ0M05NMW8wTmpndFpQZStyZkxJWDFWTWRHMXZCcm04c2NiSDR4?= =?utf-8?Q?Kga8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QjhJOUlkRXltTlJQcTFTVUtDdXZDZTdFM1IzZ3dsaUpiNmEwaVJtcGtBT3FH?= =?utf-8?B?a0tJY1JrUFZFZEpuSnl0ZG5IZG5KeVhSNnFheDlOWlIxbDMzSjMwVFM5MytM?= =?utf-8?B?VGtBYy9KWHl0ZFZ6a0d1RUpVOE5QdGxwLzRjRnhMMUEvblk1RHFjUGVKRU9O?= =?utf-8?B?dnBzQUdnaHRtV2JIRE43cnV2TExYemd0cGFmQTY5bEtISUtPcUlmQ01sK091?= =?utf-8?B?cHVQVjd6NkF2Q2M2ejFPUXhCeFcyVFRWb3J3eW42dXFSRWVhZGlGeUk3eGZj?= =?utf-8?B?SDFsbHJXRW1JZWsyK1RDTmllV2FJdnJIL0lVQUQ4UlhFVk5ROFV0eWR6Zm1r?= =?utf-8?B?RFdwZ3RJcVJYNVYxNHVnaTBIcnpoY0FrWjFIaC93MGM3UmtUN2taMFU2SUk2?= =?utf-8?B?VGNPOWEvK0FaZTRNK1ZUazhZSzg3NmwxbTRUNXNwYTZqT3RUUm11eVhCd0lG?= =?utf-8?B?ME5SWk9CMjhHdmd5eGJFL2ZudmU0SEtSODRFcWpaaDF5bGJiR01FZlk3aUVq?= =?utf-8?B?d1V6aTdQakg1YjlGSVFUejUzK1I2YS9vVkp5czlyRDFaWWZHclZxTGhmb1FT?= =?utf-8?B?cTlzUXZuOXNLTmxYck1hc09oUWdzSWF4Y3VOQ0p1K2NtQy9sZE5wOWJSWUhh?= =?utf-8?B?M3NZVzFPUERjL1JMWlc0dTlMeVVrNEpTVDEyUC93Q3NrYXhveXRkTXh3cUhx?= =?utf-8?B?cGVDd2QxWlNLdnlJSkl2eFZIOEhpZHh2UUc3N1dnR1ErQUpsazJrLzQyeXA3?= =?utf-8?B?M1VSQkFkUXVTcjFWak9VSkFSdk1sdTJBWWpJMnd6R2VmNkxtQnRHZHJMM1FI?= =?utf-8?B?KzV0WGxmMFBUamtFM08vZjQwdm9LVlp1UWRjN3paZFlURXJ0MlpackNRSDJx?= =?utf-8?B?a2lTQkhPRW9XcG51eXFNRXlObFF6TElzQzA1ZmUvakhscmdlR2xaRUF6MVQz?= =?utf-8?B?Q1VOaHd6RmVsMm05YTdObnlZemowY2FMWS9Gc0IxZnJLRnlHcWg0NzJmTVFJ?= =?utf-8?B?Z004YnIvOGQxL2sxM3VnL2duaDI2SDhUZmZ2cHJwRFBQVFEzQVpqemRyS2RV?= =?utf-8?B?TGlGUkQ1Mk1EUVZxMkg0Qzg5L3ZTamdSbTJpR3lxeTFFaXF1RzlPNnM5VVRK?= =?utf-8?B?UUxSWFZuT2JJZ0xvWTRtcTZIdlJITVE0SDFBZ1Vpa3FWRWYyTGFOUi9oT254?= =?utf-8?B?dS8zTTk3OWZEYmw3ekJFbVliYUZXZUlrTTJSeVNkT1htbVcvdCtsb0JLQUZ2?= =?utf-8?B?ZFZsSnpBQVhsblFEaGplYlFRVElHMVVVaFhEa0xyMXdGbEJUT0pCenptZ1dY?= =?utf-8?B?OTkwSVhJWUJZSjNQODNHUHM2NlNJTTdDbnc3TmIySHhPMHcycnBmemtTTGtv?= =?utf-8?B?L1ErY0x0dXl5dEZ1dGlIN2VFKzVIbk9EVFpMSFQzcDkyYVJhamJXeWNRaXpO?= =?utf-8?B?Y1RJM3ZkN3R6VytCbXhkcjVOQ0ZSTG9jTk1zdHVlWjlXbHpjNzRuVmZhOHZ0?= =?utf-8?B?clBtRHRSS29IYU54OU5TYXQ5QXB6dGlDVzN2U20vaDN6SHF0NXY3a3NQQ3dn?= =?utf-8?B?U3lBT1ptUGxOdEREMmRLNTg3KzA5MjlNVzd6YnpUeG1GUHpMM2E4SGpWK1A0?= =?utf-8?B?Y2pxV1FoV2w3N2ROUUY3b3hwbEN0bE1XVTlhc3Z4RXRrNGk5UEJvT0Q0QXJ4?= =?utf-8?B?RVgyUlUxdmhXWHE2aSszdUZhS21uZzM1V1Q5Z0s5MndkbDlINUd5UTVVaEJB?= =?utf-8?B?T1k4Q1JFdzVNQWpGRXVuOGU0RDlMZXZ0R29SaTE0ZWpSSUtqM2VuN0EvblM0?= =?utf-8?B?SExYZktuc3J4RnNTcGFEeVRxRXhGczU5SDdIcUlFQUNiNldxNjVwVytLMjVR?= =?utf-8?B?OUFxRHlpK3pYaHA5bFhpYjQva040M2xrUXJwNmlWeTN4b01sQlFVMlBCMmE5?= =?utf-8?B?ZzNXQ0pkcVNLdlhVc0NKS1JUYXZnRzRMZEhEaW80MjhVVjVycXBaY2RRNmhK?= =?utf-8?B?YWRBTVlsSkZlUXZCRkt5OXc2R08zdmx0SU4zVWpaZ21KT3U1cTVSRWV4cE5Z?= =?utf-8?B?RlFPTEhubzN3OVVMSDV6TW1EZGUyR053WVJmSm44WGpROU1hclI1QkhsWHhB?= =?utf-8?B?Yi9ZT25WekRFYjRvemhwYWZmYnNZWCtUMklOSkhGM1d1WG5ZekJYYkVTSTNi?= =?utf-8?B?d2tiRzl5WnRRVWRJZGlyTUQ1U2Zvd2RGQ3lhRmIwSGtOZnQ2SFVEd3VzTHc1?= =?utf-8?B?MTdGbW9QME1leUJuOU45endoaDcwZTV6Q3JsTDNTdDFuaDNIMzJacURHWTN5?= =?utf-8?B?eUdYY0hWNlZTSDEvVXM5Q3BiYjF3SXpBYWJqN3hFbmNxcng1NTVBdWhvTEQr?= =?utf-8?Q?g+aPsmWJ47VNBOJkDVsVBjYoy8kQSa4rt4tUkoSTKFO9A?= X-MS-Exchange-AntiSpam-MessageData-1: 7J7CLteIB+560w== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0690cbe0-284d-4810-de28-08de6a002413 X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 06:29:57.1930 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hRpxfo6gwhIIvj9/11ugcSSMMhEiE7tUsS/2VkNtBigZ/YIBB6rgcxuluzA59iOsf0CFAnKO0i+9gnu3vM5BjA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6674 Splits large RPCs if necessary and sends the remaining parts using continuation records. RPCs that do not need continuation records continue to write directly into the command buffer. Ones that do write into a staging buffer first, so there is one copy. Continuation record for receive is not necessary to support at the moment because those replies do not need to be read and are currently drained by retrying `receive_msg` on ERANGE. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/cmdq.rs | 47 ++++++++++++- drivers/gpu/nova-core/gsp/commands.rs | 124 ++++++++++++++++++++++++++++++= ++++ drivers/gpu/nova-core/gsp/fw.rs | 5 ++ 3 files changed, 173 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/nova-core/gsp/cmdq.rs b/drivers/gpu/nova-core/gsp/= cmdq.rs index 3e9f88eec7cc..c24d813fc587 100644 --- a/drivers/gpu/nova-core/gsp/cmdq.rs +++ b/drivers/gpu/nova-core/gsp/cmdq.rs @@ -29,6 +29,10 @@ use crate::{ driver::Bar0, gsp::{ + commands::{ + ContinuationRecord, + WrappingCommand, // + }, fw::{ GspMsgElement, MsgFunction, @@ -524,7 +528,7 @@ fn command_size(command: &M) -> usize size_of::() + command.variable_payload_len() } =20 - /// Sends `command` to the GSP. + /// Sends `command` to the GSP, without splitting it. /// /// # Errors /// @@ -533,13 +537,13 @@ fn command_size(command: &M) -> usize /// written to by its [`CommandToGsp::init_variable_payload`] method. /// /// Error codes returned by the command initializers are propagated as= -is. - pub(crate) fn send_command(&mut self, bar: &Bar0, command: M) -> Re= sult + fn send_single_command(&mut self, bar: &Bar0, command: &M) -> Result where M: CommandToGsp, // This allows all error types, including `Infallible`, to be used= for `M::InitError`. Error: From, { - let command_size =3D Self::command_size(&command); + let command_size =3D Self::command_size(command); let dst =3D self.gsp_mem.allocate_command_with_timeout(command_siz= e)?; =20 // Extract area for the command itself. The GSP message header and= the command header @@ -590,6 +594,43 @@ pub(crate) fn send_command(&mut self, bar: &Bar0, c= ommand: M) -> Result Ok(()) } =20 + fn send_continuation_record(&mut self, bar: &Bar0, cont: &Continuation= Record<'_>) -> Result { + self.send_single_command(bar, cont) + } + + /// Sends `command` to the GSP. + /// + /// The command may be split into multiple messages if it is large. + /// + /// # Errors + /// + /// - `ETIMEDOUT` if space does not become available within the timeou= t. + /// - `EIO` if the variable payload requested by the command has not b= een entirely + /// written to by its [`CommandToGsp::init_variable_payload`] method. + /// + /// Error codes returned by the command initializers are propagated as= -is. + pub(crate) fn send_command(&mut self, bar: &Bar0, command: M) -> Re= sult + where + M: CommandToGsp, + Error: From, + { + let msg_max_size =3D MSGQ_MSG_SIZE_MAX - size_of::(= ); + let mut wrapped =3D WrappingCommand::new(command, msg_max_size)?; + + self.send_single_command(bar, &wrapped)?; + + while let Some(continuation) =3D wrapped.next_continuation_record(= ) { + dev_dbg!( + &self.dev, + "GSP RPC: send continuation: size=3D0x{:x}\n", + Self::command_size(&continuation), + ); + self.send_continuation_record(bar, &continuation)?; + } + + Ok(()) + } + /// Wait for a message to become available on the message queue. /// /// This works purely at the transport layer and does not interpret or= validate the message diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index c8430a076269..99603880d56f 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -242,3 +242,127 @@ pub(crate) fn get_gsp_info(cmdq: &mut Cmdq, bar: &Bar= 0) -> Result { + data: &'a [u8], +} + +impl<'a> ContinuationRecord<'a> { + /// Creates a new `ContinuationRecord` command with the given data. + pub(crate) fn new(data: &'a [u8]) -> Self { + Self { data } + } +} + +impl<'a> CommandToGsp for ContinuationRecord<'a> { + const FUNCTION: MsgFunction =3D MsgFunction::ContinuationRecord; + type Command =3D Empty; + type InitError =3D Infallible; + + fn init(&self) -> impl Init { + Empty::init_zeroed() + } + + fn variable_payload_len(&self) -> usize { + self.data.len() + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + dst.write_all(self.data) + } +} + +/// Wrapper that splits a command across continuation records if needed. +pub(crate) struct WrappingCommand { + inner: C, + offset: usize, + max_size: usize, + staging: KVVec, +} + +impl WrappingCommand +where + Error: From, +{ + /// Creates a new `WrappingCommand` that wraps `inner`, splitting it i= nto + /// multiple messages if its size exceeds `max_size`. + pub(crate) fn new(inner: C, max_size: usize) -> Result { + let payload_len =3D inner.variable_payload_len(); + let command_size =3D size_of::() + payload_len; + let (offset, staging) =3D if command_size > max_size { + let mut staging =3D KVVec::::from_elem(0u8, payload_len, G= FP_KERNEL)?; + let mut sbuffer =3D SBufferIter::new_writer([staging.as_mut_sl= ice(), &mut []]); + inner.init_variable_payload(&mut sbuffer)?; + if !sbuffer.is_empty() { + return Err(EIO); + } + drop(sbuffer); + + (max_size - size_of::(), staging) + } else { + (0, KVVec::new()) + }; + Ok(Self { + inner, + offset, + max_size, + staging, + }) + } + + pub(crate) fn next_continuation_record(&mut self) -> Option> { + let remaining =3D self.staging.len() - self.offset; + if remaining > 0 { + let chunk_size =3D remaining.min(self.max_size); + let record =3D ContinuationRecord::new( + &self.staging.as_slice()[self.offset..(self.offset + chunk= _size)], + ); + self.offset +=3D chunk_size; + Some(record) + } else { + None + } + } +} + +impl CommandToGsp for WrappingCommand { + const FUNCTION: MsgFunction =3D C::FUNCTION; + type Command =3D C::Command; + type InitError =3D C::InitError; + + fn init(&self) -> impl Init { + self.inner.init() + } + + fn variable_payload_len(&self) -> usize { + self.inner + .variable_payload_len() + .min(self.max_size - size_of::()) + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + if self.staging.is_empty() { + self.inner.init_variable_payload(dst) + } else { + dst.write_all(&self.staging.as_slice()[..self.variable_payload= _len()]) + } + } +} diff --git a/drivers/gpu/nova-core/gsp/fw.rs b/drivers/gpu/nova-core/gsp/fw= .rs index 5b96f5e622a4..5ceb070aa0d7 100644 --- a/drivers/gpu/nova-core/gsp/fw.rs +++ b/drivers/gpu/nova-core/gsp/fw.rs @@ -199,6 +199,7 @@ pub(crate) enum MsgFunction { AllocObject =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT, AllocRoot =3D bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT, BindCtxDma =3D bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA, + ContinuationRecord =3D bindings::NV_VGPU_MSG_FUNCTION_CONTINUATION_REC= ORD, Free =3D bindings::NV_VGPU_MSG_FUNCTION_FREE, GetGspStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INF= O, GetStaticInfo =3D bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO, @@ -234,6 +235,7 @@ fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Resul= t { MsgFunction::AllocObject =3D> write!(f, "ALLOC_OBJECT"), MsgFunction::AllocRoot =3D> write!(f, "ALLOC_ROOT"), MsgFunction::BindCtxDma =3D> write!(f, "BIND_CTX_DMA"), + MsgFunction::ContinuationRecord =3D> write!(f, "CONTINUATION_R= ECORD"), MsgFunction::Free =3D> write!(f, "FREE"), MsgFunction::GetGspStaticInfo =3D> write!(f, "GET_GSP_STATIC_I= NFO"), MsgFunction::GetStaticInfo =3D> write!(f, "GET_STATIC_INFO"), @@ -273,6 +275,9 @@ fn try_from(value: u32) -> Result { bindings::NV_VGPU_MSG_FUNCTION_ALLOC_OBJECT =3D> Ok(MsgFunctio= n::AllocObject), bindings::NV_VGPU_MSG_FUNCTION_ALLOC_ROOT =3D> Ok(MsgFunction:= :AllocRoot), bindings::NV_VGPU_MSG_FUNCTION_BIND_CTX_DMA =3D> Ok(MsgFunctio= n::BindCtxDma), + bindings::NV_VGPU_MSG_FUNCTION_CONTINUATION_RECORD =3D> { + Ok(MsgFunction::ContinuationRecord) + } bindings::NV_VGPU_MSG_FUNCTION_FREE =3D> Ok(MsgFunction::Free), bindings::NV_VGPU_MSG_FUNCTION_GET_GSP_STATIC_INFO =3D> Ok(Msg= Function::GetGspStaticInfo), bindings::NV_VGPU_MSG_FUNCTION_GET_STATIC_INFO =3D> Ok(MsgFunc= tion::GetStaticInfo), --=20 2.53.0 From nobody Sat Apr 18 01:57:38 2026 Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012059.outbound.protection.outlook.com [40.107.200.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EEBC1FCF41 for ; Thu, 12 Feb 2026 06:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.200.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877805; cv=fail; b=qhPnbdq9jOznvflKqhlkMhO5tF4YkP4m7xroUlBmUCnBym6kIao/F9+ccFfKjKCAfBaWrZoAqObRa8LtbAxpAG4SB6DFd3+8FUXtaRkm1oxz6sY7a7scBJ3xyvShLx+ecJwZFHMRs3kx1k1pnY7hc5kvwpYlhlw1GySGQq+0SuA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770877805; c=relaxed/simple; bh=yT3TY+MmaByp5bMZWq5sUeUdFCrsv0+SIArKBgsCY+c=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=sgSyo3j0BQOsSfUQyYx77XPGwWBgDeappsnpeL43OF39p8UwIubWJcCUnIbaoJ75KDh/Rt5wUPRbrF2WG+lxLVfYUt8ixfT2Ho0I6VALXjGvsBPvSeTEMEhN70u5QR9p3urIEd4F09xKie+82nl0qtHbp/zCLOajdPwd6VqUwwA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=KnaagRWg; arc=fail smtp.client-ip=40.107.200.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="KnaagRWg" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hQ4WqZQZala/MY+Sf4yLRvICRt1iGfh9d7SqLGZVWgqLAnD387s3uNjHPapFowi9xQn0vqHbsG/wWeaga2nJ0c7qjid5zMAuk/SiMu+re6haEUC6WTIzFWWk4ox7Leq2kRfkSfAfWesed8XwYmBlY+kYbN4zzxPHWa47WYWXbC4xmwFjLa3oST5oODeYpUlrRRytZjGBQvZQ+980JJO2kBi5IbzcS9uVN2By7kMFLXKQWq1Q8qutIurQtNFGeYW8f4udV5K2ekBc6twFloEpqsHnPGDnAuFbjCMNVJWPH1beV0TRJbP5bw+g1jl42SkRyRNFe0i0oCHu+1pycd/a7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tqjBOaqlx4goueRCMnfXo+xPHM5piYh5UXVaRXOKQU8=; b=vEJqwMwygGPExjyr3pkX0f4LAR6P8qBgGuDtuv5AJUjC49eBgxLbsI51EG5DqAdaCJmd2K+7mAi/g7in9iSJ1xomLlJXJtkk+grCbY3Pi/VuLFdibMHFziaSmd7X73sGh6iUZyu4tZ3u3SyZtsm9c3UdQocI9OUIYLzRFwPwvdhXAc0BB/w0b+ujRjZ0bvuVu715y6LVDWXfiYN1+F0be6UZ7kkKWE+/ZIOWB8L3Kr6/U3ob1X0ePNO8zjYORS4hfbVxxMEdIeTtyaWu8G1CU47A22lZCbBeEcfJeaqTcFLelfqXCbRLFv/bC/VoEoD68id+DsZDkpfhkNjHqfqqQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tqjBOaqlx4goueRCMnfXo+xPHM5piYh5UXVaRXOKQU8=; b=KnaagRWg4iXErkZ7GeMsQDA4K1sYxwWxgNBbsi2Yw2oDeAbXNVNrY1BcEftT2jfvDdnrtVIL7hLuZhzWHja6dYmK6THmBGH6mGeNG5WNjtHK166DK8kdeOZNH7jTiQPpVGJ5bUjlHUhitte22MQXwuYnhauazPaj3ZiEcuOXo/fqaqSZTDdlbsW+aNDkWfwj6aKUpKc6YsK7fETcRFzN/RpDuRJZ9OmTSg06rlBoO1Gj8+mvcHkOsbz10Sqm6cccsJcHyAzXJoo3pNHtgAdnYh5DX1C8+nuKVeL+F5z3vN2FcpAH7ONaPEYxNPmoTgf0S+JJqg0TL5vtbCaCFaTxGQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) by PH8PR12MB6674.namprd12.prod.outlook.com (2603:10b6:510:1c1::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.10; Thu, 12 Feb 2026 06:30:00 +0000 Received: from BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0]) by BL0PR12MB2353.namprd12.prod.outlook.com ([fe80::99b:dcff:8d6d:78e0%4]) with mapi id 15.20.9587.016; Thu, 12 Feb 2026 06:30:00 +0000 From: Eliot Courtney Date: Thu, 12 Feb 2026 15:28:09 +0900 Subject: [PATCH 7/7] gpu: nova-core: gsp: add tests for WrappingCommand Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260212-cmdq-continuation-v1-7-73079ded55e6@nvidia.com> References: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> In-Reply-To: <20260212-cmdq-continuation-v1-0-73079ded55e6@nvidia.com> To: Danilo Krummrich , Alice Ryhl , Alexandre Courbot , David Airlie , Simona Vetter Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Eliot Courtney X-Mailer: b4 0.14.3 X-ClientProxiedBy: TY4PR01CA0042.jpnprd01.prod.outlook.com (2603:1096:405:2bd::7) To BL0PR12MB2353.namprd12.prod.outlook.com (2603:10b6:207:4c::31) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL0PR12MB2353:EE_|PH8PR12MB6674:EE_ X-MS-Office365-Filtering-Correlation-Id: ffecd04e-b038-4d7b-2e27-08de6a00263a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|10070799003|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TkxGZXZQcThYSytPaitJUFdvNkVHdFFMMGpzWnhobkIzTGY3NVFoaE9kK2Rp?= =?utf-8?B?NlE3T1d5cUh5VnFQb3FzWlEvMGJMR3o3MnJuRklTaGpDTDhKdksxN0ZBbXcy?= =?utf-8?B?OGhEeWYyQ05hS0V6V2NJekdtdEJTTFBjSCtNb25JcUlrTUl6Ti9TSVFzbTVq?= =?utf-8?B?NnlDcnVSNWpia1IyQ1VVMkhYYi9WcFN0YkpjMlpRMHlPUTlFZXhKYVJ6UWJr?= =?utf-8?B?RWdvWUUrTlJ1OW4rblJOekkwWHVaei9CYW4xNHFTK1pmb0llbERTRHFzam1r?= =?utf-8?B?MEJiOW9LeUVYT05ZeUc1UGVNZSsrU1ZRU2xrTjI3dng1QzlyTVF6dUhacjlB?= =?utf-8?B?RUFzaWFOVmRJdXdGOE5WRE0yRXB3RzlpeDdXN211ME5ISFN4ZExoTHUvbXJq?= =?utf-8?B?Y0tZa21FVTkyM1Vmcm1EcGZuTTVFNmYyUWFPc2tJZnBxUDhzYzdEMFJRT3da?= =?utf-8?B?amFJaGt6YWJzVzlSUWZ5WitGdGhRdzdPdno2enl2akVCeGJxNjZVRDNJYWpj?= =?utf-8?B?NVBCNXlTUFVQOFNDUlhlYlZ3SnNjTkdBTk9MVEkrbjU4NkgxTGtjKzl2TGxF?= =?utf-8?B?TWVjbjVuTTE4ZjNXdlEzTWFsMzhyWHBKK0xzRnp0cVhDZDdLNUtEcjJqakxu?= =?utf-8?B?SmxKWTdidGFyNWJhdG5qMXF1WHEwMjhzVWV0WER6VmNTM3U5NzVQZUVoRHE5?= =?utf-8?B?YUFYMitjOUxMVTJLcVozWXY0VndnOTNDU1RENWlBVlZ1T2RSRm1tNjdDZmFT?= =?utf-8?B?YjJ1VGdJa1Z4Y0dvckVZVEI2bFRoYWV4bDBBNGxsUlpSajF5UlBMR2Zid3JB?= =?utf-8?B?eTZQM3dLek05dXFQdDJYMkFVRVhuNnEyelJvK0xrY09HWGhVVlhPN1V3QjF6?= =?utf-8?B?L0k5SW55YVlUdTRsQnVESTNWcGZmV0dZNXljcnc1L0E4amdoNlMwK1NpVGY0?= =?utf-8?B?NlR1anU1K1RPM0FYNWQ2MUZpZm9XQjJZakRiUTk1Wmx4MFh0WGxmWkNmYjdU?= =?utf-8?B?YUJON0lWeDdHVWVNM1pvMENXQU1uTUFrZk1WbkpvaFRSYVhOMFFNblQyN0xZ?= =?utf-8?B?TWlkTDMvcjVxY0Q5d0NXYmc1MXJVcEVtU0Mwc013alNCd2doT3B0R2FuMnY5?= =?utf-8?B?RVg0UkhVZ3lXOWhtZjIzV2diWWVwZXdKdXRIclQ4SnloeVFEYTRuell0clU4?= =?utf-8?B?L0VTWnRxN2VxWGRibS9SMVN5ME16ZThBYktwVFdCVU03Q1BmK0Vid3pCNFlS?= =?utf-8?B?L1pORDdmQnF6bnpYVFFLUloyRXgzTm9JNnZuK2ZrSzY4S3U1NXFWcitEVkVJ?= =?utf-8?B?RitlSDVRUURXdlJNZTJDL29mMWRmKzVCQmlTNWVpOHRvQ2FnWXQ5UVlCTUMw?= =?utf-8?B?OUxTTXRjS3pYUVN4Y3ZFZXNVKytXcHpBTmxEZ0pIc2tZdXZjbm0rMmNaQnp3?= =?utf-8?B?d0pqRlYrT3M5ZHZlRFJDMkZiU283OEd5R28vQUR6WGFxVzlSbm9oSGFqMjJs?= =?utf-8?B?VjhoQWJ4UWpjNVV3VitRMmRRVEtOYncrNHFPWmlzQ1ZhbFBTQllQNml0WklQ?= =?utf-8?B?STZyYmgyeDNQbmVYS0pkM2U1YjMrOTV6Yzl6ZThtSGh6YUVGT3BCWXVUOFB3?= =?utf-8?B?WFBTSGxMWXVnNVVCVW5pN3NBUkp6SEtMeGZrZ2lZSkVGckNBVEFmeEZyUFVW?= =?utf-8?B?QzJUVHc4NDR5dVBudmdWdkJZRWJoOVF1WkRvandDQzFjS21ydHAxdTV1U3J5?= =?utf-8?B?UDM5KzVaVkVPK0hzd3c0NTlSeGdQeXNzRGVFejdhN25IdG5lWnY4aUIxc1BO?= =?utf-8?B?S3RUUGFhNW8wWXdGU0xDZHhXdEEyT0hGenV3bldUZXJPVDYwSFRWNkxzbTJD?= =?utf-8?B?YjB5Z0Y1eldhUFcyR2VHa2RUNGdFeENjSEh5RDA5dGI1dVNEaFRuNGUrcXRF?= =?utf-8?B?UE9EK2JXUzRjRkp6S0hYQjcrOW9PNDZGcld3dnlUelpnVG00MWk5akxCMWFv?= =?utf-8?B?OGNGUTY0SktwemI5TTZaY2RkM29QSS9NR2Y1MlhncEZwMldSbm5XZzg0bDZR?= =?utf-8?B?aExMMnErcGFjNEozUWhtOEhMek1maGo5ZFZsRjZvYUc2NmVYRi9zckk5U2xU?= =?utf-8?Q?tsno=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB2353.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(10070799003)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXZVc1NERGlhbWo3dEJ6ZTh6YlVMOUNuV2ljRVZqcFpPZzFvR3QzZVQxVmxw?= =?utf-8?B?RjhMV0E0V0VsMkZhWDA4ZXZuQUJCOTIrL3pUa05DZFdqZ0JhVG9sMDZwcU13?= =?utf-8?B?dXFuSGNGSWhTaVpVaTFZVWoxNkNHV2JQd2hUYm56R21pQ0VhaWNOL2I4OFBH?= =?utf-8?B?QXlNcmJETjM4alpLNzZaMjRBNTRIaUUwOE9EbkJGUlRPTkU3YVAvd1FEVGtt?= =?utf-8?B?R1RQRFl0VnpHb2xBeHFVZDRTN21Ha0J2bzQrQmw1QnhNdVpWc3dQWnRETGdK?= =?utf-8?B?c3Q3elRTUDdXYWRsY1dTV1JoY05GUndJZ1ZUMWh1bHZUU1kwblk4M1JMYVN6?= =?utf-8?B?dkhGeERJcHk1STBFRmFSMk1wVlcxZE5QNzJWS1JPSXljdldrUzJneDNDdVlC?= =?utf-8?B?aGhqaXVMcmI1TGZrOW1WZ296SGNDblVyWkliQUhCM1ZUM3p2UTRRaENocjZF?= =?utf-8?B?aGxqTUI3TTVhYzlNeHFBQXZsVHZKT2trSCtFVmNsU08vOU5US0lGbGRxck0y?= =?utf-8?B?RVFORnFPby8ramFNdzlpMXNramdyNjYxNWxQcU8vWGVDVjZFYkxuVlNpenoy?= =?utf-8?B?T1pySWhwWWVYSjRtMDV2Z2JWQTcvb2JHSUhDZkFSY3JwSjJCTXlaTkZDaUFB?= =?utf-8?B?Y0VJUi8zOGNTZ0hMSzNKcFdRbUNOWVFSTjZneXZMNG9tVmk1WEVBbUhDNEdI?= =?utf-8?B?Q2pTa3BMcVRlZExVY2dHMHArL1F0dHFFYW1BU0RPNTc1dWp1TFM2ZFRrTCtE?= =?utf-8?B?VnY3Ukp6K2JJazh4S3BJZkp5QVBZZno4Zm9ZQkJFbWZUcUxoL2FuWnMwbC81?= =?utf-8?B?aEV2K0ZWUjNyRGo3TnRIM2hwMUNtMjNrdVZLZHBYT1lUR0xPdFlTcnJIQXJh?= =?utf-8?B?eVV2QUw3OEpJaEJySytRcU9iN2lXQmQ5RHRpbXdpQ0lRL3Y0ZER2NFp3cUZ0?= =?utf-8?B?MkhWRWRvQWlDWUxZUzYwWVlNTGtibG5LYVdDenBSRUxIMFBoZkViR0lFNFJm?= =?utf-8?B?dy9IQkYwRi9YeG40dmZEblNXaGhld0pjenpDUTlVditWdmt3aFpPZElzaisz?= =?utf-8?B?M1BZZTlhNDJ5SlAxV1QwbkdVd1JPMEduSE5lZ3pDUVZFZXpSL1NHK3gxcmp5?= =?utf-8?B?Y1RuY0NOREs1d00vdUJSeEc4WTF0RU9PRFpKVCtNV1RHbEdDVGhHZHQ4emRO?= =?utf-8?B?R1FINWZzLzBYK3daK0JobGVIK0lDVUdqN01EdWFTL2x1ZllaRXVHUlRaVTNR?= =?utf-8?B?cnVjZ3QweHJUdzZhMUVNMUZCSHVHZHpjWHRDdTZJWjFzYjVBdXdQY2pCTmsx?= =?utf-8?B?VVVnVkZqOWl3OGxMSU96bm13OHBQT0h4UHp3anlWemtxMDZYam1iK2J4aWRK?= =?utf-8?B?Z2tVOFBLMTRXWmtwcUV6eTdMb2hFZU8waGN0MXBzM3JhZFBjZU1ONC8xdUtm?= =?utf-8?B?ZTFRTzRYRkFERGh1bzJOdmQyb2MzK2JWOE1GNnFDSnRMQkhzTHM0cHBoZkJs?= =?utf-8?B?SEJkVitqWVVSNFJ3MjU1c1A2S1VTRE8zRlNuelpwQjY0bWh0Q3k2VDFaUG9S?= =?utf-8?B?TzJjUFN0T0c5YTU1RDFEM1RmYWpudHJQM1VxYzVTK2RJaFI5WEY1djUzOG5w?= =?utf-8?B?Zy84bWc3YXJsbjlhRVFVbE4rc01YNy94NjkzM1doTFJPVC9qcGd0Rit2T1hj?= =?utf-8?B?QkFWTkZiL3VvblpqSjVqZnV4T3Qrdk9Dazhtb3FOd2JVaGNMaFRHbjZLcVJR?= =?utf-8?B?djJDcnZhSkVGTHEvU1J2dUZtTFl3Rms0YnZtOFo5Uytobkthd2o1engxVGRq?= =?utf-8?B?a3M1WWdkRnI3L3MrZVdTL2p5TEp4NGFFcGZpck93TWVaTVRqdW5EbnBpODI4?= =?utf-8?B?cHpFQjBkanJ0cUh4a0tFcmJuUm9xVDJiS3ZuZ2JFdzlEZHdxeFFpSHZYSUVV?= =?utf-8?B?eXRsQm1vOUtXVFRndjBNWksxMDU0aXBlbFNKbjdmemtMSFpVM2NFN3JxTWN6?= =?utf-8?B?QVdyeW41ajJmcUs4U1JFeHhxbGdWdEpRemVTNGREYU5wTW5CTDFBMWRNaytM?= =?utf-8?B?QmQ5b05RTlJGMlRLQXRKUFB4Mk11UUZHbE83VHVpclJEeno3RE5KOWpDRlBq?= =?utf-8?B?QzB3L3NsUmsyQ3lHTkszWGNrOG82T2dqdjgvbFpGVnpQZXZDNGRpcDJYMTNt?= =?utf-8?B?enFrSndSSzgyMnBsV0JrcHlzTnRWcWcxRnJUd0UzemEwVjVHd2pmdXhZc3Ux?= =?utf-8?B?VnNKVXBQRW9POEpGWVF4b2NUb0J2cmtIK3FkTE41cVpXZ2Q0aDFodXp2VnNJ?= =?utf-8?B?MVJPcmxyVm02cWo1a1FMWGk2L04rSkt4cFBLZGNlSXd2QzVzZFhLaDFnYWFR?= =?utf-8?Q?3YwVkM2MdiKPHN5DFsNe5RBZ/D2ntonJeHFMSjtsH2TiX?= X-MS-Exchange-AntiSpam-MessageData-1: qDsGnNnEte6N9w== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffecd04e-b038-4d7b-2e27-08de6a00263a X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB2353.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Feb 2026 06:30:00.7943 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O3Vh2sgFn5uN3clSf2W3R/Jr9wxq39+jTn8pkpKvq38n803BSxDEMgNYyAnG9OmbaL2taY6V2k/OfKSvlF5zLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6674 Add tests for WrappingCommand. They cover boundary conditions at the split points to make sure the right number of continuation records are made. They also check that the data concatenated is correct. Signed-off-by: Eliot Courtney --- drivers/gpu/nova-core/gsp/commands.rs | 123 ++++++++++++++++++++++++++++++= ++++ 1 file changed, 123 insertions(+) diff --git a/drivers/gpu/nova-core/gsp/commands.rs b/drivers/gpu/nova-core/= gsp/commands.rs index 99603880d56f..9a41c4a9d90d 100644 --- a/drivers/gpu/nova-core/gsp/commands.rs +++ b/drivers/gpu/nova-core/gsp/commands.rs @@ -366,3 +366,126 @@ fn init_variable_payload( } } } + +#[kunit_tests(nova_core_gsp_commands)] +mod tests { + use super::*; + + struct TestPayload { + data: KVVec, + } + + impl TestPayload { + fn generate_pattern(len: usize) -> Result> { + let mut data =3D KVVec::with_capacity(len, GFP_KERNEL)?; + for i in 0..len { + data.push(i as u8, GFP_KERNEL)?; + } + Ok(data) + } + + fn new(len: usize) -> Result { + Ok(Self { + data: Self::generate_pattern(len)?, + }) + } + } + + impl CommandToGsp for TestPayload { + const FUNCTION: MsgFunction =3D MsgFunction::Nop; + type Command =3D Empty; + type InitError =3D Infallible; + + fn init(&self) -> impl Init { + Empty::init_zeroed() + } + + fn variable_payload_len(&self) -> usize { + self.data.len() + } + + fn init_variable_payload( + &self, + dst: &mut SBufferIter>, + ) -> Result { + dst.write_all(self.data.as_slice()) + } + } + + fn read_payload(cmd: &impl CommandToGsp) -> Result> { + let len =3D cmd.variable_payload_len(); + let mut buf =3D KVVec::from_elem(0u8, len, GFP_KERNEL)?; + let mut sbuf =3D SBufferIter::new_writer([buf.as_mut_slice(), &mut= []]); + cmd.init_variable_payload(&mut sbuf)?; + drop(sbuf); + Ok(buf) + } + + struct WrappingCommandTest { + payload_size: usize, + max_size: usize, + num_continuations: usize, + } + + fn check_wrapping(t: WrappingCommandTest) -> Result { + let mut wrapped =3D WrappingCommand::new(TestPayload::new(t.payloa= d_size)?, t.max_size)?; + + let mut buf =3D read_payload(&wrapped)?; + assert!(buf.len() <=3D t.max_size); + + let mut num_continuations =3D 0; + while let Some(cont) =3D wrapped.next_continuation_record() { + let payload =3D read_payload(&cont)?; + assert!(payload.len() <=3D t.max_size); + buf.extend_from_slice(&payload, GFP_KERNEL)?; + num_continuations +=3D 1; + } + + assert_eq!(num_continuations, t.num_continuations); + assert_eq!( + buf.as_slice(), + TestPayload::generate_pattern(t.payload_size)?.as_slice() + ); + Ok(()) + } + + #[test] + fn wrapping_command() -> Result { + check_wrapping(WrappingCommandTest { + payload_size: 0, + max_size: 50, + num_continuations: 0, + })?; + check_wrapping(WrappingCommandTest { + payload_size: 50, + max_size: 50, + num_continuations: 0, + })?; + check_wrapping(WrappingCommandTest { + payload_size: 100, + max_size: 50, + num_continuations: 1, + })?; + check_wrapping(WrappingCommandTest { + payload_size: 101, + max_size: 100, + num_continuations: 1, + })?; + check_wrapping(WrappingCommandTest { + payload_size: 150, + max_size: 100, + num_continuations: 1, + })?; + check_wrapping(WrappingCommandTest { + payload_size: 300, + max_size: 100, + num_continuations: 2, + })?; + check_wrapping(WrappingCommandTest { + payload_size: 350, + max_size: 100, + num_continuations: 3, + })?; + Ok(()) + } +} --=20 2.53.0