From nobody Thu Apr 2 15:41:19 2026 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87017219EB for ; Wed, 11 Feb 2026 20:07:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770840434; cv=none; b=o+f41nG0iZhGJGu3vngDNJp32JhfhFEYv6Rqsi8zF/sh5fs8dMdvqKBreiNy50seEXK6mfWddrvB7OrBq2Vu7Qr4sRTRf4TICpI8DIpp+cd3u/6wSiYVa+U5QZFLpQ5VnGERJENPTaLvP4LxG0vV4Y3VwiDuipRGln7kkskqKTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770840434; c=relaxed/simple; bh=m0Cf8Rk7n7F9fguJZFZ6hxaAupWprBDgc6kM7bQibIA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dsqMVcH9e/mEEkpQZD0WF3qtRdGggus/O1yrdT4G5IuOoJ2rDKcsvzgkR2AC9jtpBhE/vxwiU7zpexjK+Sb2enmxole/qzx04Oto6eENom0j6Ma5bC6wTfmacdK5AN1zY6QhnS01IabM5vTsXqt1Z14l0eZR5ayWzKKcKAGuFNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dOlIzv9w; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dOlIzv9w" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-7950881727cso16709217b3.3 for ; Wed, 11 Feb 2026 12:07:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770840431; x=1771445231; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6jQM1mRtKYYKchUiL9MXlFhID/L6f3Klb5mRjr3nQkI=; b=dOlIzv9wyA0SGl8vk1mfpZOsMoec9m3mBkBzxtuvLSXlRLS2528hNggcZRglHXOq3L isN1MJIO9SRzk/qkSPX4Sp0D70IuW78b2OuvZsG5quirJbGUZV571inEZaXkZ+YOOQmA F6x4PoU2NCt9ETGdfHjqQX9uFjzrUY3SnjWG+sMvne58fP1/TUcEXR4Gmq9yAx3+RBx1 RR10E5Nj+FiZhhOkJR29A0orlKj4PReJzR+nCGeKM9vckU5brdXR2qNpgYAsEqYAUsg7 Cos37VtHo8zhe5Y5AsDTEKQYZa8HM/NoHUoqg25TGfcxENu/NlnEe/BgBR0RsP0eJkF6 bhYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770840431; x=1771445231; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6jQM1mRtKYYKchUiL9MXlFhID/L6f3Klb5mRjr3nQkI=; b=XCmwdPw5RzewOKsk0smksbdfQ7Ag0ujGpUg2Qt3gFIYvSWVTB5vZEUh93DRmJoSa6e YptQq+W2nlwesTLDM3WFzZ8fZng17EbH2QoMSb522YCsYxkgN2G66uBOKOF3wsIa338C mQZA7ip9F7iHlsoSXvv/aXJm1vX5FG4fl9xkVJh44UDjCO4l2JxIC9vHlet/U/r2H88w nw6UmtgL2kCxm/HPkTUKIipRm92iH1KD7f7ACOrmA5AtV4PDXgAjkeYOpoj+obWTR/Gf Ey3WAind1kp1PxccUtnJUs+kLau+FOoyceKQVeKcAW/oIFH+6jI3aWgcEdMlWypcQwk2 /y2g== X-Forwarded-Encrypted: i=1; AJvYcCUoytC0ZuB+76FzCi7elv0sbMFJRRd2j92JHfQuXSSDDpdu7syd40GZ11hskTFyRhBaC/otU8dv/BudfTI=@vger.kernel.org X-Gm-Message-State: AOJu0YzgScRpGMv9KreSIY0WCHS04IMXf4hi8kzLIpGufPYYWAP6Baex XoZsRdc4QyPYr2UHzXxGsgC7Egx0Y3waytrGkXBnUOhP2mINZqmgurpj X-Gm-Gg: AZuq6aIGiILYh9Ru4MEU6lS2/mXWGfqSqsucXPOdKPHK7Bhu9LSdUhpfnz3LLVY7Fky OdwGewnfotp74lgCfKfMpjvMK7Bp+AKS1Xmes3ueM057mmiIMUUr9TK1tVoCoUL9WXq3wfmfcrK 4nf5mQ1e/R56Bm6CnZ8PpCTYgIDJzXAPcvi2Xri+yJ0xGfYvThTRkNmwrqTeUL3x8Rtqh+ocCvj XJlNHb/NBLF1jhUltRK2LDxc1jqf75T73MH4ETXqj7gZrWbPRXBUPkhqWf2U8aTZIzVULLO0AHa WhU5+DpY24k+hVjynNNthQyr0e1rsuViKgpSjne5P7h7Rs/DzSNNDmF62w7896s8O1AVvLE9wVl HHbTANOSWwp6C650fWeGGnxya1vK00qFFekB13nkezDEHiZMdqZkpsKI4swriAaKGElJ/Kv9Vcg oue8Ib2RsmGYQFrZN3TdUYMNJXmGsBIWy7DzsU9XhPAteAnG5J5tWxbE2qBMOvrh6o/gXH5LO4F PIExBLRGEFJLW0qnf6zKZ4T X-Received: by 2002:a05:690c:c227:b0:795:28b6:e3e3 with SMTP id 00721157ae682-7972f12410dmr12853067b3.22.1770840431219; Wed, 11 Feb 2026 12:07:11 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c254d5asm27663967b3.43.2026.02.11.12.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 12:07:11 -0800 (PST) From: Ethan Tidmore To: jic23@kernel.org Cc: andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2] iio: light: gp2ap020a00f: Correct return type to int Date: Wed, 11 Feb 2026 14:06:54 -0600 Message-ID: <20260211200654.25648-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function gp2ap020a00f_get_thresh_reg() can return -EINVAL in its error path. Yet, the function has return type of u8. Add error checking for gp2ap020a00f_get_thresh_reg() return's value. Fixes: 5d6a25bad035 ("iio:gp2ap020a00f: Switch to new event config interfac= e") Signed-off-by: Ethan Tidmore --- v2:=20 - Fixed gp2ap020a00f_get_thresh_reg() parameter alignment. - Removed unneeded whitespace between assignment and check. drivers/iio/light/gp2ap020a00f.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a= 00f.c index c7df4b258e2c..d122730176a6 100644 --- a/drivers/iio/light/gp2ap020a00f.c +++ b/drivers/iio/light/gp2ap020a00f.c @@ -992,8 +992,8 @@ static irqreturn_t gp2ap020a00f_trigger_handler(int irq= , void *data) return IRQ_HANDLED; } =20 -static u8 gp2ap020a00f_get_thresh_reg(const struct iio_chan_spec *chan, - enum iio_event_direction event_dir) +static int gp2ap020a00f_get_thresh_reg(const struct iio_chan_spec *chan, + enum iio_event_direction event_dir) { switch (chan->type) { case IIO_PROXIMITY: @@ -1023,12 +1023,17 @@ static int gp2ap020a00f_write_event_val(struct iio_= dev *indio_dev, struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); bool event_en =3D false; u8 thresh_val_id; - u8 thresh_reg_l; + int thresh_reg_l; int err =3D 0; =20 mutex_lock(&data->lock); =20 thresh_reg_l =3D gp2ap020a00f_get_thresh_reg(chan, dir); + if (thresh_reg_l < 0) { + err =3D thresh_reg_l; + goto error_unlock; + } + thresh_val_id =3D GP2AP020A00F_THRESH_VAL_ID(thresh_reg_l); =20 if (thresh_val_id > GP2AP020A00F_THRESH_PH) { @@ -1080,12 +1085,16 @@ static int gp2ap020a00f_read_event_val(struct iio_d= ev *indio_dev, int *val, int *val2) { struct gp2ap020a00f_data *data =3D iio_priv(indio_dev); - u8 thresh_reg_l; + int thresh_reg_l; int err =3D IIO_VAL_INT; =20 mutex_lock(&data->lock); =20 thresh_reg_l =3D gp2ap020a00f_get_thresh_reg(chan, dir); + if (thresh_reg_l < 0) { + err =3D thresh_reg_l; + goto error_unlock; + } =20 if (thresh_reg_l > GP2AP020A00F_PH_L_REG) { err =3D -EINVAL; --=20 2.53.0