From nobody Thu Apr 2 17:40:24 2026 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E8828AB0B for ; Wed, 11 Feb 2026 13:57:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770818262; cv=none; b=pAVFGNokb/UkA4eamOn36Igw5fO8lTRzk75WHnB7aP8Eo9veq19lEAQOPxctninsikh4amVWm+WPa4oLGlydld4EnC4FFjhlgIOVfbVoB5qCoWCq7IWFfxtpMnrUyaUBQIWHllh9/fbZFjCeS51Hk1X4cVS0v2qPK8nZjwvHqoc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770818262; c=relaxed/simple; bh=nOpcu90WA2R9uXSKx6/TlPQ/HvBsepY7KRcRGH70Ntc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LFK+/+tEzkJ616CjuCDzPBF9mHACOYTJxXICXpnbJsleShJBKFPUysmy9Ymdaja9AeG1sxgdSvwFd3COkZAK0OmWwmJ1etmzQ5+jRigE8uG8cQfa0GAMZbw/739YlrGw+G9uNi9+iFc12hKaxxHwvIfRMpvSyLouAjOA9M8q4kE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sx94jZQM; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sx94jZQM" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-436309f1ad7so3639701f8f.3 for ; Wed, 11 Feb 2026 05:57:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770818259; x=1771423059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d+9TfAUjeBuACIB/Bd1iQF+yD56azf2MlLBlQed5AnI=; b=Sx94jZQMR3XscV4NIEij/1UhV3pJDXCrVBbOuuCt5wbzjk1Uk7gvu3cRYALIZs2a5R 3XBVXDItSe9CkOVpAqOd/0tJVe/mN208JlxsjAhXCMKLAGtHmqrfCd3d0OoXHhX9zNjo eiQ8Of8N+uGS+dovrbx6eOUw9S41b7N4+8Q6QuhL1oijXgFiMqAM3fX95PFAqjLJxSl7 k3/HJwfNN3zT5V1Zvg73OVXRkEzHoRBR1+fnDJX2zOQ/lgN/9sKRAKqJkwpiWMEluM7R ziocSC7j5iS5q2BYJGh7d+nekXBLWehCVy0/RYFH3nGvv8fd0+ywb6IMVD5VDImNuvRu ZnfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770818259; x=1771423059; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d+9TfAUjeBuACIB/Bd1iQF+yD56azf2MlLBlQed5AnI=; b=J8NJsSJp/bCK9Y86NVAd0KtTSPZF74efTVfS9g1PariH4n2Q2xwZEa7464lrEGEZkO uW62ifYJVkLCZxbgnPsQq4SlBckz9H1JYoHWhg5RJcnA/TxbHrhpfBCdFb6uTUnYpHu8 TCnLMn1p4TBPaDr1iG7V9ExSJQIxZ9+LRGDJlSfa03/ITax2hkXd14o0Ndd7i3B0WDPL Onp2HJ+DJR0H/Exqsuu9Pn8mI20xVc6vV+fTz8lj+IAz98nkntfPB3pPKRIGuMgcgvn7 RRZccZzWwH2LzHy2Cf1BhgrKlTZckUR10jRuKtkuENQn3wOV4SB7HLnaemktKH7K0pfE CsEQ== X-Forwarded-Encrypted: i=1; AJvYcCXP9ulvr6ntLnvj0lCAEwCRxUL33hM6MR4yKy3IBvFsG7VbkteUjXM807dAOAFmwCh+gvMWzs7M9+zIApU=@vger.kernel.org X-Gm-Message-State: AOJu0YyFJT1vrHIcoH/jCpqHN18zEpXwLqsA3f+CU+s+BvI6GwtCKTDI ig5+YhULUtcRlBLfCCdvw2ksl3epmMnYLfFnTzM+YrYsXym60wYvlfU8 X-Gm-Gg: AZuq6aLtiAsO91GYmS0EwHL8c8ss4fxs2Jc68BEuq8pflMSbMFD3gtdzt8+WaLndRtj K2NLd7/Jb7V06nsRXj6eGJi3NB+eo7yvZVz4oEH8qMh9XqU+Tiz+uHoBt7ATB1IIIJpgGYniKc5 Zh/Fhp5vLbZRJiV3phXktjo4vmyL/xmiBLAfZY0XKRtcUCGCAJ9byj37lP2hZ0KSYc0FBeJx4vw myzxUIFzWt+Z2BOpJO+4vr8yFdAfTaMZL7qieKCgTZsAUnKfSLysg9KWprbr9nc5npZzzHxIeIy K2qAqk+I7cOXyV2sxCmQ0k67aaHjcpAV9DMdWs6xZ4ENv1uWo7sOdiAZSU/mSOBXtgj/KlkF3Ym mfDo6ZQUjD/6d38xDhbBwY5SqWGpZFkwgV0e52mjGzWdAOJmcWb4lk2rwqAvJtNE/CV0UWkRjKu wCTKD9/dVmeSk6LQxPaf5EyZopypkP4h5BVwzHASGQSX1lvXFdjNtq X-Received: by 2002:a05:6000:420e:b0:436:1517:aec7 with SMTP id ffacd0b85a97d-43782c25862mr4320987f8f.17.1770818258335; Wed, 11 Feb 2026 05:57:38 -0800 (PST) Received: from mariyam-Latitude-5310.. ([39.37.133.239]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43783d310c6sm5289978f8f.2.2026.02.11.05.57.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 05:57:37 -0800 (PST) From: Mariyam Shahid To: mariyam.shahid135@gmail.com, gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: fix YODA condition warnings Date: Wed, 11 Feb 2026 18:57:31 +0500 Message-ID: <20260211135731.13560-1-mariyam.shahid135@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Place the constants on right side of the comparison in rtw_security.c to follow kernel coding style. This resolves a checkpatch warning. Signed-off-by: Mariyam Shahid --- drivers/staging/rtl8723bs/core/rtw_security.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index 8ee5bed252bf..601178dafcc7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -1488,7 +1488,8 @@ void rtw_sec_restore_wep_key(struct adapter *adapter) struct security_priv *securitypriv =3D &(adapter->securitypriv); signed int keyid; =20 - if ((_WEP40_ =3D=3D securitypriv->dot11PrivacyAlgrthm) || (_WEP104_ =3D= =3D securitypriv->dot11PrivacyAlgrthm)) { + if ((securitypriv->dot11PrivacyAlgrthm =3D=3D _WEP40_) || + (securitypriv->dot11PrivacyAlgrthm =3D=3D _WEP104_)) { for (keyid =3D 0; keyid < 4; keyid++) { if (securitypriv->key_mask & BIT(keyid)) { if (keyid =3D=3D securitypriv->dot11PrivacyKeyIndex) --=20 2.43.0