From nobody Thu Apr 2 17:23:45 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA7A73168F5 for ; Wed, 11 Feb 2026 13:56:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770818183; cv=none; b=CHNfZwxTPYDKkhaHKvAgDQGgY2hJmyQduLo4x60MDZnhDoXfSFQoDfurR75+EyNDpn//C4fD+/g6/T5dVUMHGukNLvDiH29/DLTUQLLR4yqvlzZQTt49Vhc/fNK9hCaktvC07UNjo3TuxuvT3eoDhW0vnMA2mN1NcAbn41OTvh8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770818183; c=relaxed/simple; bh=nOpcu90WA2R9uXSKx6/TlPQ/HvBsepY7KRcRGH70Ntc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aTGgN6rRDrvskHBMOn5orDmdMqbN81aUfqXIdPI5C/Qly9Ue0WM6grjr7tKwU+xJ5UZ1k/LC7Y4rHwjzwmkSBYf6W5J6FYtJxTw4+pIRYtruY2N525CpqJhxoEjcxjdPIyUWZh86Y9wKk4lR+ToDfjzYpErMc1OG0t39z6GMVrg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IRIyZll+; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IRIyZll+" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4805ef35864so58176835e9.0 for ; Wed, 11 Feb 2026 05:56:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770818179; x=1771422979; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=d+9TfAUjeBuACIB/Bd1iQF+yD56azf2MlLBlQed5AnI=; b=IRIyZll+ziH65H4G/zbsAXO+g1uSir2bDfD8xF5n1i8+ROut0MhN5ogEFvl3gPX6qS z79r2JRC/z5VOeFvZLb44+2bh0uv6AgRi+d4/1bABqGTCRSJmyHUAmh6ZIOr+3yF63IJ nBL2a8tJDHoTr9pDv84BvBTMpVsoCpIuZNrEST4HBTQ74Y7fXW0UkRTJTMU4c33DNKXb rAYlLP8zqrWmvadEb2eXzTSgBV/JSyFqm+ivJ1zVm2CruGmGS+L1gH/aKNFa/WZIZM1d vaGXrTT1M6Hh+hKQkriYjgOM85YsbnmHeQkUJzdtCfRscTJqgeDGx/cgkV7FfS1j+Sz+ prRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770818179; x=1771422979; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d+9TfAUjeBuACIB/Bd1iQF+yD56azf2MlLBlQed5AnI=; b=qfpOeTnNXMK/RRVFvcQ+Uze+RzK42EPjbt5ymM9LSiZnh05Etht9E21OyeBaoMpp7W 0hWY2C85n1HedcmEg+xgMztVpCSEE/RN9Dk/NhwLl+x54Zgr5JfWRWFKmxCYKRX804Na Z/82e7tesmc+E5sAAHK6t29Y4Mz0S3CZluBQVsYbQAPEqJ+/nhQj+hJbzXKHbz7VCmmh ecodIM94Phduowi1MaIZi7yjmBbURUv9IkxI6GZFwYrT9QKO4p9kPcxOuKI8iWaBWtmf 1MUg+UEC3fT9mESqu81W6hIZwcc6adq2wnOuwtmi0FNpBUxpLU9rQv5bmrmMR0ictynG 8mtw== X-Forwarded-Encrypted: i=1; AJvYcCXE9vOUPkasSVhshTmTjDSnSoWketvjJMHSg9Eac8Qgc0ZzBMKMijx9mKa2VExNrgIAr0qbyFM1t9sxYpk=@vger.kernel.org X-Gm-Message-State: AOJu0YzMbYxLrW+yrcp89i8BOgmlD8kM7X0JTMkMtitS/ES6QbJ2nb5R XSQf/kGjXw5Mg9NeDJw4dgdzOHzldgR3S4tmQpLw2J+Rd/EQxSSTZTovLKFpTw== X-Gm-Gg: AZuq6aK59h/+AESOSxda6CJRRtwOTf0aE4vCZkN7civhOeRCpSBIW+txBKk3Hq3/WXl NOyVDZgLulbcL89cb3xM6AGF74BMuMdtjhxBo6/sAIof5YAs+YDIA5fjufZyU9Cv+m0dSbrOJSj SyK9rsSjj8mnOX3eP4gj2sKOSk/b+mhHA2GeENqmK5tGfrL5BQn0Rnsvp70VZhpglWwt9tCoguY UO53wNlf7EcKOhV//ceB1YsniGEad4o8qaLjIO94XCtvEr3mj0Jw3yqv4qMMVBMKw7EXIrphBKN RBlMccIpK3hEqU4PVNkUJ5QM+IH7tejno8xkZBli86vDaTi35vUTrLiG0+fDZympq4jydnYx3nz RZGlp1zkqsL7bry+muT10GBQX/K/eNk6L04UWhw0MEKFLliUyUur5ia1DRMd1RQ74WD3frV54yv kQqg4lbMMRwzkVlRE3VhkfNJ2osnctEOrewWKgFOpnmOybc1gifsSrtCYT4f5rVBM= X-Received: by 2002:a05:600c:3506:b0:477:b642:9dc9 with SMTP id 5b1f17b1804b1-4835e1cb056mr24566265e9.28.1770818178864; Wed, 11 Feb 2026 05:56:18 -0800 (PST) Received: from mariyam-Latitude-5310.. ([39.37.133.239]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835dd0e327sm44195465e9.14.2026.02.11.05.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 05:56:18 -0800 (PST) From: Mariyam Shahid To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Mariyam Shahid Subject: [PATCH] staging: rtl8723bs: fix YODA condition warnings Date: Wed, 11 Feb 2026 18:55:45 +0500 Message-ID: <20260211135545.13505-1-mariyam.shahid135@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Place the constants on right side of the comparison in rtw_security.c to follow kernel coding style. This resolves a checkpatch warning. Signed-off-by: Mariyam Shahid --- drivers/staging/rtl8723bs/core/rtw_security.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/stagin= g/rtl8723bs/core/rtw_security.c index 8ee5bed252bf..601178dafcc7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -1488,7 +1488,8 @@ void rtw_sec_restore_wep_key(struct adapter *adapter) struct security_priv *securitypriv =3D &(adapter->securitypriv); signed int keyid; =20 - if ((_WEP40_ =3D=3D securitypriv->dot11PrivacyAlgrthm) || (_WEP104_ =3D= =3D securitypriv->dot11PrivacyAlgrthm)) { + if ((securitypriv->dot11PrivacyAlgrthm =3D=3D _WEP40_) || + (securitypriv->dot11PrivacyAlgrthm =3D=3D _WEP104_)) { for (keyid =3D 0; keyid < 4; keyid++) { if (securitypriv->key_mask & BIT(keyid)) { if (keyid =3D=3D securitypriv->dot11PrivacyKeyIndex) --=20 2.43.0