From nobody Thu Apr 2 17:23:44 2026 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECEB9347BA5 for ; Wed, 11 Feb 2026 03:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.5 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770780633; cv=none; b=FmNmKZWHeoDH03LSHTUMmAsRgYvLeUeWyIklAHsg0DP+Y703jujlGz1+UeyDyFUvJiJdLsxA4T37ik9n37yZRFn1esvS9CE6vP3ed3Svg3r6mgoDyZ+MF1z8or75JCk7Dd1diVr10Fnpn91diNvBCKE+jokOKPgFjFLM90fgjUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770780633; c=relaxed/simple; bh=ozPtkJqAmbYDf1CYy485KVGkHNe8OdiGFcsuPR/vqtk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Bzvsm0xpc8e43zkqDe9YAAQGyoDS1H9uHHTwl35RciGrYoLO68zqw9+lOvjl5g74rUB28u5QtlTxMCLDAOnXKf29ITvhYrlb/+McxQCoewIFzWQCXbgVsGdP5soYTCLtMY8+bV8dlLUowC35/Zaq78xuLpC9GSGVI4n//jooD/U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=Vx/PWKIP; arc=none smtp.client-ip=220.197.31.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="Vx/PWKIP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=OR VMZK9TTKMl+jFhx+5kZzvswRYg3GhA/r8yrkv73eE=; b=Vx/PWKIPqvGfFelh/g KfFjktTZZm9TEtVUQeXkFYUO2aQlZM+uQwAIUZMjUcLhCq2LVsIP6O+esfL3QYVZ my8xCJRgIrWl2aNHNts4LZ77merEU1LF/uR9WM8mSi1Fai9gH00SZLvkomwfSo4S KAw0+FtvoH3dBRBzspho2KudQ= Received: from ubuntu24-z.. (unknown []) by gzsmtp2 (Coremail) with SMTP id PSgvCgC3f96j94tpMZp0RA--.2981S4; Wed, 11 Feb 2026 11:29:43 +0800 (CST) From: ranxiaokai627@163.com To: graf@amazon.com, rppt@kernel.org, pasha.tatashin@soleen.com, pratyush@kernel.org, akpm@linux-foundation.org Cc: kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, ran.xiaokai@zte.com.cn, ranxiaokai627@163.com Subject: [PATCH v2 2/2] kho: remove unnecessary WARN_ON(err) in kho_populate() Date: Wed, 11 Feb 2026 03:29:37 +0000 Message-ID: <20260211032937.208353-3-ranxiaokai627@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260211032937.208353-1-ranxiaokai627@163.com> References: <20260211032937.208353-1-ranxiaokai627@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: PSgvCgC3f96j94tpMZp0RA--.2981S4 X-Coremail-Antispam: 1Uf129KBjvdXoWrtw1xXw17Cw4DGFW8XF4Dtwb_yoWDKFc_WF 4xtw1Ikr4qvrn0vr1Yk39avFWrKw40qFyvv3W3XFWxt3W5tayj9393Zw4DAFn8W34qkryD Ar1kWrZ8tr4fWjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRCHq2DUUUUU== X-CM-SenderInfo: xudq5x5drntxqwsxqiywtou0bp/xtbCxgdksGmL96fAXQAA36 Content-Type: text/plain; charset="utf-8" From: Ran Xiaokai The following pr_warn() provides detailed error and location information, WARN_ON(err) adds no additional debugging value, so remove the redundant WARN_ON() call. Signed-off-by: Ran Xiaokai Reviewed-by: Pratyush Yadav Reviewed-by: Pasha Tatashin --- kernel/liveupdate/kexec_handover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_h= andover.c index 3c705b08a489..eb87d23e8da6 100644 --- a/kernel/liveupdate/kexec_handover.c +++ b/kernel/liveupdate/kexec_handover.c @@ -1507,7 +1507,7 @@ void __init kho_populate(phys_addr_t fdt_phys, u64 fd= t_len, =20 memblock_add(area->addr, size); err =3D memblock_mark_kho_scratch(area->addr, size); - if (WARN_ON(err)) { + if (err) { pr_warn("failed to mark the scratch region 0x%pa+0x%pa: %pe", &area->addr, &size, ERR_PTR(err)); goto err_unmap_scratch; --=20 2.25.1