From nobody Thu Apr 2 17:36:32 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5F0F2D5412 for ; Wed, 11 Feb 2026 14:33:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770820413; cv=none; b=Y2lRgxD2IEccTX/ElcROPiX323uS1ngr4R3EIQH3J/u2T+a/tlLaR1Lj/WgY/u6cx5isIlbiiXQIZd8IXf9RvTCGX2UKMtq1iffh1me4L5PIiqyxNlpHt/1hzKKZTkqKNhc6j51dSdlx5iYUrWHJC3EotPjPdOAwxt9r9KkdDRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770820413; c=relaxed/simple; bh=oF8OpK73AUJk7VpT2lyJVMCLoFCch3stgI5BDxkw03w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=saPnN6+MS2p5t7v2em4d6QsuheW4yvg5j08zdmtWWHc7siZsqk4TtwEXG6x7z5q2UPrc7ow0/qOWynMaCjF5c5QECFOYHBl06dRSGD4z9BTAwbJHCdVcurpomqm45WCijKbZp7qzMItDqi5kmAwXugIKm1KaTy/aMSzxg4QCrmA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=btYeXR2b; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="btYeXR2b" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-354c16d83b2so2367381a91.3 for ; Wed, 11 Feb 2026 06:33:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770820409; x=1771425209; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=34CTSOm4KFPR0zPwtT9Yc2xf8bAN7Ltci530o4vZ20U=; b=btYeXR2baHFRRU28mwBGGtGfElRTjRilhMNONyORw6+QgSp04+NCfT8f8ktwjSwh6e uFf3hHCjl9cr2oKe3YHnZd6GaPseTGRH8jBwmdlFWFzKmd6CUf4IVjJNCGB08IYRBWj8 mktBNsFmuEkDmaxKPePRl4Hp1LmbN465sGvfmhVmmFIOzwhRAi4vD1oPjnP0xM0NehKF e3YahCzyqtTG7WZrev40ygzKLl31zLkULca8fX8jPGvN6KIvkPbq5D7ciU02qcVbjOeN HexKg0t6frRdtyHMTMvHkaWLnvJikg5skc9hthfvlNATatsMFtUU683sAODFm76mVVgZ 2W3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770820409; x=1771425209; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=34CTSOm4KFPR0zPwtT9Yc2xf8bAN7Ltci530o4vZ20U=; b=dOda4mwOySJYR+/e9uNOsLmP6iSP2wf3+7cdkqV220S4tzJIlZ/kw3gZmt4ZyJHQCo oO+Cm147tbC5+PnhpO0wHhGmFJgm9+bCFl9dyy069OEooAF/oYFKetXPJjVvdSKDwH/1 j/73CUxWCDdWpTq4GIa3V/EOWbJxC6nEOZVnSJw8hBTkhIbpr6vzo2rHvQQtT+ySTkQy vwd4bqerHIT99EsJevzyjZ4Rzm54eZSKslVk1hUCB3NVX1Ojs+1/Wzoh4N0wVuBGDvmH A7Ty4nhf1nHGrZMDckr1dMCTdQzJ+NS/o0ODJ2BgJ+mZAz8JAJDqHIk3TCUJ8s8vBYii DRLw== X-Forwarded-Encrypted: i=1; AJvYcCUpDAegoXhu7HLOdD2tvuOuPGCo+D17R84gOjYKMIHATJz46+ZtF+gufsuI5oPkBQN4Q4kkW0KNENOlIa4=@vger.kernel.org X-Gm-Message-State: AOJu0Ywonw4tIoRxK6EADQglJWYtaES2igfX843cmQZfaS5Uo2EGGLz8 rq37PDRPgjas6hqWYxZ0DQHgRUfCag60BIzPYoSq82Ql0ZzKkC4uUfm+ X-Gm-Gg: AZuq6aLpdVvUkvTRpRvv0lRF8i4IRjpfEtZGvLk25awghZhP0F4l0jpPfPLNrM/gN7u 5XhU1LlD/kuIQMA2Fa2kFcmR9/Z99Rrceat9ZPzvf2/GU1b/iKlTZDYUX8Jri8VZOES0iID+2iI 6anr3uwnhNCbEXaSD51f3FblTPP/4F5qXSIyJPRyCLFQaD/eznw1YoQMblf9o96xXs18EbtvwAg 4mK0N6LpOSw1oitrSG/hRK0cFFpD4zLjfHo0tGaFZjt6p6izPowSXwca6kw7XyKWTU2J+bcY5y0 knLPxBgVw/OdFbJYK3eXUfE7VPFfu/AuHz8sj9xhLRSI66o7DjlbyHKPtMEjtH2xQ2UDSeC4ESr Fg54fPmbZ9lj2lhZLYSF3Ty3lR5qx1FMLZ/AqSaTPMFDUWWcBMe4+HGd8fnXARnqzZGXJKJPgHE 6h/PFIZCvZAr1/w0rg3qPCZTfC/RSRkMPa14BjRUCvwuLVnGZhPis7ny/8UpM5 X-Received: by 2002:a17:90b:3dcf:b0:354:a57c:65dd with SMTP id 98e67ed59e1d1-3567f85c9e4mr1617465a91.24.1770820408721; Wed, 11 Feb 2026 06:33:28 -0800 (PST) Received: from [127.0.0.1] ([101.32.222.185]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3567ebc4331sm2330386a91.16.2026.02.11.06.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 06:33:28 -0800 (PST) From: Kairui Song Date: Wed, 11 Feb 2026 22:33:23 +0800 Subject: [PATCH] mm/shmem: remove unnecessary restrain unmask of swap gfp flags Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260211-shmem-swap-gfp-v1-1-e9781099a861@tencent.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDI0ND3eKM3NRc3eLyxALd9LQC3WQziyTLFHPjREuDNCWgpoKi1LTMCrC B0bG1tQCB1yu0YAAAAA== X-Change-ID: 20260211-shmem-swap-gfp-c68b9d73a90f To: linux-mm@kvack.org Cc: Andrew Morton , Hugh Dickins , Baolin Wang , linux-kernel@vger.kernel.org, Kairui Song X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770820406; l=1202; i=kasong@tencent.com; s=kasong-sign-tencent; h=from:subject:message-id; bh=Rqa70ORfAigFfDgfrZ4/HBAYSt16a1lSXqU93koFrAM=; b=cNp7dUoJTW8PNS4B/8E4Qp0f9dpw1o5MMvOsM25jyfLpTo2jTUbzktkgUv9oIyWbaHDE+RnpU txbkQGii05EDBEi7yAnWp/+fsVdVvBk2LIon1zoIYrBF09iTxh36SZI X-Developer-Key: i=kasong@tencent.com; a=ed25519; pk=kCdoBuwrYph+KrkJnrr7Sm1pwwhGDdZKcKrqiK8Y1mI= From: Kairui Song The comment makes it look like copy-paste leftovers from shmem_replace_folio. The first try of the swap doesn't always have a limited zone. So don't drop the restraint, which should make the GFP more accurate. Signed-off-by: Kairui Song Reviewed-by: Baolin Wang --- mm/shmem.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/mm/shmem.c b/mm/shmem.c index eaaeca8f6c39..4f34dfa95a50 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -2043,14 +2043,8 @@ static struct folio *shmem_swap_alloc_folio(struct i= node *inode, struct shmem_inode_info *info =3D SHMEM_I(inode); struct folio *new, *swapcache; int nr_pages =3D 1 << order; - gfp_t alloc_gfp; + gfp_t alloc_gfp =3D gfp; =20 - /* - * We have arrived here because our zones are constrained, so don't - * limit chance of success with further cpuset and node constraints. - */ - gfp &=3D ~GFP_CONSTRAINT_MASK; - alloc_gfp =3D gfp; if (!IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) { if (WARN_ON_ONCE(order)) return ERR_PTR(-EINVAL); --- base-commit: ad92386d5debbde551129dc85f0118f5a521388c change-id: 20260211-shmem-swap-gfp-c68b9d73a90f Best regards, --=20 Kairui Song