From nobody Thu Apr 2 19:02:13 2026 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF2673595D for ; Thu, 12 Feb 2026 01:01:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770858110; cv=none; b=YCNLEwo62UQgyJlzVwp5W7gJPJCo+Lij94lAz8SDjbPDAtoLy0rQDLAkapJH4Z6TQ1lZ4xKig304ZYLWV//WdK2AB3MKtvAqDAQihFGldDSYMI+26yg2At6iWjZc20z2fwqSc9ShuA9EwIJ/P/nQJyde89mZIPP48TqkHBQW89w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770858110; c=relaxed/simple; bh=Mjn2rwH82IJpmlJxfXR9v1Sk/LuhHoeUzV8gbCAibkA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=O9JmihIWK2km7rN1e8G20APmRb9QjFC7uSY7qdZYdlikZXOdXtxkdkv3hwoI2ONG/mHLQdsDndZ1JYuLNPscQC8QaNEjydcapauSyzEeGdaqwM7UmTd9agQq74xdBm2yvyu4H4iYrp9yi6zOsVmm5FaIznQz1MDMDOEAYwVbuEI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X7dU3k2W; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X7dU3k2W" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-796d68083cdso12102947b3.1 for ; Wed, 11 Feb 2026 17:01:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770858109; x=1771462909; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1R06yw6EKxaPJEYAiD/GC4GWXLKfIpFl/ud9jyPw8/Y=; b=X7dU3k2WcYUkgJLhVzbY2udeBLv97xg/YP0NtrmwUiGb/GSwVtIiF1i7+jzabHjnHw Bttk9SO1BRd6sH6f2SymOjJhnRQpkNBwrVbL/1HyNDTpRR1jWTYmZn3Xe6iHaAeJT1eQ LlC3crS47iWNwNcdRNtcVo/ecPtWgPfCawpoWLZXohUETlt4H89WGIedm7y6wNdxnY6x EelmpMLNWuk3g6Tm4HH2of0Brk6UL6tlPxIUOCqgT81ezlKG+eer/hg9IrfPi/fzEEx3 NJIFnEmwDaB57ixctX84JKPDD1ebKaC2r4qSlc1CUF3cfVzMHT9HJfiWjELr/VV1gym2 EouQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770858109; x=1771462909; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=1R06yw6EKxaPJEYAiD/GC4GWXLKfIpFl/ud9jyPw8/Y=; b=niDMg0XRe6Zb/HXt/MvreOuvY6GwusRjnWZKzs7/gAUdr1EaY1OroYrg93j148/Abl A9e7FWh/RG3MYHsFveqWy3twzE7Djz9LIJf3Dr6wam3S4Cc3TnrRyyvT1CzDFb+JIvaq Ey0TsDJCZ4CweWAWeAdxqf0LcWHfwb1MzRu/sGh1YJG/VLxcy9xZUFAjyJZL+nJgIkdu Q7GJgI880DD+ofwgb1leOvcpIidUKwyLnnqbX4m/lbreRQYyossYYjosR8H0BE4Y6qnp vni08XQXgDAWy2l81cygqa+nhN/mmK4Zwmvf2fAjvnFUD+GFctjq5/H4iR4OA97RZv3c dlvA== X-Forwarded-Encrypted: i=1; AJvYcCUrmJnMnsQ/3MP3hxPxgtsV8vfRo5hcl5HvcadDXwonMRavDKxKCvoEBzfnsk1D5aEO8RJpatsuk8BScdY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5hdOsJ2KvVLYiCnDNT/82Y8ah4QDd6Z0n1rw8vkgLp0glzy3z x2SyDDUw5Suz7OkQgKGxOCuoqMwovKQzApIunej0NEN911VaIw5JgwAc X-Gm-Gg: AZuq6aLzei/XPsTdpdzvK4bqQCHnuBF/Mlb3LzF4f7pIdEcTd999rorGGIVCeT5StcB 4DYKFFn9CMa7WJjl87pzc902AKWukRKufMJciB9TefPBRt8stByvrFGmhJn/f84GT1hgaQNIKmU gfj0NOR4mPwYdIFuJfGKefkH/CWai8QB+H3llRn+Oop6lvPBm/0JIopRCdWlgW8arX7j6fd73ho qj8EF22RzouX5u3QaWhkH9pTC8UQR9gzHBvBMmuxWmgHKaI+W7GDnSGymy1Vvi1VSVH8ObvuRMp rIDJDu0NO0culupB9eKiGMzCUQ6H2Icv/P3IaxwwiqTT8/R8TlajXYBrcYQ+OBr9vV4LUvsvWtt cdmek4vtsNpLr28oZ0l3fpNKUmXyE7iwwWoK28C28L70tc3URllHwIdmTC1pDC5uM+v/lzHdIxb Q461+ksUh6lxYeytOt561/urMcEw8aFRoW X-Received: by 2002:a05:690c:802:b0:796:3e25:3e95 with SMTP id 00721157ae682-7977171b436mr6476207b3.18.1770858108692; Wed, 11 Feb 2026 17:01:48 -0800 (PST) Received: from localhost ([2a03:2880:25ff:4a::]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7966c254d1esm32678167b3.41.2026.02.11.17.01.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 17:01:48 -0800 (PST) From: Bobby Eshleman Date: Wed, 11 Feb 2026 17:00:41 -0800 Subject: [PATCH net 1/4] eth: fbnic: set FBNIC_QUEUE_RDE_CTL0_EN_HDR_SPLIT on RDE_CTL0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260211-fbnic-tcp-hds-fixes-v1-1-55d050e6f606@meta.com> References: <20260211-fbnic-tcp-hds-fixes-v1-0-55d050e6f606@meta.com> In-Reply-To: <20260211-fbnic-tcp-hds-fixes-v1-0-55d050e6f606@meta.com> To: Alexander Duyck , Jakub Kicinski , kernel-team@meta.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Mohsin Bashir , Shuah Khan Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Bobby Eshleman X-Mailer: b4 0.14.3 From: Bobby Eshleman Fix EN_HDR_SPLIT configuration by writing the field to RDE_CTL0 instead of RDE_CTL1. Because drop mode configuration and header splitting enablement both use RDE_CTL0, we consolidate these configurations into the single function fbnic_config_drop_mode. Fixes: 2b30fc01a6c7 ("eth: fbnic: Add support for HDS configuration") Signed-off-by: Bobby Eshleman Acked-by: Mohsin Bashir --- drivers/net/ethernet/meta/fbnic/fbnic_txrx.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c b/drivers/net/eth= ernet/meta/fbnic/fbnic_txrx.c index 13d508ce637f..e119526fce14 100644 --- a/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c +++ b/drivers/net/ethernet/meta/fbnic/fbnic_txrx.c @@ -2575,7 +2575,8 @@ static void fbnic_enable_bdq(struct fbnic_ring *hpq, = struct fbnic_ring *ppq) } =20 static void fbnic_config_drop_mode_rcq(struct fbnic_napi_vector *nv, - struct fbnic_ring *rcq, bool tx_pause) + struct fbnic_ring *rcq, bool tx_pause, + bool hdr_split) { struct fbnic_net *fbn =3D netdev_priv(nv->napi.dev); u32 drop_mode, rcq_ctl; @@ -2588,22 +2589,26 @@ static void fbnic_config_drop_mode_rcq(struct fbnic= _napi_vector *nv, /* Specify packet layout */ rcq_ctl =3D FIELD_PREP(FBNIC_QUEUE_RDE_CTL0_DROP_MODE_MASK, drop_mode) | FIELD_PREP(FBNIC_QUEUE_RDE_CTL0_MIN_HROOM_MASK, FBNIC_RX_HROOM) | - FIELD_PREP(FBNIC_QUEUE_RDE_CTL0_MIN_TROOM_MASK, FBNIC_RX_TROOM); + FIELD_PREP(FBNIC_QUEUE_RDE_CTL0_MIN_TROOM_MASK, FBNIC_RX_TROOM) | + FIELD_PREP(FBNIC_QUEUE_RDE_CTL0_EN_HDR_SPLIT, hdr_split); =20 fbnic_ring_wr32(rcq, FBNIC_QUEUE_RDE_CTL0, rcq_ctl); } =20 -void fbnic_config_drop_mode(struct fbnic_net *fbn, bool tx_pause) +void fbnic_config_drop_mode(struct fbnic_net *fbn, bool txp) { + bool hds; int i, t; =20 + hds =3D fbn->hds_thresh < FBNIC_HDR_BYTES_MIN; + for (i =3D 0; i < fbn->num_napi; i++) { struct fbnic_napi_vector *nv =3D fbn->napi[i]; =20 for (t =3D 0; t < nv->rxt_count; t++) { struct fbnic_q_triad *qt =3D &nv->qt[nv->txt_count + t]; =20 - fbnic_config_drop_mode_rcq(nv, &qt->cmpl, tx_pause); + fbnic_config_drop_mode_rcq(nv, &qt->cmpl, txp, hds); } } } @@ -2654,20 +2659,18 @@ static void fbnic_enable_rcq(struct fbnic_napi_vect= or *nv, { struct fbnic_net *fbn =3D netdev_priv(nv->napi.dev); u32 log_size =3D fls(rcq->size_mask); - u32 hds_thresh =3D fbn->hds_thresh; u32 rcq_ctl =3D 0; - - fbnic_config_drop_mode_rcq(nv, rcq, fbn->tx_pause); + bool hdr_split; + u32 hds_thresh; =20 /* Force lower bound on MAX_HEADER_BYTES. Below this, all frames should * be split at L4. It would also result in the frames being split at * L2/L3 depending on the frame size. */ - if (fbn->hds_thresh < FBNIC_HDR_BYTES_MIN) { - rcq_ctl =3D FBNIC_QUEUE_RDE_CTL0_EN_HDR_SPLIT; - hds_thresh =3D FBNIC_HDR_BYTES_MIN; - } + hdr_split =3D fbn->hds_thresh < FBNIC_HDR_BYTES_MIN; + fbnic_config_drop_mode_rcq(nv, rcq, fbn->tx_pause, hdr_split); =20 + hds_thresh =3D max(fbn->hds_thresh, FBNIC_HDR_BYTES_MIN); rcq_ctl |=3D FIELD_PREP(FBNIC_QUEUE_RDE_CTL1_PADLEN_MASK, FBNIC_RX_PAD) | FIELD_PREP(FBNIC_QUEUE_RDE_CTL1_MAX_HDR_MASK, hds_thresh) | FIELD_PREP(FBNIC_QUEUE_RDE_CTL1_PAYLD_OFF_MASK, --=20 2.47.3