From nobody Sat Apr 18 03:33:26 2026 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACFCF367F46 for ; Wed, 11 Feb 2026 10:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805671; cv=none; b=FC2mIzCsXC7e0WZypHSv3JQNlVRBiX98qm3jx14Y6DKh2gzmPcw1Vqrb/PIiXONzbuFU8OcKCb1NEnMhKEej4kAumNvQLTBCe0UT6/7mfYjXD29k5lp+ZKVAg9GXWwLrtzcRtm30//n9FoKjJdTUoahjH7bKtoEbF2mdryrCx0E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805671; c=relaxed/simple; bh=EEdEa3IUnYRnCSJujp56yp6HpXcw4IsB31pVJk5oyWo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=nWo2ZhqJWJtIGEc7GrmUiTRe+tw/Zbxp8oorE5V36SwJaXImStTwQ21DD3p9LPto0QxLImNzFM+1KxyygEhhwrSk/jaerb7VwHaeYjX4H4Lk7/uz7HrL7+3xP2gJ/+uX/JQ+5NyWuVQFXFxKHFODFRsCD7q35G5NGqfw2tG3n/Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=eBNWvaPj; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="eBNWvaPj" Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-b8eafb515aeso241077166b.1 for ; Wed, 11 Feb 2026 02:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1770805668; x=1771410468; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=roAcgFRbH54UQCdhIFxSyx+KQ1p/KfSb2O/TanFU0qU=; b=eBNWvaPjb0JiecfddRXAc7G5d3raSV7PeD98Gyn2iVple2RkA/GQQcXYinN9U3ZK60 uH26uaBXPUTT5LLUa3sKELJpA70xqTSgp5MgiGXd/Jf7BFrtmVTspBdASVlvJ7TzqBw4 QtP4pgFD7pPsXn0GPkkyKbenHKzjKZ4Yhzd7wNKyfrrfFJyMpb/jsbvyGC9zWKprlwK+ qG7fvrNPFV6aFuBALLokaZ01ighXCBnMilUGcXcGFg/FAs6BQeNbK9+tkhqB1a4Nj98+ zZqlRx3uHQEEHwFzhepX850Qv1qVnZKpOZD5hCs7Wvav9RiiSfsplVW9XuRNwzdAnEWt aloQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770805668; x=1771410468; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=roAcgFRbH54UQCdhIFxSyx+KQ1p/KfSb2O/TanFU0qU=; b=VOXrNTUSw2M3/OsYN8faa7uHdw8FMHmYIVeQzZkRoNP/tN2U2bNx+bJEMKxrCNlg3R vNC9yts5NKpFp1Bsei8HRloKhJN7t4qAoXtLWIZlC21uPA+hdjvRt5y5jaJgtDPl7wtM o8rd0/Uw0tjWvkab8c1VhHWbCkLzSdShJVWhK8qLHW435Ieh9YWRnlQkCYYJUO90t5Co DYCYsXMIz0hNwy/hKf6dRcAtKMVLibRAOXZVGcs5gnuXPg3JNasLKm8gc0ups+mcTtUW La8fdM1n0tivctvKC3KWN0YXMYMiZhSdl9UGDxNShgAZS56FRcJVBNNMkkGw0KmmWrrJ wJ2A== X-Forwarded-Encrypted: i=1; AJvYcCVstJgBQ9XYzaOwVxzv+/NneAkxIl6apbewu4Wk50UvFFyEgxvWwgs2VE8wvnitgRk3DvUW5y6tMx46OiA=@vger.kernel.org X-Gm-Message-State: AOJu0YzqJc5qp26GSFzBMOz7NzBI+D9tGsL2jXegjOJP7VGhg49thV6P /atWBHTnp4UVGaNa5p5rtsTr147NJQCDYOhF60c9RJ+MLxCOABukZPPiXCUa6BXJ3iA= X-Gm-Gg: AZuq6aJn1f2HyRU4OAQdX9VPPKUOFwW8Ez5YAWnUCQMkrIaVPNDUSlow36NDAyIgzPV EkyFD1WFlj9WP6gj4eb/AsxwhbiA5g8lDYXmB7efJuTEwNTsVx6btF3NeLl4L+q5hjyS8qFixAw 5W5xMhTQYlWWAcPNEoDh9Fr2NAJJCiIj6tcKdA9vg8x6L4Up0Cnm5Q+Fi8+oEdxZerSigC9GE+Z g+9cXv425TjQR57QZUUp8PitahBJmKz1Jhjr4lqOHLp+2YuemqjZR1qivIk8hTICfD+5a9dAmfC 3Z44iz9zU3TnVXNeyGHW9on0O/R9Pml2kSkyErzQnCIX1ar2kxuA8WhNQb3uVQmrutcQkC3V/Kf PPY4v74+H5Ui1ZiQx1oG29EHhfbS91L0vsZNeJ22BM1Oc9/J2KYeJOBFRLtSqtXdhRQdzmHAJF0 QQxKpOxTnfAlb80wQV9pBW16lKBu6m7rE9kJnrpVws4CclcNhyB3c6u5XmAOl4Mm6nfgFePFRGH nT7 X-Received: by 2002:a17:907:2da3:b0:b87:117f:b6f0 with SMTP id a640c23a62f3a-b8edf34b385mr1105176666b.30.1770805668021; Wed, 11 Feb 2026 02:27:48 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8f6ec54925sm44296266b.53.2026.02.11.02.27.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 02:27:47 -0800 (PST) From: Luca Weiss Date: Wed, 11 Feb 2026 11:27:32 +0100 Subject: [PATCH 1/3] ASoC: codecs: aw88261: Fix erroneous bitmask logic in Awinic init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260211-aw88261-fwname-v1-1-e24e833a019d@fairphone.com> References: <20260211-aw88261-fwname-v1-0-e24e833a019d@fairphone.com> In-Reply-To: <20260211-aw88261-fwname-v1-0-e24e833a019d@fairphone.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Weidong Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Ferrieux , Bhushan Shah , Bharadwaj Raju Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770805666; l=1451; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=O64Bv8tsAMjygJxOqAvbghMEW/OID2nPg5aDiw2JAmo=; b=l0mAytX0jWY9agCYFNdGfdJiZxt8eXnq5o9t+chjtb0Ha4Ns2Dqtmh2hsvZEVeTEU5UJMmnhX Uf2FjeO+lv4CgGRjzILPv7NFFMjpNQgRuysz98NogelOko4HSWnqU15 X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= From: Alexandre Ferrieux The aw88261_dev_reg_update() function sets the Awinic registers in a rather nonuniform way: - most registers get directly overwritten from the firmware blob - but a handful of them need more delicate logic to preserve some bits from their current value, according to a register- specific mask For the latter, the logic is basically NEW =3D (OLD & MASK) | (VAL & ~MASK) However, the ~MASK value is hand-computed, and in the specific case of the SYSCTRL register, in a buggy way. This patch restores the proper ~MASK value. Fixes: 028a2ae25691 ("ASoC: codecs: Add aw88261 amplifier driver") Signed-off-by: Alexandre Ferrieux --- sound/soc/codecs/aw88261.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c index 29b3fc8a1ea4..43c03d3cb252 100644 --- a/sound/soc/codecs/aw88261.c +++ b/sound/soc/codecs/aw88261.c @@ -424,9 +424,10 @@ static int aw88261_dev_reg_update(struct aw88261 *aw88= 261, if (ret) break; =20 + /* keep all three bits from current hw status */ read_val &=3D (~AW88261_AMPPD_MASK) | (~AW88261_PWDN_MASK) | (~AW88261_HMUTE_MASK); - reg_val &=3D (AW88261_AMPPD_MASK | AW88261_PWDN_MASK | AW88261_HMUTE_MA= SK); + reg_val &=3D (AW88261_AMPPD_MASK & AW88261_PWDN_MASK & AW88261_HMUTE_MA= SK); reg_val |=3D read_val; =20 /* enable uls hmute */ --=20 2.53.0 From nobody Sat Apr 18 03:33:26 2026 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FB5D367F4E for ; Wed, 11 Feb 2026 10:27:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805671; cv=none; b=PaiDuvs2edr1qJzC0FsAUgTLQ4IJyPs7yU73/pl6ay1nW4UcX9f4YYvab2/zt8DJE8TzLo462s24SUouTkFiQegJUi+xi1ApAfslaVVQRqwo3nxYTh5qq8rVNikolUggd06GiAlZIKW25eq/ILGt3gba80YTXz0OxTA4uJO5T/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805671; c=relaxed/simple; bh=81k4vDNl2gcK2y3l5OMOHs+wHy9IM6fpjbVqmXKA9Io=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bLABMzvRaiGwQKTMD3IY8jXEKkY/o1JXq+c3u7HAq++5h4QEhjSKR/BpgCGRbfzAfhL8w7+hGU8X+332u9FuPc/PKgpch3oUtwycPhEjcepnJp92GnBr4bYQ6vdGihiWObSHByvEeeqdHtEB9QGd6GGgX3gW3jT8QebTldSCq7U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=V0bB8fsn; arc=none smtp.client-ip=209.85.218.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="V0bB8fsn" Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-b885e8c679bso698556166b.1 for ; Wed, 11 Feb 2026 02:27:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1770805669; x=1771410469; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rBzLromM8fM+G/3XeZ5Gq0URj+zbmif8mTrB9fiboAE=; b=V0bB8fsn35jFn6xl4q1t917TvmoMTUX5M3DMhisfkFqsijVFlNs+c0qLhnyrymJwUd IDOD4wK7uRyEt6Rms+daf853JztUT1NYmR7OB23cBndBzvqPxlQG66SxmQWtGzwc6FSQ dLasFBLr3c4qXPvzUzOLNAPdvGzB2wSgT5Dgl1cpw+r/+k0PW+ZUh9X/IoM3qS52t/Jy nbQIbUmXhhS2VGTfwZ8ODPMJKGcrA+2+b/GwYbVJ6ac86Ybk4JW8EkNqUAc6mihu4BZ0 N1NCcJ/pViF1iRb/oWQZd6Hb68p/6RXBZUD6YJHtUn03CFYzyNCdhEf59R/Y9X/jVjqe 6gug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770805669; x=1771410469; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rBzLromM8fM+G/3XeZ5Gq0URj+zbmif8mTrB9fiboAE=; b=It+7C/05kWMy62j4NeHqY/NIQUvdYfRRQ7wOzdMavCemXQku7wmqznsTYqneSIU/Qe jYkaEcNZCpJyIwlhe2lvFya8OPq6vKRwftaw4vELeoXis6aI99ZtEs3MYMpTbmvDPO+J XiBFXIURs+l1ecyOlr3xn8RAiNpe+l80r1WwLHbX0we1rxMZLRm+LA90pdOGkhl9+UYs A1crXgH3YkJBedAgBBN9iRKHb8V/Y6N5uafhNCJw/SgR/jWin3iL708XsWIOkHJlq3DV 5+sAb6aD+TeuxN47BFldx0PyHeqhIWveR9MfOZCAstkBme0fG+hNpS/mJFg/hSOOKexV EhKA== X-Forwarded-Encrypted: i=1; AJvYcCW42B8osZmALQlZ/Ick3ZUMvP3mrdI1GnmGyzcXKBs+iFQkKpK45eaD26HnHuQnRKXXgMvrP9+UCgH58xQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwJJCuAYO/Yddg0bbJAFBHLvVY8ds/EDjSU269XX4aSanL0yiIY pN/hzJcD5zaNoFTmdXjZN481oMKEEUHcT8G6psQtmYY4ev2HAr58YMkkBqcFcSgVluo= X-Gm-Gg: AZuq6aLHP2/KKUVw6eGAavNxb6spS4CoDWvKg5QRNaz4GRLB4rkrRD50cQqi5KY2wuU 7vcbOn60JpLpc/Yz68tlO+mKLdYpuVX0ijC3tWQRUrRXqpn04ciZDkBKPqMXPg8tqCSfXTmbKe3 EoWGp7lSnaRQ/PaPMLycxDVL1Wt60rUJ159DGkS/poBFIEHA6J8ZtBxDjspRs259MEAsX4E5ElB 9fCEMJpOhcB2Oj0E4tANMdf52UpdLZX3rkpRHzOuJBbBBB9sVWsw1Q5sfaVHsR+co2kIeYJ4mu0 HXiIXnbVvZ68lYr3DYKsSeTZR73ffvLFm5F65TecFM+pgQg5LACIqX6ZtcMMMklEZMyM7uNKoiY aw6kODH5h1xlHux1nqOZXuTpIKxhsN1gNIzzGb775fJDjoax3vj+uWnWLdS1GtYQc1Ij4frA1dG j9zHnkFBhrRDV7+0yrIb2EgluqtqjXJtA7CRTEC1trd4slS2H2Q3JI0h+wTLsd7votAX5Vaesr8 pN6 X-Received: by 2002:a17:907:3f86:b0:b87:892:f440 with SMTP id a640c23a62f3a-b8f6adfa879mr131503966b.38.1770805668927; Wed, 11 Feb 2026 02:27:48 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8f6ec54925sm44296266b.53.2026.02.11.02.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 02:27:48 -0800 (PST) From: Luca Weiss Date: Wed, 11 Feb 2026 11:27:33 +0100 Subject: [PATCH 2/3] ASoC: dt-bindings: awinic,aw88395: Document firmware-name property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260211-aw88261-fwname-v1-2-e24e833a019d@fairphone.com> References: <20260211-aw88261-fwname-v1-0-e24e833a019d@fairphone.com> In-Reply-To: <20260211-aw88261-fwname-v1-0-e24e833a019d@fairphone.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Weidong Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Ferrieux , Bhushan Shah , Bharadwaj Raju Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770805666; l=1023; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=81k4vDNl2gcK2y3l5OMOHs+wHy9IM6fpjbVqmXKA9Io=; b=+TuqGtOHKZbjaHLp9RSffmfo1Jo26IZ+ZHUsmxB6KmReKvO8wMOW/FZJTG9rdaSCMl90jfaEH oA8dZV13TgvCVcuXWr6ktGI8W9pKs1sPbXA8VJJpqU5TzlZQ+RkFJGI X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Since the aw88261_acf.bin file appears to be device-specific, add a firmware-name property so that devicetree users can point to a device-specific path to not conflict with other devices that might also ship a aw88261_acf.bin. Signed-off-by: Luca Weiss Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/sound/awinic,aw88395.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml b/= Documentation/devicetree/bindings/sound/awinic,aw88395.yaml index 994d68c074a9..b9abb10942ba 100644 --- a/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml +++ b/Documentation/devicetree/bindings/sound/awinic,aw88395.yaml @@ -35,6 +35,10 @@ properties: =20 dvdd-supply: true =20 + firmware-name: + maxItems: 1 + description: Name of the *_acf.bin file used for amplifier initializat= ion + awinic,audio-channel: description: It is used to distinguish multiple PA devices, so that different --=20 2.53.0 From nobody Sat Apr 18 03:33:26 2026 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3368536920D for ; Wed, 11 Feb 2026 10:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805672; cv=none; b=T+a2D94tbRYODckrRk8QDoX29HzTug3ylN9HnwIuXHZwkyMoOGmENUKfxKE/6XWhutAqjQT4Ej9GXGOkvbypusMORbaCwXdKRuVPS6hV01UawLHoMcaAH3BMvAHA3GcFs+BTWmkdSNWa2MdKjhuynUJdeyFqz0/dPmiInP9ZhXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770805672; c=relaxed/simple; bh=LSS8xHXXjdgfnfg+IhB2Un7XBoJ2Glmk2j5+t+KJVsY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hyNIftEwWiSk7DPn1F5ezj3U3uzRoJecjwLhCDtl9A81ugYcMgz943siBBJmJjAM5TqDRL4T6rKUOdghaXPmAztzOQszESIiIB0ayY4lAdGmpBnVbMfwp7O+erXT6ohCaQFO0gEQd8kOIWqJsl6VnXT06RswP7i1Ea2ELg/HQ0c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=mxfHft1p; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="mxfHft1p" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-b8876d1a39bso718462566b.1 for ; Wed, 11 Feb 2026 02:27:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1770805670; x=1771410470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HyC/uhMpICBVlM72cJz0mCT/cxqElCQ77i9jCBuDxhs=; b=mxfHft1pnSCMmEnx2rfKkZ40Ou8M47QTSCxyLfIcL4hUMVv2JAF2682GzYJVf9A4Uo Nek9ydSK8QND0iK1OFc393Mfqh/m8PLRAXUl2XmG+TjNse0YY3/SwuVkKDBIG6ul00Tv zgN1hi+js9a1CZHHlfCQLfOjYSil11MImWjIZA6kaNcsge8A0ELdbSk6/hdf5xMQ0QsA Ia2PLyBfGgG4lr5KOigzalP4GSmS+fXE2QAVzRF2J9HaPYfEJrrZErdaheU/IbX76bAZ AeYjyfcrbv7flX+LsF95xJxS9gB2RQ5sy5VWRF8Re74coDVwRYbsLYonGHeYXF8JHwoq zfrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770805670; x=1771410470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=HyC/uhMpICBVlM72cJz0mCT/cxqElCQ77i9jCBuDxhs=; b=ajy8DqKsBQMIWI2FxmCbbRyiQX0TZdIY1iD4+Mook/v9uGu1eqxqh0YOp6wv7ixTjc I9m1dHXNnuaG97/HBpawW6n4dWG8mWmEMX3TcUmC3TtyELBzKssIWt4hcjCnAUG8BMUd npYvrMY+3vXsgZ2LqY9EMGsb2rnPTL5gfozynF5EGfl+qPw1nTFyt+pPlNFH8v9vBFpu HL0aEnCmE4kjctsI2qu3cy29i6WKdtoeyIeBuxslkJKjdmKxtIbK1oqsAS5o+aScj/6F 0LhWZa59Wcq8erPR43yiVBnC1Xz7bKDc2HtikQuCkStsn5z7CNEy6UiPEdPCJFMlbaV2 3Qjw== X-Forwarded-Encrypted: i=1; AJvYcCWb1ayuCaYWoPbI0AuNblk3CEeF1SY+MwRL4+cj7c9iYha/ajRplOb2YgSbGjxBbemPBJEsakHtpRrMwg4=@vger.kernel.org X-Gm-Message-State: AOJu0YwXQXQNptByUW2WN4s1Mo2rm4y/WzJQFU275gs1Q+5G6+EXmfux ygbbpJe5UWY7r9STkCmjhq44jrWwyWzXq5WQCM+SUN8AL07ZkRQ4fjmrDkAU6ZUJ+8g= X-Gm-Gg: AZuq6aJfFaZuLVfZHwAiZxTtwwdoQ9oEU0LE4rQXFdFd7kmEpCtYJOzlXm+CyIbkHNl Z/S2TXp3RpGA+pKc25puyMAZcad5/a9l1LxdRDIs38x0vwoECXkfB4mTsHxrGVXyGf7+BLRGVjb qiQ4M3MXeCwGP+AFWJEK5iHJ3V3p69zq7pSiIrdUDtO8BzcEkXJKbJe6bTiftZYzWl0rrxOebyq zTpfIR3eqyfAP0/3KspDYH8uXS3MQIWz3tEZftHk0d7icwdxQRxHpAev3qiTXr+1Wybqxl8Buyq TbT7YokzNqfTd3/403zaqpf2lzrY7LXMox5sQAB0J8axeWdeH9ZWSxDO85lbwBEwzaHKqOe8Dkm iIqso2o6cQNmC5tJGhAZpdJ9CUmFf5U1pj9JTpUM7mBEPcgceTvk5BmqOclfr7+Nq+tUxKfqWSJ xOMzI0jkiAKV7pfezFDB4bF59YKPckn186w7zhjXf9oa93O4+6fD1Ktoly2sDi/4fukVJlc71us ln7 X-Received: by 2002:a17:907:3e09:b0:b8e:5e2:79fc with SMTP id a640c23a62f3a-b8f6a99e36cmr109556966b.14.1770805669543; Wed, 11 Feb 2026 02:27:49 -0800 (PST) Received: from [172.16.240.99] (144-178-202-138.static.ef-service.nl. [144.178.202.138]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8f6ec54925sm44296266b.53.2026.02.11.02.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 02:27:49 -0800 (PST) From: Luca Weiss Date: Wed, 11 Feb 2026 11:27:34 +0100 Subject: [PATCH 3/3] ASoC: codecs: aw88261: Add firmware-name support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260211-aw88261-fwname-v1-3-e24e833a019d@fairphone.com> References: <20260211-aw88261-fwname-v1-0-e24e833a019d@fairphone.com> In-Reply-To: <20260211-aw88261-fwname-v1-0-e24e833a019d@fairphone.com> To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Weidong Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Ferrieux , Bhushan Shah , Bharadwaj Raju Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770805666; l=2022; i=luca.weiss@fairphone.com; s=20250611; h=from:subject:message-id; bh=LSS8xHXXjdgfnfg+IhB2Un7XBoJ2Glmk2j5+t+KJVsY=; b=DO+9FE4+TyZEMocZyMhfmVlLC5hLI6z/jUitlHfPxB64stboPJ8HugEI1vT1cWUjHvlcbXygw et+wFv7LPYXAgfGsKcfhI5Fn+yz3zSOYr8U1/7PEbbh8/ZrtEekiK8t X-Developer-Key: i=luca.weiss@fairphone.com; a=ed25519; pk=O1aw+AAust5lEmgrNJ1Bs7PTY0fEsJm+mdkjExA69q8= Since the aw88261_acf.bin file appears to be device-specific, add firmware-name support so that devicetree users can point to a device-specific path to not conflict with other devices that might also ship a aw88261_acf.bin. Read the "firmware-name" property if available, and otherwise fall back to the generic name. Signed-off-by: Luca Weiss --- sound/soc/codecs/aw88261.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/aw88261.c b/sound/soc/codecs/aw88261.c index 43c03d3cb252..02f8c2bb2569 100644 --- a/sound/soc/codecs/aw88261.c +++ b/sound/soc/codecs/aw88261.c @@ -1094,17 +1094,22 @@ static int aw88261_dev_init(struct aw88261 *aw88261= , struct aw_container *aw_cfg static int aw88261_request_firmware_file(struct aw88261 *aw88261) { const struct firmware *cont =3D NULL; + const char *fw_name; int ret; =20 aw88261->aw_pa->fw_status =3D AW88261_DEV_FW_FAILED; =20 - ret =3D request_firmware(&cont, AW88261_ACF_FILE, aw88261->aw_pa->dev); + ret =3D device_property_read_string(aw88261->aw_pa->dev, "firmware-name",= &fw_name); + if (ret) + fw_name =3D AW88261_ACF_FILE; + + ret =3D request_firmware(&cont, fw_name, aw88261->aw_pa->dev); if (ret) return dev_err_probe(aw88261->aw_pa->dev, ret, - "load [%s] failed!", AW88261_ACF_FILE); + "load [%s] failed!", fw_name); =20 dev_info(aw88261->aw_pa->dev, "loaded %s - size: %zu\n", - AW88261_ACF_FILE, cont ? cont->size : 0); + fw_name, cont ? cont->size : 0); =20 aw88261->aw_cfg =3D devm_kzalloc(aw88261->aw_pa->dev, cont->size + sizeof= (int), GFP_KERNEL); if (!aw88261->aw_cfg) { @@ -1117,7 +1122,7 @@ static int aw88261_request_firmware_file(struct aw882= 61 *aw88261) =20 ret =3D aw88395_dev_load_acf_check(aw88261->aw_pa, aw88261->aw_cfg); if (ret) { - dev_err(aw88261->aw_pa->dev, "load [%s] failed !", AW88261_ACF_FILE); + dev_err(aw88261->aw_pa->dev, "load [%s] failed !", fw_name); return ret; } =20 --=20 2.53.0