From nobody Thu Apr 2 15:44:05 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48BC91F03EF for ; Wed, 11 Feb 2026 09:17:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770801455; cv=none; b=KQ8n0ZvxUH6nDDSxfG3+bT1zINEj7z5oOK+gRcpj0LRmYop1q5R/6W5DPCeLySurkIU7XOhAZHTF2Gxr7oIKz9uBwavwwiNzlVJLAKhWSoI624NzO6sTTRHGFCzD2dni5t9wFHh8+X2nNnfw/tYoSraG+jr2tyP6tGv+Zg0IpVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770801455; c=relaxed/simple; bh=IqxC+fDfJvofB7HPgQuP4gkjImzp0FHOVZc/ziGOgBY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=elgEuvrFa//KN0o99YYa+vDQEoXtWnZp6J3owgWE1xkAiex4wZnIa8BFj+Rht5kCNjfk4Z52MU/tmyb0C/4I+hAUSqfuqNYAMGDMwELN5AxJe6S966ZcIr3yh58bgAqEu4cJo375ujR6ognpfEPr5BpRhnsYFB/Wp37tj1iVUQs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=BHBPn6Py; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OqQ1cz9p; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="BHBPn6Py"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OqQ1cz9p" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61B9GLP9170009 for ; Wed, 11 Feb 2026 09:17:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=sOvJ6FChpp5sD+ZrIanvgz u1hubSgXdK+y6O5OIIiNs=; b=BHBPn6PyqHSKyjCaKCizbaFhzYsUUGpwiwuieH lkGa7derpYpGSc0fXhKEOnXbuWa+KhyWE6ifNfJOm6sKW5UJ0VojKHjqoAuActQU /u/oqBVY6ot7NdvS30YOdUP6uyqDAg10Qt4PNnuiOdqokTUYnnDhROJu9/2wXIXA HaO2BEBueC2bSSgcMl8kXQdyX7eGxUY/ss13tkJ/lg3ZdOZWXQntfrzjT8FzHS+B lypph/05BDviPjXOoF9aOn/pZv4eSEAO/2fvazSzxlYX0uaiLI80iRW1CyuSitKJ SK8Ho0Q6sXfu1JGC6ANEPz755SjDCPO0agQ4BWrZSIeSKXJA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c8f879dj7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Feb 2026 09:17:33 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8c70ed6c849so1780818485a.1 for ; Wed, 11 Feb 2026 01:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770801452; x=1771406252; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=sOvJ6FChpp5sD+ZrIanvgzu1hubSgXdK+y6O5OIIiNs=; b=OqQ1cz9pSTdQciDq7p1h3X0BnXyEnEXmhSfapGW/1tP3DkN3U/mHeUklZgXAtOA07L twk5+QHiZUc7Jhb8ReVvTszE7uJt7Uekg4VI5m55u1v3+FF6FkHXcoZcqlmFB2mxUppB m0Lmgxv8pY5EQfmGgBDvYZ4r7G4LNdaABL6amB1UymD+TJ3xKHn2HauhR0dM6FzSk3/5 BqJJYRK7deyrYAeP57WMhN8j+83FgfzBiYi0KJfDzJyIE63sEWozXsJlywdzDyTmj0ZX nNsVqGPh+Hmz38mPbwc09Ro7eOqEtkNmqZ0x6s6V0yWIbfIh/nOJv5gk/YXQ9xt4A+A3 /kXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770801452; x=1771406252; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sOvJ6FChpp5sD+ZrIanvgzu1hubSgXdK+y6O5OIIiNs=; b=Tr5V5Hfnbar2gjXoJWt0dU/w4fRDaFawMrOeHHZjn6DkGVhr0upeUeLAL62QSOWMZE rkVq9UuUQdgaNMzbiYVSvKm9bWoofgIFpf8h9BXe5FAcBxtzGvyMxOmI2VaUr/Xuw+nv fn/2ycHal//3Twoz3MXby+o0DwIYW+Jl0lWgrc//Zhb9haCmeSSsuqS19ffnqNDo31Dk evBTHwGf4YEmQ+KTOsc61bsRrDN2AVBBMEggd9DN0gpNXZVe+c/XAViWlYBJjAzojRvk dyUdAndCpxruldoAhx0zc55cB323oD/ej0xGCya1vyaEsGF2PXXgfzvoLAw1tH3Re7gX tlEw== X-Forwarded-Encrypted: i=1; AJvYcCXsIHx75SjD20kqBTpyzbUQJp3J06hDgjjr8Dp7ffhvaxSYj0buf5y2LN5g6Qj2OuTR8/nw/WU0n9bexQY=@vger.kernel.org X-Gm-Message-State: AOJu0YyjI6lX1jPDTDGkcTIUEY2mxeLn6UIJ7OiZgl8zLedydWb+JG5J WfUqqWQJUSWVMsZc8APY6GQ5ojN+kZlKLAq3Uwe6eVLuVRwil5J14oz7m5C0LAdO3xayoQYEidj xnNzmv0vbSaJ2hsJbx9zr84J99dm752HrMGO/hMJt0YhyHmLaGY+ge070y7goZ+OA1k8= X-Gm-Gg: AZuq6aJ+a3RIMq0TRCF6VpcjWL0jl2yVCAXmTkpSzAVxZkWGNJlmO615IjX/3j5QjSy AoEYnAEnNRgte8KoLVtuvZ4KAw0IqqCQM1UTGUGNQSMMbljlM78I+ZDrHMFk3vBg2uR6gCxR6p3 +IWoXJtfRJ03jkcPxOku9N+ISY4BGEr5Fm9MEObmxzyAf8i7dHHmcGZLoK2QYxrNVWuuhQkNTCa 3ZsRGSY04QJ2ToTOLTgElV9GFhATlk8d/fwE1PFbO6mAYukNfBlFSu6sQGyMtxP1Is2ruJ7SGiN mpVP5y/fntQx4Wl6GGPpqKaY6xRzHy3C5j+lsDNEDXeHjkThx9lShLHHS8vq6i7Yzrqw7znnUlK bAnfPW5vEjr0WbK8rOLspnCaIl2gOd6G9Z5E/JSb7EIwIZOfDXODHwYmrcJD/rnQGLv2maPcJyh OKX+5ImMYdPA8rbdCbTzzdYvkeke05LP6jnsQ= X-Received: by 2002:a05:620a:4606:b0:8c6:a373:c4a1 with SMTP id af79cd13be357-8cb1f65b939mr646685085a.24.1770801452318; Wed, 11 Feb 2026 01:17:32 -0800 (PST) X-Received: by 2002:a05:620a:4606:b0:8c6:a373:c4a1 with SMTP id af79cd13be357-8cb1f65b939mr646681285a.24.1770801451640; Wed, 11 Feb 2026 01:17:31 -0800 (PST) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e5f5b2239sm213865e87.81.2026.02.11.01.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Feb 2026 01:17:31 -0800 (PST) From: Dmitry Baryshkov Date: Wed, 11 Feb 2026 11:17:27 +0200 Subject: [PATCH] drm: bridge: anx7625: correctly detect if PD can be disabled Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260211-anx7625-fix-pd-v1-1-1dd31451b06f@oss.qualcomm.com> X-B4-Tracking: v=1; b=H4sIACZJjGkC/x2MQQqAMAwEvyI5G2hStNSviAfRqLlUaUEE6d8NH meHnReKZJUCQ/NClluLnsmA2gaWY067oK7GwI57x0Q4pyf03OGmD14rhmh7JM/eE9jpymLmD45 TrR9YgHK5YAAAAA== X-Change-ID: 20260211-anx7625-fix-pd-792609132331 To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Xin Ji Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=2259; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=IqxC+fDfJvofB7HPgQuP4gkjImzp0FHOVZc/ziGOgBY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBpjEkqNlPFrg5gObDB7wYMnikVsy/c5WfpVDSej RmPDaCEDlOJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaYxJKgAKCRCLPIo+Aiko 1QPwB/0QRaZ5Y3MvNrnOBPr5oIiEOcHydh5N7mz+PVwmrUVPV7AAJadnHfXMDmG5Zo0LdBg1Tdd FbjbntwkXXNXXeVxEtQwA7ewSeTAI3HpE6DsffK++uH6GRb2Hks/9a+HwIgCL3EQHz157EQspm0 Mmb0rVuHcVeODiXFZD6MtJo4uzu4/KcgtJqcHnOsi/FwNHg6HHYmFrBdP2nDnr6YXNAmgc/+2V8 z+GOTzbAn9Q1w0tpVKZOmjDesEcEB7U9UI90PzTyVXKD6Luwp5EKMEFMYQMwbRSErkaxnFmXJSw uerstw2lpW4TX//cyNrp8WESeLvodqzlaXLAXnCHx8ICAZyB X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=KpNAGGWN c=1 sm=1 tr=0 ts=698c492d cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=Pfnx8xPYPUE69FR7zw8A:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjExMDA3NSBTYWx0ZWRfX9m2pNZ/juC/o vbb6V6fLExOkQPpoMh2viXZmjr+ggFWfAOetu32xU4cEAk7ZyW+5KDxNxHzEpqG3HZoChXzIbzp zwvElPORNC+TFl4spINlZjmJlTaeTM4GACdrMhx8wpTf6pQQIFHW7WFz4FTGlVLR/JVUryRQ+aW L5uw26f7WxBwhN4f5Dj1zIlPO5V4YpteZI2wQX0em5jpLWAVHEu/eATmNOcs6JrB2JNuMELIMF1 SvtT6V39s8cTttOVB2e8i1JnE/PyDJwOwY5Ms8jjwe1nCwYy259+CV1bmEa7da+h+QHTdnLcZyO 1YH+azZgCqz2smIjlmnT3R1ppUCJsNOOmucrWX+2SxlTkhLBuzy6QW+TN/4F5nqLRaPZN8LDk23 ORetDVJsQuYLtme0ARrkdscSG5NDqcOS67gOB9wjXDuco7BCRWXgeP1VozvHKCp7GBpCNxuZvc+ z0rDGjWtusOTCOlbIZA== X-Proofpoint-GUID: iir6YeEbIJubo0TzpwUj-AAgOOFCgUGo X-Proofpoint-ORIG-GUID: iir6YeEbIJubo0TzpwUj-AAgOOFCgUGo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_03,2026-02-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 phishscore=0 adultscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602110075 During initial checks the ANX7625 bridge can be powered on before setting up the Type-C port. At this point, when anx7625_ocm_loading_check() checks if it can disable PD or not, it will notice that typec_port is not set and disable PD, breaking orientation and HPD handling. Unify the check between anx7625_ocm_loading_check() anx7625_i2c_probe() and anx7625_typec_register() and check for the presence of the "connector" node. Fixes: 8ad0f7d2e6fd ("drm: bridge: anx7625: implement message sending") Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Tested-by: Loic Poulain --- drivers/gpu/drm/bridge/analogix/anx7625.c | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/br= idge/analogix/anx7625.c index c43519097a45..1157a58cf1b1 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1363,6 +1363,18 @@ static void anx7625_configure_hpd(struct anx7625_dat= a *ctx) anx7625_hpd_timer_config(ctx); } =20 +static bool anx7625_need_pd(struct anx7625_data *ctx) +{ + struct fwnode_handle *fwnode; + + fwnode =3D device_get_named_child_node(ctx->dev, "connector"); + if (!fwnode) + return false; + + fwnode_handle_put(fwnode); + return true; +} + static int anx7625_ocm_loading_check(struct anx7625_data *ctx) { int ret; @@ -1378,7 +1390,7 @@ static int anx7625_ocm_loading_check(struct anx7625_d= ata *ctx) if ((ret & FLASH_LOAD_STA_CHK) !=3D FLASH_LOAD_STA_CHK) return -ENODEV; =20 - if (!ctx->typec_port) + if (!anx7625_need_pd(ctx)) anx7625_disable_pd_protocol(ctx); anx7625_configure_hpd(ctx); =20 @@ -2924,12 +2936,7 @@ static int anx7625_i2c_probe(struct i2c_client *clie= nt) } =20 if (!platform->pdata.low_power_mode) { - struct fwnode_handle *fwnode; - - fwnode =3D device_get_named_child_node(dev, "connector"); - if (fwnode) - fwnode_handle_put(fwnode); - else + if (!anx7625_need_pd(platform)) anx7625_disable_pd_protocol(platform); =20 anx7625_configure_hpd(platform); --- base-commit: 400a84e1f7a3681ef24d58d49b5d07e81c14f4e9 change-id: 20260211-anx7625-fix-pd-792609132331 Best regards, --=20 With best wishes Dmitry