From nobody Thu Apr 2 17:09:59 2026 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazon11020108.outbound.protection.outlook.com [52.101.196.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35073336ED2 for ; Tue, 10 Feb 2026 21:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.196.108 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770757649; cv=fail; b=IXF6d5kHldDfUZ0SbRtKfFehspUhNb5c1jqjlr4EWoJNQ5ubLbFU3phBJy+a9LzWPUZ83K+rXAhy5WWLEoQzSLgn6DWhJ0IwVmM9wX7RB+/SsCsFlcN/KsRMC22L57jhn140iIctDH2uzEESNO6BWRD+gPyHKjot+4d551NW3Cg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770757649; c=relaxed/simple; bh=Gg+FWebNz9EHQ6nDg0UVdcGGY8ynAcRTURT/Ilf8ZSo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=bf+F/3vDdT3hZ6u5HDBpx0jLQLSuAtO4OSpIfoQmTTDAufsF3dGnqRFZ9UCmYtQnb+qUjxH1I6xQ7g/S6AgYP3beRBiSiPo9CrJfJ3FMYQ1aqKOQdErNOAlL9UhIdO+nVpxkV2OqGTO258SL7ytjJ1n8xaCi6ARNQgG52WQGIrA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com; spf=pass smtp.mailfrom=atomlin.com; arc=fail smtp.client-ip=52.101.196.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=atomlin.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e1awOje0clnTemHvRxw5qYSNBZ/wLwTSfm1Cf5U2aG9JWe1pzVAkZumdVy2SpXfdC/DoOrEl07ZciG85uGH5ToX43kKxiI+1h3um+n/oy3Nrx5g+TkR7ZJ8EDEOEaggldyOoMjg3zGPwuTB06JePoK28wiPonjQ3Ib9x1BZk9Etlru5TIU9uW8AGUCMfyoGko2uJXCAjFVjDAjf/ROpGUJbYEwL38omo4ecrkKQzoq2eGEDlDxyAurSImmvIAt0u7kanGxM3pCunye2KapuprBurOthvliPw6gfykzFTfAGFOJuzFWA0QC7c/Rgj3FBvkV7ZZRNrwqbl5sLXAgpz0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nYHrHhdNxrOHSs0NjoMfpPyDd0NWBTnXhk9NHrE43k0=; b=GlaLvqn14ZGIEch3wb9rvZAz6YAQyDcHtwcobAQqtgKbEJBIOsW+9d9+wW/1sleqlnxyKTSeIF86N83EAwE8aNgW0KtkgS41tGGbvR2ka9BxcY68H7msswyz9fjmF7YyQzQIsl0KNuSlIUdw/0tQ76ffvWVMJgAac6TE6jE7iGyzhBVhPusMEzEyslkTa8zwwUu60X3fmnqvcfES/mpcyM/rqA1JIyCGVmCHdnxOdx8WF1xuO/wqau2/PVe3ospDYUufaIkNdsIESmrHqyvR4hhg5iIhUACCYCmGROT2Qns4ASBJsrXePVArcA8I33YlsnAb25P7jH3gDSB/j6WJQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atomlin.com; dmarc=pass action=none header.from=atomlin.com; dkim=pass header.d=atomlin.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=atomlin.com; Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) by CWLP123MB6528.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:186::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8; Tue, 10 Feb 2026 21:07:27 +0000 Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf]) by CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf%2]) with mapi id 15.20.9587.013; Tue, 10 Feb 2026 21:07:26 +0000 From: Aaron Tomlin To: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: dave.martin@arm.com, sean@ashe.io, neelx@suse.com, mproche@gmail.com, chjohnst@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/2] fs/resctrl: Report invalid domain ID when parsing io_alloc Date: Tue, 10 Feb 2026 16:07:16 -0500 Message-ID: <20260210210717.3866344-2-atomlin@atomlin.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260210210717.3866344-1-atomlin@atomlin.com> References: <20260210210717.3866344-1-atomlin@atomlin.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0084.namprd13.prod.outlook.com (2603:10b6:208:2b8::29) To CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB3523:EE_|CWLP123MB6528:EE_ X-MS-Office365-Filtering-Correlation-Id: 3674870a-afe9-49a7-cd67-08de68e86458 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4yiVt+kup5VbQJHE2tWY0EPzjPIqP+r9ORRoJWvMO3euN4Bqprd7e7TkRKjy?= =?us-ascii?Q?RdPCtrCD5w4i3R7xEGH4tdpCZgjDZtRsa/6sbJxtGlYNMALhHvoLpf2GBZoy?= =?us-ascii?Q?9qYo3MGVIjlVdnc1OGw3MTgfImamD5L0XQTQ48AE+RS7+4SVAPupXqX0obD5?= =?us-ascii?Q?8TxCuryTQnz/1rTIA8InhHp2UL6P8l4H4opgUbRwqysY9uoUDu/6PqTxRJoS?= =?us-ascii?Q?/9AUkZI9wP6xUxXJTmRg9L5bu5/NKRomPq2a48m+2p9h7C75xGgiRqy1xw7h?= =?us-ascii?Q?KNHTaA3wD8aQbhnno+gRYxTJG+P/7mWUofrPK1yQ1WEYL4yKz2PwiPNuBLp3?= =?us-ascii?Q?gTqb94kgC2lm093X8RUG344Meq9mwZB5mGaVDMKxF9AaUQCtajcDQ3L9+7P6?= =?us-ascii?Q?3t3M6n6phikHCcom7npW+eNFPqtEL6mD9PHrwSM8KTIsqeJhKFIC/r6Ms5cO?= =?us-ascii?Q?4lzsOMjqSG1K74G6XAnz0OL4u9DfHR9GJUIl3WykWhd58bqNn10dcYrDaTis?= =?us-ascii?Q?dTcqGYIO3DL5FxZ3HKAj46C3EaxAJuIuI/y1FgQZCqQt8MO7tJgdkqkJEhdT?= =?us-ascii?Q?ffcQE2xxklQKYqsDXuPePDzgCOEyTpMv9wj5D+dEfjWjPIwcG2UE61KgZuFc?= =?us-ascii?Q?fRta1Xvbc2f7N/aVHHNHCxHXrcL11eEHPmC6iNhYZKnUGeFLKKgtfA6XnHeR?= =?us-ascii?Q?RhxYELy2W/WxOxr3JkCjfz/+utI05tlxdTPG0L5je8f+q0nQkb2t9gPMMpqp?= =?us-ascii?Q?h5HfDs0EVowaUHwco3vGlm8rPLBG2aOY9+UCMsYKicR8mxcaFZx54iTQzeZE?= =?us-ascii?Q?NrVQO0XT2XmK8tvmYee519uIF2OnUzNVDalbyhvgIVOjzO3kEx0u+iPaWMPd?= =?us-ascii?Q?6UACy8PeEwY8LLP3oovv8lFRIxbOMFxxpRdqQZzuqjH2dBm+e1DJfaFvVQY3?= =?us-ascii?Q?DdU2Ju0IXguoZxGE7ZkYBuNCAUmLgcWaEuNMTYEjrKFxqTH5dsZOOSlmRue0?= =?us-ascii?Q?8D3rjBofB8kRD5ZcogRKzpxzEvpfzK6+s45sDug5kNmDVNOL99nRnLyfrvjp?= =?us-ascii?Q?02sUcWN2vJx0x5BzZI6z6AGpv2TmDpmRmSNSEocknBwPYjSEepcAB2xGDK2u?= =?us-ascii?Q?liZjmXYVsh8p+A5rbUbKjz9tPnxTdxRbPaguEnzsjf0G8/0jRODGmURl7xop?= =?us-ascii?Q?CRRrXnrH+K9i8ScmZAPOSiCkzM67gaedGwJ0Ubd0T7lzZq9w8qTMjLqU19nh?= =?us-ascii?Q?rRiTwgoylPhRhREn3axdTZzKda9aoK/+2QH8/ZHnakmf3Ck6ct/qmGpyr+1Q?= =?us-ascii?Q?7kWkGw5uqqDKYoURBuhqTfwKK9647DVBwPVMNdk10Cda6AKu3sUv8zlV4Dcz?= =?us-ascii?Q?eZ30wypTF1f4iu78v7R/wXqK/wKqnd9uQcvfyE1NcMZeX3czqPofWuNID3y7?= =?us-ascii?Q?9+ANul+RHLnnrUbld8+NtgkVZY5RfQ42KXwtOWXbhGYDm1QQKeWBtmgdbQPb?= =?us-ascii?Q?gef+gg/tg49YVaUNSPbJ135T2c+ZhdhGKZ3Lpqxmo4pwnhJMYMalhc5hAB5V?= =?us-ascii?Q?AOUF3luBEFu0hBEBNbQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(1800799024)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wRAJMh6Bgv1vR3g2G4vchBF/oOzCDTUAtmGBSK89wzKLTMUjKxn9MrF6ZVdI?= =?us-ascii?Q?YQ1SnCc+JUPK6yvVVQDQz3EV6o4h46MJuIRGorlcDvZKioOo2gEEbWPQ6wd+?= =?us-ascii?Q?P951O6IEjBcX0wxxafUyJOpaxgfW4FnUqof9EU8iXyDqsu8gk32xe8KPRL2O?= =?us-ascii?Q?JuavKqTYLEw+qTAuqHleoOMlWKIx1mHrQQxGc8+GNzBEWCQVu/WS9PzjklFA?= =?us-ascii?Q?/biIEzfYel2Zjp5+TWVeE50Sht7E8rJlh/ElNUxw9Q6YhM//Hb/G6XelOAxH?= =?us-ascii?Q?hUSlGKGlM5AoXOr2WwooKMu636ZonTOk7JyIFJlZVJWRKP2ociJElOe8UXRO?= =?us-ascii?Q?hnrs9XTqhOJx5T4876EIfE1Pk577cDo0wuGt2zhp/KSlKpWh3HWhTEWaIMx+?= =?us-ascii?Q?9mgrm2n0isC5UCVYuVuv4WHZBLJ5cFGwbSpCWkuq+Mp4eOZhWh//U9ZMfILe?= =?us-ascii?Q?eqT6gXxFN3j0vseMvd8ZCgfh5drzCN5bBrtfpQ2uP4RNKxlBy0XixQiziOqS?= =?us-ascii?Q?Ycd5ivKGN7DIgBu6FNAd22o3kSTp4yuacdqLEq98gkP3pnSY30NUaEEIm5hI?= =?us-ascii?Q?zQg/2qXZ+SNCZzb4/u4P2hjukczKqQ7jmlgurD49RxQIiCh4LzSN/JvBY1+y?= =?us-ascii?Q?4LD/eUhIYV3ZKmiCio0JlrsUMrL3m+WvHhSvPUbODKhHLdOhavvZ6a1vDztj?= =?us-ascii?Q?UX7KrpasFuFz8pKJ12B6L9wzPpDTswM4mdv5eVe/OIPtWR/bxCF24vT6+fQj?= =?us-ascii?Q?ljL+Hygp+dgme2ek60t9Wd78yDaw3kJV5dn6rTSjGwCE8cKE39hcFkjjJA/q?= =?us-ascii?Q?Dv2W7i/kOT/SEZMUkp2z+SfqIC1gTNuMpv0opjmbaK1R1xLJ3NyULYIi7i6k?= =?us-ascii?Q?fVrMhXJ4Y5yUSkcy7I25L0J42TRH62HVkqW94Qzo41bWwJI1YBtEpBrrf7ON?= =?us-ascii?Q?NSZ+RtEOvdnMPr3dmUDOK1iTmP5SVrys3wZHYdzDt2/JVBR6HXJZFu9TfirD?= =?us-ascii?Q?PZCU+asBlZzw9IQ2kKlNeoFWWyYaKMa9gh1ga3SvPH0hX9+xyz4lZPNaCVBb?= =?us-ascii?Q?XSE2tgAFfzgJKA+IRH6aeMdbDxlPWJWHtRoyK58GrNsOGrTWC7A2VCf02hYX?= =?us-ascii?Q?ZQM4reaXK3FCqACZ8IkInME75Mf7wqV87uWDAbaNgOSuOHmVwlzgi99DiTeN?= =?us-ascii?Q?RtEuMiHoXR9KSoNr//q9qbNBGovH3T5bzvG12Nx1hNFDe/eKcUqyzAla8oLv?= =?us-ascii?Q?xdluOVWMY28sWfo9t1hK2XyumMIg7Fi7T1KkmzkqONlE5R6XgEEstKVqAkZf?= =?us-ascii?Q?FFaysi8qd2CFd1/d8119oCMiIQ6EPZXmGGLwONDiIoL6CHJcoOLb69H8Zvmi?= =?us-ascii?Q?nlHugpDL3nIqbCLptTuU7Z4uJ5t9eBswpI8ElZ8SqwV5/uW6/qUb/FEbByok?= =?us-ascii?Q?ckrLORY74/8YTt6eUGnc3hKLqYbjG/Np3EKVRch+2caB3tiyddM+1Q5aqCtb?= =?us-ascii?Q?LdGn8PSuNo/x/ZB7PubZGQa01DFYOh9bQ56f0L144D1pdjj9FkySH6/MsgR3?= =?us-ascii?Q?sdjG0xlxkoQTIazbe8y0liAR23reNnyt9muY7W5ZHtysA1WPYcMySBgi0EQs?= =?us-ascii?Q?vYONRbjh+FRsVw/Vk0FzyV5FkyKNqnho5wNrIM39TW3Y98uwQhAXNwF9K+Zl?= =?us-ascii?Q?FiWN+bbZDoFlb8ED7nFa34jZ9S6APyidjRVUhqv5sxbsizScCLtHhySG7Ohg?= =?us-ascii?Q?GTscay70yg=3D=3D?= X-OriginatorOrg: atomlin.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3674870a-afe9-49a7-cd67-08de68e86458 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2026 21:07:26.9070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e6a32402-7d7b-4830-9a2b-76945bbbcb57 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NCCNALqUCAhPWgea5ogm1vEqwiXdEteAyxRDLzR0SZdYdFns0xpg8SIJzdEAI8R14Fhq5E8zL4qpLShiUofiQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB6528 Content-Type: text/plain; charset="utf-8" The last_cmd_status file is intended to report details about the most recent resctrl filesystem operation, specifically to aid in diagnosing failures. However, when parsing io_alloc_cbm, if a user provides a domain ID that does not exist in the resource, the operation fails with -EINVAL without updating last_cmd_status. This results in inconsistent behaviour where the system call reports an error, but the status file may misleadingly report "ok" (retained from a previous successful operation), leaving the user unaware that the failure was caused by an invalid domain ID. Update resctrl_io_alloc_parse_line() to explicitly write an error message to last_cmd_status when the target domain ID cannot be found. Suggested-by: Reinette Chatre Fixes: 28fa2cce7a83 ("fs/resctrl: Introduce interface to modify io_alloc ca= pacity bitmasks") Signed-off-by: Aaron Tomlin --- fs/resctrl/ctrlmondata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index b2d178d3556e..b96b661626c2 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -907,6 +907,7 @@ static int resctrl_io_alloc_parse_line(char *line, str= uct rdt_resource *r, } } =20 + rdt_last_cmd_printf("Invalid domain %lu\n", dom_id); return -EINVAL; } =20 --=20 2.51.0