From nobody Thu Apr 2 15:36:14 2026 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazon11020108.outbound.protection.outlook.com [52.101.196.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35073336ED2 for ; Tue, 10 Feb 2026 21:07:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.196.108 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770757649; cv=fail; b=IXF6d5kHldDfUZ0SbRtKfFehspUhNb5c1jqjlr4EWoJNQ5ubLbFU3phBJy+a9LzWPUZ83K+rXAhy5WWLEoQzSLgn6DWhJ0IwVmM9wX7RB+/SsCsFlcN/KsRMC22L57jhn140iIctDH2uzEESNO6BWRD+gPyHKjot+4d551NW3Cg= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770757649; c=relaxed/simple; bh=Gg+FWebNz9EHQ6nDg0UVdcGGY8ynAcRTURT/Ilf8ZSo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=bf+F/3vDdT3hZ6u5HDBpx0jLQLSuAtO4OSpIfoQmTTDAufsF3dGnqRFZ9UCmYtQnb+qUjxH1I6xQ7g/S6AgYP3beRBiSiPo9CrJfJ3FMYQ1aqKOQdErNOAlL9UhIdO+nVpxkV2OqGTO258SL7ytjJ1n8xaCi6ARNQgG52WQGIrA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com; spf=pass smtp.mailfrom=atomlin.com; arc=fail smtp.client-ip=52.101.196.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=atomlin.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=e1awOje0clnTemHvRxw5qYSNBZ/wLwTSfm1Cf5U2aG9JWe1pzVAkZumdVy2SpXfdC/DoOrEl07ZciG85uGH5ToX43kKxiI+1h3um+n/oy3Nrx5g+TkR7ZJ8EDEOEaggldyOoMjg3zGPwuTB06JePoK28wiPonjQ3Ib9x1BZk9Etlru5TIU9uW8AGUCMfyoGko2uJXCAjFVjDAjf/ROpGUJbYEwL38omo4ecrkKQzoq2eGEDlDxyAurSImmvIAt0u7kanGxM3pCunye2KapuprBurOthvliPw6gfykzFTfAGFOJuzFWA0QC7c/Rgj3FBvkV7ZZRNrwqbl5sLXAgpz0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nYHrHhdNxrOHSs0NjoMfpPyDd0NWBTnXhk9NHrE43k0=; b=GlaLvqn14ZGIEch3wb9rvZAz6YAQyDcHtwcobAQqtgKbEJBIOsW+9d9+wW/1sleqlnxyKTSeIF86N83EAwE8aNgW0KtkgS41tGGbvR2ka9BxcY68H7msswyz9fjmF7YyQzQIsl0KNuSlIUdw/0tQ76ffvWVMJgAac6TE6jE7iGyzhBVhPusMEzEyslkTa8zwwUu60X3fmnqvcfES/mpcyM/rqA1JIyCGVmCHdnxOdx8WF1xuO/wqau2/PVe3ospDYUufaIkNdsIESmrHqyvR4hhg5iIhUACCYCmGROT2Qns4ASBJsrXePVArcA8I33YlsnAb25P7jH3gDSB/j6WJQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atomlin.com; dmarc=pass action=none header.from=atomlin.com; dkim=pass header.d=atomlin.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=atomlin.com; Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) by CWLP123MB6528.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:186::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8; Tue, 10 Feb 2026 21:07:27 +0000 Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf]) by CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf%2]) with mapi id 15.20.9587.013; Tue, 10 Feb 2026 21:07:26 +0000 From: Aaron Tomlin To: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: dave.martin@arm.com, sean@ashe.io, neelx@suse.com, mproche@gmail.com, chjohnst@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH v5 1/2] fs/resctrl: Report invalid domain ID when parsing io_alloc Date: Tue, 10 Feb 2026 16:07:16 -0500 Message-ID: <20260210210717.3866344-2-atomlin@atomlin.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260210210717.3866344-1-atomlin@atomlin.com> References: <20260210210717.3866344-1-atomlin@atomlin.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BL1PR13CA0084.namprd13.prod.outlook.com (2603:10b6:208:2b8::29) To CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB3523:EE_|CWLP123MB6528:EE_ X-MS-Office365-Filtering-Correlation-Id: 3674870a-afe9-49a7-cd67-08de68e86458 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?4yiVt+kup5VbQJHE2tWY0EPzjPIqP+r9ORRoJWvMO3euN4Bqprd7e7TkRKjy?= =?us-ascii?Q?RdPCtrCD5w4i3R7xEGH4tdpCZgjDZtRsa/6sbJxtGlYNMALhHvoLpf2GBZoy?= =?us-ascii?Q?9qYo3MGVIjlVdnc1OGw3MTgfImamD5L0XQTQ48AE+RS7+4SVAPupXqX0obD5?= =?us-ascii?Q?8TxCuryTQnz/1rTIA8InhHp2UL6P8l4H4opgUbRwqysY9uoUDu/6PqTxRJoS?= =?us-ascii?Q?/9AUkZI9wP6xUxXJTmRg9L5bu5/NKRomPq2a48m+2p9h7C75xGgiRqy1xw7h?= =?us-ascii?Q?KNHTaA3wD8aQbhnno+gRYxTJG+P/7mWUofrPK1yQ1WEYL4yKz2PwiPNuBLp3?= =?us-ascii?Q?gTqb94kgC2lm093X8RUG344Meq9mwZB5mGaVDMKxF9AaUQCtajcDQ3L9+7P6?= =?us-ascii?Q?3t3M6n6phikHCcom7npW+eNFPqtEL6mD9PHrwSM8KTIsqeJhKFIC/r6Ms5cO?= =?us-ascii?Q?4lzsOMjqSG1K74G6XAnz0OL4u9DfHR9GJUIl3WykWhd58bqNn10dcYrDaTis?= =?us-ascii?Q?dTcqGYIO3DL5FxZ3HKAj46C3EaxAJuIuI/y1FgQZCqQt8MO7tJgdkqkJEhdT?= =?us-ascii?Q?ffcQE2xxklQKYqsDXuPePDzgCOEyTpMv9wj5D+dEfjWjPIwcG2UE61KgZuFc?= =?us-ascii?Q?fRta1Xvbc2f7N/aVHHNHCxHXrcL11eEHPmC6iNhYZKnUGeFLKKgtfA6XnHeR?= =?us-ascii?Q?RhxYELy2W/WxOxr3JkCjfz/+utI05tlxdTPG0L5je8f+q0nQkb2t9gPMMpqp?= =?us-ascii?Q?h5HfDs0EVowaUHwco3vGlm8rPLBG2aOY9+UCMsYKicR8mxcaFZx54iTQzeZE?= =?us-ascii?Q?NrVQO0XT2XmK8tvmYee519uIF2OnUzNVDalbyhvgIVOjzO3kEx0u+iPaWMPd?= =?us-ascii?Q?6UACy8PeEwY8LLP3oovv8lFRIxbOMFxxpRdqQZzuqjH2dBm+e1DJfaFvVQY3?= =?us-ascii?Q?DdU2Ju0IXguoZxGE7ZkYBuNCAUmLgcWaEuNMTYEjrKFxqTH5dsZOOSlmRue0?= =?us-ascii?Q?8D3rjBofB8kRD5ZcogRKzpxzEvpfzK6+s45sDug5kNmDVNOL99nRnLyfrvjp?= =?us-ascii?Q?02sUcWN2vJx0x5BzZI6z6AGpv2TmDpmRmSNSEocknBwPYjSEepcAB2xGDK2u?= =?us-ascii?Q?liZjmXYVsh8p+A5rbUbKjz9tPnxTdxRbPaguEnzsjf0G8/0jRODGmURl7xop?= =?us-ascii?Q?CRRrXnrH+K9i8ScmZAPOSiCkzM67gaedGwJ0Ubd0T7lzZq9w8qTMjLqU19nh?= =?us-ascii?Q?rRiTwgoylPhRhREn3axdTZzKda9aoK/+2QH8/ZHnakmf3Ck6ct/qmGpyr+1Q?= =?us-ascii?Q?7kWkGw5uqqDKYoURBuhqTfwKK9647DVBwPVMNdk10Cda6AKu3sUv8zlV4Dcz?= =?us-ascii?Q?eZ30wypTF1f4iu78v7R/wXqK/wKqnd9uQcvfyE1NcMZeX3czqPofWuNID3y7?= =?us-ascii?Q?9+ANul+RHLnnrUbld8+NtgkVZY5RfQ42KXwtOWXbhGYDm1QQKeWBtmgdbQPb?= =?us-ascii?Q?gef+gg/tg49YVaUNSPbJ135T2c+ZhdhGKZ3Lpqxmo4pwnhJMYMalhc5hAB5V?= =?us-ascii?Q?AOUF3luBEFu0hBEBNbQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(1800799024)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wRAJMh6Bgv1vR3g2G4vchBF/oOzCDTUAtmGBSK89wzKLTMUjKxn9MrF6ZVdI?= =?us-ascii?Q?YQ1SnCc+JUPK6yvVVQDQz3EV6o4h46MJuIRGorlcDvZKioOo2gEEbWPQ6wd+?= =?us-ascii?Q?P951O6IEjBcX0wxxafUyJOpaxgfW4FnUqof9EU8iXyDqsu8gk32xe8KPRL2O?= =?us-ascii?Q?JuavKqTYLEw+qTAuqHleoOMlWKIx1mHrQQxGc8+GNzBEWCQVu/WS9PzjklFA?= =?us-ascii?Q?/biIEzfYel2Zjp5+TWVeE50Sht7E8rJlh/ElNUxw9Q6YhM//Hb/G6XelOAxH?= =?us-ascii?Q?hUSlGKGlM5AoXOr2WwooKMu636ZonTOk7JyIFJlZVJWRKP2ociJElOe8UXRO?= =?us-ascii?Q?hnrs9XTqhOJx5T4876EIfE1Pk577cDo0wuGt2zhp/KSlKpWh3HWhTEWaIMx+?= =?us-ascii?Q?9mgrm2n0isC5UCVYuVuv4WHZBLJ5cFGwbSpCWkuq+Mp4eOZhWh//U9ZMfILe?= =?us-ascii?Q?eqT6gXxFN3j0vseMvd8ZCgfh5drzCN5bBrtfpQ2uP4RNKxlBy0XixQiziOqS?= =?us-ascii?Q?Ycd5ivKGN7DIgBu6FNAd22o3kSTp4yuacdqLEq98gkP3pnSY30NUaEEIm5hI?= =?us-ascii?Q?zQg/2qXZ+SNCZzb4/u4P2hjukczKqQ7jmlgurD49RxQIiCh4LzSN/JvBY1+y?= =?us-ascii?Q?4LD/eUhIYV3ZKmiCio0JlrsUMrL3m+WvHhSvPUbODKhHLdOhavvZ6a1vDztj?= =?us-ascii?Q?UX7KrpasFuFz8pKJ12B6L9wzPpDTswM4mdv5eVe/OIPtWR/bxCF24vT6+fQj?= =?us-ascii?Q?ljL+Hygp+dgme2ek60t9Wd78yDaw3kJV5dn6rTSjGwCE8cKE39hcFkjjJA/q?= =?us-ascii?Q?Dv2W7i/kOT/SEZMUkp2z+SfqIC1gTNuMpv0opjmbaK1R1xLJ3NyULYIi7i6k?= =?us-ascii?Q?fVrMhXJ4Y5yUSkcy7I25L0J42TRH62HVkqW94Qzo41bWwJI1YBtEpBrrf7ON?= =?us-ascii?Q?NSZ+RtEOvdnMPr3dmUDOK1iTmP5SVrys3wZHYdzDt2/JVBR6HXJZFu9TfirD?= =?us-ascii?Q?PZCU+asBlZzw9IQ2kKlNeoFWWyYaKMa9gh1ga3SvPH0hX9+xyz4lZPNaCVBb?= =?us-ascii?Q?XSE2tgAFfzgJKA+IRH6aeMdbDxlPWJWHtRoyK58GrNsOGrTWC7A2VCf02hYX?= =?us-ascii?Q?ZQM4reaXK3FCqACZ8IkInME75Mf7wqV87uWDAbaNgOSuOHmVwlzgi99DiTeN?= =?us-ascii?Q?RtEuMiHoXR9KSoNr//q9qbNBGovH3T5bzvG12Nx1hNFDe/eKcUqyzAla8oLv?= =?us-ascii?Q?xdluOVWMY28sWfo9t1hK2XyumMIg7Fi7T1KkmzkqONlE5R6XgEEstKVqAkZf?= =?us-ascii?Q?FFaysi8qd2CFd1/d8119oCMiIQ6EPZXmGGLwONDiIoL6CHJcoOLb69H8Zvmi?= =?us-ascii?Q?nlHugpDL3nIqbCLptTuU7Z4uJ5t9eBswpI8ElZ8SqwV5/uW6/qUb/FEbByok?= =?us-ascii?Q?ckrLORY74/8YTt6eUGnc3hKLqYbjG/Np3EKVRch+2caB3tiyddM+1Q5aqCtb?= =?us-ascii?Q?LdGn8PSuNo/x/ZB7PubZGQa01DFYOh9bQ56f0L144D1pdjj9FkySH6/MsgR3?= =?us-ascii?Q?sdjG0xlxkoQTIazbe8y0liAR23reNnyt9muY7W5ZHtysA1WPYcMySBgi0EQs?= =?us-ascii?Q?vYONRbjh+FRsVw/Vk0FzyV5FkyKNqnho5wNrIM39TW3Y98uwQhAXNwF9K+Zl?= =?us-ascii?Q?FiWN+bbZDoFlb8ED7nFa34jZ9S6APyidjRVUhqv5sxbsizScCLtHhySG7Ohg?= =?us-ascii?Q?GTscay70yg=3D=3D?= X-OriginatorOrg: atomlin.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3674870a-afe9-49a7-cd67-08de68e86458 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2026 21:07:26.9070 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e6a32402-7d7b-4830-9a2b-76945bbbcb57 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NCCNALqUCAhPWgea5ogm1vEqwiXdEteAyxRDLzR0SZdYdFns0xpg8SIJzdEAI8R14Fhq5E8zL4qpLShiUofiQg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB6528 Content-Type: text/plain; charset="utf-8" The last_cmd_status file is intended to report details about the most recent resctrl filesystem operation, specifically to aid in diagnosing failures. However, when parsing io_alloc_cbm, if a user provides a domain ID that does not exist in the resource, the operation fails with -EINVAL without updating last_cmd_status. This results in inconsistent behaviour where the system call reports an error, but the status file may misleadingly report "ok" (retained from a previous successful operation), leaving the user unaware that the failure was caused by an invalid domain ID. Update resctrl_io_alloc_parse_line() to explicitly write an error message to last_cmd_status when the target domain ID cannot be found. Suggested-by: Reinette Chatre Fixes: 28fa2cce7a83 ("fs/resctrl: Introduce interface to modify io_alloc ca= pacity bitmasks") Signed-off-by: Aaron Tomlin --- fs/resctrl/ctrlmondata.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index b2d178d3556e..b96b661626c2 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -907,6 +907,7 @@ static int resctrl_io_alloc_parse_line(char *line, str= uct rdt_resource *r, } } =20 + rdt_last_cmd_printf("Invalid domain %lu\n", dom_id); return -EINVAL; } =20 --=20 2.51.0 From nobody Thu Apr 2 15:36:14 2026 Received: from LO3P265CU004.outbound.protection.outlook.com (mail-uksouthazon11020098.outbound.protection.outlook.com [52.101.196.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47076331226 for ; Tue, 10 Feb 2026 21:07:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.196.98 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770757655; cv=fail; b=JBLxoxCChYtww2bRvF61agmEmYo9sv54GzarMsIC1e8ytp27Eecv9TnGRO20dSB9kXvxQtOYTm4bdfFTjFobWky834em+sjhVTImLYIldDUqB2eLEOGExsFmA65bqaQExoJ24cUCI6Wwl8dQKvVfa4GcRocrNjEbo1TfG/sefVw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770757655; c=relaxed/simple; bh=AucnPCSuXvCDgtrU2uHbsbHZTtXaoGSW6Ob06I2QUzM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=luBp4emY1mc+g3J8E+lyQukI67oxSD+wWkPhKFaJ5BgEvP3l3RL/BQDQIy0JLBmbjAHBucV5RJ2ysQMz7bIub/tVUQ/EnQfau//DP+Fi83KNpMN0JqxpwJQY1EMIv2Sry1wFjZI2PpFoaLGF7SZ5Jlfk70Q9g1yC0tLZlBQKqus= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com; spf=pass smtp.mailfrom=atomlin.com; arc=fail smtp.client-ip=52.101.196.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=atomlin.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l0hiL+W5K/AeRwd0ED0HcbedT+YYsW0/9VvndeCGGkRXl8hOBEbBgrH7LCOAFwpbcldOKIRamDh0IrrXrXonjiG8S/Zud8Et4TGlwnLhudsTAx75iwHguyKxCpdTpwXvZGddy6HpjN27CrjHF5jYyKZPGYN9c0s29TiqJ0v7R1ICgAubqb99ahOhNxUKrr1a8SoLUCVfCxHnsPKXDquaNW5oounKGBjkqAjBhBTZPnrxi69b50L2SJVoBEcn1VWfknAnV+4Ki5ttME1bUCdTaWADXF2lAsjJP3Wif0ev2Ro7T55xXyUY1ZtrTmk6CED3MQHD2Sze8BYE/Vk5HLfPFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cgLYxkRdKJ1U1eRUeYEd+tRFe2qZ9X4E1AzxmZCxBrc=; b=ncTjs1d9tKylsw8yaEVJAHwUA9N5cfHfA/n8q/5rGBsyO2HVfkmX7dfdK5Di8eAhKhh9Cm49vM3weXWNyMP25VTds+JOgj/EDWQSlYqLCHuvMGYwXGTF7kJrvlJg6U5iDkGO+SbVJHRAfcAhCu/im2qFvKhuN9SAOtsrJBkAjWS94GnC4A5xbPvol8RyJLoj2NRMA2WZM1wTUCO6YBgYVMkLAAAf2XJ9UFq7HUBQFnvASM0pRO/rKZv+Fst2pBHxXgilXft3UifmLZem944XuUgUDEIKeEcQ2S4raGfVpwL283cti2Vu2yferG5hqrqAKaow4NU3a7JWn0IOSkbtng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=atomlin.com; dmarc=pass action=none header.from=atomlin.com; dkim=pass header.d=atomlin.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=atomlin.com; Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) by CWLP123MB6528.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:186::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.8; Tue, 10 Feb 2026 21:07:31 +0000 Received: from CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf]) by CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM ([fe80::de8e:2e4f:6c6:f3bf%2]) with mapi id 15.20.9587.013; Tue, 10 Feb 2026 21:07:31 +0000 From: Aaron Tomlin To: tony.luck@intel.com, reinette.chatre@intel.com, Dave.Martin@arm.com, james.morse@arm.com, babu.moger@amd.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com Cc: dave.martin@arm.com, sean@ashe.io, neelx@suse.com, mproche@gmail.com, chjohnst@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH v5 2/2] fs/resctrl: Add "*" shorthand to set io_alloc CBM for all domains Date: Tue, 10 Feb 2026 16:07:17 -0500 Message-ID: <20260210210717.3866344-3-atomlin@atomlin.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260210210717.3866344-1-atomlin@atomlin.com> References: <20260210210717.3866344-1-atomlin@atomlin.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: MN0P223CA0005.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:52b::22) To CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:70::10) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLP123MB3523:EE_|CWLP123MB6528:EE_ X-MS-Office365-Filtering-Correlation-Id: e3845f25-f09d-4b23-21b0-08de68e86760 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?10przJjD0lKaean0b19flWNUMd4REmoEljiL7SaPdxC4vKoBZDPZQ6aOH4zC?= =?us-ascii?Q?Tpy3BfFsMbvdSnwFAnTcI+iTvDOXZG4s77fsPouB+U096vLpmAZ3wLGv9rw8?= =?us-ascii?Q?9nECHTsay7mnmYh+l3rz20MQq7WzolH3VrxzmZBRITIk4O+kNl/f73yboFd8?= =?us-ascii?Q?AbEa3QhUZysFu58a5+VkQrj7OYDbT1UDwz71zvfTqLpfjm7H6cfS/XC7Nrf6?= =?us-ascii?Q?k3Yb1XaQEVoKDbfHwJFEiSm8e2pZIyuYDm4x6/R+v40njAM7wdTeloiEbMa5?= =?us-ascii?Q?zNnA2DsrAFqBIHDclhS0LyfZYiZ8TrO026KGMxWJ2+QREuChScPnAPtlLiDl?= =?us-ascii?Q?zFZjwx6h1Bjo6vR5pN7F1ukbqgoI+SxWfNPxDDipXSIAkwpvQ8vcc8XPHECY?= =?us-ascii?Q?cM+B/xsVaJLu4wuoVztUUIcdnsizP2bdpVMju9hne/2NfHfRQAOa+iywz+7r?= =?us-ascii?Q?tkn4e+M3AIsrnNzwhCLIL0WPV27jPGiJUhj+moZJrnv1ugEo2ytPwn6oWd/R?= =?us-ascii?Q?eaDBeiaJxgQQa1K8+2CKeSd60DfyKL/HPVdhWDACdS8IIZt2G0sE+jg+Xg3h?= =?us-ascii?Q?a5JSCvkAd3IMu7F4cNeLFIHtSKgfjAvwF1oZnLGB1LjqwcSEpCKZTXZNxxFs?= =?us-ascii?Q?mEu9U/7azVEdz+U8bQHZkacv9U6kt8AQDklmSgWkyor+3agPhe75VmPQwkDq?= =?us-ascii?Q?ZZS0WziRYlfYYPgM2dHjFbwe/wl6fAJmCqGtArmoOuGItPbEBJGRnyr5CVMW?= =?us-ascii?Q?oTag33Cult0NIb4Yj7Kubykshn21gC+4/9SlbOQhY+nlnaaFSHXrhull7ezN?= =?us-ascii?Q?3L237oOhGlD+PfE/W9ZCyOtK2y7WuNjR4J4mdNa9y9vrFuswUZQpdwRlA8u4?= =?us-ascii?Q?Z5Cu8PnhIJt8/l3rRVRR3uzn/T5TEMt3toWEQnd1/6JP9/V/iHxVdL5Bm5ec?= =?us-ascii?Q?0+oH+r3TGY4rX+U1tJ0RFroMITkC404Uozh1t2qKLsMDW0CaZ5EAmwIgGt5U?= =?us-ascii?Q?idQJpmzzXy+j9dJecw/Wgcrb8w2k68sZWQpEzBf9xWxdY7iWdS4pnR+0yKHu?= =?us-ascii?Q?L5CdGdLNpV3rE53Y4Xza0udgX5EHBoEs9veot0eWvfr9sAiS5AQAbNixRycN?= =?us-ascii?Q?FQBWmYu2+v7aBtpMxSGJgSxvFhTUmKs9XQ2/5B3XqTl5NP1d6XWlCxgx4mGH?= =?us-ascii?Q?Sh0894trydqpDN+LGe4wZvIVetYtWldwpw1PusU8DYFzdWUDkY75TPbVdfa2?= =?us-ascii?Q?jtMgpVaO4URzAb2K6yFeZrf3YsSkkGWSdpfKdB0pXN+z80CFjiWiNjkx+JA+?= =?us-ascii?Q?AyKjuPAt9dWmyo2x8iaqeVWSWqUUPR74vN3sDC+NYPD6wvvrF70UKO5Lkym8?= =?us-ascii?Q?rGcKEs1+Moug349M2GVWxS2mpd8119hYiv4k7H2TZj7qrSNpS/ZvTHCfMUQM?= =?us-ascii?Q?2CdMhXJi8sr8VO4j6yMvnB3xILO5SguEPUmC9lQanOjjQc3IHFhLd/8HY4GG?= =?us-ascii?Q?4lX4MSt7T6y3F0fxS2lPP2h7AourvpvJ7kStksp1sriFc+8ftoXcsI1V8Ml+?= =?us-ascii?Q?a0E+hLmaW98KX/9+nVk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(1800799024)(376014);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EXD9TuyQisc0WgDabJStBPbcDIk3hYsHAn1GiuKqE0NcKZ80S5r5jF4FCAvL?= =?us-ascii?Q?owID9bFoofN/VT9SOoLu4MYHGlevOXuQaXzUTUvdlXqN3r644avJv/PAaiyW?= =?us-ascii?Q?nFreNa1cfkRt1cUsjXaG7DtM0nzUeoedhltyd3UXC6OKHAm0JZ1NvGfCc5mq?= =?us-ascii?Q?6zVXoV7ifNG9U0m2rJegVF6LBfTOPiIYe9m6SHXOwH8cAATbM3ediwG+z2ut?= =?us-ascii?Q?gCdmmrHvgLrWfNArZWuwsRI3ot7d68Zq7aQ9QKMzbTY7HwaF5SQk5fxMTVnM?= =?us-ascii?Q?mGstDBZI4k+kywYD7ZDA1Lm6IsU14QLgM/vwylJbj6lX6U/RfPstZQYPBr9h?= =?us-ascii?Q?rTAVWBK+DMm9C9MEkKUvF7QNrx5VOKtgng8KO/jeiCJtp/ifwP6+ie9gOgzK?= =?us-ascii?Q?stoMmpDm20sw5QSdRAZoFooMnhDurol3FZ8VnC9FCxWkU9CYv87Bg120MaCM?= =?us-ascii?Q?K8VlHkGxDSxu4dnaZXA0iAYbfM0AAo+yQIrWWsLuzS8VRQFmJh0TqBuU56Tf?= =?us-ascii?Q?rlicL5k7B1ORiryfL0gxVd1f7OW/ZfJv8A83NYuU5t+Q7lnt7yfDyiziivay?= =?us-ascii?Q?4sAGgsNTOun1GypLCsShyhJqR27K/NKpAbnVAKnnDQ5jGcZhSD5h+QEfEuAC?= =?us-ascii?Q?HNa7diWcFQwQGzyS489zptV6Cl4yia72khl+pbUoINC4kncnav7/kKwFHZfB?= =?us-ascii?Q?aJzisGChVNK8/1azOdLqym3aJtaL3zwM4nV1N8iQOocPAHft9+S09Et2nqLK?= =?us-ascii?Q?8siSD7ijQ5YMnNwLX6al4kYv26r0H5WWqsHA12lAcK38RDqS3u/vXl4HGFRV?= =?us-ascii?Q?1BfYOuMv9xd4js7VtKcICHy9GQSXYQXWGHB+FNGQQcwxZkyvK40v62TLdkOL?= =?us-ascii?Q?7atzP1XTjQru1EAbeWp1/2Ymp3o0wbICXPOgwWYvb+CqCsBHwqJa2Cukn/Qs?= =?us-ascii?Q?WNGyyuzAZFrWRi7Ft7JasvatP5QT7ZfdoANpSB8mwVzvx+J8HbjIYAoC4GSH?= =?us-ascii?Q?8t101XLU4JHIozNfQGCfkRfg+3Lve4BhUkdDICKTyNimYdvNunba5CNe/Gag?= =?us-ascii?Q?tA3KE3gHv4K5W7o3K32RSg47lOLzaX4eUYIGTE7Kvy68NnjfDuwWkH4CMMby?= =?us-ascii?Q?SZkrCahZfM/XTooSfPsKYJN3dZWuLRTyttVeI09tmwQBFYFlWh3awu+a74To?= =?us-ascii?Q?3pIVr7YO420Uww5kgRDSm9EDQwSoJ9p16TaUb1XKHhSkUHVKHU+/hKzVMRpx?= =?us-ascii?Q?ja7eI7HuqnJOHMqFzOKsT11khn4T7spT+leh/fjaOMzJq6qEzc843dScak/S?= =?us-ascii?Q?AzKQjH5+cLphESePbT4YdSWz9i3EFCFwUk4si0ANORjER5cVeWBnu34m1qgo?= =?us-ascii?Q?geg+i7z7nKlUuJT1nnVfQGsHWOEGrNiex0zfaWkE1UBLQb3nhirHf9Vf3u1e?= =?us-ascii?Q?X/LLdxChN8l+n+B5FEV3EI0WfR4yKbkxiUtjNRdSr/9BvPEV1hlEWjr2CAj7?= =?us-ascii?Q?IjkBzWtkEV4VOlsHwxoew7nxUDarD1ToYWPI3u98yKGGc6OIhM3LtDmG34OO?= =?us-ascii?Q?LKg7rLZWL/yAglz5ucIuqzScAvJhUcvsFz0USFLJSuJkF7o3JtY3PC9/027K?= =?us-ascii?Q?AQ8WdPybWx6pM41IFvWRqNULWGiF/m7AZ2Khkn3WbxVbfoKJoqZeRGawyyuV?= =?us-ascii?Q?DwhkG0PV9i+iwWOg4Gcamn9/6sSfmOd/2GJa+mI1PV2f1jsY7bWk/K5af8Lr?= =?us-ascii?Q?KPwL4SfevQ=3D=3D?= X-OriginatorOrg: atomlin.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3845f25-f09d-4b23-21b0-08de68e86760 X-MS-Exchange-CrossTenant-AuthSource: CWLP123MB3523.GBRP123.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2026 21:07:31.1560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: e6a32402-7d7b-4830-9a2b-76945bbbcb57 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lSceBw9rBPJuymjMsmzlVPxH9SzJzP1GHN1HPpwVmkTDrXXMdF6oiIxyiPpt0AeuTjpp4YpDD7XShNU9gwJCRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWLP123MB6528 Content-Type: text/plain; charset="utf-8" Currently, configuring the io_alloc_cbm interface requires an explicit domain ID for each cache domain. On systems with high core counts and numerous cache clusters, this requirement becomes cumbersome for automation and management tasks that aim to apply a uniform policy. Introduce a wildcard domain ID selector "*" for the io_alloc_cbm interface. This enables users to update the Capacity Bitmask (CBM) across all cache domains in a single operation. For example, a user can write "*=3D0" to the io_alloc_cbm file to programme every domain with the same mask. The value supplied must, however, remain within the valid range defined by the resource (e.g., min_cbm_bits). Signed-off-by: Aaron Tomlin --- Documentation/filesystems/resctrl.rst | 10 ++++++++++ fs/resctrl/ctrlmondata.c | 15 ++++++++++++--- 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/Documentation/filesystems/resctrl.rst b/Documentation/filesyst= ems/resctrl.rst index 8c8ce678148a..948219e58882 100644 --- a/Documentation/filesystems/resctrl.rst +++ b/Documentation/filesystems/resctrl.rst @@ -215,6 +215,16 @@ related to allocation: # cat /sys/fs/resctrl/info/L3/io_alloc_cbm 0=3D00ff;1=3D000f =20 + Set each CBM to a specified value. + + An ID of "*" configures all domains with the provided CBM. + + Example:: + + # echo "*=3D0" > /sys/fs/resctrl/info/L3/io_alloc_cbm + # cat /sys/fs/resctrl/info/L3/io_alloc_cbm + 0=3D0;1=3D0 + When CDP is enabled "io_alloc_cbm" associated with the CDP_DATA and CDP_= CODE resources may reflect the same values. For example, values read from and written to /sys/fs/resctrl/info/L3DATA/io_alloc_cbm may be reflected by diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c index b96b661626c2..f47331a97337 100644 --- a/fs/resctrl/ctrlmondata.c +++ b/fs/resctrl/ctrlmondata.c @@ -873,21 +873,26 @@ static int resctrl_io_alloc_parse_line(char *line, s= truct rdt_resource *r, struct rdt_ctrl_domain *d; char *dom =3D NULL, *id; unsigned long dom_id; + bool update_all; =20 next: if (!line || line[0] =3D=3D '\0') return 0; =20 + update_all =3D false; dom =3D strsep(&line, ";"); id =3D strsep(&dom, "=3D"); - if (!dom || kstrtoul(id, 10, &dom_id)) { + + if (dom && !strcmp(id, "*")) { + update_all =3D true; + } else if (!dom || kstrtoul(id, 10, &dom_id)) { rdt_last_cmd_puts("Missing '=3D' or non-numeric domain\n"); return -EINVAL; } =20 dom =3D strim(dom); list_for_each_entry(d, &r->ctrl_domains, hdr.list) { - if (d->hdr.id =3D=3D dom_id) { + if (update_all || d->hdr.id =3D=3D dom_id) { data.buf =3D dom; data.mode =3D RDT_MODE_SHAREABLE; data.closid =3D closid; @@ -903,10 +908,14 @@ static int resctrl_io_alloc_parse_line(char *line, s= truct rdt_resource *r, &d->staged_config[s->conf_type], sizeof(d->staged_config[0])); } - goto next; + if (!update_all) + goto next; } } =20 + if (update_all) + goto next; + rdt_last_cmd_printf("Invalid domain %lu\n", dom_id); return -EINVAL; } --=20 2.51.0