From nobody Wed Feb 11 06:57:09 2026 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFE222DAFDD for ; Tue, 10 Feb 2026 18:57:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770749843; cv=none; b=LRBhy1eeYWfqSVSbXvYpCjMBuhhKUv5iJGpj5TtvmHL/cnPKQP2/5Sfus9Et5se0l6324RVhX9fE1Ubg6xT9h/h40Lbms/wWejvosE+Bl75/8jBZKfNHvZb3olf0u7w1+bDaf4qOJGAHmK8E0urePnA4qzFhiFmLP5Q0Eo/9yEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770749843; c=relaxed/simple; bh=gJgVXacEBUNhn77KJjM4KhMpZj1cfOPpjzzwqQ8eruA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ovT99dqrV/5tcqJy5Pe070+zwMZo5W+yfj1hHnENIPy3CsqAtJhsl5c1mmY1Go3Y3R83eiTFQ7Ex+FLsbsRyQalP/MZYEyXYXiOswTjs6ut2EsrFGTXcQJ5sNsrkA1LD88T6l6LHgBVw9pkBwZEpI91VUSosmU5exMiIQ2bXSbI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=Yb/gFLWH; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="Yb/gFLWH" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-50145d27b4cso68518321cf.2 for ; Tue, 10 Feb 2026 10:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1770749840; x=1771354640; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EsOvx8MYis3OxBhDDm84POW3mkp8XwXXG9CZxnTszuM=; b=Yb/gFLWHR5TNrjU5iEPFFphNI7O9zCwlR4wthO1vUStecIliouvq03XfdYX732WyYY 1GuWYBgg3Kap+fXIkczRN6zVujJFqnI1QMbct/q0NJCpAA+XONnU/6iNWHI3XoVA6Pc/ v8K7XqMvvBh3x8L3bkXN4lhIw4jd88/AbRGcK4a1CeTJDb6XH5wdMAjbDppMEaEnSYXE jEHDU28uOXIdg364gNsNB7G2Mb/6m6ziKfMomWLfDS/WY4Tr0KtwhpNBg212JoCBcE6S /vLe5YdHo3SIuTMOUvruLNQ+0MaK+VsrzFaq5fyqLaRjAsYBJQBKe9NQjZJRbdO6KxRI zVLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770749840; x=1771354640; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EsOvx8MYis3OxBhDDm84POW3mkp8XwXXG9CZxnTszuM=; b=LD79+LvDEYEEJNjY7pXKBGk/r/j+CMj19cViBLihAugQYvqHQM+/XZ5CmmYo5n2LsI QEtLgSaZW7rDMlHWnzUXN8CvPglZJZcBqgRErke3fEBev5t27JZrhzCbrhLyD/RslKOj egcClj5ogzJqn9512Y+EyzqAjh2qhuJjJaRgdxIfZofOdpBAsKntiBYYGRP3emutlggc j+sag7BwOAH98c8d0jElUtO/yw6Tk4Kgm3W6xim/OXXM9wrAOFAGG51X/GhBhMtTGy6y dngCO+aftbp+jAadxwwcTqb2hZGYM65NCVTpzJyC4ll1UI5B++rIlsqrbC8dxFyX6TaY Ydaw== X-Forwarded-Encrypted: i=1; AJvYcCXBkpCd0fhABCmLOzSi+sKVi0zR0XK+MGI1P+i8k4lYTJsYMd4dOEpVZ3BRFTuiMwX8a1PHEEOaO/fyIH8=@vger.kernel.org X-Gm-Message-State: AOJu0YzV0WS378+ZXzcfb6xCWGyIUJof9rb5vTXafJULvV9X2+vHutx1 fB4oXViV2Uz3OmhbE8iZzLXMhgeGXvqrMWNnf1jjLn+IEwlN8sflhZzSbD5+tovAOSX0hJD4iO+ RMz6h X-Gm-Gg: AZuq6aKGlIdOyDQ4W6MBJRuAdIGSEnSeY80Q2ZxjgjoJr6R+JrSPUaakbU6LrvT5ikn 1jBAzr61MbkWL+Ko4LkNIj1Y4LqS0XiFFlW3j5ZxLk3kFwUgI6YilPuFNMredqsQNBuFdysEV6x WQH62pjrF6TGvzgw1DuksE7JL9HlKxcBmNQ4X9+mY/1mRScYewPDveP7wDWykPWitM14r6xXx5D Va4qK4wRTWkxVe7E3Btc1Z2TsDa6npLE3h48ICQQvdYPHiyBYy7b1w3xE1Rry1wmxCTpyPtBBk3 KcGoWpPhCP7ZpxQ5s46FgGppK2P6/7SIC0cT+w8DEFGKAoy9/glh6WXs0rZMWxBRKRoWd7Ktip+ /rG3LWR256AuxbODpxkiA8xI2MKzAgToJu6gTU3RavmyoXotanc6uN5Y6liilYXKgpTuJCLmVnZ VxSVEieXGrSuLuwIveXdHK4A7Bk1EMtP1J6q9fxyaQxFCBOCr07L8vuiYw+4xoFyVC2ZzBKJkb3 PHhYwA847fbFlfG/Zw9IIFWTzF6FCXezZa1t1c58l8= X-Received: by 2002:ac8:5952:0:b0:502:a063:c439 with SMTP id d75a77b69052e-506399e4349mr205718631cf.80.1770749839732; Tue, 10 Feb 2026 10:57:19 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-506392c1d4esm106040631cf.27.2026.02.10.10.57.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 10:57:19 -0800 (PST) From: Ziyi Guo To: Mark Brown , Alexander Stein Cc: Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH v2] ASoC: fsl_xcvr: Revert fix missing lock in fsl_xcvr_mode_put() Date: Tue, 10 Feb 2026 18:57:14 +0000 Message-Id: <20260210185714.556385-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit f51424872760 ("ASoC: fsl_xcvr: fix missing lock in fsl_= xcvr_mode_put()"). The original patch attempted to acquire the card->controls_rwsem lock in fsl_xcvr_mode_put(). However, this function is called from the upper ALSA core function snd_ctl_elem_write(), which already holds the write lock on controls_rwsem for the whole put operation. So there is no need to simply hold the lock for fsl_xcvr_activate_ctl() again. Acquiring the read lock while holding the write lock in the same thread results in a deadlock and a hung task, as reported by Alexander Stein. Reported-by: Alexander Stein Closes: https://lore.kernel.org/linux-sound/5056506.GXAFRqVoOG@steina-w/ Signed-off-by: Ziyi Guo --- v2: - Refactor subject line style - Include human readable descriptions - Fix the sha1 information for sound/soc/fsl/fsl_xcvr.c sound/soc/fsl/fsl_xcvr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 5de93f458b56..a268fb81a2f8 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -223,13 +223,10 @@ static int fsl_xcvr_mode_put(struct snd_kcontrol *kco= ntrol, =20 xcvr->mode =3D snd_soc_enum_item_to_val(e, item[0]); =20 - down_read(&card->snd_card->controls_rwsem); fsl_xcvr_activate_ctl(dai, fsl_xcvr_arc_mode_kctl.name, (xcvr->mode =3D=3D FSL_XCVR_MODE_ARC)); fsl_xcvr_activate_ctl(dai, fsl_xcvr_earc_capds_kctl.name, (xcvr->mode =3D=3D FSL_XCVR_MODE_EARC)); - up_read(&card->snd_card->controls_rwsem); - /* Allow playback for SPDIF only */ rtd =3D snd_soc_get_pcm_runtime(card, card->dai_link); rtd->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK].substream_count =3D --=20 2.34.1