From nobody Wed Feb 11 01:25:54 2026 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53305215F7D for ; Tue, 10 Feb 2026 18:56:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770749797; cv=none; b=AOeS8M+jt8uWm9D9k2zTrwGrcjW+qMjCk3oO0I3XWr5Z8yf2yPOcyOmSW75oXdtYKogEUZD0Ly+p81aj98uSioJdNSGXHX84skND/+2ElOKX6Kr17x+BQiKyeCpR0Enm5z3d6zRwatjP7o62A+vXr6aU33ArIrF52/L3PdlEPXk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770749797; c=relaxed/simple; bh=vOVA+kGzaGmTmP5UGxNk5afUQ+uzViEnmXfbeCe4RNA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aBBalLqELZHsqseRZ7iVcWEj/XJ1wuy+exNUtYHvDpxN9TpbXdsnudAOwG2iGjOWhN3/xFFpeQBjCxbWeWIzHXWlkEUif0CtGrMfvlh/weMX7b8Zo91/JPTgpknWW9yHs+sXXaqJPZihTP8Fu8sZUOsE4YUbW6vvOnBqtI1lRFc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UjNPQWVp; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UjNPQWVp" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-65a26c220b6so838306a12.0 for ; Tue, 10 Feb 2026 10:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770749795; x=1771354595; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b/qjQknBhj1g5hflh341vGQ8gt7ai7rpOHf7+cHVcSI=; b=UjNPQWVpZsGT8YtF3yCvdZX+IjZtlzsIVQ0/4vPZTo+cWDOhjEXaHcjxOzou7sTEIX vR5e0ImfgvnOBKELTWL6JHruBIHKPYOSpI3PF6Ya9vNXhclK/SiG1bbKXv/PFS5P+RKr FybsqjOYQSIZLaCHUPlJ4uI4lyIQ/FtAIUkPA3VrR61QBORTvOp1i/fVOWrRTPTqN2Hs NIMlqjJHY7FnbiN+iW+TIiUCCnqkwFUF28YzdGJ20nPyr1iDGSu89w+GdLTv0OdVhcaX HcjLJrNNh/91wXalCm4V174tqGKRq8507WS0Edc6sUo5xby7okm0xVjUPfMzBoYTaiQZ GiAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770749795; x=1771354595; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b/qjQknBhj1g5hflh341vGQ8gt7ai7rpOHf7+cHVcSI=; b=ttpMWdYQAdi8ItjW8WklW/ldRvtiO5INXzfkRBkDMvu0krCOio281okXiW62LUEbwG tT9uNgKacfDlZKXZ3UwK9pzBvC128Us93rBhRzMLLO4nJUByV/1nNnVw3KtPVGfK/yQi U5w40VpsVYy22dO55X+qFeBEe7Ybzsne/+lpVTndudSnnPlmv6BgRQygJal/ir4gss51 K1vt95mIjE4UpUzqWdaiUGCP24N9P0048sdmwPKzGHifXxT/f0yaOvExuJoXF5hKwgXb HjzGom4bR0O2Y4GtKvfOs2IjpkyzfEUAG7k9eXl0n3fIqRmd8/6mVtTi1B7/C8cpJ03W 61lA== X-Forwarded-Encrypted: i=1; AJvYcCUONUV7leEmhp6cWRR8F50ekWiG0mUrgPVqriuUktOVUoS46GnBHTnj7Lc9mzAsBiEWxlX+uE53+lKGEOY=@vger.kernel.org X-Gm-Message-State: AOJu0YxQismdI9AQv/x2DPKNtCs1BKUfyEousYrhw/x0CBag1wPhxEBz ZfgLxm8s0PBKSji8+rINxliL9U0R1zF0+8QX528CxGzYWYa/jxSFfnts X-Gm-Gg: AZuq6aKPuu8c2/vykj/EjRA9ptWQXIVHIP+8S8xxLZYMVp39Kpzhvv4zQCRXt0p3WDf jLuDHv3iC6Wg0/oRwNxxgxc6dS59DvOuPF71HnwLtFXpl6zjnf1ac1gHIQJXwslrwo2ip1KOWqA hNjBUKvOs24KkWgAJ/CafmDquvtSrkEa2Erjz38Oj2FT9JwNZRgLgm1/M0uoJRqat+5POFzPTRB zNnouO895kcCw7No6MKGZPhjEm0lSTiUd2jFl8Q1zDaPDB2ncN35DKOq/QEIs0W/FPbn0CFCHUc 40sfUrviOrizFFG8w+Ant4Vv0FDmHkJU/VEJt/oRbdnbrMOrBbrzz/p7SgXg7YXHBcH4/f+P+f7 E2yN+XwlOcUYoEQtWLzZP+tv7F8nIEnc5YE1ERrzlCFOYvdVrEdJ8AkywhrExbDTD9Sa+K1KqvT m5d1sESg8wQdk3rzc= X-Received: by 2002:a17:906:4fd2:b0:b87:368a:2bf7 with SMTP id a640c23a62f3a-b8edf174604mr1130961366b.13.1770749794599; Tue, 10 Feb 2026 10:56:34 -0800 (PST) Received: from arch ([178.230.12.29]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8eda74a52bsm551546766b.14.2026.02.10.10.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 10:56:34 -0800 (PST) From: Haroen Tmimi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Haroen Tmimi Subject: [PATCH v3] staging: rtl8723bs: remove shadowed variable in sdio_halinit Date: Tue, 10 Feb 2026 19:56:30 +0100 Message-ID: <20260210185630.54577-1-tmimiharoen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable 'bMacPwrCtrlOn' was redeclared in the function CardEnable, shadowing a variable of the same name declared at the top of the function (line 21). Remove the redundant 'u8' type declaration to use the existing outer variable and resolve a -Wshadow warning. Signed-off-by: Haroen Tmimi Reviewed-by: Ethan Tidmore --- Changes in v3: Resending clean patch (v2 accidentally included unrelated changes from another commit due to an oversight). Changes in v2: Removed incorrect blank line after the opening brace that was left behind when removing the Adapter variable. drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 0fa1b22fdf9a..861d5162de15 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -30,7 +30,7 @@ static u8 CardEnable(struct adapter *padapter) =20 ret =3D HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, = PWR_INTF_SDIO_MSK, rtl8723B_card_enable_flow); if (ret =3D=3D _SUCCESS) { - u8 bMacPwrCtrlOn =3D true; + bMacPwrCtrlOn =3D true; rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); } } else --=20 2.53.0