From nobody Tue Feb 10 23:53:29 2026 Received: from mail-yw1-f195.google.com (mail-yw1-f195.google.com [209.85.128.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4234538A9AD for ; Tue, 10 Feb 2026 17:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.195 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770744625; cv=none; b=LZa/29QWzOMmFrQE4bssrN/zVu33LkXqYmrSgldhej8PtwrGTkmCP4rOBu2SBSrQJFAEb0DDmZLZvUkPJcmpjZyux1ZSSyuDivQ1vI7SDO68mk0vY8Q/O96mricO5ACcMvluAcNb7mKWzbaMUORPziVDk6XEVd1s4PSQt3AkbEA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770744625; c=relaxed/simple; bh=8k+xxJnpSoXooUu+73Ayc4bVRWbrEfVHYZ+kRuDPJMs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KrEPwNjDoGZK9+SklB3UcBM7yhvzBJNCxs9JjoiAdVED0qBZmrAL5cCX8gcEJiHKFDMnQIkObm3e7xfgIBJExftHBBiHWTXrP7mfcd6SYxm3spfhXQwLyumG0ukHsAA/iujr6f3TAeQ6S649U3M5UecGw1TwoQpW6bv8027qN24= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SeJEW20L; arc=none smtp.client-ip=209.85.128.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SeJEW20L" Received: by mail-yw1-f195.google.com with SMTP id 00721157ae682-7963aa14dbbso955837b3.1 for ; Tue, 10 Feb 2026 09:30:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770744623; x=1771349423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jIIDoThfHkVOb07+iYSdsFpmFFWma4WyN2ASPrt42Cg=; b=SeJEW20L8PevOhD+lBVYLjbdAeOBAQqyNCro9zbn7zfhS/wkcYrsNBmIsz0+HFqUZW ETdaNCYFx1wMvAlauGXpkUg9Nmn+U/pxdX9x+wldIk+Ip/nM8iyzYQVRF5cIDOd9gJ80 Ln6QokP98wbjLkn8GFGq8nQM3bbVvHt5+nF5Jn6YZMf1wUf634274Auav2PRH9wkZlUu lx2GyKlcgTZwej7+wILjp/G5KPX7SBuLWyhDP0hALamguFTHjuTi2sQEE0w4PBetnzrf chlXqI+IQiTaeAB7mOKj4ZhuYFgZCEtXSq8lN1ryXLjehPVn5FSDAiPl4aFIlo/Mtq1l IHqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770744623; x=1771349423; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jIIDoThfHkVOb07+iYSdsFpmFFWma4WyN2ASPrt42Cg=; b=oKn3dVSx4DJhTihrbqqU8+OiqYAW+qxz82TEhYQSeIayuhoiXZF0EH7Funvc5GJovs GxNTiSluLRgS92bPbYWmpJPFDLYTQO3T576wUBL5Li5xovz+Z0M2FIjXz5ejtt78Axi5 A3glgIutrinAmZeJyACGCIKlb554v2QMlTXPX/uJUEVMdwJyH00lPShMLiQwsGP7vzu8 cUA3Qdnzg42Hws1Rd9ptCcV9DXRNSDtI/XLvJQqkcP3aEa03Xdzfd83ZMNZdYV/zIzRr 2exo4g3pilOa4UtPsg9cnQkII8an5mRlkaumlUNlx8lLWsai16+xmVPHVxEEcqFIsDBj pUMQ== X-Forwarded-Encrypted: i=1; AJvYcCVB8EqXAjgSXbuiPc4uLotUEc5bxgoc/lgILBZzdb9hV0HUPIpxW7ldr0L3YM8Hj8IAoBgH2XfvnBV8dZA=@vger.kernel.org X-Gm-Message-State: AOJu0YzfYe3ztD37swS8DWWY1Ld+eUiWcJDnUhAEp6oW3SWfnIX3Yugg oMqntZNlwtWbIElBJQdrHPyKigBCKPUhxEFzWm5RxHCG92jJarOevhSz X-Gm-Gg: AZuq6aJwrTY+d8OeWtge+i7ivs42xkfbbNBBdlgDljiyITa+uLys29aBCTnforepOyY Wg9jJggJTrx0QCGwZVQKGH1yL3vaUPzGM4MPVnI3H6vCxpjR93+ycnY6M0TlmPSDJliMfzLraXn GtcyDGLnhvVCK5Pmsfgdu6WPExyJyUgtXV3rBU+KiUCgh5LfZjS7xVHB4oqwJQLOfJ17yCvgGH+ bovZSEzEDyKQEvLl4GVa+VMgQqXDYo38lInd7Dxpqv4HR9stMx5tjF+rZx6l70gKtTkGr9DoxhQ 6tsEIbY5KQus0O5l4NKtZArtoee1hsGLlI642TBp3YHfFW8edJKlHkQvwzUY6CXM4dzSHHx/4RP mqHbXerhtbx7OtNytUuHGfl8ljgI5ej+OdzmAVF1z0RmYJAs8y8zPMCsI/GSaVCudQHOx81FHMe qhqjGi8/eumLObNkg+UMHDDlzFjzFIcg3jYNCQyWhkRIOPmU9DM7mmapZNelXOuBRWtxyLZRPyP bkuAAx+kFDLTnme6PTcxLD2 X-Received: by 2002:a05:690c:586:b0:794:c2fc:73b1 with SMTP id 00721157ae682-7965e15c9e7mr29878347b3.2.1770744623059; Tue, 10 Feb 2026 09:30:23 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::9944]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7964e371479sm49792307b3.15.2026.02.10.09.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 09:30:22 -0800 (PST) From: Ethan Tidmore To: andy.yan@rock-chips.com, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] drm/bridge: synopsys: dw-dp: correct signedness bug Date: Tue, 10 Feb 2026 11:30:04 -0600 Message-ID: <20260210173004.791856-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function dw_dp_video_need_vsc_sdp() returns a bool type but in a error path -EINVAL is returned. This allows the possibility of this function returning true when dw_dp_get_bridge_state() fails. Signed-off-by: Ethan Tidmore --- drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/brid= ge/synopsys/dw-dp.c index 432342452..a80d955f2 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c @@ -1149,7 +1149,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp) =20 state =3D dw_dp_get_bridge_state(dp); if (!state) - return -EINVAL; + return false; =20 if (!link->vsc_sdp_supported) return false; --=20 2.53.0