From nobody Tue Feb 10 22:15:41 2026 Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D8D43254AC for ; Tue, 10 Feb 2026 17:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770743106; cv=none; b=tO5igfaKjL0EFe2LX4beH3rT2iYUd2oyLUgqMn0lZuIBcIWByjuPjRR7UxZLamcH3tyEXVrWgV6Uyyza6M8x9qcg62yQaD/vzrf3Lgem2ulCh4I4C8LT6BkruNEvlupsjEBnzaMMgy6tHf5pwoIAdGjCnesv7WaNtDjp62FoHM0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770743106; c=relaxed/simple; bh=JTGeqIE6flBnr2MWVwyz2Dyk1s/yNb6+1M/j4kiR7kU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HIPzQobWgw3TrOsllhx466v6p/u/qbA4PZfieKzpzKNrpICBBC9+FueA8VRZDP6Jtc1BH4G0WpE4lJc5NZblbImZsSjeCpyZTAXvmgB0TJsp4KFxV2rrImeBFTkgV3NK5oKMoyh/3sSmVMs7rKzTOI9MBMO795OjeQ5CeSEDBvY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i3zS9Y8e; arc=none smtp.client-ip=209.85.218.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i3zS9Y8e" Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-b8850aa5b56so1012218266b.2 for ; Tue, 10 Feb 2026 09:05:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770743103; x=1771347903; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JKMH95g2zFbmX4wIGmKmRh9ohizNBq7eSvsYjPLDOjs=; b=i3zS9Y8eWHAUUoyl/qAX8EO6Y6iGZVLr6DRbO09yql5fto98wvodHTEJCb3wbGRfje O5P8Y/6cLNA2zU83a0/1SorbiQk8mXEInVtiJc18oRF1Fv1rZIeNoiKGAG2s9ilLuKme OjhGyDKhxCX/tM71c2iJEhKYKRg/KUoWy9GAGyYEu/bCJJkmEkSVSeO+mah5FjJst0Ad evuKX9gDbCnEUsp90WVcHUuorv+R4BFGJ2Pu1/RuvozD1XoAwfZDI13UpGPGxgL6y0I5 98OEDZYzWjf1DfTRv/BkJKWOZkGBJxBGEvJFiQ2JdWmwXTOFBu0+DEWv4XAHMa448WZT tKJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770743103; x=1771347903; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JKMH95g2zFbmX4wIGmKmRh9ohizNBq7eSvsYjPLDOjs=; b=AI1PZiZS+jvcGJr9UpW1JZkR/hSCY075f/7RAgy04lr0ekelrq0zcAyMpQk/q1gMzH bY9NtsE6cHtoTwnASUNNpGfOTEj/D1c1WNtNuLbmNB0Cb7GV4/AQUh71dlxrdDecdVXz 3AzogWYPrgqvWoaTiheABdLIpUUibgpGD13uf3mRcMJq4SmrZuEAn5u40bq/fxI9Ee5C ceIlbdJvkJOlaX3RdzAIfMA3SXAfZH3Bks1kKFXXHxjZGxAcNWNSAiUCUqvRmtYm7Iyd UAIBlCRh1oW4lE6oDvcb58mULDMh4gi3lGI/lXeSGvp2TwqNKhE25onazcJd78bAoL+l LpPQ== X-Forwarded-Encrypted: i=1; AJvYcCX+vN9APMrn/RFraS5DIzcH4iNCvbdCBgP5AMkEvlTMJc42IMgphySUq0BLBzYgozSCQTNiPpejB5UnXe8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzkj7eAhC9vEoNkaimHQaV9vk5BsIU2Dyc/pAugYic8/FqxF/Eo 9n1LbMZ4tA9B8cfPWfBnVsNRU2I/mxXEgZOmIz+KQxyDg+JJlK5aAFRU X-Gm-Gg: AZuq6aKydnKQrygoTN1fdpqaPcYXfVIC+GVbaWVEnvOAwBZaloqaF/g/0nSswCQGmXY As+3IlPmQOuoLUxtHjbvZSFO8ScTaf3W7MWEpT9crtTd0hbNzDUqX+y6RjaVnpWtY4XSMdh6//c lCQKmyuxDQDaJlsiaG4JG9sOTxdH9S/hd8ObzB7QROoumuw2YWcQk9GXmlCIjxCJso/kIAlQv3/ 59ZHY/Naws6fZRV5ud2E/aflKU3Hl2m/n8o3n9fDVdO9IV12ocOKADbEUVbIx3VIY9bN45naZB5 SvJdVRDZ51hYaPQpPdrMjAeQzNtq/j/Z5Ky5hS83cH1r2joxqm8mCIIGxVaSVZW3THOZ9iRZrUk aumEmq13OrtaZ7Tn2Kps3qoOvnP3Qf4TPhpFppHiZNSMaCsKL+0/D2ACe01j8OzhfbXGm9CnLzU qvP35Hc2f1k2OKvpRZFQqx93YI6W44+QPoWiRUmQ== X-Received: by 2002:a17:907:3c8c:b0:b87:3c4a:e68a with SMTP id a640c23a62f3a-b8f5438b063mr145446366b.9.1770743103070; Tue, 10 Feb 2026 09:05:03 -0800 (PST) Received: from arch (wlan-208086.nbw.tue.nl. [131.155.208.86]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8eda7a3004sm541870866b.15.2026.02.10.09.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 09:05:02 -0800 (PST) From: Haroen Tmimi To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Haroen Tmimi Subject: [PATCH v2] staging: rtl8723bs: remove shadowed variable in sdio_halinit Date: Tue, 10 Feb 2026 18:04:57 +0100 Message-ID: <20260210170457.50720-1-tmimiharoen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The variable 'bMacPwrCtrlOn' was redeclared in the function CardEnable, shadowing a variable of the same name declared at the top of the function (line 21). Remove the redundant 'u8' type declaration to use the existing outer variable and resolve a -Wshadow warning. Signed-off-by: Haroen Tmimi --- Changes in v2: Removed incorrect blank line after the opening brace that was left behind when removing the Adapter variable. drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c | 1 - drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/stagi= ng/rtl8723bs/hal/HalPhyRf_8723B.c index f712d0345b99..0f915589b518 100644 --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c @@ -208,7 +208,6 @@ void ODM_TxPwrTrackSetPwr_8723B( } =20 if (Method =3D=3D TXAGC) { - pDM_Odm->Remnant_OFDMSwingIdx[RFPath] =3D pDM_Odm->Absolute_OFDMSwingIdx= [RFPath]; =20 pDM_Odm->Modify_TxAGC_Flag_PathA =3D true; diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging= /rtl8723bs/hal/sdio_halinit.c index 0fa1b22fdf9a..861d5162de15 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c +++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c @@ -30,7 +30,7 @@ static u8 CardEnable(struct adapter *padapter) =20 ret =3D HalPwrSeqCmdParsing(padapter, PWR_CUT_ALL_MSK, PWR_FAB_ALL_MSK, = PWR_INTF_SDIO_MSK, rtl8723B_card_enable_flow); if (ret =3D=3D _SUCCESS) { - u8 bMacPwrCtrlOn =3D true; + bMacPwrCtrlOn =3D true; rtw_hal_set_hwreg(padapter, HW_VAR_APFM_ON_MAC, &bMacPwrCtrlOn); } } else --=20 2.53.0