From nobody Thu Apr 2 14:14:42 2026 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6159631B80B; Tue, 10 Feb 2026 12:02:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.11.138.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770724942; cv=none; b=EgTqu02Z3VGOC28gsQXbEV4S1mQ0CdrPAaDpkG2nQCmzTl5h1EIvPbxdOHsyU7sntT1SbhEJrSqDiBZdjYmS13hESzIHQLMWAvzIU1m+qErjuMFYdN72prZgUYeTGQm0F5QJSNIUnIYhUqRCdXfKy/NK10hNG3OkIbpo7CbSTgE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770724942; c=relaxed/simple; bh=e40v1gUy96BXqFR6hjWKMIDAHRVEqR0kayxwtpCeB5k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=G6e/svsSsgSV/0JVcEXm7ZZFAfgQ+5676SlsJlvafVeDZcUcmuRYqf2Er4HV130a0YWo+JNF7Vaq30jCd82TYEvgBlPobQsYqKbCWuvWjnk46uDwMA+rRt+mmWPCr5jPh/cMbXZQumPfTfBduigbe/cz1QCWD8S/5nbEojqP6nA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b=Pz/kwafX; arc=none smtp.client-ip=185.11.138.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.b="Pz/kwafX" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-Type:In-Reply-To:References; bh=MA8XtkyTeXl7r9NYADWLTbBNblgwxWj94nMGkruZhVo=; b=Pz/kwafXMpzn18HUjhM6RMkhj6 L52/VJwnl7fwM/YF93KhyrTRBjSOkP5odXCCUy0ymCtlyynt+8hd5xGgByI9BJjWL2gd6/aLtZPVV N8APRQ1nVr0MYDw86JVuT3t1zK9cKE6/AHnlUNbF493OIkM2mefUYPiON/vMw34/mYVIPf8BTxwso BjhvlIMEIEU6RPlLJWQlAMrzZ36j3Wlaq5UKD0CMNB3LgEELABTxsAZrd6Edhyzwp5BsyNh/akF3c rSX8cn2kzH2eJyVPFFDd0eulKChVb8uL7qFw7WleQmFQNpwiRQftP+h1YkjKI5eexSTPM8QVx2DeP f9HdBcMA==; Received: from i53875a81.versanet.de ([83.135.90.129] helo=phil..) by gloria.sntech.de with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1vpmRY-007wxR-CX; Tue, 10 Feb 2026 13:02:12 +0100 From: Heiko Stuebner To: heiko@sntech.de Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jan Palus , Peter Robinson , Thorsten Leemhuis , stable@vger.kernel.org Subject: [PATCH] Revert "arm64: dts: rockchip: Further describe the WiFi for the Pinebook Pro" Date: Tue, 10 Feb 2026 13:01:42 +0100 Message-ID: <20260210120142.698512-1-heiko@sntech.de> X-Mailer: git-send-email 2.47.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This reverts commit 6d54d935062e2d4a7d3f779ceb9eeff108d0535d. It seems there are different variants of the Wifi chipset in use on the Pinebook Pro. And according to the reported regression - see Closes below, the reverted change causes issues with one Wifi chipset. The original commit message indicates a "further description" only and does not indicate this would fix an actual problem, so a revert should not cause further problems. Fixes: 6d54d935062e ("arm64: dts: rockchip: Further describe the WiFi for t= he Pinebook Pro") Cc: Jan Palus Cc: Peter Robinson Cc: Thorsten Leemhuis Cc: stable@vger.kernel.org Closes: https://lore.kernel.org/r/aUKOlj-RvTYlrpiS@rock.grzadka/ Signed-off-by: Heiko Stuebner Reviewed-by: Dragan Simic Tested-by: Jan Palus --- .../boot/dts/rockchip/rk3399-pinebook-pro.dts | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/ar= m64/boot/dts/rockchip/rk3399-pinebook-pro.dts index 810ab6ff4e67..7c23971920f0 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts @@ -883,12 +883,6 @@ vcc5v0_host_en_pin: vcc5v0-host-en-pin { }; }; =20 - wifi { - wifi_host_wake_l: wifi-host-wake-l { - rockchip,pins =3D <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_none>; - }; - }; - wireless-bluetooth { bt_wake_pin: bt-wake-pin { rockchip,pins =3D <2 RK_PD3 RK_FUNC_GPIO &pcfg_pull_none>; @@ -946,19 +940,7 @@ &sdio0 { pinctrl-names =3D "default"; pinctrl-0 =3D <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; sd-uhs-sdr104; - #address-cells =3D <1>; - #size-cells =3D <0>; status =3D "okay"; - - brcmf: wifi@1 { - compatible =3D "brcm,bcm4329-fmac"; - reg =3D <1>; - interrupt-parent =3D <&gpio0>; - interrupts =3D ; - interrupt-names =3D "host-wake"; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&wifi_host_wake_l>; - }; }; =20 &sdhci { --=20 2.47.2