From nobody Thu Apr 2 15:37:42 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57ACA31A7E1 for ; Tue, 10 Feb 2026 11:34:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770723292; cv=none; b=tdrWqAc8S6zMZbl2GlnJs46sBLvP2ZGBsrWRjPfw3QpGOL8bpu637QyRhMjDl12ayssdH+iT2QQITFZffcFNjlQmD5dXWhBwRKP+aB3VignyQp4aYDW+9t+0bat7ddn1DSFtK4eqkN7VZxZDqpTfHFp5X6Zzo988FjkQw+JIOAM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770723292; c=relaxed/simple; bh=/wNrpal0qtMMUTMGWc1/B9FLAgALtewvvMh2uxWSIxA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SgmneNpC0gcqCtwqICHrr4nB1t+3bpyb6AZUBxIiQoiGQzNVVzfHjUceLnkwmIIspYgxYMdQfgXI9VuOuARUEoIDMH9jwfUkKzYF/KG+Cks+RB632ARU1+XrqjJ1pS5HOBb98qP9S68eei3CAIDSU7/WXc0csa/Rq+/hkazvvHc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=R4Lqt7eS; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="R4Lqt7eS" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4834826e555so16699975e9.2 for ; Tue, 10 Feb 2026 03:34:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1770723289; x=1771328089; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=czouTc/9gRTT7IgUdEbhXZCgCHvwee4zpUuFlhXPjB8=; b=R4Lqt7eSipGesNFPHaPM/9tJOtAV5DnBNR+nLFvhtQrMXhJhBimuRVwAduAsZOIKz4 qEWeHfd393j+QKqQbdu6v80z4fceOFCNEEXjhSFEsGFyDFow+uTDm+kEqdheakpmY+1G rDMdEsis3VE7jb71F+gmXmaD8gLcddQu0iXLSS0eE/xb8+5vXrxfAOzWaefVdbgWL9VJ /lch/kSD4D9IQwrAfgm6pnd1zBheNeeYzRgILQuUD+/GJq2ET/T6VFmwIn1IG/eLiM4n w7ivsYDx6T2MgYPaVEwV0drgNN7eTuh0rDi1f85ITDRBHE6HO1xWjnOUb6dx46020QZa FIbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770723289; x=1771328089; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=czouTc/9gRTT7IgUdEbhXZCgCHvwee4zpUuFlhXPjB8=; b=DadCbTNyxfg0NxDne552GyRB8st3zG4IwsGqLodWC/Gd0vKxDoD0uEu0tn4lChGfp8 G8HBjM/0jRFlsWP9R8Y1DXaXIXXXNgGHralNB41qebilkZX/zKyhpMVqi6S7bjTYXxuT 1h7q7JBZu/KDjoZ8Ic7R2l9E9HXE3RyzxBL7L4LOLnVhZRMbk3Y4IKALSCWv9In6y1J8 XT3uUk3xgPOlpt8XiMjde3YRtvgYoBPyT4TCfNcnNUVDJjweqlq6gqZ+2v0Twq6FuioX r1+2Z2Hc1/wyR/nmi4MYNufQ+o2+rHWVoYoIf1rt/Btm8rJkEYAzKbvHwLGZR4xc5qvB C7TA== X-Forwarded-Encrypted: i=1; AJvYcCXWxJjO6UheILf0nioWpUx7Jm5F4oPBN+BQtYD/ccEzJQfEuSJl7pRUX9+D15vlSX5gtZGNIoGS7zmBR3A=@vger.kernel.org X-Gm-Message-State: AOJu0YxYuiIkFTQgdj+PGk9mxysWOPU3iLHExvaPDHGtZQSPIGp410Yg clPw1fHWLYavzMlOfj8aigVjUXhSz9oofGVSG8lBkQn7tnXZNDQ7q7XqngoFqY1cr8Ixuzuf1uF phh4C X-Gm-Gg: AZuq6aL1BOQhMr/TPh3LCqiDBalPgEKRyx/ZWaAJGXuPY73isytjoqu6Kpr2NziUzgD YMrRhH5SbFKe8v5adIv4D4WrwQveVIDtFW/uRvG5CtDEQ96Dgji6CDxtbGrUEpOeWSNAHWpCjg6 Ju6WwbKp3agrhHaVG57WKllTc8Bc0DsXoENnpZcaaghHOMRA+KyHYVBorBq0M0FBG2dadhs0oVD eBkvWNL24B8Tegey2NBV3JzepveIqVyQZIotxZesreNrGb3PxY0tDFlUy/FtTJMrZ+FxP4L1Zyg lTgMA7m86CfZeeoHVx7KRVa8aVuVEbEDio3dNVZQyKtPwgjQe5HCwJIPeLNZBen+cvk2eFbE4ga s9dFpAhDX34ChTE99b79EZ1w5eGZnrl3yoOXwkqdxlA4/kruJruKI4rbry31wYSbZe5L1LsMOTr FSkK3nD8wxgzn+asbDiHVkFmP70yycgjt0FtP1QqlYr4JSUdLrgnLKiY9TLARkpyou2OqHtH+3J +tKYQoKS9ZU3TsbXd9G8gvA X-Received: by 2002:a05:600c:444f:b0:477:a219:cdb7 with SMTP id 5b1f17b1804b1-48320181c15mr203558835e9.0.1770723288713; Tue, 10 Feb 2026 03:34:48 -0800 (PST) Received: from zovi.suse.cz (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483209cfd77sm120182275e9.14.2026.02.10.03.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 03:34:48 -0800 (PST) From: Petr Pavlu To: Steven Rostedt , Masami Hiramatsu Cc: Mathieu Desnoyers , Tom Zanussi , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Petr Pavlu Subject: [PATCH 1/5] tracing: Fix checking of freed trace_event_file for hist files Date: Tue, 10 Feb 2026 12:28:16 +0100 Message-ID: <20260210113427.1068932-2-petr.pavlu@suse.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260210113427.1068932-1-petr.pavlu@suse.com> References: <20260210113427.1068932-1-petr.pavlu@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The event_hist_open() and event_hist_poll() functions currently retrieve a trace_event_file pointer from a file struct by invoking event_file_data(), which simply returns file->f_inode->i_private. The functions then check if the pointer is NULL to determine whether the event is still valid. This approach is flawed because i_private is assigned when an eventfs inode is allocated and remains set throughout its lifetime. Instead, the code should call event_file_file(), which checks for EVENT_FILE_FL_FREED. Using the incorrect access function may result in the code potentially opening a hist file for an event that is being removed or becoming stuck while polling on this file. A related issue is that although event_hist_poll() attempts to verify whether an event file is being removed, this check may not occur or could be unnecessarily delayed. This happens because hist_poll_wakeup() is currently invoked only from event_hist_trigger() when a hist command is triggered. If the event file is being removed, no associated hist command will be triggered and a waiter will be woken up only after an unrelated hist command is triggered. Fix these issues by changing the access method to event_file_file() and adding a call to hist_poll_wakeup() in remove_event_file_dir() after setting the EVENT_FILE_FL_FREED flag. This ensures that a task polling on a hist file is woken up and receives EPOLLERR. Fixes: 1bd13edbbed6 ("tracing/hist: Add poll(POLLIN) support on hist file") Signed-off-by: Petr Pavlu Acked-by: Masami Hiramatsu (Google) --- kernel/trace/trace_events.c | 3 +++ kernel/trace/trace_events_hist.c | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c index 137b4d9bb116..e8ed6ba155cf 100644 --- a/kernel/trace/trace_events.c +++ b/kernel/trace/trace_events.c @@ -1295,6 +1295,9 @@ static void remove_event_file_dir(struct trace_event_= file *file) free_event_filter(file->filter); file->flags |=3D EVENT_FILE_FL_FREED; event_file_put(file); + + /* Wake up hist poll waiters to notice the EVENT_FILE_FL_FREED flag. */ + hist_poll_wakeup(); } =20 /* diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_h= ist.c index c97bb2fda5c0..744c2aa3d668 100644 --- a/kernel/trace/trace_events_hist.c +++ b/kernel/trace/trace_events_hist.c @@ -5778,7 +5778,7 @@ static __poll_t event_hist_poll(struct file *file, st= ruct poll_table_struct *wai =20 guard(mutex)(&event_mutex); =20 - event_file =3D event_file_data(file); + event_file =3D event_file_file(file); if (!event_file) return EPOLLERR; =20 @@ -5816,7 +5816,7 @@ static int event_hist_open(struct inode *inode, struc= t file *file) =20 guard(mutex)(&event_mutex); =20 - event_file =3D event_file_data(file); + event_file =3D event_file_file(file); if (!event_file) { ret =3D -ENODEV; goto err; --=20 2.52.0