From nobody Thu Apr 2 14:08:55 2026 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85C9E341AAE for ; Tue, 10 Feb 2026 10:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770717834; cv=none; b=j78d3a61SFH2HnqcKfbHPw0/4DQKT6tMo0gA4QhEd5gNwMj77zmxA5Lblye4R6Xqw/BolmeMsqDoWgntltuejWW3zF68Yikttc4vaWW6/QPes8F7sZpamxRBx42lnIGBqpupfhrkkeuMzzudFGOF8sYpJgK4gbqBJKyra0HF7V8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770717834; c=relaxed/simple; bh=S3/6N4SOvYS7aSgee11rTdBONAdaMtKZy4RNbCy1m6Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DSyytpbQroMBxDZzR0a1AyL8B5ZyiW6k0isDHXEfKceAzA+h74qFQvpss3rSM0oonc2jzol567Ifr5UCeQ0t+JO7z6H3GJwT/oq27vw5mG7N48riZQfEi7Q449pFrp1btsLxTBpG0HfMgJ/GXnk2Ng365Nq/rYeWzK1LD0vgMyA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=DCvLrc4a; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="DCvLrc4a" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2a79ded11a2so4427125ad.3 for ; Tue, 10 Feb 2026 02:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1770717832; x=1771322632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hHVJixIP8UMg5ol65T77X2qIxHiSjwoDF2HJwmtsqKc=; b=DCvLrc4aEFMgnfaavDU2YF9duTaekLpc+xreI9JrZ7h+AmzN+b4wi+w/lBNGhBv3kM kmdEmiTWK2fS1z3YMMMz21iswccMwhGX5noPOYVqn4e32I8UfPkwq1larRNjMttQy2bX gPtqmW+fY+1D9JFH3qOd3EQausw75b84GoITc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770717832; x=1771322632; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hHVJixIP8UMg5ol65T77X2qIxHiSjwoDF2HJwmtsqKc=; b=Y+Zx8/2ctYS++hRS4woRXaTWyxBurjMlK+KTdNI/t8aYbT/TcRSqsCpFF671f7c6T0 8RvyndcJ6ppPn6ydv9EyMCk5xjyM0453c1kFjq5oEXPYnJuLE2Q5+DCfB2aDrc9Epdb2 Vm8CGKPKJ+2EUoalGdh8d8l4TL/lwhNvwcyWj4MBLyOMQV83Ux4ds6qkoQ5AGSESHrSc sn3o2wnNnwMeOReb1+hUYFPgKJwPUF6sq+HkZWy/Jj0phB6VtsB0cUAqKpwcJmi7scbU l3VRP8vePI2zkOe8HtcEePOqq1dTa2U0qecMR7dnQyYH+lBn+q4pnooRi+A+rxWZpaoy TjNA== X-Forwarded-Encrypted: i=1; AJvYcCVKv5UcejwBKzDpGMfOt+U5QxKHdjIgvOCCNIO2UKKh73ay8UCaV7wqXuNxY0kRJH3w7awY84db2Y/n93Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu/fBO1Ltjb81TAlcw0yNuCsHFsvQogiwQQnTtGsXjoO3vyPNV xi1IrUz9Upv2FNeVNCKp9v6wKMJkdtaEkgpc7FnnXCJTyZuK6r6e69bq5Z98mZtB5A== X-Gm-Gg: AZuq6aKf1klfGyS7qAoJrIDk4rA4UDlipEowgtlT11OoC8JrfDN8Nyp9odm3PKrUMUr Dbi2CrwSVEUGRjpmYl+p8kWGmCe8uV9lPkuqwC8bVihR5eFSCbVqzmCWSAW1lealc+tUUPvfGXo apHRltViYzOJ+CeM9J2tvr21u4fJePj0N56/PnBStIwSl3BOmThdyF2jahXOlAeas7XuRj5fmhj 69EBoyQS4Zm4ZnCXBBpSQugiIcb01dPIrbdFNW6S5g4TqFX2BeK+lgCQrO9VayU68VBZzv3G4+v 13/7UGMnZJLgSwCZVi9uIoaUik3+OpyKqdXa+VEWFHxMMXfKZ8Fdnpoio0tudTFLrAY87RGZKeL t2crQ2QfMpAov1vcCGgEeqgyHyhZKAfGuB0w9BB1QnyEd0n6cAG9bZYRbhBEzYnuj9c6/72fcAU GyYFvJf/Y4rP43VschmTcsaDB89nKEFmod8hteWlX5U86E/xIGNty+V/4J3OuOB8x74aUrI2Uve Nejo087 X-Received: by 2002:a17:902:ea11:b0:2aa:ffa0:4454 with SMTP id d9443c01a7336-2aaffa04758mr46974475ad.31.1770717831890; Tue, 10 Feb 2026 02:03:51 -0800 (PST) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:822c:995b:f23f:e04e]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a951a636aasm129318065ad.12.2026.02.10.02.03.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 02:03:51 -0800 (PST) From: Chen-Yu Tsai To: Brian Norris , Francesco Dolcini , Johannes Berg Cc: Chen-Yu Tsai , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Carpenter Subject: [PATCH] wifi: mwifiex: Fix dev_alloc_name() return value check Date: Tue, 10 Feb 2026 18:03:34 +0800 Message-ID: <20260210100337.1131279-1-wenst@chromium.org> X-Mailer: git-send-email 2.53.0.rc2.204.g2597b5adb4-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" dev_alloc_name() returns the allocated ID on success, which could be over 0. Fix the return value check to check for negative error codes. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aYmsQfujoAe5qO02@stanley.mountain/ Fixes: 7bab5bdb81e3 ("wifi: mwifiex: Allocate dev name earlier for interfac= e workqueue name") Signed-off-by: Chen-Yu Tsai Reviewed-by: Francesco Dolcini --- drivers/net/wireless/marvell/mwifiex/cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/marvell/mwifiex/cfg80211.c b/drivers/net/= wireless/marvell/mwifiex/cfg80211.c index a66d18e380fc..bc0a946e8e6e 100644 --- a/drivers/net/wireless/marvell/mwifiex/cfg80211.c +++ b/drivers/net/wireless/marvell/mwifiex/cfg80211.c @@ -3148,7 +3148,7 @@ struct wireless_dev *mwifiex_add_virtual_intf(struct = wiphy *wiphy, SET_NETDEV_DEV(dev, adapter->dev); =20 ret =3D dev_alloc_name(dev, name); - if (ret) + if (ret < 0) goto err_alloc_name; =20 priv->dfs_cac_workqueue =3D alloc_workqueue("MWIFIEX_DFS_CAC-%s", --=20 2.53.0.rc2.204.g2597b5adb4-goog