From nobody Thu Apr 2 15:37:23 2026 Received: from s.wrqvtbkv.outbound-mail.sendgrid.net (s.wrqvtbkv.outbound-mail.sendgrid.net [149.72.123.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B9AB3242B2 for ; Tue, 10 Feb 2026 09:24:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.72.123.24 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715457; cv=none; b=i5gcCWstyt9k7aZKyKzt+2CrAOkbrHuE8oX7iZWxMPA7qE0gdawHYS1pdI9nAXJ7kR5A3jwESBBEY4FvD8KmVv3MQeQ03Qe+6AvfGdpgLrmmSaGuAaYhSundDWUW7p1jqSaCSBqip+vewylkGgNueGONN8+S7Fak0nAC67X4xeY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715457; c=relaxed/simple; bh=mdHV/OrvcoTOfYGXpBzBJ5qf8muzn3HLdO3CHr+Ip3Y=; h=From:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version: To:Cc:Content-Type; b=rtx3zQ1zia2lkSxmaw40vKwU+l0MmiaHJiLRQu+3dQrrXi05hEvmxREkULLp7bBcfSNpvziBulTe5vO7c476Mg3LzTzFLwAPvRv9r4ty5jhUa8FXyZfUXuqsDRO4TUpnKMx+42S2/xLt8zP4F0MPRlllgZyYQ9E4lGrHiQgQKi0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mattwardle.net; spf=pass smtp.mailfrom=em431.mattwardle.net; dkim=pass (2048-bit key) header.d=mattwardle.net header.i=@mattwardle.net header.b=lp0SA8Iv; arc=none smtp.client-ip=149.72.123.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mattwardle.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em431.mattwardle.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mattwardle.net header.i=@mattwardle.net header.b="lp0SA8Iv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mattwardle.net; h=from:subject:date:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:date:from:subject:to; s=s1; bh=snQso672sutlEFlqaXhUA/V91FaIPJyTuuy2toBCCeM=; b=lp0SA8IvRapHLb7CAvDenq94EAZbFwKGcj2l1P/PRxN0Waj54CWf30MSl0d1Q6STusvs VKfnJzqG7LyaAcI54dJYPs1CZlCXyA9KHjYA1MGJkWFLCu26vCS59JlQF87jqjrnCHEdBh MjTn4BHpsVCXyOcu9H5ubTnik8ljwxMCcnaezH5t5354p1MOOdoKtzO8PADtgSVtuAIQL0 Vr+CPGAvjgshU7OLXATjS3DAcjK/dAnSJcKoRbgvpqNq2sej3EvwK3EiTZhMOBuc5SIeAB /NXyOrdPH0B2J44A8F5kZ1CL0dgYdeUwx3e1xnjdjGzupLrBGi83v5yr5rjSYoPw== Received: by recvd-5fb7fdbd94-cwpcz with SMTP id recvd-5fb7fdbd94-cwpcz-1-698AF93F-E 2026-02-10 09:24:15.304883989 +0000 UTC m=+55682.711982724 Received: from mail.3n0xdopx5uce3ivigaxioahche.ix.internal.cloudapp.net (unknown) by geopod-ismtpd-3 (SG) with ESMTP id 0-zhEk9CQjCSmtlsjGGwsg Tue, 10 Feb 2026 09:24:05.513 +0000 (UTC) Authentication-Results: mail.3n0xdopx5uce3ivigaxioahche.ix.internal.cloudapp.net; dmarc=fail (p=reject dis=none) header.from=mattwardle.net Received: from thinkpad (unknown [161.142.117.49]) by mail.3n0xdopx5uce3ivigaxioahche.ix.internal.cloudapp.net (Postfix) with ESMTPSA id 57BDE40E37; Tue, 10 Feb 2026 09:24:05 +0000 (UTC) From: Matt Wardle Subject: [PATCH 3/3] staging: media: atomisp: Fix braces on incorrect lines Date: Tue, 10 Feb 2026 09:24:15 +0000 (UTC) Message-ID: <20260210092243.294732-4-matt@mattwardle.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260210092243.294732-1-matt@mattwardle.net> References: <20260210092243.294732-1-matt@mattwardle.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?u001=2EFlbIg1=2FBrpD1HWcEBlj1tgh=2F0VDwewqbkmeZ1SFD9tLmzlDepFYnLmfnO?= =?us-ascii?Q?moWHy7n5HdVZTdyWWeMojZeck4brVYul=2FIqvcwM?= =?us-ascii?Q?d58FkwoGE+aZ=2FgGAunHiGqEHnhv=2FBXvNq3Sld2d?= =?us-ascii?Q?LlXs9vZ21PJ+CaCiAVfYXkHFKFIS+L7TS+2bQ8L?= =?us-ascii?Q?WgJ1EBT4r2+NDmY5YYxqHeO1KduwgyO3RJ8j5UT?= =?us-ascii?Q?RMRZ1FWIjMxRsWqIiV11zrXjWdF0DB53AB2Q2Pk?= =?us-ascii?Q?6klv?= To: Hans de Goede , Mauro Carvalho Chehab , Andy Shevchenko Cc: Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Matt Wardle X-Entity-ID: u001.OAl4HwJfzvoR6h5DRlrySA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl errors: ERROR: that open brace { should be on the previous line Signed-off-by: Matt Wardle --- .../isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c | 3 +- .../isp/kernels/raw/raw_1.0/ia_css_raw.host.c | 3 +- .../kernels/sdis/sdis_2/ia_css_sdis2.host.c | 6 +- .../isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 3 +- .../atomisp/pci/runtime/binary/src/binary.c | 60 +++++++------------ .../pci/runtime/isp_param/src/isp_param.c | 6 +- drivers/staging/media/atomisp/pci/sh_css.c | 6 +- 7 files changed, 29 insertions(+), 58 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_c= ss_dvs.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/i= a_css_dvs.host.c index 4c85b5a62224..cf6c29155758 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.= host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.= host.c @@ -273,8 +273,7 @@ int store_dvs_6axis_config(const struct ia_css_dvs_6axi= s_config *dvs_6axis_confi binary, dvs_in_frame_info); =20 - if (!me) - { + if (!me) { IA_CSS_LEAVE_ERR_PRIVATE(-ENOMEM); return -ENOMEM; } diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/ia_c= ss_raw.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/i= a_css_raw.host.c index 80fd64a8eb98..fb0e2a88cadb 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/ia_css_raw.= host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/ia_css_raw.= host.c @@ -23,8 +23,7 @@ static const struct ia_css_raw_configuration default_conf= ig =3D { /* MW: These areMIPI / ISYS properties, not camera function properties */ static enum sh_stream_format css2isp_stream_format(enum atomisp_input_form= at from) { - switch (from) - { + switch (from) { case ATOMISP_INPUT_FORMAT_YUV420_8_LEGACY: return sh_stream_format_yuv420_legacy; case ATOMISP_INPUT_FORMAT_YUV420_8: diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_c= ss_sdis2.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2= /ia_css_sdis2.host.c index aaabb3388044..6f92709f87eb 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_css_sdis= 2.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_css_sdis= 2.host.c @@ -176,13 +176,11 @@ int ia_css_get_dvs2_statistics(struct ia_css_dvs2_sta= tistics *host_stats, assert(isp_stats); =20 map =3D ia_css_isp_dvs_statistics_map_allocate(isp_stats, NULL); - if (map) - { + if (map) { hmm_load(isp_stats->data_ptr, map->data_ptr, isp_stats->size); ia_css_translate_dvs2_statistics(host_stats, map); ia_css_isp_dvs_statistics_map_free(map); - } else - { + } else { IA_CSS_ERROR("out of memory"); ret =3D -ENOMEM; } diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css= _vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css= _vf.host.c index f8870f7e790d..152faab2b169 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.hos= t.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.hos= t.c @@ -64,8 +64,7 @@ int sh_css_vf_downscale_log2(const struct ia_css_frame_in= fo *out_info, * test for the height since the vmem buffers only put restrictions on * the width of a line, not on the number of lines in a frame. */ - while (out_width >=3D vf_info->res.width) - { + while (out_width >=3D vf_info->res.width) { ds_log2++; out_width /=3D 2; } diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c = b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c index c7962549e999..39b37b557aff 100644 --- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c +++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c @@ -477,8 +477,7 @@ int ia_css_binary_init_infos(void) if (!all_binaries) return -ENOMEM; =20 - for (i =3D 0; i < num_of_isp_binaries; i++) - { + for (i =3D 0; i < num_of_isp_binaries; i++) { int ret; struct ia_css_binary_xinfo *binary =3D &all_binaries[i]; bool binary_found; @@ -502,8 +501,7 @@ int ia_css_binary_uninit(void) unsigned int i; struct ia_css_binary_xinfo *b; =20 - for (i =3D 0; i < IA_CSS_BINARY_NUM_MODES; i++) - { + for (i =3D 0; i < IA_CSS_BINARY_NUM_MODES; i++) { for (b =3D binary_infos[i]; b; b =3D b->next) { if (b->xmem_addr) hmm_free(b->xmem_addr); @@ -664,8 +662,7 @@ int ia_css_binary_fill_info(const struct ia_css_binary_= xinfo *xinfo, assert(binary); =20 binary->info =3D xinfo; - if (!accelerator) - { + if (!accelerator) { /* binary->css_params has been filled by accelerator itself. */ err =3D ia_css_isp_param_allocate_isp_parameters( &binary->mem_params, &binary->css_params, @@ -673,15 +670,13 @@ int ia_css_binary_fill_info(const struct ia_css_binar= y_xinfo *xinfo, if (err) return err; } - for (i =3D 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++) - { + for (i =3D 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++) { if (out_info[i] && (out_info[i]->res.width !=3D 0)) { bin_out_info =3D out_info[i]; break; } } - if (in_info && bin_out_info) - { + if (in_info && bin_out_info) { need_scaling =3D (in_info->res.width !=3D bin_out_info->res.width) || (in_info->res.height !=3D bin_out_info->res.height); } @@ -712,8 +707,7 @@ int ia_css_binary_fill_info(const struct ia_css_binary_= xinfo *xinfo, binary->internal_frame_info.res.height =3D isp_internal_height; binary->internal_frame_info.raw_bit_depth =3D bits_per_pixel; =20 - if (in_info) - { + if (in_info) { binary->effective_in_frame_res.width =3D in_info->res.width; binary->effective_in_frame_res.height =3D in_info->res.height; =20 @@ -741,15 +735,13 @@ int ia_css_binary_fill_info(const struct ia_css_binar= y_xinfo *xinfo, binary->in_frame_info.crop_info =3D in_info->crop_info; } =20 - if (online) - { + if (online) { bits_per_pixel =3D ia_css_util_input_format_bpp( stream_format, two_ppc); } binary->in_frame_info.raw_bit_depth =3D bits_per_pixel; =20 - for (i =3D 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++) - { + for (i =3D 0; i < IA_CSS_BINARY_MAX_OUTPUT_PORTS; i++) { if (out_info[i]) { binary->out_frame_info[i].res.width =3D out_info[i]->res.width; binary->out_frame_info[i].res.height =3D out_info[i]->res.height; @@ -768,8 +760,7 @@ int ia_css_binary_fill_info(const struct ia_css_binary_= xinfo *xinfo, } } =20 - if (vf_info && (vf_info->res.width !=3D 0)) - { + if (vf_info && (vf_info->res.width !=3D 0)) { err =3D ia_css_vf_configure(binary, bin_out_info, (struct ia_css_frame_info *)vf_info, &vf_log_ds); if (err) { @@ -787,8 +778,7 @@ int ia_css_binary_fill_info(const struct ia_css_binary_= xinfo *xinfo, binary->input_format =3D stream_format; =20 /* viewfinder output info */ - if ((vf_info) && (vf_info->res.width !=3D 0)) - { + if ((vf_info) && (vf_info->res.width !=3D 0)) { unsigned int vf_out_vecs, vf_out_width, vf_out_height; =20 binary->vf_frame_info.format =3D vf_info->format; @@ -820,23 +810,20 @@ int ia_css_binary_fill_info(const struct ia_css_binar= y_xinfo *xinfo, binary->vf_frame_info.padded_width =3D vf_out_width; binary->vf_frame_info.res.height =3D vf_out_height; } - } else - { + } else { binary->vf_frame_info.res.width =3D 0; binary->vf_frame_info.padded_width =3D 0; binary->vf_frame_info.res.height =3D 0; } =20 - if (info->enable.ca_gdc) - { + if (info->enable.ca_gdc) { binary->morph_tbl_width =3D _ISP_MORPH_TABLE_WIDTH(isp_internal_width); binary->morph_tbl_aligned_width =3D _ISP_MORPH_TABLE_ALIGNED_WIDTH(isp_internal_width); binary->morph_tbl_height =3D _ISP_MORPH_TABLE_HEIGHT(isp_internal_height); - } else - { + } else { binary->morph_tbl_width =3D 0; binary->morph_tbl_aligned_width =3D 0; binary->morph_tbl_height =3D 0; @@ -846,8 +833,7 @@ int ia_css_binary_fill_info(const struct ia_css_binary_= xinfo *xinfo, sc_3a_dis_padded_width =3D binary->in_frame_info.padded_width; sc_3a_dis_height =3D binary->in_frame_info.res.height; if (bds_out_info && in_info && - bds_out_info->res.width !=3D in_info->res.width) - { + bds_out_info->res.width !=3D in_info->res.width) { /* TODO: Next, "internal_frame_info" should be derived from * bds_out. So this part will change once it is in place! */ sc_3a_dis_width =3D bds_out_info->res.width + info->pipeline.left_croppi= ng; @@ -857,18 +843,15 @@ int ia_css_binary_fill_info(const struct ia_css_binar= y_xinfo *xinfo, =20 s3a_isp_width =3D _ISP_S3A_ELEMS_ISP_WIDTH(sc_3a_dis_padded_width, info->pipeline.left_cropping); - if (info->s3a.fixed_s3a_deci_log) - { + if (info->s3a.fixed_s3a_deci_log) { s3a_log_deci =3D info->s3a.fixed_s3a_deci_log; - } else - { + } else { s3a_log_deci =3D binary_grid_deci_factor_log2(s3a_isp_width, sc_3a_dis_height); } binary->deci_factor_log2 =3D s3a_log_deci; =20 - if (info->enable.s3a) - { + if (info->enable.s3a) { binary->s3atbl_width =3D _ISP_S3ATBL_WIDTH(sc_3a_dis_width, s3a_log_deci); @@ -881,21 +864,18 @@ int ia_css_binary_fill_info(const struct ia_css_binar= y_xinfo *xinfo, binary->s3atbl_isp_height =3D _ISP_S3ATBL_ISP_HEIGHT(sc_3a_dis_height, s3a_log_deci); - } else - { + } else { binary->s3atbl_width =3D 0; binary->s3atbl_height =3D 0; binary->s3atbl_isp_width =3D 0; binary->s3atbl_isp_height =3D 0; } =20 - if (info->enable.sc) - { + if (info->enable.sc) { binary->sctbl_width_per_color =3D _ISP_SCTBL_WIDTH_PER_COLOR(sc_3a_dis_p= added_width, s3a_log_deci); binary->sctbl_aligned_width_per_color =3D SH_CSS_MAX_SCTBL_ALIGNED_WIDTH= _PER_COLOR; binary->sctbl_height =3D _ISP_SCTBL_HEIGHT(sc_3a_dis_height, s3a_log_dec= i); - } else - { + } else { binary->sctbl_width_per_color =3D 0; binary->sctbl_aligned_width_per_color =3D 0; binary->sctbl_height =3D 0; diff --git a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_pa= ram.c b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c index 354e5405fd60..1d20eb650757 100644 --- a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c +++ b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c @@ -101,8 +101,7 @@ int ia_css_isp_param_allocate_isp_parameters(struct ia_= css_isp_param_host_segmen unsigned int mem, pclass; =20 pclass =3D IA_CSS_PARAM_CLASS_PARAM; - for (mem =3D 0; mem < IA_CSS_NUM_MEMORIES; mem++) - { + for (mem =3D 0; mem < IA_CSS_NUM_MEMORIES; mem++) { for (pclass =3D 0; pclass < IA_CSS_NUM_PARAM_CLASSES; pclass++) { u32 size =3D 0; =20 @@ -176,8 +175,7 @@ int ia_css_isp_param_copy_isp_mem_if_to_ddr(struct ia_c= ss_isp_param_css_segments { unsigned int mem; =20 - for (mem =3D 0; mem < N_IA_CSS_ISP_MEMORIES; mem++) - { + for (mem =3D 0; mem < N_IA_CSS_ISP_MEMORIES; mem++) { size_t size =3D host->params[pclass][mem].size; ia_css_ptr ddr_mem_ptr =3D ddr->params[pclass][mem].address; char *host_mem_ptr =3D host->params[pclass][mem].address; diff --git a/drivers/staging/media/atomisp/pci/sh_css.c b/drivers/staging/m= edia/atomisp/pci/sh_css.c index 73bd87f43a8c..e7f2443696d1 100644 --- a/drivers/staging/media/atomisp/pci/sh_css.c +++ b/drivers/staging/media/atomisp/pci/sh_css.c @@ -2256,8 +2256,7 @@ alloc_continuous_frames(struct ia_css_pipe *pipe, boo= l init_time) ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "alloc_continuous_frames() IA_CSS_FRAME_FORMAT_RAW_PACKED\n"); ref_info.format =3D IA_CSS_FRAME_FORMAT_RAW_PACKED; - } else - { + } else { ia_css_debug_dtrace(IA_CSS_DEBUG_TRACE_PRIVATE, "alloc_continuous_frames() IA_CSS_FRAME_FORMAT_RAW\n"); ref_info.format =3D IA_CSS_FRAME_FORMAT_RAW; @@ -7862,8 +7861,7 @@ ia_css_stream_create(const struct ia_css_stream_confi= g *stream_config, =20 /* check if mipi size specified */ if (stream_config->mode =3D=3D IA_CSS_INPUT_MODE_BUFFERED_SENSOR) - if (!IS_ISP2401 || !stream_config->online) - { + if (!IS_ISP2401 || !stream_config->online) { unsigned int port =3D (unsigned int)stream_config->source.port.port; =20 if (port >=3D N_MIPI_PORT_ID) { --=20 2.53.0