From nobody Thu Apr 2 15:37:23 2026 Received: from s.wrqvwxzv.outbound-mail.sendgrid.net (s.wrqvwxzv.outbound-mail.sendgrid.net [149.72.154.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09165340A47 for ; Tue, 10 Feb 2026 09:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.72.154.232 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715445; cv=none; b=Y69N5XPeMAH04NS62LgHz39BiVPAd+Fy5F8l3BVJc4inRdtWPvmwxbcgGBgERAHphMrpHDa6ECxUmj1b9ervr0TcN799oVn0yidJFViQgr9APali0Z+T4Kl52PmJLkyb5hoZMA5tsgk+111ZApYIj+kinK9djHbugmX3TNebhLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770715445; c=relaxed/simple; bh=9jJs7MmJoKsYj3XlZrD6IjmxfM3I0wNi4KUdZUQ/z0w=; h=From:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version: To:Cc:Content-Type; b=Ix0i8KUIXGBUKVacU2FlPEUJh/iHJNEN+tBChS1kHsxR6hJLhUU3YzaEsdC8ON2V92Zm8J9dFg5iAUN3m80LpGI983am14FDMO9Fp5iyhj97EvD2XCEz0JLxPSQgLZS++HgfdQfgTBViMe0/XxXPLu4fKi77cDXNUQcjH/wIxtI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mattwardle.net; spf=pass smtp.mailfrom=em431.mattwardle.net; dkim=pass (2048-bit key) header.d=mattwardle.net header.i=@mattwardle.net header.b=RC/gdnGS; arc=none smtp.client-ip=149.72.154.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mattwardle.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=em431.mattwardle.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mattwardle.net header.i=@mattwardle.net header.b="RC/gdnGS" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mattwardle.net; h=from:subject:date:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:date:from:subject:to; s=s1; bh=dcfTklgjaCy1rPUq2cimFzYnzz4hXIpUGtmQWpURVCM=; b=RC/gdnGSpA/05ZE2HfkUBNzc3GfZXA0ykVegS6mpfVt//+p9E8fszP2Pq+pXgNiRv9cv WWLiKonqUktfNWT0uyFv0A06R3KrJX2SZ7d5D3m2ZPnBRwjRy0pCfKD1laCXTxsODQiJUA zEq6LMlG0QWanbJcvbJMoVP/N7PbX4ueNI5eKV7vQ09Duq8tlPNoZfTgQvrq4SEAillXda wzURGYKhNHTmJi+OhpuVVEADl1xqy7mvmKz3yg5v7F1E7U6KtoLbxKu1zxC2YbumZTE4sd UzzIMOeJwfBE9IWCw0pmby6/zrIAjRvBjHLBOY1TzbnOinwau68bSF9/gW/fByiQ== Received: by recvd-5fb7fdbd94-cwpcz with SMTP id recvd-5fb7fdbd94-cwpcz-1-698AF932-1 2026-02-10 09:24:02.014661469 +0000 UTC m=+55669.421760190 Received: from mail.3n0xdopx5uce3ivigaxioahche.ix.internal.cloudapp.net (unknown) by geopod-ismtpd-9 (SG) with ESMTP id Hm-93m4YR7qK3Sh1Thencg Tue, 10 Feb 2026 09:24:01.896 +0000 (UTC) Authentication-Results: mail.3n0xdopx5uce3ivigaxioahche.ix.internal.cloudapp.net; dmarc=fail (p=reject dis=none) header.from=mattwardle.net Received: from thinkpad (unknown [161.142.117.49]) by mail.3n0xdopx5uce3ivigaxioahche.ix.internal.cloudapp.net (Postfix) with ESMTPSA id A8D9040E37; Tue, 10 Feb 2026 09:24:01 +0000 (UTC) From: Matt Wardle Subject: [PATCH 2/3] staging: media: atomisp: Fix function indentation and braces Date: Tue, 10 Feb 2026 09:24:02 +0000 (UTC) Message-ID: <20260210092243.294732-3-matt@mattwardle.net> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260210092243.294732-1-matt@mattwardle.net> References: <20260210092243.294732-1-matt@mattwardle.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?u001=2EFlbIg1=2FBrpD1HWcEBlj1tgh=2F0VDwewqbkmeZ1SFD9tLmzlDepFYnLmfnO?= =?us-ascii?Q?moWHy7n5HdVZTdyWWeMojZeck4braJp6ggXS5Hg?= =?us-ascii?Q?cJ0Tx4HbZa5NjIBJq7+IQTJAc9yh0Nsf2VPaIe1?= =?us-ascii?Q?fp9P9VSCOImMpkkO6ksDynSXEEjUhrfpshoE10E?= =?us-ascii?Q?O100pz3xsbC3dofMlQ=2FYccprr1I+KW1NQ089kLI?= =?us-ascii?Q?Z37esaK9GizzkqjV4pWtb=2FRD3g5ANuf83353awU?= =?us-ascii?Q?58lY?= To: Hans de Goede , Mauro Carvalho Chehab , Andy Shevchenko Cc: Sakari Ailus , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Matt Wardle X-Entity-ID: u001.OAl4HwJfzvoR6h5DRlrySA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix parameter indentation for functions and move opening braces onto new line. Fix checkpatch.pl errors: ERROR: open brace '{' following function definitions go on the next line Signed-off-by: Matt Wardle --- .../isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c | 11 ++--- .../isp/kernels/raw/raw_1.0/ia_css_raw.host.c | 4 +- .../kernels/sdis/sdis_2/ia_css_sdis2.host.c | 7 ++- .../isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 22 ++++----- .../atomisp/pci/runtime/binary/src/binary.c | 48 +++++++++---------- .../pci/runtime/isp_param/src/isp_param.c | 18 ++++--- 6 files changed, 52 insertions(+), 58 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_c= ss_dvs.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/i= a_css_dvs.host.c index e9d6dd0bbfe2..4c85b5a62224 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.= host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.= host.c @@ -258,12 +258,11 @@ convert_allocate_dvs_6axis_config( return me; } =20 -int -store_dvs_6axis_config( - const struct ia_css_dvs_6axis_config *dvs_6axis_config, - const struct ia_css_binary *binary, - const struct ia_css_frame_info *dvs_in_frame_info, - ia_css_ptr ddr_addr_y) { +int store_dvs_6axis_config(const struct ia_css_dvs_6axis_config *dvs_6axis= _config, + const struct ia_css_binary *binary, + const struct ia_css_frame_info *dvs_in_frame_info, + ia_css_ptr ddr_addr_y) +{ struct ia_css_host_data *me; =20 assert(dvs_6axis_config); diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/ia_c= ss_raw.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/i= a_css_raw.host.c index a00f8d049a33..80fd64a8eb98 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/ia_css_raw.= host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/raw/raw_1.0/ia_css_raw.= host.c @@ -21,8 +21,8 @@ static const struct ia_css_raw_configuration default_conf= ig =3D { }; =20 /* MW: These areMIPI / ISYS properties, not camera function properties */ -static enum sh_stream_format -css2isp_stream_format(enum atomisp_input_format from) { +static enum sh_stream_format css2isp_stream_format(enum atomisp_input_form= at from) +{ switch (from) { case ATOMISP_INPUT_FORMAT_YUV420_8_LEGACY: diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_c= ss_sdis2.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2= /ia_css_sdis2.host.c index 027eae0ca69e..aaabb3388044 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_css_sdis= 2.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_2/ia_css_sdis= 2.host.c @@ -164,10 +164,9 @@ void ia_css_sdis2_clear_coefficients( dvs2_coefs->ver_coefs.even_imag =3D NULL; } =20 -int -ia_css_get_dvs2_statistics( - struct ia_css_dvs2_statistics *host_stats, - const struct ia_css_isp_dvs_statistics *isp_stats) { +int ia_css_get_dvs2_statistics(struct ia_css_dvs2_statistics *host_stats, + const struct ia_css_isp_dvs_statistics *isp_stats) +{ struct ia_css_isp_dvs_statistics_map *map; int ret =3D 0; =20 diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css= _vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css= _vf.host.c index 3c675063c4a7..f8870f7e790d 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.hos= t.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.hos= t.c @@ -45,11 +45,10 @@ int ia_css_vf_config(struct sh_css_isp_vf_isp_config = *to, * to the requested viewfinder resolution on the upper side. The output ca= nnot * be smaller than the requested viewfinder resolution. */ -int -sh_css_vf_downscale_log2( - const struct ia_css_frame_info *out_info, - const struct ia_css_frame_info *vf_info, - unsigned int *downscale_log2) { +int sh_css_vf_downscale_log2(const struct ia_css_frame_info *out_info, + const struct ia_css_frame_info *vf_info, + unsigned int *downscale_log2) +{ unsigned int ds_log2 =3D 0; unsigned int out_width; =20 @@ -80,13 +79,12 @@ sh_css_vf_downscale_log2( return 0; } =20 -static int -configure_kernel( - const struct ia_css_binary_info *info, - const struct ia_css_frame_info *out_info, - const struct ia_css_frame_info *vf_info, - unsigned int *downscale_log2, - struct ia_css_vf_configuration *config) { +static int configure_kernel(const struct ia_css_binary_info *info, + const struct ia_css_frame_info *out_info, + const struct ia_css_frame_info *vf_info, + unsigned int *downscale_log2, + struct ia_css_vf_configuration *config) +{ int err; unsigned int vf_log_ds =3D 0; =20 diff --git a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c = b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c index 60ae7bf5512b..c7962549e999 100644 --- a/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c +++ b/drivers/staging/media/atomisp/pci/runtime/binary/src/binary.c @@ -347,10 +347,10 @@ ia_css_binary_dvs_stat_grid_info( return; } =20 -int -ia_css_binary_3a_grid_info(const struct ia_css_binary *binary, - struct ia_css_grid_info *info, - struct ia_css_pipe *pipe) { +int ia_css_binary_3a_grid_info(const struct ia_css_binary *binary, + struct ia_css_grid_info *info, + struct ia_css_pipe *pipe) +{ struct ia_css_3a_grid_info *s3a_info; int err =3D 0; =20 @@ -439,9 +439,9 @@ supports_bds_factor(u32 supported_factors, return ((supported_factors & PACK_BDS_FACTOR(bds_factor)) !=3D 0); } =20 -static int -binary_init_info(struct ia_css_binary_xinfo *info, unsigned int i, - bool *binary_found) { +static int binary_init_info(struct ia_css_binary_xinfo *info, unsigned int= i, + bool *binary_found) +{ const unsigned char *blob =3D sh_css_blob_info[i].blob; unsigned int size =3D sh_css_blob_info[i].header.blob.size; =20 @@ -464,8 +464,8 @@ binary_init_info(struct ia_css_binary_xinfo *info, unsi= gned int i, /* When binaries are put at the beginning, they will only * be selected if no other primary matches. */ -int -ia_css_binary_init_infos(void) { +int ia_css_binary_init_infos(void) +{ unsigned int i; unsigned int num_of_isp_binaries =3D sh_css_num_binaries - NUM_OF_SPS - N= UM_OF_BLS; =20 @@ -497,8 +497,8 @@ ia_css_binary_init_infos(void) { return 0; } =20 -int -ia_css_binary_uninit(void) { +int ia_css_binary_uninit(void) +{ unsigned int i; struct ia_css_binary_xinfo *b; =20 @@ -625,19 +625,19 @@ binary_in_frame_padded_width(int in_frame_width, return rval; } =20 -int -ia_css_binary_fill_info(const struct ia_css_binary_xinfo *xinfo, - bool online, - bool two_ppc, - enum atomisp_input_format stream_format, - const struct ia_css_frame_info *in_info, /* can be NULL */ - const struct ia_css_frame_info *bds_out_info, /* can be NULL */ - const struct ia_css_frame_info *out_info[], /* can be NULL */ - const struct ia_css_frame_info *vf_info, /* can be NULL */ - struct ia_css_binary *binary, - struct ia_css_resolution *dvs_env, - int stream_config_left_padding, - bool accelerator) { +int ia_css_binary_fill_info(const struct ia_css_binary_xinfo *xinfo, + bool online, + bool two_ppc, + enum atomisp_input_format stream_format, + const struct ia_css_frame_info *in_info, /* can be NULL */ + const struct ia_css_frame_info *bds_out_info, /* can be NULL */ + const struct ia_css_frame_info *out_info[], /* can be NULL */ + const struct ia_css_frame_info *vf_info, /* can be NULL */ + struct ia_css_binary *binary, + struct ia_css_resolution *dvs_env, + int stream_config_left_padding, + bool accelerator) +{ const struct ia_css_binary_info *info =3D &xinfo->sp; unsigned int dvs_env_width =3D 0, dvs_env_height =3D 0, diff --git a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_pa= ram.c b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c index 251dd75a7613..354e5405fd60 100644 --- a/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c +++ b/drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c @@ -93,11 +93,10 @@ ia_css_init_memory_interface( } } =20 -int -ia_css_isp_param_allocate_isp_parameters( - struct ia_css_isp_param_host_segments *mem_params, - struct ia_css_isp_param_css_segments *css_params, - const struct ia_css_isp_param_isp_segments *mem_initializers) { +int ia_css_isp_param_allocate_isp_parameters(struct ia_css_isp_param_host_= segments *mem_params, + struct ia_css_isp_param_css_segments *css_params, + const struct ia_css_isp_param_isp_segments *mem_initializers) +{ int err =3D 0; unsigned int mem, pclass; =20 @@ -171,11 +170,10 @@ ia_css_isp_param_load_fw_params( } } =20 -int -ia_css_isp_param_copy_isp_mem_if_to_ddr( - struct ia_css_isp_param_css_segments *ddr, - const struct ia_css_isp_param_host_segments *host, - enum ia_css_param_class pclass) { +int ia_css_isp_param_copy_isp_mem_if_to_ddr(struct ia_css_isp_param_css_se= gments *ddr, + const struct ia_css_isp_param_host_segments *host, + enum ia_css_param_class pclass) +{ unsigned int mem; =20 for (mem =3D 0; mem < N_IA_CSS_ISP_MEMORIES; mem++) --=20 2.53.0