From nobody Sat Apr 18 06:56:12 2026 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 005C8309EFB for ; Tue, 10 Feb 2026 07:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770708482; cv=none; b=TKHZJ6X6A0zFWyc05aQuzuaH1cBXiRDr9PiSuqJsBhQyC+v3jUSeiow7veboNEoPcF2z1a1qspDj2cDh+6aOe9zVmabzFaP8kXaa0D359vjGM3ipcF3E+y+Nt/BAjS8w+0VNhD+VTBw2n7a7x+HQ9qdlFJcACCRDnt8aVZ4nWOw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770708482; c=relaxed/simple; bh=j93aIEqTGj+396duWgyhguOVoxFq+K21vZAj3wINd/s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Kn4MJYD3jgCQMigzDW4/6HsuVXVpEiW3JTVnKRQZDcy5PUwsGc2sW8pVcgr0FdOJugSr44WkXmHmc6Ek4voJbh6pcLWjYAANoWk2CUIuvNJp0PVwy+SMF+pf3mz+9eGL4u9QTYNnC/8iMttZTGVPR0098+13cX4KZWES/Wo56OM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kCNzqpQs; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kCNzqpQs" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-8244c048d41so3052312b3a.0 for ; Mon, 09 Feb 2026 23:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770708480; x=1771313280; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+2n8AfJ/rmzUBqXia8gMnmb7T2rloTKAYwpyZYCexbI=; b=kCNzqpQse1RkbitxE0xTpog4Wkr2jtjqMfOjzSpdNzb1xGVtNo52/FAYDKQ8GnkuD+ Jbr9ASYd5/754w94bnaTMPyj3oqZPpgvYrbfFpPcncAJ41jNwFkLbdYm693uJk4Xu9LB VUiwdVIlaGxEXgKTFiikuos+j9tDxskEG+nbrlREjX5uYyXIZ/2pKJZ8r+XSt6f/P5EU xIIJu0I03RcmlzrOLJ5EyHC9KS5fyAn6Isi69w5rJVuwyauz58yJE0pv87+j5s776oZZ krptCx9jAToj9paLclibt0avqz5Bgorb958kf3TFuO1Qjh/1yCRk4oxIMrcJTZAQhHz+ TGMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770708480; x=1771313280; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+2n8AfJ/rmzUBqXia8gMnmb7T2rloTKAYwpyZYCexbI=; b=ovqahklvcO/pAmxl2a4MeC+q4tswfiEogJyLcPfLLX2CEANthaP05edueM11+wsVpn Gq/jFzNwrFe63mvSH9vYlUDmJCP9bk21XAlha0UNBTrYIuRlXHhAXV5oL9wHvSCf3wFf FGOBaKEmtgDDGHn9xSGptIEjHvAya5E5+ysRs1qhEYAb0HBUCYjCrEJ0Z4qp5FrS0+6E YH9BVoW/1+DT+2B8+Z8yZ9IqyRljJluPgkEH1F6pTcUDo6FDT6J5yisCJzrKFySBgOQk 2GosKsWIeMsMfo0QmTqwyufp3dF5WV1g8Z+19M+gTBwS6lTVXw4gz24mcBlicaXnijAY P42A== X-Gm-Message-State: AOJu0YxRpBD8OUJWDCsw2i/mqi0LUjKh/x1WRuRfVO0BPFYBiIkFLtH0 ocwhiC/aW2VVcRw3q7iuLnorY4lddyEJl4MVyyK5xDBTpLUKXEsqG/pw X-Gm-Gg: AZuq6aJOyKBl5QMd9ojpkj9/lDeA9nTG/OwxUSb44mTSBmcUEDhyAWyRuziboptB+L0 pEG36tjTXEW/zb04G8+UQxPq/D480qDgErc1GY4BJEG6Mr6Y6/yaEaK8jW8lS/cNPtj4UEfiWSN uUf77tHUEtDsniB9KrXsBhQ+zS2/TJ7TbZScdxHgfq6MtdVFXq4wRfO0lFXXfSkTIXrr4lOh/gZ Z0mGoYHLYqn69ilhWSs3lmScXIPcAtXCKbR/h740tlV30KHW7iGOb+AV2EUZ2GMCo25AEJ7wtzt etX4LtsnICTKsUZtdQPCvR3Fdc2VnmHE7QBMfc71VctIuaAmUi2VXyQBSO3qbMfAZXoWMocrHE8 O178c/a3ajFGvgJVHN+QhqPGzwZFnaBVcCIlsblj7CgPFBgNfVpjZqwlbupkKdhqrvUNWHsHx5s hTeBtrCG0xVGK+i3kaZEYTXFQxsuV4wpDyttMQqgawYLkEXACNWDEYbsCy0A== X-Received: by 2002:a05:6a21:7702:b0:366:19e9:f43 with SMTP id adf61e73a8af0-3941785305emr1343247637.6.1770708480310; Mon, 09 Feb 2026 23:28:00 -0800 (PST) Received: from DESKTOP-MOQC9AF.mioffice.cn ([43.224.245.239]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb5298a9sm10795714a12.14.2026.02.09.23.27.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 23:27:59 -0800 (PST) From: Zhan Xusheng X-Google-Original-From: Zhan Xusheng To: Frederic Weisbecker Cc: linux-kernel@vger.kernel.org, Zhan Xusheng Subject: [PATCH] clockevents: Add error handling and rollback in tick_init_sysfs() Date: Tue, 10 Feb 2026 15:27:54 +0800 Message-ID: <20260210072754.178963-1-zhanxusheng@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ensure proper error handling and logging when creating device files for each CPU. If device creation or file creation fails, the function now properly unregisters the device and removes any previously created files to maintain system consistency. Signed-off-by: Zhan Xusheng --- kernel/time/clockevents.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index eaae1ce9f060..daa875f1d37c 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -756,12 +756,24 @@ static int __init tick_init_sysfs(void) dev->id =3D cpu; dev->bus =3D &clockevents_subsys; err =3D device_register(dev); - if (!err) - err =3D device_create_file(dev, &dev_attr_current_device); - if (!err) - err =3D device_create_file(dev, &dev_attr_unbind_device); if (err) return err; + + err =3D device_create_file(dev, &dev_attr_current_device); + if (err) + goto err_unregister; + + err =3D device_create_file(dev, &dev_attr_unbind_device); + if (err) + goto err_remove_file; + + continue; + +err_remove_file: + device_remove_file(dev, &dev_attr_current_device); +err_unregister: + device_unregister(dev); + return err; } return tick_broadcast_init_sysfs(); } --=20 2.43.0