From nobody Sat Apr 18 06:54:43 2026 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9C59329E4F for ; Tue, 10 Feb 2026 06:53:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.194 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770706430; cv=none; b=cq+BaoeK1aj4fa7Nd06g9hs+f7BdNkXQeUsMna4NRxTo4njyppWEddvH5l1ecABJjRMVlWnzA2wlK8XE5HQeK2z66hr64zxe+WKciq6KuT9l3f5lBES/KvMT27LsIh3rV2xkPQy1AVJgksWcIR3wdm4qmfcR5a654TZA//Q5Bbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770706430; c=relaxed/simple; bh=TYHSo59jwpc6IISLlmY/4lk/BIA8Fbp2hXvGwPzP8yo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dfMGgWrV0MNlOH42sIZIte2xYdK7pn0mDYiZN7gYGbjoPGrysggrXb1m9hQUwE4SWVYyGxzb6I1yWtUEFPSHO7sKVG0Q3Dz2SRd91edVrGVcZwvCwvVjIB6QYR7rEirK2gDI5hhaw64n4vUhBzR3xbRh2fSyWF2ga4qjcp8PXds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QLhkGquq; arc=none smtp.client-ip=209.85.210.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QLhkGquq" Received: by mail-pf1-f194.google.com with SMTP id d2e1a72fcca58-81f47610542so3501013b3a.0 for ; Mon, 09 Feb 2026 22:53:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770706427; x=1771311227; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=K/2qbLVn2pI9kG8ZE9O4WONBuadW6N5yVpKJ1i4ouus=; b=QLhkGquqxdN4iK1DBOxo9PijdMpOLPdxpGRrNuUvVqCXhKd9eZpwMnnjeJch1CveSV Zh9nMUg699DFCp6nUOD9bJ6IFJN2O/ZryN5cEHynfS38jiUODV8GSz3GiI8Clgkm2K+B otMNVn7Q1Gny8RA7xn8scj/I+h8nqAqOae5nmrJpa2r0qoUtPVxYpkvPvdI4S17dQQ/e h5YHz72s5iD7CcdOi2xu0HjUVpkpebrh2Mq6nT9UUGMsLJyciJ1a3qA2sm8R5zxGkZmy 9IyPhETMgeFruLvGxVLbKw2a07B9ocLOpMmn0V32qKUcbW8keVi4tZnzZD/9Y/ZUt9/9 T9ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770706427; x=1771311227; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=K/2qbLVn2pI9kG8ZE9O4WONBuadW6N5yVpKJ1i4ouus=; b=eol58u8DbRTF44rYVY1G6O+2RLGClV6ky3ClJAKNAiGQBUoKS4F/RQqZbP6+v6lnJ7 7p7kAEZCurHnx9wI5fmt9LND8kY+UAQyq1sCAs8/sGN+AC4uQe90UrzVpIngDwpjAXF+ vYkUT7wetaJsH0G6dZahe4JIcRq/0YO1leeMV+L8MHEj4/bGGGkM4SDYmzPPrTJ5EmPa wexYcSBap6uKkRVqPwJ5aeuh69mklcjydJ4y9yTmphey/BY5Bjh/+rMhsGoABQdiWtnx D8ovQnOenibv0fOMKeSO7Ovclsl75VrWlnKxYmxXuWAAP5+GsOFUQGF1ROy5ugPa13gK 5/CQ== X-Forwarded-Encrypted: i=1; AJvYcCUgz/n2kNiq9Exl5T/TXTjbgeL8fex9TyWgkmM4YYpc54MKncEH8Bpr1cCzhEgtE6AIL8q8KLZ6FDFN2fA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzq5v0QMgY7eRFDcyAWiyBQL53zmb++k3QO289f7w7xYdITv0z5 SGz/Lt342itz2YE0OHDvyNerUwra4SxoDdK35+b40DdwWvaBqbmpzrzV X-Gm-Gg: AZuq6aKrJf9H525AqdKtVX36BYf6dDL1SDniLzQjFrGQfEWW9It+cxx5J3oVBlNi1lZ x/ZFj2pNwsk4xkP48VayjTAA16/LADgIHeboHJQ6Iu4kbZKoZQUtxDhToNAnp6EAJJhQ9U+3L+U 8ga213fLJfEHgmDJClqFdOOgerR9wkAr17K2VUvhcH+T23SQ5GZsfKrm95JdrTSDjJeFHfkrwQG H7PxmRWj7oUIeKuTdRXzeAvFT7Fevbhi/tE927azYHIMb6xdBWHDpFAFa3jH/RA/0xcyTFQn91D bORbBgdtga3fyQnt+FDDGGcpiyPWChvxBYfybEr0gIs/Im/fafNVavKipw/0wYxTTFuyJE41b+a RdYMyjXHzs1YDmEIibW9+pys9paLULZF5gXkgRoQrhi+JejWKIaENPoRGx6GnJYO2qgftTohJOc NR0Y63f5h1VIvJmOQtE0MQB6jUFbjGMQ7bT6ugY8tVdWwVD3EqjnfigTsg9m/XJg2KDpc/JM9yE SniIKA= X-Received: by 2002:a05:6a00:2498:b0:81f:9aa4:1e70 with SMTP id d2e1a72fcca58-824417bc327mr11349070b3a.70.1770706427062; Mon, 09 Feb 2026 22:53:47 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([110.93.227.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824418b3b80sm12154180b3a.48.2026.02.09.22.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 22:53:46 -0800 (PST) From: Zeeshan Ahmad To: Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman Cc: Dan Carpenter , Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH v4 1/2] staging: most: dim2: move extra info messages to dev_dbg Date: Tue, 10 Feb 2026 11:51:20 +0500 Message-ID: <20260210065121.3661-2-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260210065121.3661-1-zeeshanahmad022019@gmail.com> References: <20260210065121.3661-1-zeeshanahmad022019@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dim2 driver is currently too talkative in the system logs. Informational messages such as node addresses and state changes are useful for developers but provide unnecessary noise for regular users during normal operation. Move these non-critical info messages to the debug level using dev_dbg(). This ensures a quiet log by default while preserving the information for debugging purposes. Signed-off-by: Zeeshan Ahmad --- v4: - Split the work into a 2-patch series as requested by Greg KH. - Converted non-critical informational messages to dev_dbg() to ensure the driver is quiet during normal operation. - Converted remaining error and warning messages to dev_err() and dev_warn() for proper device-specific logging. v3: - Removed "staging-next" and redundant "[PATCH]" from the subject line. - Shortened commit message lines to stay under 75 characters. - Added this changelog below the "---" as suggested by Ethan Tidmore. - Cleaned up temporary submission notes from the permanent commit body. v2: - Rebased against the staging-next branch. - Fixed CC list to include relevant maintainers. drivers/staging/most/dim2/dim2.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index 80af965356d0..e1b1a606f36a 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -246,9 +246,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, stru= ct mbo *mbo) { u8 *data =3D mbo->virt_address; =20 - pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]); + dev_dbg(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17= ]); dev->link_state =3D data[18]; - pr_info("NIState: %d\n", dev->link_state); + dev_dbg(&dev->dev, "NIState: %d\n", dev->link_state); memcpy(dev->mac_addrs, data + 19, 6); dev->deliver_netinfo++; wake_up_interruptible(&dev->netinfo_waitq); @@ -799,8 +799,7 @@ static int dim2_probe(struct platform_device *pdev) dev_fcnt =3D pdata->fcnt; } =20 - dev_info(&pdev->dev, "sync: num of frames per sub-buffer: %u\n", - dev_fcnt); + dev_dbg(&pdev->dev, "sync: num of frames per sub-buffer: %u\n", dev_fcnt); hal_ret =3D dim_startup(dev->io_base, dev->clk_speed, dev_fcnt); if (hal_ret !=3D DIM_NO_ERROR) { dev_err(&pdev->dev, "dim_startup failed: %d\n", hal_ret); --=20 2.43.0 From nobody Sat Apr 18 06:54:43 2026 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 98F6232E72F for ; Tue, 10 Feb 2026 06:54:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770706444; cv=none; b=Rn+OZtFaClhIoxS/TUgwPthW3RMesSvRKumtCRpH1Pqe5RZN+/mToIyjs4dk735RWWiOpHpH78LZwQDLVB28mCOhqkjWnTdxieEHm36ndcwi82kihD/PVZQnhAtuWd5FO0svLWih87K2swQDRfFSuliNjKcHOrNUJFl/OORc9lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770706444; c=relaxed/simple; bh=Q2VYFQgEVOU/u7R3vzhLGaCgwNXK2WJK6+Zrz42RVWM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JbJTMc5xNd6ARUkrZBsFWXiolNtNK0dbhwYVR9b9Evw611m9PYWc37e7gW6pGSFYRy5ds0v7gfbtP8y6lq3jB+34y46GPf+Uz1kt3QQvTYGaztdTrBVRK8Ooi+I2yapcJaaFyiinCZarpGQxyakFIWZSHuvwEPZ2/R6dZWmOyRs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dUpn52XN; arc=none smtp.client-ip=209.85.210.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dUpn52XN" Received: by mail-pf1-f196.google.com with SMTP id d2e1a72fcca58-81f4f4d4822so238247b3a.3 for ; Mon, 09 Feb 2026 22:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770706441; x=1771311241; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ClrEluuRBpBNX3LtTP3TbTvXVdo/TuK3+YRH6EpwVjE=; b=dUpn52XNUW21flBB1Af3iWcJBLJXqW3dzAByNkwEhd/71QVgLWGPSzaz81paxHMqkl eLpT5qSvBIb9OC6fgGpV0owMNIGCrKqER0iU53KwJg5tKl0448OD25WXSKOz2iKIDsME 21FkO/v3Xex69ORaJMX0Jluj4Mu8h6zuOkqr2eINlRCirJoVIwAEftfmTSmq+mi+8lyo V1fke+I8AG+fB+KEuwY+ORLWrbXXkv0XcREVVK5eJxLHwjeg4EgHTqbHzfhxiQLviToX UVcvHZ/JKSKeAu3kD3p+YPQxXvgkDXOg9QDpi2RRis2BylUVjbPYm53I/SUm5zsvuxIo iRXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770706441; x=1771311241; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ClrEluuRBpBNX3LtTP3TbTvXVdo/TuK3+YRH6EpwVjE=; b=VZfAR8fDbTyb9Z+qA9QdC5VikxScx9V2cLPmRtwyAFgUY9goHwh6egNy0YqOA51RPo 7sc5XF7Xfwwc0aHTEHxiFRDL9yHuv++14/RCt+LOmX2ldHOFoKhLkzgNsy/gxK2betfn V4DE1ZDBogxurU/M5HiEttWWNZ1Wb1Vqkl9zhzW8iwGUaXtR07bZpuVPPqBc7gkqkk08 hiHGwh+IP6nwkIXl8aP1TN+fZhQf/J30kaVCiBLfiMh3uJMKPLjptEONqebn7TwzIIya lNlMkJqworLgN1f+xN47BFSzl7uQxvXf443X7DbmwMRwi6G1GV7tefVrnBAdmdf4cQkR xtoQ== X-Forwarded-Encrypted: i=1; AJvYcCWcA+0yKscqnZoayP6NZCZtgyhTGyecRQqEsSw9Ch9nU9tu8Y6OemXHPfMeCcxWQ4J0gPzc+mwzqoxTxxQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+WulkQeC0hBnL2LzmY1OI1cI570PyQEpoCASUaz1zSyrX9IlS aAl60Y3ieniZzwHCvsYEsLLIuEVL63M/JstHbBzXHBcKYz7A1KurHiSk X-Gm-Gg: AZuq6aJcnGBwvjrCY+3EMGn5K5xXADjiUYfJa+Q47BIl3swnhcfljgsNVzFC7VIcB2j htDaw3srPCR8oTYn0V2JMYou7hDrWW1dbDrmvMjF05xJi45qmCsAHCm7xRqZvCgM25XGfPa5rlI emz1d2RoWsluv9XWGTS/TQGm1qCudyTJgODBzLjvPytHud0aNANc/oNTzUrCoWj+R2UbEfZiaZj 9EN1Os0YGY1BUe25IPcqJZy4dRibaNw650fpn4h29D/+Cfq/wurzFICBf7yfilCY2DR+S7feodd EPEickfSZ30e1l64AkPQC0feK+PvXuyw1ihmrVKK4Y1uQnMuhUN45wmIpHRXjHQlBa/Xb5uNa21 ABCOgihjxLNcvAqjohCtZsJ+BW7V1dUYT6FnxmaHXIZhn9P8wzfQLgu1HWjMHXDrXO5yAlPR2Op mmgKn/MmFklqvlDtRkRs7epv/0leGwd7BEfYfIpl3xEUBdM/Z6M5fri38+lqyVxrPfhhfpGUhUi HokaX0= X-Received: by 2002:a05:6a00:4c07:b0:81f:ac81:d597 with SMTP id d2e1a72fcca58-824413cef8bmr13476647b3a.0.1770706440767; Mon, 09 Feb 2026 22:54:00 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([110.93.227.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824418b3b80sm12154180b3a.48.2026.02.09.22.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 22:54:00 -0800 (PST) From: Zeeshan Ahmad To: Parthiban Veerasooran , Christian Gromm , Greg Kroah-Hartman Cc: Dan Carpenter , Ethan Tidmore , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH v4 2/2] staging: most: dim2: convert pr_err/warn to dev_err/warn Date: Tue, 10 Feb 2026 11:51:21 +0500 Message-ID: <20260210065121.3661-3-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260210065121.3661-1-zeeshanahmad022019@gmail.com> References: <20260210065121.3661-1-zeeshanahmad022019@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The dim2 driver currently uses generic pr_* logging macros for reporting hardware errors. Modern hardware drivers should use the device-specific dev_* logging macros. This provides better context in the system logs by identifying the specific hardware instance associated with the error or warning, which is especially helpful in systems with multiple controllers. Signed-off-by: Zeeshan Ahmad --- v4: - Split the work into a 2-patch series as requested by Greg KH. - Converted non-critical informational messages to dev_dbg() to ensure the driver is quiet during normal operation. - Converted remaining error and warning messages to dev_err() and dev_warn() for proper device-specific logging. v3: - Removed "staging-next" and redundant "[PATCH]" from the subject line. - Shortened commit message lines to stay under 75 characters. - Added this changelog below the "---" as suggested by Ethan Tidmore. - Cleaned up temporary submission notes from the permanent commit body. v2: - Rebased against the staging-next branch. - Fixed CC list to include relevant maintainers. drivers/staging/most/dim2/dim2.c | 40 ++++++++++++++++---------------- 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index e1b1a606f36a..e173a00336fa 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -472,13 +472,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_CONTROL: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_control(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -486,13 +486,13 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ASYNC: new_size =3D dim_norm_ctrl_async_buffer_size(buf_size); if (new_size =3D=3D 0) { - pr_err("%s: too small buffer size\n", hdm_ch->name); + dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_async(&hdm_ch->ch, is_tx, ch_addr, is_tx ? new_size * 2 : new_size); @@ -500,41 +500,41 @@ static int configure_channel(struct most_interface *m= ost_iface, int ch_idx, case MOST_CH_ISOC: new_size =3D dim_norm_isoc_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_isoc(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; case MOST_CH_SYNC: new_size =3D dim_norm_sync_buffer_size(buf_size, sub_size); if (new_size =3D=3D 0) { - pr_err("%s: invalid sub-buffer size or too small buffer size\n", - hdm_ch->name); + dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer siz= e\n", + hdm_ch->name); return -EINVAL; } ccfg->buffer_size =3D new_size; if (new_size !=3D buf_size) - pr_warn("%s: fixed buffer size (%d -> %d)\n", - hdm_ch->name, buf_size, new_size); + dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n", + hdm_ch->name, buf_size, new_size); spin_lock_irqsave(&dim_lock, flags); hal_ret =3D dim_init_sync(&hdm_ch->ch, is_tx, ch_addr, sub_size); break; default: - pr_err("%s: configure failed, bad channel type: %d\n", - hdm_ch->name, ccfg->data_type); + dev_err(&dev->dev, "%s: configure failed, bad channel type: %d\n", + hdm_ch->name, ccfg->data_type); return -EINVAL; } =20 if (hal_ret !=3D DIM_NO_ERROR) { spin_unlock_irqrestore(&dim_lock, flags); - pr_err("%s: configure failed (%d), type: %d, is_tx: %d\n", - hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); + dev_err(&dev->dev, "%s: configure failed (%d), type: %d, is_tx: %d\n", + hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx); return -ENODEV; } =20 @@ -608,7 +608,7 @@ static void request_netinfo(struct most_interface *most= _iface, int ch_idx, return; =20 if (dev->atx_idx < 0) { - pr_err("Async Tx Not initialized\n"); + dev_err(&dev->dev, "Async Tx Not initialized\n"); return; } =20 @@ -657,7 +657,7 @@ static int poison_channel(struct most_interface *most_i= face, int ch_idx) dev->atx_idx =3D -1; spin_unlock_irqrestore(&dim_lock, flags); if (hal_ret !=3D DIM_NO_ERROR) { - pr_err("HAL Failed to close channel %s\n", hdm_ch->name); + dev_err(&dev->dev, "HAL Failed to close channel %s\n", hdm_ch->name); ret =3D -EFAULT; } =20 --=20 2.43.0