From nobody Wed Feb 11 03:02:28 2026 Received: from mail-ej1-f66.google.com (mail-ej1-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9952038A70C for ; Tue, 10 Feb 2026 17:23:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770744235; cv=none; b=hX320V0nU2/mDdV8PKSYvKENQIKuqz39ZUEB+YYqcOa6YgCNiEoMsD1RpZsv/D6ctRNX2u8cwa7UNEai/GkAhA0XpNktkizHXoE81Wtzgi0GVnRSL2Oc1s9gLdrN6tyEWTGyzWlz+j71VerHfy9jNVgYOoRfZvDrZ94KgTneJvA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770744235; c=relaxed/simple; bh=OQpJ7IYnT8xb76mOab+nkkVlDX6VAyHoVT/Zn38Uqtw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=iMjKtryfrqudNUnp6cUcdto1tQiN+kVbOd5F8Ux6r4/gCezlSKRUa/wSwabSbbPPXQiHB+r5s1iu8i5TMnebe70YGF3Axe3Cq64K3OT/M3c4bbggysSQCCRwm8cLqh2h5oLvReM8u17+dr/SWlFXJ8O4bzTTODLlW0kWIeBqg2c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=H2iRf1dr; arc=none smtp.client-ip=209.85.218.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H2iRf1dr" Received: by mail-ej1-f66.google.com with SMTP id a640c23a62f3a-b885a18f620so904789066b.3 for ; Tue, 10 Feb 2026 09:23:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770744232; x=1771349032; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Odlmn82b7E/WniPHvp3dlBNUvvTQqWZ4svWbjlixDwQ=; b=H2iRf1drW++Dxbc3QVrziu0insAA6KgKplODOGVNMKmwSp/EkxdigcDZEXqtA+5ylX BQv9KPhW7P8ehRyOGS1zVsTgaDfp84huJmhP7p8VBtq/vgK7nsW9MqAKwESPZg7z8+xb HiEXe89ND4iBxQrt5aNtJl449b/dTndisSQOvfnxsdw68rV1EX6nyBs49e8S+vBTtrWY MCcsjCaYNU2f5o+Z1DBlalDiftTOIGF7njPSV+NpXHrQd/qGuyJb9Yzw1y9q42fKd7Ba qS1prygXsfLEhAlke0cj0DQiuW7a0DPGoaEAvYWobq0g5pDxzTL2KUJCab7m7cxiWdl+ oQdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770744232; x=1771349032; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Odlmn82b7E/WniPHvp3dlBNUvvTQqWZ4svWbjlixDwQ=; b=QTZpoiVN33M48GS9QvwCd59jNpzd7WTUuCn0/jRfnaFhK6QaXIjXzfD1Fe5t6vXQBQ yPac9xZZf5RwpIjIa9WjXpLzOLsIAnwSsMNQRJ1+FKAk0prLcpupMelLknnKqTLl7gqd gZ42bhCd0YVmwKFn8fdLQc+4w7iPt6T+UtDzs6ODA5arI8gTLDDTCmDjNv/M+ZER1E6T DrfktHTzszD3TjwOmoqxqiCija3THQkbH+3askrkHjD4zYzxguvZSIwgQvjFnOYnQ5iM jztblWTkMVmh1sSR/ZGMSnuGZywOKXXiqx/qWB8Sq/018P5ujdouxMP4OmI0dJ9iMnot NvmQ== X-Gm-Message-State: AOJu0YyGcmC7d/TaBFbRyCjSQObm/NfcEtaXlA8CgxmOMFBDEIQC5psh XXQxD/8sABQM8/jr8ecC2/kYQUVVE9QO77QB91IL5ZBZEkPGCIf7MJqJfwNCfxUO44U= X-Gm-Gg: AZuq6aIruPNIyU/qxB9+LbSgpjX37Ut8kD681RB+DhZfjVLZxK4AJsfhAdo2XMFWARu +t916j8xI7Wu8swDvxSKPBxYE4f5EtDAACHJhWitTGO76UDRtVEuM/PqiBFprhB9CpYPY3DFk9H rHDzA/4eNApqwcT0fqaiv732SA0IMdjYDnR5wkwDjiUKpD3cAhSdbYHLvuYfKxWTt7yfmPmJ65o redmS52OEbM3b1FyrPtzl+zvkhBBYQRaR25tJTlzQ3KrlUVpcc6TB4TBg+bHq30ETpmZKDI2yzN PHqoiiEJUnpaN/DU7BZghOK8G8oOLcjzJSDJCrBTXCS18qzDeEumgC4m+my0E2+35W91RaBxSa8 mP8xQAwmCVt1wnd7IOdo4otwzEWYkX+9d+lJd4ARk1pJARwelwjmvYXAzwu3Qw3Xrn73TNXUq5K N8Xm4LU4dTUs1uV7wHe6AruedHOtoEkMiUm6Trkh0EqeHXKeujIN3SqFXuNP3upBYKl2T+UxE7l iu0MDGlmEs13TbxtbTwCIC3vHZ+ X-Received: by 2002:a17:907:26c7:b0:b88:5957:2d65 with SMTP id a640c23a62f3a-b8f54565497mr184444466b.37.1770744231978; Tue, 10 Feb 2026 09:23:51 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8edae3ae99sm565533666b.60.2026.02.10.09.23.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 09:23:51 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 10 Feb 2026 17:23:50 +0000 Subject: [PATCH v2 1/2] regulator: s2mps11: drop redundant sanity checks in s2mpg10_of_parse_cb() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260210-s2mpg1x-regulators-fixes-v2-1-ab3d3457f1ae@linaro.org> References: <20260210-s2mpg1x-regulators-fixes-v2-0-ab3d3457f1ae@linaro.org> In-Reply-To: <20260210-s2mpg1x-regulators-fixes-v2-0-ab3d3457f1ae@linaro.org> To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Dan Carpenter , Krzysztof Kozlowski X-Mailer: b4 0.14.2 The sanity checks being removed in this commit are useless as earlier code already checks for all conditions, including all error cases like out-of-bounds conditions. In other words, the code being removed here has no effect, as any potential error it could catch will already have been caught by earlier code. The checks removed here are also incomplete (as they're off-by-one) - they should have been checking >=3D ARRAY_SIZE() to be complete. Simply remove this redundant and incorrect code. No functional change. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/aYmsu8qREppwBESH@stanley.mountain/ Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andr=C3=A9 Draszik --- v2: * reword commit message (Krzysztof) --- drivers/regulator/s2mps11.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 2d5510acd0780ab6f9296c48ddcde5efe15ff488..2d67c5c16f487506a2e9e4b119f= 33faa846269f7 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -478,8 +478,6 @@ static int s2mpg10_of_parse_cb(struct device_node *np, return -EINVAL; } =20 - if (ext_control > ARRAY_SIZE(ext_control_s2mpg10)) - return -EINVAL; ext_control =3D ext_control_s2mpg10[ext_control]; break; =20 @@ -503,8 +501,6 @@ static int s2mpg10_of_parse_cb(struct device_node *np, return -EINVAL; } =20 - if (ext_control > ARRAY_SIZE(ext_control_s2mpg11)) - return -EINVAL; ext_control =3D ext_control_s2mpg11[ext_control]; break; =20 --=20 2.53.0.rc2.204.g2597b5adb4-goog From nobody Wed Feb 11 03:02:28 2026 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56F9E38A299 for ; Tue, 10 Feb 2026 17:23:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770744235; cv=none; b=hqtMCy1ZMQCGoGKJilxPJwvis8s3B2POr3z2h3HgSaHY/5pfOv0+JAj0+b2kuHoL9mKagKkDCQkrN5qswxNnoADY9nETcQRKLns0eR0bYa5uzitRoqANBQcax4d3mU0duoJDoRwklIIv2U3YMGlhNx/s+4wHv7ANEZNEbxCV+3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770744235; c=relaxed/simple; bh=V8OfhvBu1qNdN0KD4nFF3ROMtpeDRLHG6GJmQmeUi2M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rvwHRylVRrXl12Bg+r91kKXMXlRqKFvErC+Xr6epQOV1dCPEgWC9WGJmmVSqo2alvuc9GKSxF5cyiUUivKtgyt1De/OS7TiU825f0jJhOPi8cQwShtGRwRpPdiBgbZ4hbFaS8zQNwGBRtgcLyq+VHX9nQmYgZMu95QsoYI9QAQg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ElN3SjIc; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ElN3SjIc" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-b8876d1a39bso623074166b.1 for ; Tue, 10 Feb 2026 09:23:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770744233; x=1771349033; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=iQDNu+LBE5AULrwMKg6yBqocyEp3U+FKLIXmvE5hWBs=; b=ElN3SjIcYnKvykj0s2ap5fU++kJbA+OynAbOndMA7afksu7Q32aBvK94jtztl5W2oD o9PobOUHK/OBtmTy6QinZSgigX+l3c76lzGSEJvvkydm/+lOiGgeLQKXLJFMe4i+KLwT S+vaKek142k9XpWiAzpMqNbc1v3ph3RREWyeqXb+mvJfLxg8JwA+YYWKSglxjRWcioow e9k6BjjStWRR6fqu5LXufLRHC8VUMhy+7gQjKLIKttmJDEKWwPiIQx3OuznP4Erzst6L wqpGpKgloxLXcyO52KKInwuaR7tk2fJqdlrgCzMn1knRQa0yan5VUhu8kDddDosemDNJ Aonw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770744233; x=1771349033; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=iQDNu+LBE5AULrwMKg6yBqocyEp3U+FKLIXmvE5hWBs=; b=ooJhcisDg++3NUEsVAJSAHyukPCnzqD/zLUB+sXEH6yUd2QAPqwlnJjekyiZ1mOwBU R174amaS00Hd39EccTt8n9bwxmMGVkrzKUyDSW/3zIzui29qviqyaXSbV4Gm5Rnadalq Bg+z0IY8mS76Q0fSjFetLrRZvm+6F2tfB6iYZIja2kZTkjRddJaTFdyMBb87+60tYPdz 07j0xhRA4T6eOvjP8m1K0MKimFD9w/TDbi/X+PQPPOrKGpdLW+ElbqJlFDZ4B4DKENnL KbKndWCvM6LWtSEA/b7W/XuoSaR/eAfVQdqiWQKAGLyu9aw3qsKZu/H0S5KDdMh1X6j0 m4KA== X-Gm-Message-State: AOJu0YwmUJMtRWPp5iUiNq+2Rg1JzOku8rAjuW07Fw67kN5xD8HT8bST 8HoPkmOhY4oMU9q+E3F7z2vLXcJSSKaYnXDPs9d4Y/r3nIqWH0rw6W6wvfPn9wbwoJA= X-Gm-Gg: AZuq6aJsqrj4m0dehaRzjwuBVM5+A/h6Da6ZhY+DgZjcJJNbeKqPK/WlH1VllXjWkaN ROEafQI5C6TVikGsgKtd5zH+BxOV//Sgb2UFaL/xfcb2JxPrCzpdd7icj2fezEdJn7V32bJljwJ T5kFxfpmgkPHJD/T3o6+O+GuB2sT1GI4PLdOehqTIf2fSEAW/JJtg6Z1P5quomimr+ze/1MdrW6 X4PT175clF3sKfjOregBX4Z797Ytonad0reAINNwn0EurhF5AcIy5wl4WFWfjssvPGhwsJ3aNkr qZWuz+5aihaEr6a6OqlJ3x5w1YqbQz2EfBHbBWkxEi1/nAirnTfzcd4wIGTAHRqnKbE+tzQgrvZ 1Q+EKzZ23CrrnGLLC7AzeOSj4SQdUe8lwCD5hk2L1eiijv5slryEFXwISla2IddLLTENNhbWB8x 4DnIKEYV9x9jUwiRPz1VYQQMT93/OI7980MdE0pAkKwtH2N5bSIW4rk810U8JKcIG01ruy9Mq5G u8YY3WStLWFZdIeqeOGOZaG/3h3 X-Received: by 2002:a17:907:6d0f:b0:b88:713e:78a5 with SMTP id a640c23a62f3a-b8edf25ccebmr891244466b.28.1770744232655; Tue, 10 Feb 2026 09:23:52 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8edae3ae99sm565533666b.60.2026.02.10.09.23.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Feb 2026 09:23:52 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Tue, 10 Feb 2026 17:23:51 +0000 Subject: [PATCH v2 2/2] regulator: s2mps11: fix pctrlsel macro usage in s2mpg10_of_parse_cb() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260210-s2mpg1x-regulators-fixes-v2-2-ab3d3457f1ae@linaro.org> References: <20260210-s2mpg1x-regulators-fixes-v2-0-ab3d3457f1ae@linaro.org> In-Reply-To: <20260210-s2mpg1x-regulators-fixes-v2-0-ab3d3457f1ae@linaro.org> To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown Cc: linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= X-Mailer: b4 0.14.2 Commit 979dd8da76eb ("regulator: s2mps11: add S2MPG11 regulator") incorrectly ended up using macros for S2MPG10 in the S2MPG11 case. They happen to end up giving the same result, but for clarity, the correct macros should be used. No functional change. Signed-off-by: Andr=C3=A9 Draszik --- drivers/regulator/s2mps11.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 2d67c5c16f487506a2e9e4b119f33faa846269f7..81cfd60460f8bb35a460f44753a= bfbb745121322 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -440,15 +440,15 @@ static int s2mpg10_of_parse_cb(struct device_node *np, [S2MPG10_EXTCTRL_LDO20M_EN] =3D S2MPG10_PCTRLSEL_LDO20M_EN, }; static const u32 ext_control_s2mpg11[] =3D { - [S2MPG11_EXTCTRL_PWREN] =3D S2MPG10_PCTRLSEL_PWREN, - [S2MPG11_EXTCTRL_PWREN_MIF] =3D S2MPG10_PCTRLSEL_PWREN_MIF, - [S2MPG11_EXTCTRL_AP_ACTIVE_N] =3D S2MPG10_PCTRLSEL_AP_ACTIVE_N, - [S2MPG11_EXTCTRL_G3D_EN] =3D S2MPG10_PCTRLSEL_CPUCL1_EN, - [S2MPG11_EXTCTRL_G3D_EN2] =3D S2MPG10_PCTRLSEL_CPUCL1_EN2, - [S2MPG11_EXTCTRL_AOC_VDD] =3D S2MPG10_PCTRLSEL_CPUCL2_EN, - [S2MPG11_EXTCTRL_AOC_RET] =3D S2MPG10_PCTRLSEL_CPUCL2_EN2, - [S2MPG11_EXTCTRL_UFS_EN] =3D S2MPG10_PCTRLSEL_TPU_EN, - [S2MPG11_EXTCTRL_LDO13S_EN] =3D S2MPG10_PCTRLSEL_TPU_EN2, + [S2MPG11_EXTCTRL_PWREN] =3D S2MPG11_PCTRLSEL_PWREN, + [S2MPG11_EXTCTRL_PWREN_MIF] =3D S2MPG11_PCTRLSEL_PWREN_MIF, + [S2MPG11_EXTCTRL_AP_ACTIVE_N] =3D S2MPG11_PCTRLSEL_AP_ACTIVE_N, + [S2MPG11_EXTCTRL_G3D_EN] =3D S2MPG11_PCTRLSEL_G3D_EN, + [S2MPG11_EXTCTRL_G3D_EN2] =3D S2MPG11_PCTRLSEL_G3D_EN2, + [S2MPG11_EXTCTRL_AOC_VDD] =3D S2MPG11_PCTRLSEL_AOC_VDD, + [S2MPG11_EXTCTRL_AOC_RET] =3D S2MPG11_PCTRLSEL_AOC_RET, + [S2MPG11_EXTCTRL_UFS_EN] =3D S2MPG11_PCTRLSEL_UFS_EN, + [S2MPG11_EXTCTRL_LDO13S_EN] =3D S2MPG11_PCTRLSEL_LDO13S_EN, }; u32 ext_control; =20 --=20 2.53.0.rc2.204.g2597b5adb4-goog