From nobody Tue Feb 10 06:04:42 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9A681C7012 for ; Mon, 9 Feb 2026 17:38:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770658716; cv=none; b=ISJnI8pH24tePCbak1DaCAPmwPXOwSJ3dtScTiPy9moVl6JlrGjjva3Ugz1ASSERC7AV+DJfENd78QXfa1OFNK23BP4a1xyDHkk/e9EW2ss4/45MkmGPgBLKMEy92bb36awfBLTzbe1TuzZ9950AdWtIKownNo0y/N7LFnYYUD8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770658716; c=relaxed/simple; bh=m/i1X2lXiKcn07FMp6qZlT9erwk+ht7cleXRIb7SBZM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gAg96F0EcVQqHoizGmCYoy4R6jOSXE46FV4uGF6HC0kJ2tmSxq/FUKSRw19azT8lrzGtAPSVG3aonboQyb9ybwa1xKhmW4mF09KlnD3de8ePoAOsaRw8tCbrTjeYvSnyyn05pcYBvm2YUUdhAgcXU3lU1L8qXr5y3fme53NL2BE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DSMMIrDa; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DSMMIrDa" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-59e17afd2d5so3687547e87.3 for ; Mon, 09 Feb 2026 09:38:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770658714; x=1771263514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wJ1qvlMmC9r0M+r6ivGBZ3k3nGz8gfz87Oob6k8D3IQ=; b=DSMMIrDaZMANDwYalNiCbeYvavfvB3VzGv7KDnUbjFOpTRLoU519pYalgRZMuKil3w W6J9T6trk7A5990RIaxgdVV4ZcqbTiPhxSWIevDWQO+a38YReLbKsoMX3Nb37DNMMYy+ mJNPfV3H4guZWrS2BcU7l+oEkCfGSHrYvHkHX6P58bIZjl4GIlfqgNsVO8lByePiBRAc xVWx0T0OqgLv6w/HLFx+ahyMeBm3DasObvpirLjeb8ToYQ+saFq1qkZAhtXPgRzAEZH/ JZlKPcEW9phHtrMkaaBGdqKVADrRx1OdBUuSn9K8VDhcNSiypICxGMvJytds1PdhtOiO evZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770658714; x=1771263514; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wJ1qvlMmC9r0M+r6ivGBZ3k3nGz8gfz87Oob6k8D3IQ=; b=Qf5Zful8dC8UZfii78s4fn9lprJ1ByeDwj0r3CCafMiwqpDrJdG/LDYX/RhvLNyPZp wLg1ehnClr4TVYRmCSqH0cbo884MP4M/8apv9ae3jrwW49xuNd/HTd/nS0qXfwCHviQU NOcLW1plMMpbZulJx2BJe/7l/EkAQ8f1nimEq+5Z9KsYnF2XZdJtX8z1Bw8GflGZ8mNo 8sKck4iy8VWOFlbbHJVmSARtq0ABhBJOgkFrgw2hzSkBYDEWt5ft+BPflls9ME5mgJ5J D+7VwjC3ImVHGAINyGkWQFqKdmv/VdyorpOi++RvOwuYBddxXeN3t1CtsxKxKLkFQ/4w ux0w== X-Forwarded-Encrypted: i=1; AJvYcCWsMjjRBCKSGFzoZ7X38b+ry/h/wqP8gjDj/8GBHEj3KRlhC2DdtLXmda2oPslYFeamJxs6AxFDzWiG+Is=@vger.kernel.org X-Gm-Message-State: AOJu0YwaXGQQ1F/MUSHuJZ0ThUWZ7KdTcMWWK7vK3Cqe0bmUFjoaLS7+ w3lCQjxXZ1Iz71W+3aEZmO6/jvaXs3j6QwD+4dClLDtmGcLyY9jVJGku X-Gm-Gg: AZuq6aKsL4Xxj4XFtdE7qQBnYbUL5/edLT7ZKzZS4UknbnEJQ5Ih/h44l5FwptMAWrO VZeFZCqCOFR1FelN8qoltvoQwpX8x8I0/V/6gICrdezzGA6EzZm7TcVgdrSTC7IN7jR/ZeZ/wRc grAzZTXI/ttBdoJTSKS6Ewo+oXzxlEJ8JfU32VvYafbWut6qT7IoF07eL3AeJtx1nBKQ3FKaGQf P2alsbSiQTTgYsYm+y4AUFijxUwRNsYjUh80xBPRZWTFMYOxNXBdalpRi6yg3VunkdUyuuYEpWE drsVQRJJ09kBbxIk//2yRc6CQAULOdMJhyJ8UJ4bZzMg8bW2pkuAXNgd+PYbJRo73tB40TlBkiH KlEwF4pQY4xnP+versUog+v05Gdb4oW6QSDfEAjmKO9zq52MEHjWep0gIikwwoJafpyziwtYw88 i5rxzmGyKQjii+RInclQVAW+uvgBHlaULV3t6X3amrdu9ijdIdIm0JEJurQvs1FflOHdUWLGHli 6HaD60C9SOMpziEqzy8BgpABQ== X-Received: by 2002:a2e:be91:0:b0:37c:cf34:536c with SMTP id 38308e7fff4ca-386b4e92401mr37765091fa.3.1770658713610; Mon, 09 Feb 2026 09:38:33 -0800 (PST) Received: from localhost.localdomain ([176.33.64.73]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-386b62363a9sm26282541fa.9.2026.02.09.09.38.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 09:38:33 -0800 (PST) From: Alper Ak To: rafael@kernel.org Cc: lenb@kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Alper Ak Subject: [PATCH] ACPI: battery: Avoid dereferencing battery before NULL check Date: Mon, 9 Feb 2026 20:38:27 +0300 Message-ID: <20260209173827.87744-1-alperyasinak1@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" acpi_battery_notify() dereferences the battery pointer before checking for NULL. Reorder the check to ensure the pointer is validated before use. This issue was reported by the Smatch static analyzer. Fixes: 08b54fd57782 ("ACPI: battery: Adjust event notification routine") Signed-off-by: Alper Ak --- drivers/acpi/battery.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index 3bbddd6f622c..abc82be69215 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -1063,12 +1063,14 @@ static void acpi_battery_refresh(struct acpi_batter= y *battery) static void acpi_battery_notify(acpi_handle handle, u32 event, void *data) { struct acpi_battery *battery =3D data; - struct acpi_device *device =3D battery->device; + struct acpi_device *device; struct power_supply *old; =20 if (!battery) return; =20 + device =3D battery->device; + guard(mutex)(&battery->update_lock); =20 old =3D battery->bat; --=20 2.43.0