From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12FBE369204 for ; Mon, 9 Feb 2026 10:44:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.68 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633870; cv=none; b=Pah4X7TyF7CRnL7vCMPET1zGRPS6FLJo+ZKQKd9r36zVIxrc14YEDKY6ZU0q0Dh1lUJemcmElea81J9G+G+dhq9FcEYiq+3hjADu6b9jskIEZuVH3AGwSiS+K3FheyJm9KYmffC/wOIWnhALtq2fEqC/ArjDPGjg/NxaZgwqtpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633870; c=relaxed/simple; bh=0rMc9serpkGe0Fm6CAZ7oAjYMwzI8MQXlyyHyy0L5GA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ZWCQODr9u5nfxOulowfF1bqzXOMVjAt9b4Ql2qRTK3reSe1CaJbG4D9TJEUOjlfIK7yCZ2rVyyARi5R5ymzJz8vcIqqE5boEFlJ2XuoTFpx9CS8UDSM05azQZHCX0n30xlAI+dk3djM7biDziFLQnI5Ito723MKex+U22neOHSo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pt3lXARm; arc=none smtp.client-ip=209.85.167.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pt3lXARm" Received: by mail-lf1-f68.google.com with SMTP id 2adb3069b0e04-59de2d1fc2cso6369974e87.2 for ; Mon, 09 Feb 2026 02:44:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633868; x=1771238668; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pvOWIK1480Z8Yx2DsXHdUSkuQ/WnPILfKjXKA3uostg=; b=Pt3lXARmjg3kVulV3S5F7WLUVPqFht8rBb9v9tagQPuKAud9SSF8o9gteV5jYy9kv0 pjDE+bPx1h2AqwKfxiTmVeSc7RS9ye+WroCUjeFMn4Q/8e735BAU1aP+hBiErrd4ZYoQ T+cgyV8o5BLmg7qTmtoMkV/yCf+hEregYpf64ttZehYgWP9ThvU4FYQhMewZ8u/NPtxJ 2JMylXD5aPt4yB2GQjbLk1D6CVXpr7mmrot3TajSTupjbkbYJvHkiMlHcWMnK25hFF0P OBEZI0JCeR4+1o2N5oY91fEl4r5fmBgvLr+o6NcoX5TVr9ZUS5GlSGBhSZkS2C6QYWW/ 2PFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633868; x=1771238668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=pvOWIK1480Z8Yx2DsXHdUSkuQ/WnPILfKjXKA3uostg=; b=SNy+zOVKYxaNRcMNVPpIqv7NzoydZ+1tT/yWnP2gRnbgKYjSQ3aFBMT3H/rYP/qN5u nGMVRDwMSeTcLemeulh4DcAwJsf3ySC2h3CG05oTS3MAD2qhHP//tbM80GdM7FE/U05m DBH3pqlqj2wUCQxskTrYOBiOLl/eSgG2IRRnE49rPojTWijMInaIkIeauoYNSAz68Z4I PrJRmMxBUxWIi0c9Fee+i4wmFwvne87HDUTPpwgXyXAhdg8fBAIVjbXhSWKzbbKhJxAe EV65Cfn5QoFQEZVjw7+9iuls+vLFyYdiXbPwspRLOxwi/0OBN3xpDIrDvM+IroAyOrVV 9OUg== X-Forwarded-Encrypted: i=1; AJvYcCXgG1DgdHM4IxPIuHkRlM66vb6wNcEM+q3aQrNAzFvw8kuDP51egKFVJfOO2wRWusI2LqfSRtewwT5kkz8=@vger.kernel.org X-Gm-Message-State: AOJu0YwtkG+9oxhM6y1eaeH8TFBW3gR6WAUhGsWNoqqvqYzhtf2R5fIS yt4M3lEvxfiYPoVGDQqxO2Dz7SceaQCYOAvf4IC2zF8YpA/H3Ns3l/ED X-Gm-Gg: AZuq6aIwsHqs+25lTXFsyZ6X+LT4ce7VVAKvmM+wmO+DtvK7ccd2HS/ptLAe9Rh7K8d BPfo9Vpt1k0xAJg7LfP2fegqtuXUjdyQi8WyLWcwlQKA2YOTuPPZIXsbB3LfxipkQFRenurjWpX bzieaT0j9Blc6uXhp/LclSiQigdzPvrxe5cKlIQztaKgdqQ8wT207wnXUd4zUzir3GyYjmv8s2H TqwIDmamA94VGCJYlCwXYVWS0EuqqQ7uI1jz4Ub8F6Mp1NWRTkqhP2yOjx0R+4iLSc+wvYp5fGq OkuhzRxucJbH/wZZb8+vZNHqnq+nZLk3cWCMU6y5Bja9b4Va1MmoCQiFKhsHF4wxk0a4vyy9rV/ cLIKaqjDZ4d7zZewkkqmA1+DWPKQ9QO6kA5G6/uw82HOtNlsu3JpDXOHyMyZbB2j+EoW/RhvI5V 9b X-Received: by 2002:a05:6512:32c8:b0:59d:d615:4b72 with SMTP id 2adb3069b0e04-59e451532f8mr3290200e87.25.1770633867920; Mon, 09 Feb 2026 02:44:27 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:27 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 1/9] dt-bindings: misc: document ASUS Transformers EC DockRAM Date: Mon, 9 Feb 2026 12:43:59 +0200 Message-ID: <20260209104407.116426-2-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Documenting an I2C device used in conjunction with the EC on ASUS Transformers. The main function of DockRAM (the name used by downstream ASUS sources) is to provide power-related functions, such as battery and charger communication. The device is exposed as an individual entity because multiple embedded controllers can utilize the same DockRAM instance. Signed-off-by: Svyatoslav Ryhel --- .../bindings/misc/asus,dockram.yaml | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 Documentation/devicetree/bindings/misc/asus,dockram.yaml diff --git a/Documentation/devicetree/bindings/misc/asus,dockram.yaml b/Doc= umentation/devicetree/bindings/misc/asus,dockram.yaml new file mode 100644 index 000000000000..0cfde619ba01 --- /dev/null +++ b/Documentation/devicetree/bindings/misc/asus,dockram.yaml @@ -0,0 +1,40 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/misc/asus,dockram.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Asus Transformer EC DockRAM + +maintainers: + - Svyatoslav Ryhel + +description: + Dedicated i2c device used to provide power related functions of the + embedded controller used in ASUS Transformer device family. + +properties: + compatible: + const: asus,dockram + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + dockram@17 { + compatible =3D "asus,dockram"; + reg =3D <0x17>; + }; + }; +... --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A5A2369224 for ; Mon, 9 Feb 2026 10:44:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633871; cv=none; b=T8cttjAVxWSv7QVKM59S5CVYAKBQXijJUpaMza2qyrv8/YAQzvdLfES1MYnn4xwj6oeSbix6PN5u953blXV0uU4AYI70Gj/Q9EEnAL+T8kR4p8edeGuWOExiTTk3Cxg4om06w5tISh2rjN/Ggf6BQXdqLcbY4BA3iteCJKY8Qrc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633871; c=relaxed/simple; bh=LN5BArXu/Se7+4dtxV14gw9vAVWZi+IUkDx4iP67oRI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CPzDWaq/SbE5hwSLGXW6ebbN7wgPez5BhJw5g2ovjlkT7OZZn0g4voFs02pb62tTCKAROkyM1V5iM5oZlTjfB4d/USlWuCDul6qMKazRMhKRLI92f7CB9qZ26jYgh/0WL9j7hveFmlaZE5YYJgOaDX4853769DZULyCk8kViMPk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Chz2uP1z; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Chz2uP1z" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-59dea72099eso2802529e87.0 for ; Mon, 09 Feb 2026 02:44:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633870; x=1771238670; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Uq2FpxhF2cZ84ZQ1df1uG3zKLBW+YrD//0pnj4fZFUA=; b=Chz2uP1zG6zYtVaC8jpJtQgeZGmqVBqYxQF7pMQ1WZnXTKcc52oEspwfMDkTC8CEHu +3XEEhwA8d5M92g181htNe72LV/BHj+QPp5V0ysVLv7Siq7GNJLOodPFINSDnNHJdbtb SFxEVH+PgAmtXCAIIMhCwKZFYKdTnrpXumOf/WaLOISdBWXajGaWWAvwRTqEbDFWHoFf s+EmFqQ9WFOKNGK1N+l9o+6Vt0Lm+/TokU7erECXcMiGvVFZxTTeaQx+3cDYxOsAqYSc HsYasm6nFByxLcrtGSEBwFZGRLY7s17oVuwYVhMcBqgELV2oUQ9JfgI/Gi1gHDOyOX9F +TdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633870; x=1771238670; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Uq2FpxhF2cZ84ZQ1df1uG3zKLBW+YrD//0pnj4fZFUA=; b=dFndN+oR61C7Ae89eXRbcXDXrSvum7+Tc8pU3M887TPDVSH2MrbLRNryG/dZNulhMr BLPGUZnKKoSSNzPMR/VHJG5cVy3n88dw3xCiwK0UalA2kkrz9dUill4Fql8EVShxXH3s 8ehgvlNqqz5iUaG2HLrm9qyDvGFbiLvC4uG/iPqKN+m3CMlazRSVTKea0cJlqMMTSlnu Z2O3ZjaQSuqbswRl8M7SbctuS5VLWCT7y/3L3n2uyCqVPfQOpEhCdhZcsjqjGz6cgWmD +kjdKk1LSbsiWptPzxofswf9buAz6S87yeC6oI4RliW3EAAXLPj+xCUitLKuBgVfq8mO JIJw== X-Forwarded-Encrypted: i=1; AJvYcCUfmg0uxiawn0+M8UDmEzqFmqtgkjdWbQJxt6IhdkLnXyCRT6vKKllykt9AUqc4k4RUln+ER34bV38az6o=@vger.kernel.org X-Gm-Message-State: AOJu0Yzc/pUJlKXeyqV80WYW+xi3Xh8LhMhTEr3B3IJrnzwF9my11lq0 xXrDoRnx12f4a+GzKMV7Ex6o3L5s/jyil1/SZW5vpN2MaUAbF45aXBu+ X-Gm-Gg: AZuq6aKTAvm6mx3fDayZI69m0ySWf8V4yUDf+S7DiT2fOoh/8/hTTXBUfMiz2H7okNw 4jTE++xs3x1wT9p37fdlYdNetkaxlPkH5C9NBYUhcRunKv1UFNrf+oHf63LEw32zt7ynjwfI7dH Kzc0hn3yHlC7ogD8aR1ZHqb9AlrhH2K/lMOTG1HjFtOGfw44OLdytJ51O/la9SONu6pLwH+Mz02 G8yOkrxSmeYlXWy+XUb23tmf2rbImDGbTvc57PswwrFf8lFZFZI1uYVpdj3P13ln6fibXaH3UUm YZhF6h1tQyI4oJxgGZaLYoZjZY6cPwK54hLRVJgzzbu7NDYOf8ojA2E1BXhqHn32s8SSJzrueST xfEDD38hVArhyzpt/J4aDBdGszuJGSq7TTgstFsddW76W+YCTrhgUXchmo051qTgPVpq87ssejm SZymEqsNzhCEo= X-Received: by 2002:a05:6512:1591:b0:59e:249f:81c7 with SMTP id 2adb3069b0e04-59e451583demr2912259e87.30.1770633869363; Mon, 09 Feb 2026 02:44:29 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:28 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 2/9] misc: Support Asus Transformer's EC access device Date: Mon, 9 Feb 2026 12:44:00 +0200 Message-ID: <20260209104407.116426-3-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for accessing Embedded Controller of Asus Transformer devices. This will be used by the EC MFD drivers. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/misc/Kconfig | 9 + drivers/misc/Makefile | 1 + drivers/misc/asus-dockram.c | 370 ++++++++++++++++++++++++++++++++++++ include/linux/mfd/asus-ec.h | 24 +++ 4 files changed, 404 insertions(+) create mode 100644 drivers/misc/asus-dockram.c create mode 100644 include/linux/mfd/asus-ec.h diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index dd1ab7e445ac..e7faa7ab4199 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -50,6 +50,15 @@ config AD525X_DPOT_SPI To compile this driver as a module, choose M here: the module will be called ad525x_dpot-spi. =20 +config ASUS_DOCKRAM + tristate "Asus Transformer's EC DockRAM" + depends on I2C + help + Select this if you are building for Asus Transformer's. + + To compile this driver as a module, choose M here: the + module will be called asus-dockram. + config DUMMY_IRQ tristate "Dummy IRQ handler" help diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index bfad6982591c..d2287e912d59 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_IBMVMC) +=3D ibmvmc.o obj-$(CONFIG_AD525X_DPOT) +=3D ad525x_dpot.o obj-$(CONFIG_AD525X_DPOT_I2C) +=3D ad525x_dpot-i2c.o obj-$(CONFIG_AD525X_DPOT_SPI) +=3D ad525x_dpot-spi.o +obj-$(CONFIG_ASUS_DOCKRAM) +=3D asus-dockram.o obj-$(CONFIG_ATMEL_SSC) +=3D atmel-ssc.o obj-$(CONFIG_DUMMY_IRQ) +=3D dummy-irq.o obj-$(CONFIG_ICS932S401) +=3D ics932s401.o diff --git a/drivers/misc/asus-dockram.c b/drivers/misc/asus-dockram.c new file mode 100644 index 000000000000..ecda7b0c6d63 --- /dev/null +++ b/drivers/misc/asus-dockram.c @@ -0,0 +1,370 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASUS EC: DockRAM + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct dockram_ec_data { + struct mutex ctl_lock; /* prevent simultaneous access */ + char ctl_data[DOCKRAM_ENTRY_BUFSIZE]; +}; + +/** + * asus_dockram_read - Read a register from the DockRAM device. + * @client: Handle to the DockRAM device. + * @reg: Register to read. + * @buf: Byte array into which data will be read; must be large enough to + * hold the data returned by the DockRAM. + * + * This executes the DockRAM read based on the SMBus "block read" protocol + * or its emulation. It extracts DOCKRAM_ENTRY_SIZE bytes from the set + * register address. + * + * Returns a negative errno code else zero on success. + */ +int asus_dockram_read(struct i2c_client *client, int reg, char *buf) +{ + struct device *dev =3D &client->dev; + int ret; + + memset(buf, 0, DOCKRAM_ENTRY_BUFSIZE); + ret =3D i2c_smbus_read_i2c_block_data(client, reg, DOCKRAM_ENTRY_BUFSIZE,= buf); + if (ret < 0) + return ret; + + if (buf[0] > DOCKRAM_ENTRY_SIZE) { + dev_err(dev, "bad data len; buffer: %*ph; ret: %d\n", + DOCKRAM_ENTRY_BUFSIZE, buf, ret); + return -EPROTO; + } + + dev_dbg(dev, "got data; buffer: %*ph; ret: %d\n", + DOCKRAM_ENTRY_BUFSIZE, buf, ret); + + return 0; +} +EXPORT_SYMBOL_GPL(asus_dockram_read); + +/** + * asus_dockram_write - Write a byte array to a register of the DockRAM de= vice. + * @client: Handle to the DockRAM device. + * @reg: Register to write to. + * @buf: Byte array to be written (up to DOCKRAM_ENTRY_SIZE bytes). + * + * This executes the DockRAM write based on the SMBus "block write" protoc= ol + * or its emulation. It writes DOCKRAM_ENTRY_SIZE bytes to the specified + * register address. + * + * Returns a negative errno code else zero on success. + */ +int asus_dockram_write(struct i2c_client *client, int reg, const char *buf) +{ + if (buf[0] > DOCKRAM_ENTRY_SIZE) + return -EINVAL; + + dev_dbg(&client->dev, "sending data; buffer: %*ph\n", buf[0] + 1, buf); + + return i2c_smbus_write_i2c_block_data(client, reg, buf[0] + 1, buf); +} +EXPORT_SYMBOL_GPL(asus_dockram_write); + +/** + * asus_dockram_access_ctl - Read from or write to the DockRAM control reg= ister. + * @client: Handle to the DockRAM device. + * @out: Pointer to a variable where the register value will be stored. + * @mask: Bitmask of bits to be cleared. + * @xor: Bitmask of bits to be set (via XOR). + * + * This performs a control register read if @out is provided and both @mask + * and @xor are zero. Otherwise, it performs a control register update if + * @mask and @xor are provided. + * + * Returns a negative errno code else zero on success. + */ +int asus_dockram_access_ctl(struct i2c_client *client, u64 *out, u64 mask, + u64 xor) +{ + struct dockram_ec_data *priv =3D i2c_get_clientdata(client); + char *buf =3D priv->ctl_data; + u64 val; + int ret =3D 0; + + guard(mutex)(&priv->ctl_lock); + + ret =3D asus_dockram_read(client, ASUSEC_DOCKRAM_CONTROL, buf); + if (ret < 0) + goto exit; + + if (buf[0] !=3D ASUSEC_CTL_SIZE) { + ret =3D -EPROTO; + goto exit; + } + + val =3D get_unaligned_le64(buf + 1); + + if (out) + *out =3D val; + + if (mask || xor) { + put_unaligned_le64((val & ~mask) ^ xor, buf + 1); + ret =3D asus_dockram_write(client, ASUSEC_DOCKRAM_CONTROL, buf); + } + +exit: + if (ret < 0) + dev_err(&client->dev, "Failed to access control flags: %d\n", + ret); + + return ret; +} +EXPORT_SYMBOL_GPL(asus_dockram_access_ctl); + +static ssize_t dockram_read(struct file *filp, char __user *buf, + size_t count, loff_t *ppos) +{ + struct i2c_client *client =3D filp->private_data; + unsigned int reg, rsize; + ssize_t n_read =3D 0, val; + loff_t off =3D *ppos; + char *data; + int ret; + + reg =3D off / DOCKRAM_ENTRY_SIZE; + off %=3D DOCKRAM_ENTRY_SIZE; + rsize =3D DOCKRAM_ENTRIES * DOCKRAM_ENTRY_SIZE; + + if (!count) + return 0; + + data =3D kmalloc(DOCKRAM_ENTRY_BUFSIZE, GFP_KERNEL); + + while (reg < DOCKRAM_ENTRIES) { + unsigned int len =3D DOCKRAM_ENTRY_SIZE - off; + + if (len > rsize) + len =3D rsize; + + ret =3D asus_dockram_read(client, reg, data); + if (ret < 0) { + if (!n_read) + n_read =3D ret; + break; + } + + val =3D copy_to_user(buf, data + 1 + off, len); + if (val =3D=3D len) + return -EFAULT; + + *ppos +=3D len; + n_read +=3D len; + + if (len =3D=3D rsize) + break; + + rsize -=3D len; + buf +=3D len; + off =3D 0; + ++reg; + } + + kfree(data); + + return n_read; +} + +static int dockram_write_one(struct i2c_client *client, int reg, + const char __user *buf, size_t count) +{ + struct dockram_ec_data *priv =3D i2c_get_clientdata(client); + int ret; + + if (!count || count > DOCKRAM_ENTRY_SIZE) + return -EINVAL; + if (buf[0] !=3D count - 1) + return -EINVAL; + + guard(mutex)(&priv->ctl_lock); + + priv->ctl_data[0] =3D (u8)count; + memcpy(priv->ctl_data + 1, buf, count); + ret =3D asus_dockram_write(client, reg, priv->ctl_data); + + return ret; +} + +static ssize_t dockram_write(struct file *filp, const char __user *buf, + size_t count, loff_t *ppos) +{ + struct i2c_client *client =3D filp->private_data; + unsigned int reg; + loff_t off =3D *ppos; + int ret; + + if (off % DOCKRAM_ENTRY_SIZE !=3D 0) + return -EINVAL; + + reg =3D off / DOCKRAM_ENTRY_SIZE; + if (reg >=3D DOCKRAM_ENTRIES) + return -EINVAL; + + ret =3D dockram_write_one(client, reg, buf, count); + + return ret < 0 ? ret : count; +} + +static const struct debugfs_short_fops dockram_fops =3D { + .read =3D dockram_read, + .write =3D dockram_write, + .llseek =3D default_llseek, +}; + +static int control_reg_get(void *client, u64 *val) +{ + return asus_dockram_access_ctl(client, val, 0, 0); +} + +static int control_reg_set(void *client, u64 val) +{ + return asus_dockram_access_ctl(client, NULL, ~0ull, val); +} + +DEFINE_DEBUGFS_ATTRIBUTE(control_reg_fops, control_reg_get, control_reg_se= t, "%016llx\n"); + +/** + * asus_dockram_debugfs_init - Register DockRAM debugfs. + * @client: Handle to the DockRAM device. + * @debugfs_root: Pointer to the root directory dentry. + * + * Creates a debugfs setup for DockRAM in the directory of the linked EC. + * The debugfs setup must be removed by the caller. + * + * Return: 0 on success or a negative error code on failure. + */ +void asus_dockram_debugfs_init(struct i2c_client *client, struct dentry *d= ebugfs_root) +{ + struct dentry *dockram_dir; + + dockram_dir =3D debugfs_create_dir("dockram", debugfs_root); + + debugfs_create_file("control_reg", 0644, dockram_dir, client, &control_re= g_fops); + debugfs_create_file("dockram", 0644, dockram_dir, client, &dockram_fops); +} +EXPORT_SYMBOL_GPL(asus_dockram_debugfs_init); + +static int asus_dockram_probe(struct i2c_client *client) +{ + struct dockram_ec_data *priv; + struct device *dev =3D &client->dev; + + if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_I2C_BLOCK)) + return dev_err_probe(dev, -ENXIO, + "I2C bus is missing required SMBus block mode support\n"); + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + i2c_set_clientdata(client, priv); + mutex_init(&priv->ctl_lock); + + return 0; +} + +static const struct of_device_id asus_dockram_ids[] =3D { + { .compatible =3D "asus,dockram" }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_dockram_ids); + +static struct i2c_driver asus_dockram_driver =3D { + .driver =3D { + .name =3D "asus-dockram", + .of_match_table =3D of_match_ptr(asus_dockram_ids), + }, + .probe =3D asus_dockram_probe, +}; +module_i2c_driver(asus_dockram_driver); + +static void devm_i2c_device_release(struct device *dev, void *res) +{ + struct i2c_client **pdev =3D res; + struct i2c_client *child =3D *pdev; + + if (child) + put_device(&child->dev); +} + +static struct i2c_client *devm_i2c_device_get_by_phandle(struct device *de= v, + const char *name, + int index) +{ + struct device_node *np; + struct i2c_client **pdev; + + pdev =3D devres_alloc(devm_i2c_device_release, sizeof(*pdev), + GFP_KERNEL); + if (!pdev) + return ERR_PTR(-ENOMEM); + + np =3D of_parse_phandle(dev_of_node(dev), name, index); + if (!np) { + devres_free(pdev); + dev_err(dev, "can't resolve phandle %s: %d\n", name, index); + return ERR_PTR(-ENODEV); + } + + *pdev =3D of_find_i2c_device_by_node(np); + of_node_put(np); + + if (!*pdev) { + devres_free(pdev); + return ERR_PTR(-EPROBE_DEFER); + } + + devres_add(dev, pdev); + + return *pdev; +} + +/** + * devm_asus_dockram_get - Device-managed request of DockRAM via device ph= andle. + * @parent: Parent device which requests the DockRAM device. + * + * Request the DockRAM device by phandle from the parent's device-tree nod= e. + * The DockRAM device phandle will be automatically released and DockRAM w= ill be + * detached on parent driver detach. + * + * Return: Pointer to the DockRAM I2C device on success, or an ERR_PTR on = failure. + */ +struct i2c_client *devm_asus_dockram_get(struct device *parent) +{ + struct i2c_client *dockram =3D + devm_i2c_device_get_by_phandle(parent, "asus,dockram", 0); + + if (IS_ERR(dockram)) + return dockram; + if (!dockram->dev.driver) + return ERR_PTR(-EPROBE_DEFER); + if (dockram->dev.driver !=3D &asus_dockram_driver.driver) + return ERR_PTR(-EBUSY); + + return dockram; +} +EXPORT_SYMBOL_GPL(devm_asus_dockram_get); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's dockram driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/asus-ec.h b/include/linux/mfd/asus-ec.h new file mode 100644 index 000000000000..6a36313b9ebd --- /dev/null +++ b/include/linux/mfd/asus-ec.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +#ifndef __MISC_ASUS_EC_H +#define __MISC_ASUS_EC_H + +struct i2c_client; + +#define DOCKRAM_ENTRIES 0x100 +#define DOCKRAM_ENTRY_SIZE 32 +#define DOCKRAM_ENTRY_BUFSIZE (DOCKRAM_ENTRY_SIZE + 1) + +/* control register [0x0A] layout */ +#define ASUSEC_CTL_SIZE 8 + +#define ASUSEC_DOCKRAM_CONTROL 0x0a + +/* dockram comm */ +int asus_dockram_read(struct i2c_client *client, int reg, char *buf); +int asus_dockram_write(struct i2c_client *client, int reg, const char *buf= ); +int asus_dockram_access_ctl(struct i2c_client *client, + u64 *out, u64 mask, u64 xor); +struct i2c_client *devm_asus_dockram_get(struct device *parent); +void asus_dockram_debugfs_init(struct i2c_client *client, + struct dentry *debugfs_root); +#endif /* __MISC_ASUS_EC_H */ --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62364369219 for ; Mon, 9 Feb 2026 10:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.66 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633872; cv=none; b=gxFrU1qyi6w9YHGkHpJ0H7ZRvBMTMVkiMjvNLU9dnBu66T8JgBaMfWXCPqe31mzys7lEklE+awRnMEB4g2QdueTMw26dNYNMCt8KLAdOxkcdcv9v70/Gczt9rT5equrkDL9oY8leyk0I5t9V/Y+SLzu3oFgug0LRuwwYW00Ar/Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633872; c=relaxed/simple; bh=LrlW5n+TfvOTYQQ1oHM2HINQqXlrDDVoUzaHz6OuCwQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C0wuTY0dw/CMe3i9z8FHbLbh820OOJX77WtGjaSkSou7eNT1nV0nc4hcOt4SOl1CVlqtyfsJkfSeZb11MXYmDhMf6xe6Nl5yVApUEqLdciLm250/GNgrzCkAaQBHtL0Q70fF+aHg8wYdBPYRhjo/aLCFbvHQLiBrd2f9EXoxsJk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ndko//IB; arc=none smtp.client-ip=209.85.167.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ndko//IB" Received: by mail-lf1-f66.google.com with SMTP id 2adb3069b0e04-59deec3d8dcso3938100e87.3 for ; Mon, 09 Feb 2026 02:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633871; x=1771238671; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RRcfAUL2ICmQKvT/5ZV8//xYR9dZpc5jMuyeuAnPWmA=; b=Ndko//IB84vUxt8p5uDSr+MrGTrXRXofr0gO4O3a03KH6hQGLMIZKqV2HzU0Pj7P4O cKCaSDF4wXfDU4GB1lI7pwWxG4UxPf6ZrzP7oy1MlmjyGdS2ukbzhXNdrZHlwjt3iFqe mo1T0i//yefXghYxDk8x0OUGs0AcjCbHLJO3IVT9Bu1PIsDYgNwvNXDxzNYNqFyqFj3s aeiga+4Ss4EWtElO1ZGP7Yp6B8U081CKSa7158T2ZdpLqDV1Itbe54C4OxLrAISC9A7X 9x56CUU4rJWaH55YdWE6tqHZGMh853AB7+cohF6A8hRmqGIJqBPBVCeTiy0VyaohTBrc aByQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633871; x=1771238671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=RRcfAUL2ICmQKvT/5ZV8//xYR9dZpc5jMuyeuAnPWmA=; b=vw9YXMaZDTlsT/MpYUnBX9Gt0DD6u2QPyIzR2AS3r9a6Fnt7ZLzUq0qI8ostJ4yzRc bo/EiaRYxke2dcNMmc+gY+ZRdlqDp3A4mi2WyaniJhGYri8UjQLv2FMFvYK4KV4OspOk ulaQ7XIF1YzjAsB6EcEKdvEJz92C+FRtKKYGRXafNeQbb7L1eGbR04zuSMXpYph85bcA BUquVrTSsZVOgTaHfaWHCBsspqC8Qz/UPzwalpIEwJzRYRpWPQ/fGs1xWPm/STcPjhxG +92q9GSGVz/rdvOEA/QlrXp7uWc6c6QfoAtGQXZgB6G8b1EKBQ0AWKBewFa/psBSP7nW CpLA== X-Forwarded-Encrypted: i=1; AJvYcCUfg1NAMNHJsTWzb/BecHZb3clLdnTl9nJ+a9gK2hFVu/b5tQHmAorGk+Gl3FCeF5wP7QsHOjUhUj2rhPw=@vger.kernel.org X-Gm-Message-State: AOJu0Yyf5mv6VMbgFxEeWWkfqOMkTeqP7aEnvPLEaKsZEY1bydjvgYLt 1mrLjmp2ojSRz6ip/bRrHYoLKDLTk+lgdhcdpO5y3NVEh85bO+6sn11f X-Gm-Gg: AZuq6aJnQTfrYPbT9WusN4+QP1p6BTAOANaJh38Hx0p0+uG+j+Fio4MAvMjts1nmH0y SLxfWCet724fIbxcUvw3jagJXBvZJBc3/gBJCvS08SB+sfTmDZxZtjniwrAfj/cAEYQ7/Kc3TYY +XSnOM8orVk6oqLZnKvasqGe2pNzKiPn8whRsj0YGGnIlkSaHyPAI0MiiRz+aHVPgJTTBoL0W9E NnR7iI7Y0rYv+cwlXG+jfrFVG7tex03kgt+uf4vAeAGiAJ4oCpjF4dgZjehcvLAbCTBJVRIjdau QzoxbGA29qOtY2iJC7/8u/tXUQiGvefeKXVorbqQw5yC9n7Az76NQM8DttVCJb/90kA1MLPJYPz ohew4Cj28vgSJ78ypL4Odo21DBegzD/i+/V7ZUrVyIbqQzRGIsboVhxO6yJgoQWPIuxUMNFOZgf cI X-Received: by 2002:a05:6512:3088:b0:59e:4a0:ac5e with SMTP id 2adb3069b0e04-59e451733demr3569115e87.35.1770633870507; Mon, 09 Feb 2026 02:44:30 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:30 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 3/9] dt-bindings: mfd: document ASUS Transformer EC Date: Mon, 9 Feb 2026 12:44:01 +0200 Message-ID: <20260209104407.116426-4-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Document embedded controller used in ASUS Transformer device series. Signed-off-by: Svyatoslav Ryhel --- .../devicetree/bindings/mfd/asus,ec.yaml | 152 ++++++++++++++++++ 1 file changed, 152 insertions(+) create mode 100644 Documentation/devicetree/bindings/mfd/asus,ec.yaml diff --git a/Documentation/devicetree/bindings/mfd/asus,ec.yaml b/Documenta= tion/devicetree/bindings/mfd/asus,ec.yaml new file mode 100644 index 000000000000..1d1a62761b71 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/asus,ec.yaml @@ -0,0 +1,152 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/asus,ec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ASUS Transformer's Embedded Controller + +description: + Several Nuvoton based Embedded Controller attached to an I2C bus, + running a custom ASUS firmware, specific to the Asus Transformer + device series. + +maintainers: + - Svyatoslav Ryhel + +properties: + compatible: + oneOf: + - enum: + - asus,ec-pad # Pad part of Asus Transformer + - asus,ec-dock # Dock part of Asus Transformer + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + request-gpio: + maxItems: 1 + + asus,dockram: + $ref: /schemas/types.yaml#/definitions/phandle + description: I2C device used to access power related functions. + + asus,clear-factory-mode: + type: boolean + description: clear Factory Mode bit in EC control register + + battery: + type: object + $ref: /schemas/power/supply/power-supply.yaml + unevaluatedProperties: false + + properties: + compatible: + const: asus,ec-battery + + required: + - compatible + + charger: + type: object + $ref: /schemas/power/supply/power-supply.yaml + additionalProperties: false + + properties: + compatible: + const: asus,ec-charger + + monitored-battery: true + + required: + - compatible + + keyboard-ext: + type: object + description: top row of multimedia keys + additionalProperties: false + + properties: + compatible: + const: asus,ec-keys + + required: + - compatible + + led: + type: object + additionalProperties: false + + properties: + compatible: + const: asus,ec-led + + required: + - compatible + + serio: + type: object + description: keyboard and touchpad + additionalProperties: false + + properties: + compatible: + const: asus,ec-kbc + + required: + - compatible + +required: + - compatible + - reg + - interrupts + - request-gpio + - asus,dockram + +additionalProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + embedded-controller@19 { + compatible =3D "asus,ec-dock"; + reg =3D <0x19>; + + interrupt-parent =3D <&gpio>; + interrupts =3D <151 IRQ_TYPE_LEVEL_LOW>; + + request-gpio =3D <&gpio 134 GPIO_ACTIVE_LOW>; + asus,dockram =3D <&dockram_ec>; + + battery { + compatible =3D "asus,ec-battery"; + monitored-battery =3D <&dock_battery>; + }; + + charger { + compatible =3D "asus,ec-charger"; + monitored-battery =3D <&dock_battery>; + }; + + keyboard-ext { + compatible =3D "asus,ec-keys"; + }; + + led { + compatible =3D "asus,ec-led"; + }; + + serio { + compatible =3D "asus,ec-kbc"; + }; + }; + }; +... --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4F7A36998F for ; Mon, 9 Feb 2026 10:44:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633874; cv=none; b=QAWaXAgNZuK/pmObFdD2FvbBXFVUuSQzbkd3WUKL4CJRAlhhrQQFeYPiDgYdKCC9uEBfPTWdfoxOuyDsYT51qiAcV3CWd12IjbCYxzazGzpamSxRHTZtkd+9BpRPA/xevPrxcbaHMENcwVE28U6IDslUL4wZbu2GO+Y1Gp0ma3g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633874; c=relaxed/simple; bh=hV54Yu+MeVuM4Qoi+5SWKGA+oX8glPOKlXgo5DVvINU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LkbbRr2X76XEtpkzFHmIwM+64e4BTB7QrOWhaxeJnYhpdAdhD2HTfJIQOMHIz2T8YJDKVCj0r7+4IsBaydlzGHWeAQK/Z0dRoWH/1YfysbYH8MiyRj2CQ2MrovR83g9ruD7fr8AaPvwSiJwAKWquB+Leu75MUBBf8b2lPxek2d8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KYzGfHVG; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KYzGfHVG" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-59dd9aef51eso5701616e87.2 for ; Mon, 09 Feb 2026 02:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633872; x=1771238672; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WfRX1YNPlct4TcvSkoUlBO1DFWs7MCvRGoizOsYkrMU=; b=KYzGfHVGmsbXPaW4VAKSr1K1/5z7nWAmtgdHawHrjrem7i6btJ9Vaee6MmVwmhoW+L Q80+8u/pi+uloN68cLXImmmxeNfLMHDcQVCbXLXgJc8e0KasIWpReXvT43FNBgsr9aSO mxlZsPAi1MK2wa1gSZ5d9YFC9tAZ1ki7KvXKTPAQovr78Fwz88YlXy0XIQZ3J5YA9/eo +BbcFhqD297E5C3S6DHGE/j2SpjDF0rXioIYsBSqBdlqRcHq0Iwd9G0DcfU+IHd5rHNB ZBxDStguub2ozoKpSoqKsUgKRRc4JMhxuYcFqSSztznUPw99fxxvn4HPW8cMFP6i2/wZ YWpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633872; x=1771238672; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WfRX1YNPlct4TcvSkoUlBO1DFWs7MCvRGoizOsYkrMU=; b=SraU7/+PuJuTpFLRqOpbLfo6FwLWJgr48Higav8iGukxlNJb4OS2uWeOiGVk4Kq8Ym fKh3aDYqehPz4IcgqOyOHU3OMjVT4tmtxCAGPIwXgVaNfc+FaSMMIdcx7q/E5Id8aGtP YDIcT40UrRX5e2G+spTOWsy+CLinhA2fB5Og+4K7XtzTY+qgcljb4EXLRsddhLHeveex wKEcAdS3FJsRZ7FyES6iIKeAhPTi3Fq/GGDIdK1oLWOE89lxFZowmwmfpvx5MONwzhfx 7i1enasLesbnOlBu8dVHQ7g+gFVCZMtebQcoLAI1Ex2nO+l3wwCqXGxWDwvAHPKmo2pj aS8A== X-Forwarded-Encrypted: i=1; AJvYcCU3l/p8o0fDnGETAoohVbixl8CuVvC9Nt07VN3/EVH3/+Vv7Y6YVhpu/I9WTa+SQJJljjPQ5stQbZcG9+E=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4+MctW2dAZjvjesgHP7xxUM1LCGKJDl6EcSwVTZtKuOmX5RY0 ADtDhAS1DZaIcaGIImtfdsWbMhzUAcgR2g6nShz9N/+1PFnIN2u8H4Z7 X-Gm-Gg: AZuq6aLMDpqxUflE51udP0K/Lwc3YMh+5YrqzxPkVP0OHmSW9e2z1c10o8BAkH5Y8D3 bb/VxOrL9izY5szaKPVNb/FCPztCcueXzQ9iiY7fT3x5jW0q8d9CEcxDSIOCHGaIZ5G0WECO7IZ WdPtnGFiL+SwQjdaEG4DXmJXbgPV3rfqh2kLZqT8o41sMhW08OSx3fp8h6dL5CJ0FRkSY8D5aSk Sy2w5iRZtjWYFO9UROujjHfaYQXlVLtYHUswdK890a6sdJjRDHmrR1rNZ7enN3dWTNbvX0PEQLx oWmzxrsdrUKmK82zBBWNzLDagoxpbAhhFF8lQsRMyDEVDWRYj65C1WcaTPoTqOQzulhcoAnuLDA x7n3er6UKeJPGr7Ncvddo0iAdrbeiafNNfIMsoakFrU3wriygF5HSSgJsJ8Pe/RmESKPvOJuYzt qW X-Received: by 2002:a05:6512:3c9e:b0:59e:a44:1b5d with SMTP id 2adb3069b0e04-59e45150eb8mr3184885e87.25.1770633871714; Mon, 09 Feb 2026 02:44:31 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:31 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 4/9] mfd: Add driver for Asus Transformer embedded controller Date: Mon, 9 Feb 2026 12:44:02 +0200 Message-ID: <20260209104407.116426-5-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Support Nuvoton NPCE795-based ECs as used in Asus Transformer TF201, TF300T, TF300TG, TF300TL and TF700T pad and dock, as well as TF101 dock and TF600T, P1801-T and TF701T pad. This is a glue driver handling detection and common operations for EC's functions. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/mfd/Kconfig | 15 ++ drivers/mfd/Makefile | 1 + drivers/mfd/asus-ec.c | 467 ++++++++++++++++++++++++++++++++++++ include/linux/mfd/asus-ec.h | 138 +++++++++++ 4 files changed, 621 insertions(+) create mode 100644 drivers/mfd/asus-ec.c diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index 7192c9d1d268..312fd15eec6a 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -137,6 +137,21 @@ config MFD_AAT2870_CORE additional drivers must be enabled in order to use the functionality of the device. =20 +config MFD_ASUSEC + tristate "ASUS Transformer's embedded controller" + depends on I2C && OF + select SYSFS + select ASUS_DOCKRAM + help + Support ECs found in ASUS Transformer's Pad and Mobile Dock. + + This provides shared glue for functional part drivers: + asus-ec-kbc, asus-ec-keys, leds-asus-ec, asus-ec-battery + and asus-ec-charger. + + This driver can also be built as a module. If so, the module + will be called asus-ec. + config MFD_AT91_USART tristate "AT91 USART Driver" select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index e75e8045c28a..b676922601ba 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -10,6 +10,7 @@ obj-$(CONFIG_MFD_88PM805) +=3D 88pm805.o 88pm80x.o obj-$(CONFIG_MFD_88PM886_PMIC) +=3D 88pm886.o obj-$(CONFIG_MFD_ACT8945A) +=3D act8945a.o obj-$(CONFIG_MFD_SM501) +=3D sm501.o +obj-$(CONFIG_MFD_ASUSEC) +=3D asus-ec.o obj-$(CONFIG_ARCH_BCM2835) +=3D bcm2835-pm.o obj-$(CONFIG_MFD_BCM590XX) +=3D bcm590xx.o obj-$(CONFIG_MFD_BD9571MWV) +=3D bd9571mwv.o diff --git a/drivers/mfd/asus-ec.c b/drivers/mfd/asus-ec.c new file mode 100644 index 000000000000..e151c1506aa2 --- /dev/null +++ b/drivers/mfd/asus-ec.c @@ -0,0 +1,467 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASUS EC driver + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_RSP_BUFFER_SIZE 8 + +struct asus_ec_chip_data { + const char *name; + const struct mfd_cell *mfd_devices; + unsigned int num_devices; +}; + +struct asus_ec_data { + struct asusec_info info; + struct mutex ecreq_lock; /* prevent simultaneous access */ + struct gpio_desc *ecreq; + struct i2c_client *self; + const struct asus_ec_chip_data *data; + u8 ec_data[DOCKRAM_ENTRY_BUFSIZE]; + bool clr_fmode; + bool logging_disabled; +}; + +#define to_ec_data(ec) \ + container_of(ec, struct asus_ec_data, info) + +static void asus_ec_remove_notifier(struct device *dev, void *res) +{ + struct asusec_info *ec =3D dev_get_drvdata(dev->parent); + struct notifier_block **nb =3D res; + + blocking_notifier_chain_unregister(&ec->notify_list, *nb); +} + +/** + * devm_asus_ec_register_notifier - Managed registration of notifier to an + * ASUS EC blocking notifier chain. + * @pdev: Device requesting the notifier (used for resource management). + * @nb: Notifier block to be registered. + * + * Register a notifier to the ASUS EC blocking notifier chain. The notifier + * will be automatically unregistered when the requesting device is detach= ed. + * + * Return: 0 on success or a negative error code on failure. + */ +int devm_asus_ec_register_notifier(struct platform_device *pdev, + struct notifier_block *nb) +{ + struct asusec_info *ec =3D dev_get_drvdata(pdev->dev.parent); + struct notifier_block **res; + int ret; + + res =3D devres_alloc(asus_ec_remove_notifier, sizeof(*res), GFP_KERNEL); + if (!res) + return -ENOMEM; + + *res =3D nb; + ret =3D blocking_notifier_chain_register(&ec->notify_list, nb); + if (ret) { + devres_free(res); + return ret; + } + + devres_add(&pdev->dev, res); + + return 0; +} +EXPORT_SYMBOL_GPL(devm_asus_ec_register_notifier); + +static int asus_ec_signal_request(const struct asusec_info *ec) +{ + struct asus_ec_data *priv =3D to_ec_data(ec); + + guard(mutex)(&priv->ecreq_lock); + + dev_dbg(&priv->self->dev, "EC request\n"); + + gpiod_set_value_cansleep(priv->ecreq, 1); + msleep(50); + + gpiod_set_value_cansleep(priv->ecreq, 0); + msleep(200); + + return 0; +} + +static int asus_ec_write(struct asus_ec_data *priv, u16 data) +{ + int ret =3D i2c_smbus_write_word_data(priv->self, ASUSEC_WRITE_BUF, data); + + dev_dbg(&priv->self->dev, "EC write: %04x, ret =3D %d\n", data, ret); + return ret; +} + +static int asus_ec_read(struct asus_ec_data *priv, bool in_irq) +{ + int ret =3D i2c_smbus_read_i2c_block_data(priv->self, ASUSEC_READ_BUF, + sizeof(priv->ec_data), + priv->ec_data); + + dev_dbg(&priv->self->dev, "EC read: %*ph, ret =3D %d%s\n", + sizeof(priv->ec_data), priv->ec_data, + ret, in_irq ? "; in irq" : ""); + + return ret; +} + +/** + * asus_ec_i2c_command - Send a 16-bit command to the ASUS EC. + * @ec: Pointer to the shared ASUS EC structure. + * @data: The 16-bit command (word) to be sent. + * + * Return: 0 on success or a negative error code on failure. + */ +int asus_ec_i2c_command(const struct asusec_info *ec, u16 data) +{ + return asus_ec_write(to_ec_data(ec), data); +} +EXPORT_SYMBOL_GPL(asus_ec_i2c_command); + +static void asus_ec_clear_buffer(struct asus_ec_data *priv) +{ + int retry =3D ASUSEC_RSP_BUFFER_SIZE; + + while (retry--) { + if (asus_ec_read(priv, false) < 0) + continue; + + if (priv->ec_data[1] & ASUSEC_OBF_MASK) + continue; + + break; + } +} + +static int asus_ec_log_info(struct asus_ec_data *priv, unsigned int reg, + const char *name, char **out) +{ + char buf[DOCKRAM_ENTRY_BUFSIZE]; + int ret; + + ret =3D asus_dockram_read(priv->info.dockram, reg, buf); + if (ret < 0) + return ret; + + if (!priv->logging_disabled) + dev_info(&priv->self->dev, "%-14s: %.*s\n", name, buf[0], buf + 1); + + if (out) + *out =3D kstrndup(buf + 1, buf[0], GFP_KERNEL); + + return 0; +} + +static int asus_ec_reset(struct asus_ec_data *priv) +{ + int retry, ret; + + for (retry =3D 0; retry < 3; retry++) { + ret =3D asus_ec_write(priv, 0); + if (!ret) + return 0; + + msleep(300); + } + + return ret; +} + +static int asus_ec_magic_debug(struct asus_ec_data *priv) +{ + u64 flag; + int ret; + + ret =3D asus_ec_get_ctl(&priv->info, &flag); + if (ret < 0) + return ret; + + flag &=3D ASUSEC_CTL_SUSB_MODE; + dev_info(&priv->self->dev, "EC FW behaviour: %s\n", + flag ? "susb on when receive ec_req" : "susb on when system wakeup"); + + return 0; +} + +static int asus_ec_set_factory_mode(struct asus_ec_data *priv, bool on) +{ + dev_info(&priv->self->dev, "Entering %s mode.\n", on ? "factory" : "norma= l"); + return asus_ec_update_ctl(&priv->info, ASUSEC_CTL_FACTORY_MODE, + on ? ASUSEC_CTL_FACTORY_MODE : 0); +} + +static void asus_ec_handle_smi(struct asus_ec_data *priv, unsigned int cod= e); + +static irqreturn_t asus_ec_interrupt(int irq, void *dev_id) +{ + struct asus_ec_data *priv =3D dev_id; + unsigned long notify_action; + int ret; + + ret =3D asus_ec_read(priv, true); + if (ret <=3D 0 || !(priv->ec_data[1] & ASUSEC_OBF_MASK)) + return IRQ_NONE; + + notify_action =3D priv->ec_data[1]; + if (notify_action & ASUSEC_SMI_MASK) { + unsigned int code =3D priv->ec_data[2]; + + asus_ec_handle_smi(priv, code); + + notify_action |=3D code << 8; + dev_dbg(&priv->self->dev, "SMI code: 0x%02x\n", code); + } + + blocking_notifier_call_chain(&priv->info.notify_list, + notify_action, priv->ec_data); + + return IRQ_HANDLED; +} + +static int asus_ec_detect(struct asus_ec_data *priv) +{ + char *model =3D NULL; + int ret; + + ret =3D asus_ec_reset(priv); + if (ret) + goto err_exit; + + asus_ec_clear_buffer(priv); + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_MODEL, "model", &model= ); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_FW, "FW version", NULL= ); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_CFGFMT, "Config format= ", NULL); + if (ret) + goto err_exit; + + ret =3D asus_ec_log_info(priv, ASUSEC_DOCKRAM_INFO_HW, "HW version", NULL= ); + if (ret) + goto err_exit; + + priv->logging_disabled =3D true; + + ret =3D asus_ec_magic_debug(priv); + if (ret) + goto err_exit; + + priv->info.model =3D model; + priv->info.name =3D priv->data->name; + + if (priv->clr_fmode) + asus_ec_set_factory_mode(priv, false); + +err_exit: + if (ret) + dev_err(&priv->self->dev, "failed to access EC: %d\n", ret); + + return ret; +} + +static void asus_ec_handle_smi(struct asus_ec_data *priv, unsigned int cod= e) +{ + dev_dbg(&priv->self->dev, "SMI interrupt: 0x%02x\n", code); + + switch (code) { + case ASUSEC_SMI_HANDSHAKE: + case ASUSEC_SMI_RESET: + asus_ec_detect(priv); + break; + } +} + +static int ec_request_set(void *ec, u64 val) +{ + if (val) + asus_ec_signal_request(ec); + + return 0; +} + +DEFINE_DEBUGFS_ATTRIBUTE(ec_request_fops, NULL, ec_request_set, "%llu\n"); + +static int ec_irq_set(void *ec, u64 val) +{ + struct asus_ec_data *priv =3D to_ec_data(ec); + + if (val) + irq_wake_thread(priv->self->irq, priv); + + return 0; +} + +DEFINE_DEBUGFS_ATTRIBUTE(ec_irq_fops, NULL, ec_irq_set, "%llu\n"); + +static void asus_ec_debugfs_remove(void *debugfs_root) +{ + debugfs_remove_recursive(debugfs_root); +} + +static void devm_asus_ec_debugfs_init(struct device *dev) +{ + struct asusec_info *ec =3D dev_get_drvdata(dev); + struct asus_ec_data *priv =3D to_ec_data(ec); + struct dentry *debugfs_root; + char *name =3D devm_kasprintf(dev, GFP_KERNEL, "asus-ec-%s", + priv->data->name); + + debugfs_root =3D debugfs_create_dir(name, NULL); + + debugfs_create_file("ec_irq", 0200, debugfs_root, ec, &ec_irq_fops); + debugfs_create_file("ec_request", 0200, debugfs_root, ec, &ec_request_fop= s); + + asus_dockram_debugfs_init(priv->info.dockram, debugfs_root); + + devm_add_action_or_reset(dev, asus_ec_debugfs_remove, debugfs_root); +} + +static int asus_ec_probe(struct i2c_client *client) +{ + struct device *dev =3D &client->dev; + struct asus_ec_data *priv; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->data =3D device_get_match_data(dev); + if (!priv->data) + return -ENODEV; + + i2c_set_clientdata(client, priv); + priv->self =3D client; + + priv->info.dockram =3D devm_asus_dockram_get(dev); + if (IS_ERR(priv->info.dockram)) + return dev_err_probe(dev, PTR_ERR(priv->info.dockram), + "failed to get dockram\n"); + + priv->ecreq =3D devm_gpiod_get(dev, "request", GPIOD_OUT_LOW); + if (IS_ERR(priv->ecreq)) + return dev_err_probe(dev, PTR_ERR(priv->ecreq), + "failed to get request GPIO\n"); + + BLOCKING_INIT_NOTIFIER_HEAD(&priv->info.notify_list); + mutex_init(&priv->ecreq_lock); + + priv->clr_fmode =3D device_property_read_bool(dev, "asus,clear-factory-mo= de"); + + asus_ec_signal_request(&priv->info); + + ret =3D asus_ec_detect(priv); + if (ret) + return dev_err_probe(dev, ret, "failed to detect EC version\n"); + + ret =3D devm_request_threaded_irq(dev, client->irq, NULL, + &asus_ec_interrupt, + IRQF_ONESHOT | IRQF_SHARED, + client->name, priv); + if (ret) + return dev_err_probe(dev, ret, "failed to register IRQ\n"); + + /* Parent I2C controller uses DMA, ASUS EC and child devices do not */ + client->dev.coherent_dma_mask =3D 0; + client->dev.dma_mask =3D &client->dev.coherent_dma_mask; + + devm_asus_ec_debugfs_init(dev); + + return devm_mfd_add_devices(dev, 0, priv->data->mfd_devices, + priv->data->num_devices, NULL, 0, NULL); +} + +static const struct mfd_cell asus_ec_pad_mfd_devices[] =3D { + { + .name =3D "asus-ec-battery", + .id =3D 0, + .of_compatible =3D "asus,ec-battery", + }, { + .name =3D "asus-ec-charger", + .id =3D 0, + .of_compatible =3D "asus,ec-charger", + }, { + .name =3D "asus-ec-led", + .id =3D 0, + .of_compatible =3D "asus,ec-led", + }, +}; + +static const struct mfd_cell asus_ec_dock_mfd_devices[] =3D { + { + .name =3D "asus-ec-battery", + .id =3D 1, + .of_compatible =3D "asus,ec-battery", + }, { + .name =3D "asus-ec-charger", + .id =3D 1, + .of_compatible =3D "asus,ec-charger", + }, { + .name =3D "asus-ec-led", + .id =3D 1, + .of_compatible =3D "asus,ec-led", + }, { + .name =3D "asus-ec-keys", + .of_compatible =3D "asus,ec-keys", + }, { + .name =3D "asus-ec-kbc", + .of_compatible =3D "asus,ec-kbc", + }, +}; + +static const struct asus_ec_chip_data asus_ec_pad_data =3D { + .name =3D "pad", + .mfd_devices =3D asus_ec_pad_mfd_devices, + .num_devices =3D ARRAY_SIZE(asus_ec_pad_mfd_devices), +}; + +static const struct asus_ec_chip_data asus_ec_dock_data =3D { + .name =3D "dock", + .mfd_devices =3D asus_ec_dock_mfd_devices, + .num_devices =3D ARRAY_SIZE(asus_ec_dock_mfd_devices), +}; + +static const struct of_device_id asus_ec_match[] =3D { + { .compatible =3D "asus,ec-pad", .data =3D &asus_ec_pad_data }, + { .compatible =3D "asus,ec-dock", .data =3D &asus_ec_dock_data }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_ec_match); + +static struct i2c_driver asus_ec_driver =3D { + .driver =3D { + .name =3D "asus-ec", + .of_match_table =3D asus_ec_match, + }, + .probe =3D asus_ec_probe, +}; +module_i2c_driver(asus_ec_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's EC driver"); +MODULE_LICENSE("GPL"); diff --git a/include/linux/mfd/asus-ec.h b/include/linux/mfd/asus-ec.h index 6a36313b9ebd..6a06b125ba30 100644 --- a/include/linux/mfd/asus-ec.h +++ b/include/linux/mfd/asus-ec.h @@ -2,16 +2,78 @@ #ifndef __MISC_ASUS_EC_H #define __MISC_ASUS_EC_H =20 +#include +#include +#include + struct i2c_client; =20 +struct asusec_info { + const char *model; + const char *name; + struct i2c_client *dockram; + struct workqueue_struct *wq; + struct blocking_notifier_head notify_list; +}; + #define DOCKRAM_ENTRIES 0x100 #define DOCKRAM_ENTRY_SIZE 32 #define DOCKRAM_ENTRY_BUFSIZE (DOCKRAM_ENTRY_SIZE + 1) =20 +/* interrupt sources */ +#define ASUSEC_OBF_MASK BIT(0) +#define ASUSEC_KEY_MASK BIT(2) +#define ASUSEC_KBC_MASK BIT(3) +#define ASUSEC_AUX_MASK BIT(5) +#define ASUSEC_SCI_MASK BIT(6) +#define ASUSEC_SMI_MASK BIT(7) + +/* SMI notification codes */ +#define ASUSEC_SMI_POWER_NOTIFY 0x31 /* [un]plugging USB cable */ +#define ASUSEC_SMI_HANDSHAKE 0x50 /* response to ec_req edge */ +#define ASUSEC_SMI_WAKE 0x53 +#define ASUSEC_SMI_RESET 0x5f +#define ASUSEC_SMI_ADAPTER_EVENT 0x60 /* [un]plugging charger to dock */ +#define ASUSEC_SMI_BACKLIGHT_ON 0x63 +#define ASUSEC_SMI_AUDIO_DOCK_IN 0x70 + +#define ASUSEC_SMI_ACTION(code) (ASUSEC_SMI_MASK | ASUSEC_OBF_MASK | \ + (ASUSEC_SMI_##code << 8)) + /* control register [0x0A] layout */ #define ASUSEC_CTL_SIZE 8 =20 +/* + * EC reports power from 40-pin connector in the LSB of the control + * register. The following values have been observed (xor 0x02): + * + * PAD-ec no-plug 0x40 / PAD-ec DOCK 0x20 / DOCK-ec no-plug 0x40 + * PAD-ec AC 0x25 / PAD-ec DOCK+AC 0x24 / DOCK-ec AC 0x25 + * PAD-ec USB 0x45 / PAD-ec DOCK+USB 0x24 / DOCK-ec USB 0x41 + */ + +#define ASUSEC_CTL_DIRECT_POWER_SOURCE BIT_ULL(0) +#define ASUSEC_STAT_CHARGING BIT_ULL(2) +#define ASUSEC_CTL_FULL_POWER_SOURCE BIT_ULL(5) +#define ASUSEC_CTL_SUSB_MODE BIT_ULL(11) +#define ASUSEC_CMD_SUSPEND_S3 BIT_ULL(41) +#define ASUSEC_CTL_TEST_DISCHARGE BIT_ULL(43) +#define ASUSEC_CMD_SUSPEND_INHIBIT BIT_ULL(45) +#define ASUSEC_CTL_FACTORY_MODE BIT_ULL(46) +#define ASUSEC_CTL_KEEP_AWAKE BIT_ULL(47) +#define ASUSEC_CTL_USB_CHARGE BIT_ULL(50) +#define ASUSEC_CMD_SWITCH_HDMI BIT_ULL(70) +#define ASUSEC_CMD_WIN_SHUTDOWN BIT_ULL(76) + +#define ASUSEC_DOCKRAM_INFO_MODEL 0x01 +#define ASUSEC_DOCKRAM_INFO_FW 0x02 +#define ASUSEC_DOCKRAM_INFO_CFGFMT 0x03 +#define ASUSEC_DOCKRAM_INFO_HW 0x04 #define ASUSEC_DOCKRAM_CONTROL 0x0a +#define ASUSEC_DOCKRAM_BATT_CTL 0x14 + +#define ASUSEC_WRITE_BUF 0x64 +#define ASUSEC_READ_BUF 0x6A =20 /* dockram comm */ int asus_dockram_read(struct i2c_client *client, int reg, char *buf); @@ -21,4 +83,80 @@ int asus_dockram_access_ctl(struct i2c_client *client, struct i2c_client *devm_asus_dockram_get(struct device *parent); void asus_dockram_debugfs_init(struct i2c_client *client, struct dentry *debugfs_root); + +/* EC public API */ + +/** + * cell_to_ec - Request the shared ASUS EC structure via a subdevice's pde= v. + * @pdev: EC subdevice pdev requesting access to the shared ASUS EC struct= ure. + * + * Returns a pointer to the asusec_info structure. + */ +static inline struct asusec_info *cell_to_ec(struct platform_device *pdev) +{ + return dev_get_drvdata(pdev->dev.parent); +} + +/** + * asus_ec_get_ctl - Read from the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @out: Pointer to the variable where the register value will be stored. + * + * Performs a control register read and stores the value in @out. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_get_ctl(const struct asusec_info *ec, u64 *out) +{ + return asus_dockram_access_ctl(ec->dockram, out, 0, 0); +} + +/** + * asus_ec_update_ctl - Update the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @mask: Bitmask of bits to be cleared. + * @xor: Bitmask of bits to be toggled or set (via XOR). + * + * Performs a read-modify-write update on the control register using + * the provided @mask and @xor values. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_update_ctl(const struct asusec_info *ec, + u64 mask, u64 xor) +{ + return asus_dockram_access_ctl(ec->dockram, NULL, mask, xor); +} + +/** + * asus_ec_set_ctl_bits - Sets bits of the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @mask: Bitmask of bits to be set. + * + * Sets bits of the control register using the provided @mask value. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_set_ctl_bits(const struct asusec_info *ec, u64 m= ask) +{ + return asus_dockram_access_ctl(ec->dockram, NULL, mask, mask); +} + +/** + * asus_ec_clear_ctl_bits - Clears bits of the DockRAM control register. + * @ec: Pointer to the shared ASUS EC structure. + * @mask: Bitmask of bits to be cleared. + * + * Clears bits of the control register using the provided @mask value. + * + * Return: 0 on success, or a negative errno code on failure. + */ +static inline int asus_ec_clear_ctl_bits(const struct asusec_info *ec, u64= mask) +{ + return asus_dockram_access_ctl(ec->dockram, NULL, mask, 0); +} + +int asus_ec_i2c_command(const struct asusec_info *ec, u16 data); +int devm_asus_ec_register_notifier(struct platform_device *dev, + struct notifier_block *nb); #endif /* __MISC_ASUS_EC_H */ --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E67B36A006 for ; Mon, 9 Feb 2026 10:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633875; cv=none; b=QYPZiq54qHbzcOBl3EKRVCUr/AdpIjDniNRDc6gnwz+HTBG4I71U0pr/UC21y3WQ0LBDTrOAOBKLevKQADMhBYlfP6VcRRXxWgeQxjOT4D/ivKjgD29Ldhs5o0WOZOT+snKY/Kjs05nHFHrVhiuszL9/4mao+ccFXM2eKPx8IXw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633875; c=relaxed/simple; bh=L5L8z3dEdEv23jGtH4a9T59EHgzniV+IyLmlJZ/Ob6U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HETHtdQ0Ik3X8A2Kwp6kjbLKjhBxOau2S+EJTwvb24DHCsKyaI0xGClZzJ4UPdR895GU8P7gFtDKz81s1kS+QWh1K659uVIHE5VK+qHsOdgfa1ZkpRevhY90C6UnDojrGoSQtSslPMCY+0V/ZAxP6CoGQPeQB2Zn2FsoCS8M2JU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d5crbl4D; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d5crbl4D" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-59e4993e00aso2064607e87.3 for ; Mon, 09 Feb 2026 02:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633873; x=1771238673; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6mbuhFCPPv7pIkklBXErJ3O0VBejat88okAITG/2NqA=; b=d5crbl4DGV3PofoOXt/1Rf1PbAQudr9O02gge2MhQ+l6d++jwE3pGokY19nAVVGSmG 8Z06QNiqOiLSe8Xd0Twob/VnRe1VBbDn50/XCpr6uykLxrNnOYAlfXug33OVJV8aA5hO a+uLwiLZf+5rJ3UA7wHQAzcpJeNJC6ANjdb5H3Nb6MvihV2p0Ey3fHXoj6OY5BrNhrfR EpXlprkKF9b2E9Xjo/ssAhjmj41XLfWA6hhaAuT15LaM85R6dnkcP0iOvYBAEdxWpt0Q r7bC+b8w4BymEwQAcjo5sQnAMTZoUct+5twIcEruyIJr1CTyn264psizcJC2GjnBjcGJ lUzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633873; x=1771238673; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6mbuhFCPPv7pIkklBXErJ3O0VBejat88okAITG/2NqA=; b=J0z3AqKQiehVnmi4hCNM0p2MoQdoxFQiSXpjiPRlmN/x4zc4dEC8TYlqYJZs/gblNA NgSG0jz+2TQBfT6NgzawlTZt4mXnu1h+BPVFizHYHHePPpyvK1GlNONizXSEHfssvMCM sIuWJdC6UfY9vmRFbLGPHHl7/nREzricE4x7lSX8Z8+LpTTUYxf8+CWevb6MXIJH2+/k g95rwjt3OF9+wf+22eUZyivQRjlr2O/xqVOfove9MhglOyKSohLIdZR3TC1Q2ZuDS9C/ s6uinbfRkhkU3XmB4wAlsFragmjOY2JC1HMFUQ5vCAQ7E4jZoLQTDXYMfPutd/rGFoZM lqPg== X-Forwarded-Encrypted: i=1; AJvYcCUlTeERmkY+sJB2bVnkk/ruq3+XFkDjNfMZhuUqplKYPgUcVhoLZQztbqF4usoF2ci/+f9gzfcMxn0HCiY=@vger.kernel.org X-Gm-Message-State: AOJu0YyArTq7wBiK+F7JxiG524GEbSNHolxCxPDZ4wMGPrsnAjbzYbjp oybig5yQ474P2+rL6fLdvSFwQpsqnBRXyBJsPln1o0uThTLc74BRPQaf X-Gm-Gg: AZuq6aKXnylH3gUqDXO0WqXtVInqUGomdJrwe1jr1c261bHlNgy2Iupxi65baqWQkDv PHBQzZnUIQYnhZf7LKh1ymKJ7daM0aHx7H1lMkfaRAWISXd7Qg7kPFoRB5LdHUu6W0lF3V+QX0l DxWhwyU+s03+5UrBH4q6YzUPk1lYoZ+ilwXGU43bvwuZHJxrUZUHdqvQ8P8EfSWxq073bJRLihl D6Gerhe9MQeVyVO4w9+n0FST8jZ84tfurCrHSlQY+R5SozAWmxmqx/om5PFF1zox254zkRV29W0 CtM4jrCa7gJzEuxhM0YgbXKjAYv2njGlUvChdhUM3/kqvdbAw0bB3iQcEGCzSWiQzUMQyV02R8S 6FoVC5L53DRLwte0DDF6PooaHsLZNZIIwZ0i3vtStwf5Ikv/HY/8V9AgLoaNPAGFdHlOYXryPzr ak X-Received: by 2002:a05:6512:3f07:b0:59d:f28a:be11 with SMTP id 2adb3069b0e04-59e45044658mr3280391e87.3.1770633872876; Mon, 09 Feb 2026 02:44:32 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:32 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 5/9] input: serio: Add driver for Asus Transformer dock keyboard and touchpad Date: Mon, 9 Feb 2026 12:44:03 +0200 Message-ID: <20260209104407.116426-6-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add input driver for Asus Transformer dock keyboard and touchpad. Some keys in Asus Dock report keycodes that don't make sense according to their position, this patch modifies the incoming data that is sent to serio to send proper scancodes. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/input/serio/Kconfig | 15 +++ drivers/input/serio/Makefile | 1 + drivers/input/serio/asus-ec-kbc.c | 160 ++++++++++++++++++++++++++++++ 3 files changed, 176 insertions(+) create mode 100644 drivers/input/serio/asus-ec-kbc.c diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig index c7ef347a4dff..46c4286cd5f6 100644 --- a/drivers/input/serio/Kconfig +++ b/drivers/input/serio/Kconfig @@ -97,6 +97,21 @@ config SERIO_RPCKBD To compile this driver as a module, choose M here: the module will be called rpckbd. =20 +config SERIO_ASUSEC + tristate "Asus Transformer's Dock keyboard and touchpad controller" + depends on MFD_ASUSEC + help + Say Y here if you want to use the keyboard and/or touchpad on + Asus Transformed's Mobile Dock. + + For keyboard support you also need atkbd driver. + + For touchpad support you also need psmouse driver with Elantech + touchpad option enabled. + + To compile this driver as a module, choose M here: the module will + be called asus-ec-kbc. + config SERIO_AMBAKMI tristate "AMBA KMI keyboard controller" depends on ARM_AMBA diff --git a/drivers/input/serio/Makefile b/drivers/input/serio/Makefile index 6d97bad7b844..444e3ea70e37 100644 --- a/drivers/input/serio/Makefile +++ b/drivers/input/serio/Makefile @@ -13,6 +13,7 @@ obj-$(CONFIG_SERIO_CT82C710) +=3D ct82c710.o obj-$(CONFIG_SERIO_RPCKBD) +=3D rpckbd.o obj-$(CONFIG_SERIO_SA1111) +=3D sa1111ps2.o obj-$(CONFIG_SERIO_AMBAKMI) +=3D ambakmi.o +obj-$(CONFIG_SERIO_ASUSEC) +=3D asus-ec-kbc.o obj-$(CONFIG_SERIO_Q40KBD) +=3D q40kbd.o obj-$(CONFIG_SERIO_GSCPS2) +=3D gscps2.o obj-$(CONFIG_HP_SDC) +=3D hp_sdc.o diff --git a/drivers/input/serio/asus-ec-kbc.c b/drivers/input/serio/asus-e= c-kbc.c new file mode 100644 index 000000000000..c03f4721fc33 --- /dev/null +++ b/drivers/input/serio/asus-ec-kbc.c @@ -0,0 +1,160 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASUS EC - keyboard and touchpad + */ + +#include +#include +#include +#include +#include +#include +#include +#include + +struct asus_ec_kbc_data { + struct notifier_block nb; + struct asusec_info *ec; + struct serio *sdev[2]; +}; + +static int asus_ec_kbc_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_kbc_data *priv =3D container_of(nb, struct asus_ec_kbc_dat= a, nb); + unsigned int port_idx, n; + u8 *data =3D data_; + + if (action & (ASUSEC_SMI_MASK | ASUSEC_SCI_MASK)) + return NOTIFY_DONE; + else if (action & ASUSEC_AUX_MASK) + port_idx =3D 1; + else if (action & (ASUSEC_KBC_MASK | ASUSEC_KEY_MASK)) + port_idx =3D 0; + else + return NOTIFY_DONE; + + n =3D data[0] - 1; + data +=3D 2; + + /* + * We need to replace these incoming data for keys: + * RIGHT_META Press 0xE0 0x27 -> LEFT_ALT Press 0x11 + * RIGHT_META Release 0xE0 0xF0 0x27 -> LEFT_ALT Release 0xF0 0x11 + * COMPOSE Press 0xE0 0x2F -> RIGHT_META Press 0xE0 0x27 + * COMPOSE Release 0xE0 0xF0 0x2F -> RIGHT_META Release 0xE0 0xF0 0x27 + */ + + if (port_idx =3D=3D 0 && n >=3D 2 && data[0] =3D=3D 0xE0) { + if (n =3D=3D 3 && data[1] =3D=3D 0xF0) { + switch (data[2]) { + case 0x27: + data[0] =3D 0xF0; + data[1] =3D 0x11; + n =3D 2; + break; + case 0x2F: + data[2] =3D 0x27; + break; + } + } else if (n =3D=3D 2) { + switch (data[1]) { + case 0x27: + data[0] =3D 0x11; + n =3D 1; + break; + case 0x2F: + data[1] =3D 0x27; + break; + } + } + } + + while (n--) + serio_interrupt(priv->sdev[port_idx], *data++, 0); + + return NOTIFY_OK; +} + +static int asus_ec_serio_write(struct serio *port, unsigned char data) +{ + const struct asusec_info *ec =3D port->port_data; + + return asus_ec_i2c_command(ec, (data << 8) | port->id.extra); +} + +static void asus_ec_serio_remove(void *data) +{ + serio_unregister_port(data); +} + +static int asus_ec_register_serio(struct platform_device *pdev, int idx, + const char *name, int cmd) +{ + struct asus_ec_kbc_data *priv =3D platform_get_drvdata(pdev); + struct i2c_client *parent =3D to_i2c_client(pdev->dev.parent); + struct serio *port =3D kzalloc(sizeof(*port), GFP_KERNEL); + + if (!port) + return -ENOMEM; + + priv->sdev[idx] =3D port; + port->dev.parent =3D &pdev->dev; + port->id.type =3D SERIO_8042; + port->id.extra =3D cmd & 0xFF; + port->write =3D asus_ec_serio_write; + port->port_data =3D (void *)priv->ec; + snprintf(port->name, sizeof(port->name), "%s %s", + priv->ec->model, name); + snprintf(port->phys, sizeof(port->phys), "i2c-%u-%04x/serio%d", + i2c_adapter_id(parent->adapter), parent->addr, idx); + + serio_register_port(port); + + return devm_add_action_or_reset(&pdev->dev, asus_ec_serio_remove, port); +} + +static int asus_ec_kbc_probe(struct platform_device *pdev) +{ + struct asusec_info *ec =3D cell_to_ec(pdev); + struct asus_ec_kbc_data *priv; + int ret; + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D ec; + + ret =3D asus_ec_register_serio(pdev, 0, "Keyboard", 0); + if (ret < 0) + return ret; + + ret =3D asus_ec_register_serio(pdev, 1, "Touchpad", I8042_CMD_AUX_SEND); + if (ret < 0) + return ret; + + priv->nb.notifier_call =3D asus_ec_kbc_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static const struct of_device_id asus_ec_kbc_match[] =3D { + { .compatible =3D "asus,ec-kbc" }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_ec_kbc_match); + +static struct platform_driver asus_ec_kbc_driver =3D { + .driver =3D { + .name =3D "asus-ec-kbc", + .of_match_table =3D asus_ec_kbc_match, + }, + .probe =3D asus_ec_kbc_probe, +}; +module_platform_driver(asus_ec_kbc_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's Dock keyboard and touchpad controll= er driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EDA936A035 for ; Mon, 9 Feb 2026 10:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633876; cv=none; b=GmMpe/9ASLBQj5+jyKeKOE+YQ9NmZ+Ldw3p/xXTz0xlsDaMjBa2BMcehmh9v4yuQv7jjEaCFKHDZYc7UVvAE2MqpuRJA5oD5mPpztpG7WVkwcoqYMzAiSNsuTFiVeA2R4WF6ILD5Bjevz+VT/7tkzzvsQyAMFfbXNxvzT/kQt3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633876; c=relaxed/simple; bh=UfX7Y4kge1HoGiefxZCO8c5sDOxYGSr7IO7YjJ8srSc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J4k5/nhnDShkzrqDtuMrFqGOdVFNUNZ12fBe4hlMeCUy/4L8jcDoiNzXJgVGWtCErcdIUchKCeR1LMxhT0Pv+3UkQ22jNpwvws+kvJtmUq9xTqzZ54GSj023xeGTwjce9Ireni0Z/GX6Q0WtXRwmg2K9Ple20kfAoxHBBy0EraE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f1KSMayi; arc=none smtp.client-ip=209.85.167.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f1KSMayi" Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-59b834e3d64so3127007e87.2 for ; Mon, 09 Feb 2026 02:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633874; x=1771238674; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rjZiOg3lkMvh/gEkfmcLfpQWK2TTmdrTX3Exrd9Xdss=; b=f1KSMayiRYaSmZSAknLAyhNxqFC7r8VZrhwgPdRUfJ+UmNDzfGLlFX9Vsajt2SZs0J 57gs49ceDCg9b3dhexQxZic4FLw4OnmWBeqDgVWAhSiIoltsKNxuhnS1rn2+EW92KCEG Cg2T8/UC0RosgKtpJMhtTGRfsVQwWHXMWy1wZthIh8CnkrIhtgRZ1rgyX9HkSDP0sAjH +2yxPwEfY7qBRiDtJzP2qtBTH9y7CttLHUTXCfzIpD/P0UzvvaFTEUnNoG4egrxeOPfM ryie7RchwSBoOsRv9Pri1WP3bR/vrR6GChwO1YDXBX67APiC9bG5frZacO73roXF9Wo+ 5Y8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633874; x=1771238674; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rjZiOg3lkMvh/gEkfmcLfpQWK2TTmdrTX3Exrd9Xdss=; b=AW6CpCDMBt7AhnIDbic3f0woYuoj7zApyCc/lsUBUSGwmmdrknX5yZUNDEEQnzfcpz CEJ6gO/3ma4glvwp36QXMUndFs0zVktD6iHzMZdOGXW0v72pkHW1Sh2xvPl8L3RV34bj zH9qLhuGB2z44SnNSaCUEJH2b6nipA4xC634EKzHek1WwujFmWNm81ukeZBMCTRewuNt /b8HxuuUEWLD3lXpJ8RfOpG/7uT3uDV8DJuwiCSJrE+Rep3LTcF8zc0N4B0246j/7B1x NkYSaWUs4e+BnyxOkDPhar7LHlFHVInwC9xxdX2ni6zXSHo+neYozbHtxxbUaibtaz22 SRfQ== X-Forwarded-Encrypted: i=1; AJvYcCWagaZNbyavNWOMKg7xe+lQVwRk5ABzTp6zKdXXpWO8ckg6ziXUEa9SvsLwv4YP3pBmgnm0mi7Fsuw+pG8=@vger.kernel.org X-Gm-Message-State: AOJu0YxVf4eP0+JRQDu0Ny+lVpEjGT90qTnOrqg/CYTTilZDKU5CG6dp A9WUMKK9e9uwn27XGhu/BtgjgcXl5PEV2jEcxzaV91Be+Vxv0qYJVYbI X-Gm-Gg: AZuq6aISMSX1tVj3BOOomj/K+AQAQuM/RLigYknY/6hhgr+STOgwxGxY3gYGTCFusGA cqtmLgj4w7/8bS5c/Kuw9v9SMShNzGB9wTSeo1pDdz3GU3QmpyxEc9UjlmerlP/pL+tqPrDt785 eeWlCfjYZfyxwXItEeH4fpfr0x5/N5RFoZkoDsDXb4za+LuWiVjgSqv4m7vjELIntS9HraBJpvf H8tVCLU0a96tirBEIoUowxxrWnxCcUw7mP1aGTgZ9NgQFPh/kkhZi7RMXD+yy6gL4WtlGc7P658 4ZfLGWS3YGwYFwDXu1euJkAQKfOcMT53i0EF+MVGgd7ancwGbNl+8rBnM8Z5kohNPZocOeH7E3W eitkeGclq6oCzvQcglPmMvSJzbqk2RhCAm6IDYN5FParLFItbQjFwKPK5Qy62w478aCjAyP0mt5 eq X-Received: by 2002:a05:6512:108a:b0:59e:2262:f174 with SMTP id 2adb3069b0e04-59e4504b616mr3142015e87.15.1770633874109; Mon, 09 Feb 2026 02:44:34 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:33 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 6/9] input: keyboard: Add driver for Asus Transformer dock multimedia keys Date: Mon, 9 Feb 2026 12:44:04 +0200 Message-ID: <20260209104407.116426-7-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for multimedia top button row of ASUS Transformer's Mobile Dock keyboard. Driver is made that function keys (F1-F12) are used by default which suits average Linux use better and with pressing ScreenLock + AltGr function keys layout is switched to multimedia keys. Since this only modifies codes sent by asus-ec-keys it doesn't affect normal keyboards at all. Co-developed-by: Ion Agorria Signed-off-by: Ion Agorria Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/input/keyboard/Kconfig | 10 + drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/asus-ec-keys.c | 285 ++++++++++++++++++++++++++ 3 files changed, 296 insertions(+) create mode 100644 drivers/input/keyboard/asus-ec-keys.c diff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index 2ff4fef322c2..d23af13ab99a 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig @@ -89,6 +89,16 @@ config KEYBOARD_APPLESPI To compile this driver as a module, choose M here: the module will be called applespi. =20 +config KEYBOARD_ASUSEC + tristate "Asus Transformer's Mobile Dock multimedia keys" + depends on MFD_ASUSEC + help + Say Y here if you want to use multimedia keys present on Asus + Transformer's Mobile Dock. + + To compile this driver as a module, choose M here: the + module will be called asus-ec-keys. + config KEYBOARD_ATARI tristate "Atari keyboard" depends on ATARI diff --git a/drivers/input/keyboard/Makefile b/drivers/input/keyboard/Makef= ile index 2d906e14f3e2..7226aafddf7a 100644 --- a/drivers/input/keyboard/Makefile +++ b/drivers/input/keyboard/Makefile @@ -11,6 +11,7 @@ obj-$(CONFIG_KEYBOARD_ADP5585) +=3D adp5585-keys.o obj-$(CONFIG_KEYBOARD_ADP5588) +=3D adp5588-keys.o obj-$(CONFIG_KEYBOARD_AMIGA) +=3D amikbd.o obj-$(CONFIG_KEYBOARD_APPLESPI) +=3D applespi.o +obj-$(CONFIG_KEYBOARD_ASUSEC) +=3D asus-ec-keys.o obj-$(CONFIG_KEYBOARD_ATARI) +=3D atakbd.o obj-$(CONFIG_KEYBOARD_ATKBD) +=3D atkbd.o obj-$(CONFIG_KEYBOARD_BCM) +=3D bcm-keypad.o diff --git a/drivers/input/keyboard/asus-ec-keys.c b/drivers/input/keyboard= /asus-ec-keys.c new file mode 100644 index 000000000000..42365db63bdf --- /dev/null +++ b/drivers/input/keyboard/asus-ec-keys.c @@ -0,0 +1,285 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASUS Transformer Pad - multimedia keys + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_EXT_KEY_CODES 0x20 + +struct asus_ec_keys_data { + struct notifier_block nb; + struct asusec_info *ec; + struct input_dev *xidev; + bool special_key_pressed; + bool special_key_mode; + unsigned short keymap[ASUSEC_EXT_KEY_CODES * 2]; +}; + +static void asus_ec_input_event(struct input_handle *handle, + unsigned int event_type, + unsigned int event_code, int value) +{ + struct asus_ec_keys_data *priv =3D handle->handler->private; + + /* Store special key state */ + if (event_type =3D=3D EV_KEY && event_code =3D=3D KEY_RIGHTALT) + priv->special_key_pressed =3D !!value; +} + +static int asus_ec_input_connect(struct input_handler *handler, struct inp= ut_dev *dev, + const struct input_device_id *id) +{ + struct input_handle *handle; + int error; + + handle =3D kzalloc(sizeof(*handle), GFP_KERNEL); + if (!handle) + return -ENOMEM; + + handle->dev =3D dev; + handle->handler =3D handler; + handle->name =3D "asusec-media-handler"; + + error =3D input_register_handle(handle); + if (error) + goto err_free_handle; + + error =3D input_open_device(handle); + if (error) + goto err_unregister_handle; + + return 0; + + err_unregister_handle: + input_unregister_handle(handle); + err_free_handle: + kfree(handle); + + return error; +} + +static void asus_ec_input_disconnect(struct input_handle *handle) +{ + input_close_device(handle); + input_unregister_handle(handle); + kfree(handle); +} + +static const struct input_device_id asus_ec_input_ids[] =3D { + { + .flags =3D INPUT_DEVICE_ID_MATCH_EVBIT, + .evbit =3D { BIT_MASK(EV_KEY) }, + }, + { } +}; + +static struct input_handler asus_ec_input_handler =3D { + .name =3D "asusec-media-handler", + .event =3D asus_ec_input_event, + .connect =3D asus_ec_input_connect, + .disconnect =3D asus_ec_input_disconnect, + .id_table =3D asus_ec_input_ids, +}; + +static const unsigned short asus_ec_dock_ext_keys[] =3D { + /* Function keys [0x00 - 0x19] */ + [0x01] =3D KEY_DELETE, + [0x02] =3D KEY_F1, + [0x03] =3D KEY_F2, + [0x04] =3D KEY_F3, + [0x05] =3D KEY_F4, + [0x06] =3D KEY_F5, + [0x07] =3D KEY_F6, + [0x08] =3D KEY_F7, + [0x10] =3D KEY_F8, + [0x11] =3D KEY_F9, + [0x12] =3D KEY_F10, + [0x13] =3D KEY_F11, + [0x14] =3D KEY_F12, + [0x15] =3D KEY_MUTE, + [0x16] =3D KEY_VOLUMEDOWN, + [0x17] =3D KEY_VOLUMEUP, + /* Multimedia keys [0x20 - 0x39] */ + [0x21] =3D KEY_SCREENLOCK, + [0x22] =3D KEY_WLAN, + [0x23] =3D KEY_BLUETOOTH, + [0x24] =3D KEY_TOUCHPAD_TOGGLE, + [0x25] =3D KEY_BRIGHTNESSDOWN, + [0x26] =3D KEY_BRIGHTNESSUP, + [0x27] =3D KEY_BRIGHTNESS_AUTO, + [0x28] =3D KEY_PRINT, + [0x30] =3D KEY_WWW, + [0x31] =3D KEY_CONFIG, + [0x32] =3D KEY_PREVIOUSSONG, + [0x33] =3D KEY_PLAYPAUSE, + [0x34] =3D KEY_NEXTSONG, + [0x35] =3D KEY_MUTE, + [0x36] =3D KEY_VOLUMEDOWN, + [0x37] =3D KEY_VOLUMEUP, +}; + +static void asus_ec_keys_report_key(struct input_dev *dev, unsigned int co= de, + unsigned int key, bool value) +{ + input_event(dev, EV_MSC, MSC_SCAN, code); + input_report_key(dev, key, value); + input_sync(dev); +} + +static int asus_ec_keys_process_key(struct input_dev *dev, u8 code) +{ + struct asus_ec_keys_data *priv =3D dev_get_drvdata(dev->dev.parent); + unsigned int key =3D 0; + + if (code =3D=3D 0) + return NOTIFY_DONE; + + /* Flip special key mode state when pressing key 1 with special key press= ed */ + if (priv->special_key_pressed && code =3D=3D 1) { + priv->special_key_mode =3D !priv->special_key_mode; + return NOTIFY_DONE; + } + + /* + * Relocate code to second "page" if pressed state XOR's mode state + * This way special key will invert the current mode + */ + if (priv->special_key_mode ^ priv->special_key_pressed) + code +=3D ASUSEC_EXT_KEY_CODES; + + if (code < dev->keycodemax) { + unsigned short *map =3D dev->keycode; + + key =3D map[code]; + } + + if (!key) + key =3D KEY_UNKNOWN; + + asus_ec_keys_report_key(dev, code, key, 1); + asus_ec_keys_report_key(dev, code, key, 0); + + return NOTIFY_OK; +} + +static int asus_ec_keys_notify(struct notifier_block *nb, + unsigned long action, void *data_) +{ + struct asus_ec_keys_data *priv =3D container_of(nb, struct asus_ec_keys_d= ata, nb); + u8 *data =3D data_; + + if (action & ASUSEC_SMI_MASK) + return NOTIFY_DONE; + + if (action & ASUSEC_SCI_MASK) + return asus_ec_keys_process_key(priv->xidev, data[2]); + + return NOTIFY_DONE; +} + +static void asus_ec_keys_setup_keymap(struct asus_ec_keys_data *priv) +{ + struct input_dev *dev =3D priv->xidev; + unsigned int i; + + BUILD_BUG_ON(ARRAY_SIZE(priv->keymap) < ARRAY_SIZE(asus_ec_dock_ext_keys)= ); + + dev->keycode =3D priv->keymap; + dev->keycodesize =3D sizeof(*priv->keymap); + dev->keycodemax =3D ARRAY_SIZE(priv->keymap); + + input_set_capability(dev, EV_MSC, MSC_SCAN); + input_set_capability(dev, EV_KEY, KEY_UNKNOWN); + + for (i =3D 0; i < ARRAY_SIZE(asus_ec_dock_ext_keys); i++) { + unsigned int code =3D asus_ec_dock_ext_keys[i]; + + if (!code) + continue; + + __set_bit(code, dev->keybit); + priv->keymap[i] =3D code; + } +} + +static void asus_ec_input_handler_deregister(void *priv) +{ + input_unregister_handler(&asus_ec_input_handler); +} + +static int asus_ec_keys_probe(struct platform_device *pdev) +{ + struct asusec_info *ec =3D cell_to_ec(pdev); + struct i2c_client *parent =3D to_i2c_client(pdev->dev.parent); + struct asus_ec_keys_data *priv; + int ret; + + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D ec; + + priv->xidev =3D devm_input_allocate_device(&pdev->dev); + if (!priv->xidev) + return -ENOMEM; + + priv->xidev->name =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, + "%s Keyboard Ext", ec->model); + priv->xidev->phys =3D devm_kasprintf(&pdev->dev, GFP_KERNEL, + "i2c-%u-%04x", + i2c_adapter_id(parent->adapter), + parent->addr); + asus_ec_keys_setup_keymap(priv); + + ret =3D input_register_device(priv->xidev); + if (ret < 0) { + dev_err(&pdev->dev, "failed to register extension keys: %d\n", + ret); + return ret; + } + + asus_ec_input_handler.private =3D priv; + + ret =3D input_register_handler(&asus_ec_input_handler); + if (ret) + return ret; + + ret =3D devm_add_action_or_reset(&pdev->dev, asus_ec_input_handler_deregi= ster, + priv); + if (ret) + return ret; + + priv->nb.notifier_call =3D asus_ec_keys_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static const struct of_device_id asus_ec_keys_match[] =3D { + { .compatible =3D "asus,ec-keys" }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_ec_keys_match); + +static struct platform_driver asus_ec_keys_driver =3D { + .driver =3D { + .name =3D "asus-ec-keys", + .of_match_table =3D asus_ec_keys_match, + }, + .probe =3D asus_ec_keys_probe, +}; +module_platform_driver(asus_ec_keys_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer's multimedia keys driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4052236A03C for ; Mon, 9 Feb 2026 10:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633877; cv=none; b=fsEPPfx7UPkAWAFm3cSLSW3vsGHBXSKtCFb/Dtlu7C6tYhgPaa1FBy0WCaITUgjoD5rEXKB46dYkpg6KCzVnkVen2wCpRAReqhq/2upkbfIayJnggN+Uvc/L1TsadMhJGeUDuW5tsFaiycaYsyc3qabyHtt08vNXOguOxbauY+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633877; c=relaxed/simple; bh=ngKFCu3cqOl5gPWRaEKogf59QUayqMRH5eB6YPE7vFk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Qq4abe4VLML7UM1hFjp3ZidHNtUy2i+8d7IvWbK/L0Z1pmPUHX54vuf6AfQ7ZvYZF0ORusrers2xt87X6XL+yMLdPh7VIoi4GiY3tafGaL6Wb3qWLMJdn7OwVAukgVC5MJOL2umIvy8sY4JPmc9hcCk8/F80npHTjYd3UevAbrY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QEVQmzJP; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QEVQmzJP" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-59de8155501so4649049e87.3 for ; Mon, 09 Feb 2026 02:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633875; x=1771238675; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XIqndriki6fg3AQEF8QYByWC9DeqMY7pkJM5t0jf4fU=; b=QEVQmzJPK1YE+CYWirktDsG0llMNQTi6y40dxxhCGeDZMx4znmtkyBnpCTZVzZ3Gcx uYU/MQwMjXphMBX+zwYHCd2Bbtr/BO1xSRP0kVwFp3sZYZ3nvzTutihzLjcwxG8hBlGz KQ1I5p/nqSz9nobl24l1NUwUDsT6diiCq3vZ1gT+eN71m66/IN6dFLdKyHPVcapHCa1y 7TaM4VDK2PogWE+CfBPPgwE3cN+bLF5neM9PPFsoLSoVcqfOuCYRONmXJmRkCI1ktvE0 d8okLgDBmD5sUO9D2t/As48/BzkxiK3W/BTMqPbzEZwt6lcRKPBLyW7AyI1+fkVVGT0M X+rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633875; x=1771238675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XIqndriki6fg3AQEF8QYByWC9DeqMY7pkJM5t0jf4fU=; b=pyldeWlATv4e7K8lwzkV2/ehNqg0s73m/Tv2a9UwRx6ROchp+8g+dL27SaGVvWViOD tZtztXVHcwXVeNFdPuypRfQVsoRoE0KNDuRXDr/cZn7M5MDF8vmLfOBdBmHUsixrWBLz CwZuBaT8rdLjk6MKbQVzajMMSnysBpHsOZPdb4EYWCZj4Q/TTQn4I8S8nbFq1u4UT2yX umt9AmC/50Fy1b0pTzQcCaMaInzl5qFNKYzxj0ETcF9xDv5TAggRJYyfLwLtj1D/BZl6 T7fUYPUWSa1WxjYy0Svrjsy/k/6euGGbq52wc8klpgS/cHze+pl3gFU3O8USYGG0FyCJ R3sA== X-Forwarded-Encrypted: i=1; AJvYcCVs9YcaQOg4RcPTxgmiHFzZZi2Uu7rPFEF70VQN1V7Sn7CaKKDRxHIb0oLCZPR9Ds2J3Sy/v9+De6ns8Io=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9Hci+3Ta0OqLNqNzogVxOhsVK8Gcy4Yl2lIFtfkQGuXKAppWK A1h6huXZ8x+a4SbMWOroyYYTtxHmk2iwy0H8pFoEY1lAPbbrlS52SYLI X-Gm-Gg: AZuq6aJaZmO2yp57n3rtyTLoiztgRPijUoQnQsNmmEIKKfkC5CsJU1+WJ7bNghb0SQg IkGEVSAYqoBWMq8CtmJOyrFS02X2Da6dl+YwMdnUGk1++jQtyroiXE74U1dDhP653UpCe8zdZ32 PvAjYj4rB1O0kqYSQn5Yb0rwebe2OHlwnJRg4s4qtT87HSUDintuuoOUfzZ+vJuPiSgXMcnB27D e1a9n30+FmFYGNauGjIxzvZuCEdWa2XvWuYZHqsiwgh0bAIWP1vTwUwRxVA8c3fq9B9hPzMbARC KRbtlJgo5p/1cJLWO81MU/T6COWsR0swOS/4NMDzoljder223QXCLsdFgcfWuflyjgXQIEPGk+g 6//4CM4bsBkeYUCvaRdt/Li9lbCRlHxMJsHIxiHOtyZC5F4D3QezRZhMpZvEyByTfRSE8IuKKmy 15 X-Received: by 2002:a05:6512:250c:b0:59e:5243:6c95 with SMTP id 2adb3069b0e04-59e52436ed4mr233533e87.24.1770633875248; Mon, 09 Feb 2026 02:44:35 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:34 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 7/9] leds: Add driver for Asus Transformer LEDs Date: Mon, 9 Feb 2026 12:44:05 +0200 Message-ID: <20260209104407.116426-8-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Asus Transformer tablets have a green and an amber LED on both the Pad and the Dock. If both LEDs are enabled simultaneously, the emitted light will be yellow. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/leds/Kconfig | 11 ++++ drivers/leds/Makefile | 1 + drivers/leds/leds-asus-ec.c | 104 ++++++++++++++++++++++++++++++++++++ 3 files changed, 116 insertions(+) create mode 100644 drivers/leds/leds-asus-ec.c diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 597d7a79c988..96dab210f6ca 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -120,6 +120,17 @@ config LEDS_OSRAM_AMS_AS3668 To compile this driver as a module, choose M here: the module will be called leds-as3668. =20 +config LEDS_ASUSEC + tristate "LED Support for Asus Transformer charging LED" + depends on LEDS_CLASS + depends on MFD_ASUSEC + help + This option enables support for charging indicator on + Asus Transformer's Pad and it's Dock. + + To compile this driver as a module, choose M here: the module + will be called leds-asus-ec. + config LEDS_AW200XX tristate "LED support for Awinic AW20036/AW20054/AW20072/AW20108" depends on LEDS_CLASS diff --git a/drivers/leds/Makefile b/drivers/leds/Makefile index 8fdb45d5b439..1117304dfdf4 100644 --- a/drivers/leds/Makefile +++ b/drivers/leds/Makefile @@ -16,6 +16,7 @@ obj-$(CONFIG_LEDS_AN30259A) +=3D leds-an30259a.o obj-$(CONFIG_LEDS_APU) +=3D leds-apu.o obj-$(CONFIG_LEDS_ARIEL) +=3D leds-ariel.o obj-$(CONFIG_LEDS_AS3668) +=3D leds-as3668.o +obj-$(CONFIG_LEDS_ASUSEC) +=3D leds-asus-ec.o obj-$(CONFIG_LEDS_AW200XX) +=3D leds-aw200xx.o obj-$(CONFIG_LEDS_AW2013) +=3D leds-aw2013.o obj-$(CONFIG_LEDS_BCM6328) +=3D leds-bcm6328.o diff --git a/drivers/leds/leds-asus-ec.c b/drivers/leds/leds-asus-ec.c new file mode 100644 index 000000000000..5dd76c9247ee --- /dev/null +++ b/drivers/leds/leds-asus-ec.c @@ -0,0 +1,104 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * ASUS EC driver - battery LED + */ + +#include +#include +#include +#include +#include +#include +#include + +/* + * F[5] & 0x07 + * auto: brightness =3D=3D 0 + * bit 0: blink / charger on + * bit 1: amber on + * bit 2: green on + */ + +#define ASUSEC_CTL_LED_BLINK BIT_ULL(40) +#define ASUSEC_CTL_LED_AMBER BIT_ULL(41) +#define ASUSEC_CTL_LED_GREEN BIT_ULL(42) + +static void asus_ec_led_set_brightness_amber(struct led_classdev *led, + enum led_brightness brightness) +{ + const struct asusec_info *ec =3D dev_get_drvdata(led->dev->parent); + + if (brightness) + asus_ec_set_ctl_bits(ec, ASUSEC_CTL_LED_AMBER); + else + asus_ec_clear_ctl_bits(ec, ASUSEC_CTL_LED_AMBER); +} + +static void asus_ec_led_set_brightness_green(struct led_classdev *led, + enum led_brightness brightness) +{ + const struct asusec_info *ec =3D dev_get_drvdata(led->dev->parent); + + if (brightness) + asus_ec_set_ctl_bits(ec, ASUSEC_CTL_LED_GREEN); + else + asus_ec_clear_ctl_bits(ec, ASUSEC_CTL_LED_GREEN); +} + +static int asus_ec_led_probe(struct platform_device *pdev) +{ + struct asusec_info *ec =3D cell_to_ec(pdev); + struct device *dev =3D &pdev->dev; + struct led_classdev *amber_led, *green_led; + int ret; + + platform_set_drvdata(pdev, ec); + + amber_led =3D devm_kzalloc(dev, sizeof(*amber_led), GFP_KERNEL); + if (!amber_led) + return -ENOMEM; + + amber_led->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s::amber", ec->name= ); + amber_led->max_brightness =3D 1; + amber_led->flags =3D LED_CORE_SUSPENDRESUME | LED_RETAIN_AT_SHUTDOWN; + amber_led->brightness_set =3D asus_ec_led_set_brightness_amber; + + ret =3D devm_led_classdev_register(dev, amber_led); + if (ret) + return dev_err_probe(dev, ret, "failed to register amber LED\n"); + + green_led =3D devm_kzalloc(dev, sizeof(*green_led), GFP_KERNEL); + if (!green_led) + return -ENOMEM; + + green_led->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s::green", ec->name= ); + green_led->max_brightness =3D 1; + green_led->flags =3D LED_CORE_SUSPENDRESUME | LED_RETAIN_AT_SHUTDOWN; + green_led->brightness_set =3D asus_ec_led_set_brightness_green; + + ret =3D devm_led_classdev_register(dev, green_led); + if (ret) + return dev_err_probe(dev, ret, "failed to register green LED\n"); + + return 0; +} + +static const struct of_device_id asus_ec_led_match[] =3D { + { .compatible =3D "asus,ec-led" }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_ec_led_match); + +static struct platform_driver asus_ec_led_driver =3D { + .driver =3D { + .name =3D "asus-ec-led", + .of_match_table =3D asus_ec_led_match, + }, + .probe =3D asus_ec_led_probe, +}; +module_platform_driver(asus_ec_led_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's charging LED driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53D0736AB72 for ; Mon, 9 Feb 2026 10:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633878; cv=none; b=Lp+vZZArF2X2EaFl2ZugsoItZl6On/oGj+M4hF0Quu1hplMtOOBjSxE0RV1QjjkVI6o3D4TlLt6N2CcLccNhX6vqBkwFf+svnLNg6lLDdqK0JX41ebr+hQPlLMAeA1P90LDzVZ281LM+BRdGdoLwcESQxbcB+Z1eR7CDZDy7lE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633878; c=relaxed/simple; bh=FsJ+X3k1e9X8sla61EI4zubOpztm+0MUD/QW/rZ5kcI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fL52cD6Ij+5EscK51zwKqQjFxyhs9B/cPQvkHESR7RfGPKyezzpp62+GQKHC7HgUK8mEa7oeHWfSX40eZk9g78yzIPuS7WTehJDt9/b7FBkfv79gKzc1DbO31afKBOuIKebF5Ep6KL2i51TJOUZhd3He/PT7eXW40M73KvC/1Uc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IuBaKhpk; arc=none smtp.client-ip=209.85.167.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IuBaKhpk" Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-59e4a04f054so1900470e87.3 for ; Mon, 09 Feb 2026 02:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633877; x=1771238677; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cHqilh4OCO0Ejn0Cq4d6My+FDfTClRdKat9V/LZP6I4=; b=IuBaKhpkMhlFE4Ttcl0bvx9JgPcRudDCZ0GMEDR7QfRFDsLmOxx5UxANsLSbXcTTgH +NHQ26IgI5wvLmANg7DedOyHqnwUVkiiO1A/CL2Kz/X4J71qpmZk0jLypmW0GYDDfg8x R02OZGN1K1bo1+FvyNEQq8EQ7jPPG9kaJtYgFnNurVEHAhEt/PhG53rSjebJkt5gZcee L8q1aMb8mIXQiM2zICUllGjOAlivQZBzAik9E91o+dlIbWfyjOUNb1uksLWUWuInTM8c /8vWXjU9dRUglLG+S66ojN9jhlciZeD3SiSwZiETNRCAJQr6ohLSl0eszWomqnc5bA+C pjvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633877; x=1771238677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cHqilh4OCO0Ejn0Cq4d6My+FDfTClRdKat9V/LZP6I4=; b=NIRnorlFDQMUyPIcNrhJbv4SCV6kjPDs5aSBvVDZWG+YsBdkhUp6PM/4D+Tu45NNSA wKU/Zs+R5MVi7wjm0aCWRd2o6+HwXRSRTQRCqF3VEj2Jx6ljzVgk/b7uRM2BKc9HbOQi 6LQVLbuW4U5o39v8nXPExZb21Fkf+Mi9BYxF1QsOzLIl8bR/7eixWnwTxnjcIX/IhBYh 6ic9E7+VQC8fbBP1mPbdT9nJ60jPYiW6TrT4WeOWO+qOYTg2EVHL+dyrx2ZnXoufc0kH YJqdRhLwPI4c51TgNgq7m0fWNbJB9cYpfu7d9eLWnJGMmOoJmMnhXKDDgwlS9Kc4Dog9 mpKw== X-Forwarded-Encrypted: i=1; AJvYcCWXT2oGd+Uwoh/Fa8szrYjEEi6Lo9+efgELbGkPO/Ym0nq8BmmD1ZwY15YcuDxRMJD55bJxCgCWn6/e69g=@vger.kernel.org X-Gm-Message-State: AOJu0YwCPgHPYf88c3pABp9SdN+EsPH7db8xrAe7632rS83Mj9mTy73i jyJvNV4Djnsx/H0M0czQ5mv/Vokpi0h1BlcaAMBmmt3Xn+sNECkJlr0n X-Gm-Gg: AZuq6aK35GyW/NuDr9icWU65kz4y/kz1a63MpTtqMn3Yr2vRwFG5YxLUxIAyadlMvet +C7RKPJMVNDvFV7G2L+tiDlpLqGD/Z7kKFKX1R3hxA9vk5oCjnyjy2aJN7PVPVv9HTWnzVfi7wC Xzc+scp1kHDKKXlqXLBt7kxuSQOqD3axYK9jruMNl51we0NOas8ugryEWFlGRELaXvd4kVbinH7 eV1D6n0YnJrzdUPhjCBJ2KwfyHwNgsN5n5Cf9KHOFmw7R42rI2uV0RPzUNBmMVEkZbqks1wqxmo aUQ+CMzSi0jYp0GYjKn93LwQfAyhErpms9xLEUPkMBbJt5TlzqobMbek0rTIaFnOHAhUk56Vt6o M08XTh0/vwRLfLmhDxRpcleE1sAZpvuxZw8Zh0AXI8a06uSwi+/Gq1lET7WVGtBnH8Iy6m2cI9+ H7 X-Received: by 2002:a05:6512:b1d:b0:59e:aba:d1b5 with SMTP id 2adb3069b0e04-59e45152f35mr4051611e87.31.1770633876454; Mon, 09 Feb 2026 02:44:36 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:36 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 8/9] power: supply: Add driver for Asus Transformer battery Date: Mon, 9 Feb 2026 12:44:06 +0200 Message-ID: <20260209104407.116426-9-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Driver implements one battery cell per EC controller and supports reading of battery status for Asus Transformer's pad and mobile dock. Co-developed-by: Svyatoslav Ryhel Signed-off-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw --- drivers/power/supply/Kconfig | 11 + drivers/power/supply/Makefile | 1 + drivers/power/supply/asus-ec-battery.c | 283 +++++++++++++++++++++++++ 3 files changed, 295 insertions(+) create mode 100644 drivers/power/supply/asus-ec-battery.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index 81fadb0695a9..bcf6a23858be 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -122,6 +122,17 @@ config BATTERY_CHAGALL This driver can also be built as a module. If so, the module will be called chagall-battery. =20 +config BATTERY_ASUSEC + tristate "Asus Transformer's battery driver" + depends on MFD_ASUSEC + help + Say Y here to enable support APM status emulation using + battery class devices. + + This sub-driver supports battery cells found in Asus Transformer + tablets and mobile docks and controlled by special embedded + controller. + config BATTERY_CPCAP tristate "Motorola CPCAP PMIC battery driver" depends on MFD_CPCAP && IIO diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 41c400bbf022..0a2cbfa96ed9 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -22,6 +22,7 @@ obj-$(CONFIG_TEST_POWER) +=3D test_power.o obj-$(CONFIG_BATTERY_88PM860X) +=3D 88pm860x_battery.o obj-$(CONFIG_CHARGER_ADP5061) +=3D adp5061.o obj-$(CONFIG_BATTERY_ACT8945A) +=3D act8945a_charger.o +obj-$(CONFIG_BATTERY_ASUSEC) +=3D asus-ec-battery.o obj-$(CONFIG_BATTERY_AXP20X) +=3D axp20x_battery.o obj-$(CONFIG_CHARGER_AXP20X) +=3D axp20x_ac_power.o obj-$(CONFIG_BATTERY_CHAGALL) +=3D chagall-battery.o diff --git a/drivers/power/supply/asus-ec-battery.c b/drivers/power/supply/= asus-ec-battery.c new file mode 100644 index 000000000000..36ebc5093730 --- /dev/null +++ b/drivers/power/supply/asus-ec-battery.c @@ -0,0 +1,283 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASUS EC driver - battery monitoring + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define ASUSEC_BATTERY_DATA_FRESH_MSEC 5000 + +#define ASUSEC_BATTERY_DISCHARGING 0x40 +#define ASUSEC_BATTERY_FULL_CHARGED 0x20 +#define ASUSEC_BATTERY_NOT_CHARGING 0x10 + +#define TEMP_CELSIUS_OFFSET 2731 + +struct asus_ec_battery_data { + const struct asusec_info *ec; + struct power_supply *battery; + struct power_supply_desc psy_desc; + struct delayed_work poll_work; + struct mutex battery_lock; /* for data refresh */ + unsigned long batt_data_ts; + int last_state; + u8 batt_data[DOCKRAM_ENTRY_BUFSIZE]; +}; + +static int asus_ec_battery_refresh(struct asus_ec_battery_data *priv) +{ + int ret =3D 0; + + guard(mutex)(&priv->battery_lock); + + if (time_before(jiffies, priv->batt_data_ts)) + return ret; + + ret =3D asus_dockram_read(priv->ec->dockram, ASUSEC_DOCKRAM_BATT_CTL, + priv->batt_data); + if (ret < 0) + return ret; + + priv->batt_data_ts =3D jiffies + + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC); + + return ret; +} + +static enum power_supply_property asus_ec_battery_properties[] =3D { + POWER_SUPPLY_PROP_STATUS, + POWER_SUPPLY_PROP_VOLTAGE_MAX, + POWER_SUPPLY_PROP_CURRENT_MAX, + POWER_SUPPLY_PROP_TEMP, + POWER_SUPPLY_PROP_VOLTAGE_NOW, + POWER_SUPPLY_PROP_CURRENT_NOW, + POWER_SUPPLY_PROP_CAPACITY, + POWER_SUPPLY_PROP_CHARGE_NOW, + POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW, + POWER_SUPPLY_PROP_TIME_TO_FULL_NOW, + POWER_SUPPLY_PROP_PRESENT, +}; + +static const unsigned int asus_ec_battery_prop_offs[] =3D { + [POWER_SUPPLY_PROP_STATUS] =3D 1, + [POWER_SUPPLY_PROP_VOLTAGE_MAX] =3D 3, + [POWER_SUPPLY_PROP_CURRENT_MAX] =3D 5, + [POWER_SUPPLY_PROP_TEMP] =3D 7, + [POWER_SUPPLY_PROP_VOLTAGE_NOW] =3D 9, + [POWER_SUPPLY_PROP_CURRENT_NOW] =3D 11, + [POWER_SUPPLY_PROP_CAPACITY] =3D 13, + [POWER_SUPPLY_PROP_CHARGE_NOW] =3D 15, + [POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW] =3D 17, + [POWER_SUPPLY_PROP_TIME_TO_FULL_NOW] =3D 19, +}; + +static int asus_ec_battery_get_value(struct asus_ec_battery_data *priv, + enum power_supply_property psp) +{ + int ret, offs; + + if (psp >=3D ARRAY_SIZE(asus_ec_battery_prop_offs)) + return -EINVAL; + + offs =3D asus_ec_battery_prop_offs[psp]; + if (!offs) + return -EINVAL; + + ret =3D asus_ec_battery_refresh(priv); + if (ret < 0) + return ret; + + if (offs >=3D priv->batt_data[0]) + return -ENODATA; + + return get_unaligned_le16(priv->batt_data + offs); +} + +static int asus_ec_battery_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_battery_data *priv =3D power_supply_get_drvdata(psy); + int ret; + + switch (psp) { + case POWER_SUPPLY_PROP_PRESENT: + val->intval =3D 1; + break; + + default: + ret =3D asus_ec_battery_get_value(priv, psp); + if (ret < 0) + return ret; + + val->intval =3D (s16)ret; + + switch (psp) { + case POWER_SUPPLY_PROP_STATUS: + if (ret & ASUSEC_BATTERY_FULL_CHARGED) + val->intval =3D POWER_SUPPLY_STATUS_FULL; + else if (ret & ASUSEC_BATTERY_NOT_CHARGING) + val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING; + else if (ret & ASUSEC_BATTERY_DISCHARGING) + val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + val->intval =3D POWER_SUPPLY_STATUS_CHARGING; + break; + + case POWER_SUPPLY_PROP_TEMP: + val->intval -=3D TEMP_CELSIUS_OFFSET; + break; + + case POWER_SUPPLY_PROP_CHARGE_NOW: + case POWER_SUPPLY_PROP_CURRENT_NOW: + case POWER_SUPPLY_PROP_CURRENT_MAX: + case POWER_SUPPLY_PROP_VOLTAGE_NOW: + case POWER_SUPPLY_PROP_VOLTAGE_MAX: + val->intval *=3D 1000; + break; + + case POWER_SUPPLY_PROP_TIME_TO_EMPTY_NOW: + case POWER_SUPPLY_PROP_TIME_TO_FULL_NOW: + val->intval *=3D 60; + break; + + default: + break; + } + + break; + } + + return 0; +} + +static void asus_ec_battery_poll_work(struct work_struct *work) +{ + struct asus_ec_battery_data *priv =3D + container_of(work, struct asus_ec_battery_data, poll_work.work); + int state; + + state =3D asus_ec_battery_get_value(priv, POWER_SUPPLY_PROP_STATUS); + if (state < 0) + return; + + if (state & ASUSEC_BATTERY_FULL_CHARGED) + state =3D POWER_SUPPLY_STATUS_FULL; + else if (state & ASUSEC_BATTERY_DISCHARGING) + state =3D POWER_SUPPLY_STATUS_DISCHARGING; + else + state =3D POWER_SUPPLY_STATUS_CHARGING; + + if (priv->last_state !=3D state) { + priv->last_state =3D state; + power_supply_changed(priv->battery); + } + + /* continuously send uevent notification */ + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); +} + +static const struct power_supply_desc asus_ec_battery_desc =3D { + .name =3D "asus-ec-battery", + .type =3D POWER_SUPPLY_TYPE_BATTERY, + .properties =3D asus_ec_battery_properties, + .num_properties =3D ARRAY_SIZE(asus_ec_battery_properties), + .get_property =3D asus_ec_battery_get_property, + .external_power_changed =3D power_supply_changed, +}; + +static int asus_ec_battery_probe(struct platform_device *pdev) +{ + struct asus_ec_battery_data *priv; + struct device *dev =3D &pdev->dev; + struct power_supply_config cfg =3D { }; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + + mutex_init(&priv->battery_lock); + + priv->ec =3D cell_to_ec(pdev); + priv->batt_data_ts =3D jiffies - 1; + priv->last_state =3D POWER_SUPPLY_STATUS_UNKNOWN; + + cfg.fwnode =3D dev_fwnode(dev); + cfg.drv_data =3D priv; + + memcpy(&priv->psy_desc, &asus_ec_battery_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-battery", + priv->ec->name); + + priv->battery =3D devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->battery)) + return dev_err_probe(dev, PTR_ERR(priv->battery), + "Failed to register power supply\n"); + + ret =3D devm_delayed_work_autocancel(dev, &priv->poll_work, + asus_ec_battery_poll_work); + if (ret) + return ret; + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static int __maybe_unused asus_ec_battery_suspend(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + cancel_delayed_work_sync(&priv->poll_work); + + return 0; +} + +static int __maybe_unused asus_ec_battery_resume(struct device *dev) +{ + struct asus_ec_battery_data *priv =3D dev_get_drvdata(dev); + + schedule_delayed_work(&priv->poll_work, + msecs_to_jiffies(ASUSEC_BATTERY_DATA_FRESH_MSEC)); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(asus_ec_battery_pm_ops, + asus_ec_battery_suspend, asus_ec_battery_resume); + +static const struct of_device_id asus_ec_battery_match[] =3D { + { .compatible =3D "asus,ec-battery" }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_ec_battery_match); + +static struct platform_driver asus_ec_battery_driver =3D { + .driver =3D { + .name =3D "asus-ec-battery", + .of_match_table =3D asus_ec_battery_match, + .pm =3D &asus_ec_battery_pm_ops, + }, + .probe =3D asus_ec_battery_probe, +}; +module_platform_driver(asus_ec_battery_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_AUTHOR("Svyatoslav Ryhel "); +MODULE_DESCRIPTION("ASUS Transformer's battery driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0 From nobody Mon Feb 9 23:01:15 2026 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9728736B047 for ; Mon, 9 Feb 2026 10:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633879; cv=none; b=bYKNRXnQaHFmvfZDSj0FnLBxEE8RDU72pXDSfeqR+Pm1rRTDLqbOy99C994WYSScEclqVsWVpYQqjRcW6DlcrS5TkG64nTn7PeISoZL1I8ejD6OxVCnt0in9hpjkCcd3X8wPwJQ9qogt7FaM9cDX3R/6lPsDGbX/cEpPTWdCbY4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633879; c=relaxed/simple; bh=k7KRvNMoe4RCXdyS7KBOhLVUnIAHbOo5C9BcfOqLyNg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JmZQwjY0WDZ49YMhe+tvSqKJaU/NjbC9KsznKHj/8UQ+vYi6eIp6zT7oaRi1BZRDm0s06zGk5kC6rLgwtDbwf1TOJBluxxQGbo6ITEx8XA6qnkIoC1t8zk0d7t1ykZFh/2OvOwUhgqIcKAA3KQICDEIC4ADDnI7v4fwW+tDD88A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gM3bS39W; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gM3bS39W" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-59e4993dff5so1979878e87.3 for ; Mon, 09 Feb 2026 02:44:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633878; x=1771238678; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KaZhNgZQVw9D9Ed/1KFIESjeSdNz3uuFn8/CvSdtQc0=; b=gM3bS39WMYGMqD9XN2AH9ZAnkr7u2GFXk2xFRa2h10fRRJ/7Qy+uX2H/e5uXSmDe3u E1TXP2k47E/75WPlDf2c8qsuKZ9Bt95x1CREAiNEq3lu4TE6PkrRt5N9f6/tSMDDLA3O e81X4p2HTFa802S2X21zCY/z4IC9RWg+fydxIEepc7IYNiLvxXfWoNEZuaKuGYzgPyJC wPfJseFZAuLPEE9myAC4G6J5KrmlfG7/dhJlWXxITCEXVWb9fV9CgWmxgXMSwViIebL8 05KxWqItbVglZoiQ+Fzd5mC8A8jg+tvKzltBPYsDkJ/mlFRKQ1rm3OnHSK+TmkemWUXC 2N5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633878; x=1771238678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KaZhNgZQVw9D9Ed/1KFIESjeSdNz3uuFn8/CvSdtQc0=; b=spb+jISaiZ11LF7T2B/oJ4Dw4lUxw78qlYDauYgvNKJmI6vJbP9RKpOYmNsfIC0M2C NePi3GJKJ/BBWByhw5oxBpTIk8PK/tamKL3zIjhw6wCeOEpRt0f/xsrNvLHkvRWyfQ0Y Os+yUY4AinK5KCgkQnmdST+XZkgsfNXKhkrNcoCo14l3D8f0HzHTnpFso0t/YT4qX0lg 6c8+O2zGT2r95CZo4TTbafSlnhhaOxXQ8PtwnmKYOAFkkrGbZowr2jnc/VktQK+yEq05 gHpNdwyOm4DMoLPvIoJkja7uum/1Y6Wr2KstxUlHoA7+x7PqMupZlcG1TExON9pcUfLt F5Zg== X-Forwarded-Encrypted: i=1; AJvYcCVGCdZ/uZIYpCaIQyhXBQlF070gna84GtRepz34lsBWBtajkNIW4tAcD7YpDfZpB2h0uPtYK12SkvmnvIM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4To1kHXUbIrUDB9sX8G8WgPPSQrtCmSO/nkjblZPb0jnqM0cE 1xazYDTlAIZZjkvhFJTfBbw02a2cW2834/CO7+6bPgKfEP4PU0v0TUr9 X-Gm-Gg: AZuq6aKuiiXqg60bXOWT+HY7HiGEFCgtAihMZ9KNyTGdXHphX+lEt0RfVe1dBRN7yux M0V2xM7BiSpR+8krv7z3wMxZ4sBaP+U9W7f5CKXPCnNX+n1z12r32gahaPMHNnecHk0lbq9Bz7z SdySeHkgRlbRpvUQhSUzasLgK9gQ+FYpZSATZYuGFHjDNg7TCiSujdw5vYArryQg7P3L2daGtkV XxvtEk+tx1tuKM8eTPkzn1J4Bwu11xUrhDIGChfZdd6sQNzo71XKt9QuySWu8tFzTmh/mCnsgCH lkt47UC3PJUX6k83i1s40lcs0UYtJviti1ikPruvXKA0wQZ6JysCKbHtn3vadUZbBFmRTLzz6FY a5cmaEl3Q4WJe0MUTMvBIBiZnSJ5WQLp7xuPLntIFwKFEbbD2oPp+KuiE+rLfInkQP2CkJ688k6 E5 X-Received: by 2002:a05:6512:ad5:b0:59e:2479:7607 with SMTP id 2adb3069b0e04-59e450452efmr3115787e87.9.1770633877613; Mon, 09 Feb 2026 02:44:37 -0800 (PST) Received: from xeon ([188.163.112.51]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59e44cf6f88sm2501469e87.21.2026.02.09.02.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:44:37 -0800 (PST) From: Svyatoslav Ryhel To: Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Torokhov , Pavel Machek , Arnd Bergmann , Greg Kroah-Hartman , Sebastian Reichel , Svyatoslav Ryhel , =?UTF-8?q?Micha=C5=82=20Miros=C5=82aw?= , Ion Agorria Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH v2 9/9] power: supply: Add charger driver for Asus Transformers Date: Mon, 9 Feb 2026 12:44:07 +0200 Message-ID: <20260209104407.116426-10-clamor95@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260209104407.116426-1-clamor95@gmail.com> References: <20260209104407.116426-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable From: Micha=C5=82 Miros=C5=82aw Add support for charger detection capabilities found in the embedded controller of ASUS Transformer devices. Suggested-by: Maxim Schwalm Suggested-by: Svyatoslav Ryhel Signed-off-by: Micha=C5=82 Miros=C5=82aw Signed-off-by: Svyatoslav Ryhel --- drivers/power/supply/Kconfig | 11 ++ drivers/power/supply/Makefile | 1 + drivers/power/supply/asus-ec-charger.c | 206 +++++++++++++++++++++++++ 3 files changed, 218 insertions(+) create mode 100644 drivers/power/supply/asus-ec-charger.c diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index bcf6a23858be..43b902a12795 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -497,6 +497,17 @@ config CHARGER_88PM860X help Say Y here to enable charger for Marvell 88PM860x chip. =20 +config CHARGER_ASUSEC + tristate "Asus Transformer's charger driver" + depends on MFD_ASUSEC + help + Say Y here to enable support AC plug detection on Asus Transformer + Dock. + + This sub-driver supports charger detection mechanism found in Asus + Transformer tablets and mobile docks and controlled by special + embedded controller. + config CHARGER_PF1550 tristate "NXP PF1550 battery charger driver" depends on MFD_PF1550 diff --git a/drivers/power/supply/Makefile b/drivers/power/supply/Makefile index 0a2cbfa96ed9..b93848227f50 100644 --- a/drivers/power/supply/Makefile +++ b/drivers/power/supply/Makefile @@ -23,6 +23,7 @@ obj-$(CONFIG_BATTERY_88PM860X) +=3D 88pm860x_battery.o obj-$(CONFIG_CHARGER_ADP5061) +=3D adp5061.o obj-$(CONFIG_BATTERY_ACT8945A) +=3D act8945a_charger.o obj-$(CONFIG_BATTERY_ASUSEC) +=3D asus-ec-battery.o +obj-$(CONFIG_CHARGER_ASUSEC) +=3D asus-ec-charger.o obj-$(CONFIG_BATTERY_AXP20X) +=3D axp20x_battery.o obj-$(CONFIG_CHARGER_AXP20X) +=3D axp20x_ac_power.o obj-$(CONFIG_BATTERY_CHAGALL) +=3D chagall-battery.o diff --git a/drivers/power/supply/asus-ec-charger.c b/drivers/power/supply/= asus-ec-charger.c new file mode 100644 index 000000000000..bcf798432755 --- /dev/null +++ b/drivers/power/supply/asus-ec-charger.c @@ -0,0 +1,206 @@ +// SPDX-License-Identifier: GPL-2.0-or-later +/* + * ASUS EC driver - charger monitoring + */ + +#include +#include +#include +#include +#include +#include +#include + +struct asus_ec_charger_data { + struct notifier_block nb; + const struct asusec_info *ec; + struct power_supply *psy; + struct power_supply_desc psy_desc; +}; + +static enum power_supply_property asus_ec_charger_properties[] =3D { + POWER_SUPPLY_PROP_USB_TYPE, + POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR, + POWER_SUPPLY_PROP_ONLINE, + POWER_SUPPLY_PROP_MODEL_NAME, +}; + +static int asus_ec_charger_get_property(struct power_supply *psy, + enum power_supply_property psp, + union power_supply_propval *val) +{ + struct asus_ec_charger_data *priv =3D power_supply_get_drvdata(psy); + enum power_supply_usb_type psu; + int ret; + u64 ctl; + + ret =3D asus_ec_get_ctl(priv->ec, &ctl); + if (ret) + return ret; + + switch (ctl & (ASUSEC_CTL_FULL_POWER_SOURCE | ASUSEC_CTL_DIRECT_POWER_SOU= RCE)) { + case ASUSEC_CTL_FULL_POWER_SOURCE: + psu =3D POWER_SUPPLY_USB_TYPE_CDP; /* DOCK */ + break; + case ASUSEC_CTL_DIRECT_POWER_SOURCE: + psu =3D POWER_SUPPLY_USB_TYPE_SDP; /* USB */ + break; + case 0: + psu =3D POWER_SUPPLY_USB_TYPE_UNKNOWN; /* no power source connected */ + break; + default: + psu =3D POWER_SUPPLY_USB_TYPE_ACA; /* power adapter */ + break; + } + + switch (psp) { + case POWER_SUPPLY_PROP_ONLINE: + val->intval =3D psu !=3D POWER_SUPPLY_USB_TYPE_UNKNOWN; + return 0; + + case POWER_SUPPLY_PROP_USB_TYPE: + val->intval =3D psu; + return 0; + + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + if (ctl & ASUSEC_CTL_TEST_DISCHARGE) + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE; + else if (ctl & ASUSEC_CTL_USB_CHARGE) + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO; + else + val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE; + return 0; + + case POWER_SUPPLY_PROP_MODEL_NAME: + val->strval =3D priv->ec->model; + return 0; + + default: + return -EINVAL; + } +} + +static int asus_ec_charger_set_property(struct power_supply *psy, + enum power_supply_property psp, + const union power_supply_propval *val) +{ + struct asus_ec_charger_data *priv =3D power_supply_get_drvdata(psy); + + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + switch ((enum power_supply_charge_behaviour)val->intval) { + case POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO: + return asus_ec_update_ctl(priv->ec, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE, + ASUSEC_CTL_USB_CHARGE); + + case POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE: + return asus_ec_clear_ctl_bits(priv->ec, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE); + + case POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE: + return asus_ec_update_ctl(priv->ec, + ASUSEC_CTL_TEST_DISCHARGE | ASUSEC_CTL_USB_CHARGE, + ASUSEC_CTL_TEST_DISCHARGE); + default: + return -EINVAL; + } + + default: + return -EINVAL; + } +} + +static int asus_ec_charger_property_is_writeable(struct power_supply *psy, + enum power_supply_property psp) +{ + switch (psp) { + case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR: + return true; + default: + return false; + } +} + +static const struct power_supply_desc asus_ec_charger_desc =3D { + .name =3D "asus-ec-charger", + .type =3D POWER_SUPPLY_TYPE_USB, + .charge_behaviours =3D BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO) | + BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE) | + BIT(POWER_SUPPLY_CHARGE_BEHAVIOUR_FORCE_DISCHARGE), + .usb_types =3D BIT(POWER_SUPPLY_USB_TYPE_UNKNOWN) | + BIT(POWER_SUPPLY_USB_TYPE_SDP) | + BIT(POWER_SUPPLY_USB_TYPE_CDP) | + BIT(POWER_SUPPLY_USB_TYPE_ACA), + .properties =3D asus_ec_charger_properties, + .num_properties =3D ARRAY_SIZE(asus_ec_charger_properties), + .get_property =3D asus_ec_charger_get_property, + .set_property =3D asus_ec_charger_set_property, + .property_is_writeable =3D asus_ec_charger_property_is_writeable, + .no_thermal =3D true, +}; + +static int asus_ec_charger_notify(struct notifier_block *nb, + unsigned long action, void *data) +{ + struct asus_ec_charger_data *priv =3D + container_of(nb, struct asus_ec_charger_data, nb); + + switch (action) { + case ASUSEC_SMI_ACTION(POWER_NOTIFY): + case ASUSEC_SMI_ACTION(ADAPTER_EVENT): + power_supply_changed(priv->psy); + break; + } + + return NOTIFY_DONE; +} + +static int asus_ec_charger_probe(struct platform_device *pdev) +{ + struct asus_ec_charger_data *priv; + struct device *dev =3D &pdev->dev; + struct power_supply_config cfg =3D { }; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + platform_set_drvdata(pdev, priv); + priv->ec =3D cell_to_ec(pdev); + + cfg.fwnode =3D dev_fwnode(dev); + cfg.drv_data =3D priv; + + memcpy(&priv->psy_desc, &asus_ec_charger_desc, sizeof(priv->psy_desc)); + priv->psy_desc.name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-charger", + priv->ec->name); + + priv->psy =3D devm_power_supply_register(dev, &priv->psy_desc, &cfg); + if (IS_ERR(priv->psy)) + return dev_err_probe(dev, PTR_ERR(priv->psy), + "Failed to register power supply\n"); + + priv->nb.notifier_call =3D asus_ec_charger_notify; + + return devm_asus_ec_register_notifier(pdev, &priv->nb); +} + +static const struct of_device_id asus_ec_charger_match[] =3D { + { .compatible =3D "asus,ec-charger" }, + { } +}; +MODULE_DEVICE_TABLE(of, asus_ec_charger_match); + +static struct platform_driver asus_ec_charger_driver =3D { + .driver =3D { + .name =3D "asus-ec-charger", + .of_match_table =3D asus_ec_charger_match, + }, + .probe =3D asus_ec_charger_probe, +}; +module_platform_driver(asus_ec_charger_driver); + +MODULE_AUTHOR("Micha=C5=82 Miros=C5=82aw "); +MODULE_DESCRIPTION("ASUS Transformer Pad battery charger driver"); +MODULE_LICENSE("GPL"); --=20 2.51.0