From nobody Tue Feb 10 07:57:50 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80451368283 for ; Mon, 9 Feb 2026 10:42:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633729; cv=none; b=bT2DMz2nikqitO+t14Ut4KQZVr92SdpZDm3RM4OTSSjCJfEgB7mNOIRKK+ZD86lz3GfykP6JaAEWtyRHYJJmBa454fjHy8UHsYAJOK6sVjZEBMPxv5TYqeJPw9xbkgDR+F99kjbABNUKltMgx2aNShMPcGSQA1XdGHTKqx+qLXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770633729; c=relaxed/simple; bh=X8VRsDJSUKbzQeLVYD69jLukOlhuzFACaxjGzj9VlIo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LecAHYUDf6Kcogq2he25HAIw/WB34F3PD6/Fam3j13C9fXheWAHl3PgLEWWD8TEwH5Tu28Cl7O8MFUpqMXXgbEcgUa1TX4pmtJMxNwtKfNCjUhdjEaHRvBxBhuKOTD6eDM84qvDG5MnO7Fsm7ZPq54c8LnWtdUJaIKYLJxi3N/4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LC62rWA1; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LC62rWA1" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-436317c80f7so1103856f8f.1 for ; Mon, 09 Feb 2026 02:42:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770633728; x=1771238528; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rjZGwoGLvpD/x60R9yhO9bbOT/PRB//ibosQk+nz2+I=; b=LC62rWA1K7KciWYqJnfuHL7CJZCN+gg4p5StCucztjfd67sJmod+wEn6Nain+aRNjI dRPG0kBaOeKu9Y59+PMsJvF1GVMTbweCCc9ty5ZaRUoKlnDsbocZpR3zXcbQDLdz7PaX Rg5UJO07EneZdV3LwEHuhjYfc0yqyqQuACqHOxo9AFQdCbr0fvu4gtYC0FlAVgyVRbIG IMl3Cdzf87rsbMUZdRSg96VQEBDuTWNyp1kdIqP0VF+l2BW8m0mtude2UyWL/AqR/JP8 iHXqeIBTQBZciEDzfb7RnKBxwJCcVi0T5ivFX611F2Inh1Es7FzPH6ilB/U5CleB7LeJ n9GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770633728; x=1771238528; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rjZGwoGLvpD/x60R9yhO9bbOT/PRB//ibosQk+nz2+I=; b=DCZ4SCNj516WHA2r726tzVFALqA4o5RcYng6YCqzq1gLfspuIXtvsWriEdkVFstTkE o4Sx8BILsDWNg5VM2oXdAlH+xb9Hb5l3UT8JjIMlXrKeoBHg+DAqxEWpqjP/JBevtkcN 1jQSSnlN9PkvTV+BqMPYQp/Jq6ik89Wf/Ss0RUv1jNY/9ZEvSWKvbeb7Baio64/omARO 54KZKNQp/GoB256Dhxb9ouNM6AQWo2aGaXz9W6WkpWft9cqI37vuAAIOkUF0F031ZITa QO9m7TrUA7gkoCL0oN8eBWW1JDft8vToXP5rByRBpBPi37psQEyWaUfSCRscsGyfs4CW Z63w== X-Gm-Message-State: AOJu0YzIgL9bMgAHScY2iRATwwsOQAz+1H8+1dN0PF6TFxdwVyN3PZpM gi/P4hv2zS+GJJ/9dFFeG2JBkvImA9iqJ7oo9hO3Uw/MLiQkSqbvQUyo X-Gm-Gg: AZuq6aKdZ2QhUwOXxxaxud0dsldAZ3ezf//Sj1EsjLr/EoeB/XoAkfu4gxSzXF2VhT1 kw9/tzVmYpprUqIgn+P0VhCFaoZBBfZlXwwyAMYaOERuqmktKuAg/LQ7mfeUW1pPvCeh+1iWG41 U2IoWG4ySEW0ejWzlS+txCyVGikrnN3Lvp8g2Ukpls4tUAzpnYZNuT9GfsnUNyjNuPPKPOQjd9z 9LYH+ynjODLpVUqOOnvaP2GGuopW9pg1kupEGSB4xy7px6H30DQYpeiDY1VBSvFDzHmK0RA2w0m uIfvDZTB5lPkLnj6VTS2D6tiq0iIRmQyB9oNViaxnU162G+1U6u8/+U36/JoaruHdXMvlarN2Mw 3+B5FRZktmWDG+i642sBvUupqLwrlEVEhhfdyRJTrPlq1mMgOsmg1zmTMuKDlLDd76OaeN/aVGy Q1AHJlJtXWUK77DIjdV2iHeMONKtucEirEk4vW2zhHHbPUhs80WTs5KrhP7YYLhZmtzkU6Di0Ad mgalyuKR7PlZ6Qg/Hf6GYk2Vb0c55ioNzs= X-Received: by 2002:a05:6000:2210:b0:435:92c6:d556 with SMTP id ffacd0b85a97d-4362933ec62mr18293299f8f.16.1770633727746; Mon, 09 Feb 2026 02:42:07 -0800 (PST) Received: from iku.Home ([2a06:5906:61b:2d00:436e:8b6:a7da:63b7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436296b20fasm25962211f8f.6.2026.02.09.02.42.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 02:42:07 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Philipp Zabel , Geert Uytterhoeven , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH v3 2/6] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Date: Mon, 9 Feb 2026 10:41:16 +0000 Message-ID: <20260209104121.26172-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260209104121.26172-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260209104121.26172-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use a local struct device pointer in rzv2h_icu_probe_common() to avoid repeated dereferencing of pdev->dev. Signed-off-by: Lad Prabhakar --- v2->v3: - No change. v1->v2: - No change. --- drivers/irqchip/irq-renesas-rzv2h.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 20c0cd11ef25..766b981cf3d8 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -555,57 +555,58 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no { struct irq_domain *irq_domain, *parent_domain; struct device_node *node =3D pdev->dev.of_node; + struct device *dev =3D &pdev->dev; struct reset_control *resetn; int ret; =20 parent_domain =3D irq_find_host(parent); if (!parent_domain) { - dev_err(&pdev->dev, "cannot find parent domain\n"); + dev_err(dev, "cannot find parent domain\n"); return -ENODEV; } =20 - rzv2h_icu_data =3D devm_kzalloc(&pdev->dev, sizeof(*rzv2h_icu_data), GFP_= KERNEL); + rzv2h_icu_data =3D devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL); if (!rzv2h_icu_data) return -ENOMEM; =20 platform_set_drvdata(pdev, rzv2h_icu_data); =20 - rzv2h_icu_data->base =3D devm_of_iomap(&pdev->dev, node, 0, NULL); + rzv2h_icu_data->base =3D devm_of_iomap(dev, node, 0, NULL); if (IS_ERR(rzv2h_icu_data->base)) return PTR_ERR(rzv2h_icu_data->base); =20 ret =3D rzv2h_icu_parse_interrupts(rzv2h_icu_data, node); if (ret) { - dev_err(&pdev->dev, "cannot parse interrupts: %d\n", ret); + dev_err(dev, "cannot parse interrupts: %d\n", ret); return ret; } =20 - resetn =3D devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL); + resetn =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); if (IS_ERR(resetn)) { ret =3D PTR_ERR(resetn); - dev_err(&pdev->dev, "failed to acquire deasserted reset: %d\n", ret); + dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); return ret; } =20 - ret =3D devm_pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { - dev_err(&pdev->dev, "devm_pm_runtime_enable failed, %d\n", ret); + dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret); return ret; } =20 - ret =3D pm_runtime_resume_and_get(&pdev->dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) { - dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret); + dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret); return ret; } =20 raw_spin_lock_init(&rzv2h_icu_data->lock); =20 irq_domain =3D irq_domain_create_hierarchy(parent_domain, 0, ICU_NUM_IRQ, - dev_fwnode(&pdev->dev), &rzv2h_icu_domain_ops, + dev_fwnode(dev), &rzv2h_icu_domain_ops, rzv2h_icu_data); if (!irq_domain) { - dev_err(&pdev->dev, "failed to add irq domain\n"); + dev_err(dev, "failed to add irq domain\n"); ret =3D -ENOMEM; goto pm_put; } @@ -616,12 +617,12 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no =20 /* * coccicheck complains about a missing put_device call before returning,= but it's a false - * positive. We still need &pdev->dev after successfully returning from t= his function. + * positive. We still need dev after successfully returning from this fun= ction. */ return 0; =20 pm_put: - pm_runtime_put(&pdev->dev); + pm_runtime_put(dev); =20 return ret; } --=20 2.52.0