From nobody Tue Feb 10 06:04:32 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CABBD324B3C for ; Mon, 9 Feb 2026 09:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770629826; cv=none; b=RLLg5CTPnmcTcj8tRVdHidkQiHOL7WGSnqDuQxf8+O80nLMN7p2f9o1VzpryzTuBOvA7XA1EDLH2nYDTA2Ah4BSgd8ip1ue9n7eGCcwzQNotjEyodsbx11qT2AUplXri6IEXwV7IZQXywXq+1/xtIgRuC0EittAyCga9Vbq3A6k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770629826; c=relaxed/simple; bh=wOG+XZyfJ1ECBp3bdpMqJuYFU9m98cCaqUKQHSPHqOI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Hq5A5+9M7bEK6zYKtD5pY/aKoHAKiqdPeN/HRwRHI/jKkYdW3HJ2DtX20IQL7mmc/tVHETa+K+nMHBQdMeu35QE/ULSV1pBz/ENlH7wifZsG7TwBcJx90vKI+r5/0S2V35AXc0+Xq1r2Os9rzks0cY43sgdVkeW/LZFe9CJwLcg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DEeuIrq2; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DEeuIrq2" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-8220bd582ddso2855187b3a.2 for ; Mon, 09 Feb 2026 01:37:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770629826; x=1771234626; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q5teP0ad/u/RJjO/iZ2u1LHked4QjrPKeg2T8iSxlEY=; b=DEeuIrq22pAFomBi8i/oE8lF+pT0U41/zbI6EQpB+O5M57yDlkrthpVA5jje1pZnhm qqxTs8ydOV0gRbfYn9vMZmtKzuBJTUs31mYDCWdAEp5N0xjJAxopp1roKYMPD08C0aNs lvfumTW8sxyv+Ygy6A3cenyoNiWIl4A5mQD6/A4qUuEyotovMKkQBYycTfQhDtv4+u7n YFyJUUnZK1oYI2MQeEFmB+rzlr4YtqDs0he1n4ajp1uA+eWjYm6Z3GGq/GOiHVM4jHEo LMFqqSTvZvly2vCsC0+4JNuVgSW0gEBdREI+C9Y9hx8YxZnY9KxnXP8igUTeG2lBepaM ysMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770629826; x=1771234626; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q5teP0ad/u/RJjO/iZ2u1LHked4QjrPKeg2T8iSxlEY=; b=tadlqNUf0w4mzke1HRAEQhKQC5tOm5sRnJ+96TxcPUWxlmqWO/plh78xuvl9dCrC5E VjzsGcA5PKp1hXoYqR+nt6ceTOOetLFnlY3SIlXu7XYZQl7wPZNu4Iqdu/cojn9u1Xd/ tgTh8Jtdoxn1w+hHQXjMFB1OY8gabZy0RrdLYHEVq4Yg4zdhZZBx1dwUlNVZZtbBivIG KsNRV9YQn/BPJYtkISo0Fnml+7Fyh+YcHmv9Yknrib0xgq9v2L0aTJFtbQgt4QWzYG4f IRNaKyG8vLW0Ss0eW4gkdK54hKyFEA1FyGQMkFn6OZmBzjHBp6wFdcRpqKNYD+dPPSo3 0VfA== X-Forwarded-Encrypted: i=1; AJvYcCUQ3ya7DGfSZNL1l8Hhi65KnBj/t59JZygbDpbzFqowceQcRUdwLA9DO/52hme5viUq/MFxGKnoSJGIF/Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4/YWjCpZj3/ALw+WZWnOpn1NbAHrb6+7LS5dsvZe5qxbiv06x FAuKGUXL50ydgOubJToWTzbL7Jnz/zLRddPokEc25eHXlupOBrrUgwrn X-Gm-Gg: AZuq6aISa+1p55di3t5w7OdHeLHjZWbIVAX6eNkOEGsZZqKafgHoa7CYJtXFgeRZeVL TZHK3acHvo7sWsFq4DmJI2HaZZQVS0yHtkzKfv0/gjbwXCuoioQTabD+52+NqeOIgxuE9ApYv18 bic3nr9yzMUi012Hr/GYWnZieyTXd7gRbYrWMzWSB20RHsHcDlbsazawxEvgNy5HnuZddv0LK4M gqD+1tILajgYGe4BVscnPKDPWO5Me9jGmK9HAWMdCAszxeMO4gIblcSiXEWJEcyEOtVUDh8rYOJ w1qVcDSEJbTuo8lHq3LxLzsHnSsX73veiIv8S1povEFvAe4q3qUc0MOjoTPVjE01S/zTyEepxDu l+lm9OJsQUfZ51MipbifbrxwYEKXoes2DrmbfuTXNfRNazOvtX3xebmdTKc/KBkWfyv9B8Wvilk xo0mpcBUealR6O9p4nEXpywoue2xhC2kpOnOM= X-Received: by 2002:a05:6a00:908b:b0:823:3078:f684 with SMTP id d2e1a72fcca58-824416f2555mr10247075b3a.32.1770629825991; Mon, 09 Feb 2026 01:37:05 -0800 (PST) Received: from localhost.localdomain ([171.88.165.217]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-824418b60easm9917610b3a.55.2026.02.09.01.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 01:37:05 -0800 (PST) From: Shi-Shenghui X-Google-Original-From: Shi-Shenghui To: Frank.Li@nxp.com, vkoul@kernel.org Cc: manivannan.sadhasivam@linaro.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, brody.shi@m2semi.com, kevin.song@m2semi.com, qixiang.zhong@m2semi.com, tom.hu@m2semi.com, richard.yang@m2semi.com Subject: [PATCH v6] dmaengine: dw-edma: fix MSI data programming for multi-IRQ case Date: Mon, 9 Feb 2026 17:36:42 +0800 Message-ID: <20260209093642.273-1-brody.shi@m2semi.com> X-Mailer: git-send-email 2.49.0.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Shenghui Shi When using MSI (not MSI-X) with multiple IRQs, the MSI data value must be unique per vector to ensure correct interrupt delivery. Currently, the driver fails to increment the MSI data per vector, causing interrupts to be misrouted. Fix this by caching the base MSI data and adjusting each vector's data accordingly during IRQ setup. Fixes: e63d79d1ff04 ("dmaengine: dw-edma: Add Synopsys DesignWare eDMA IP c= ore driver") Signed-off-by: Shenghui Shi --- drivers/dma/dw-edma/dw-edma-core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-ed= ma-core.c index 8e5f7defa6b6..dccc686b7a3e 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -844,6 +844,7 @@ static int dw_edma_irq_request(struct dw_edma *dw, { struct dw_edma_chip *chip =3D dw->chip; struct device *dev =3D dw->chip->dev; + struct msi_desc *msi_desc; u32 wr_mask =3D 1; u32 rd_mask =3D 1; int i, err =3D 0; @@ -895,9 +896,15 @@ static int dw_edma_irq_request(struct dw_edma *dw, &dw->irq[i]); if (err) goto err_irq_free; + msi_desc =3D irq_get_msi_desc(irq); + if (msi_desc) { + bool is_msi; =20 - if (irq_get_msi_desc(irq)) get_cached_msi_msg(irq, &dw->irq[i].msi); + is_msi =3D msi_desc && !msi_desc->pci.msi_attrib.is_msix; + if (is_msi) + dw->irq[i].msi.data =3D dw->irq[0].msi.data + i; + } } =20 dw->nr_irqs =3D i; --=20 2.49.0.windows.1