From nobody Tue Feb 10 06:06:33 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85641327210 for ; Mon, 9 Feb 2026 09:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770627933; cv=none; b=ME6etoZCQx2IoxOh3Whx39fUHILNOqvBK1RogLijnSibYJ/Uoij/lDJF1M0/GUR+c2P60EME+gPvtPMIe2X4FQ2p8rgU4kTFCxwfOSQVOMJtscAx+sw+wVELjtTCCj6k7gHRMLFnhe7AEfsz6tXVirS6sC3IbOcKPmKl0UPB+AM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770627933; c=relaxed/simple; bh=2a0bn2zR/MAO+biU9nycQx2a+ocpDZL2IZFwlRtuu+Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=m7b5RmYmCBIFGLDGZw/mwWoLsTLbIp5YbCbbwbx/RKW/2FC/ABEHbe9NVM3Jr5BsS4CPmm1QwfEWY06CbEs0lR1+DWwggBMyQ10m9d5XsWtOlWvWwxDQkQ+C/HoIJ0CX798OYQXN/v60UkyzcYj60HUF6n4ZISpNjYA2eRuIkmQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TAf51stu; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TAf51stu" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-482f454be5bso42687075e9.0 for ; Mon, 09 Feb 2026 01:05:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770627932; x=1771232732; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bK67bz6+ZRm2fCC4bR1rHQZob0A/Zg4DSSdjRpq2kto=; b=TAf51stuq+cJWp26JtA3EC4Ljt0oCUiprTXY946nNGU1WOgIv+ZwBFxStMCxGi3rua +Fw7rPWHXFED3+hNzCgRUkjnTAIz3k42n3nTwAW+fw8FD+p3J7yeshOVn/zosSHPuhQl Dg2NqUjWkmWr3zGVLTZpo63lN/dZeEJBzk6o5i1kF2KOuwZY9rL+QyGMUKEY6UuRQOWR sGV18MF46pxZb2R5G2nkZOSQ0Il/6XgsAIBNqYJ3/mD9xawCImBcWgWVfSlGsiv51cnr SimHnTgJXSuFanpQDZ44kPFG5Gwr5OnHw/lz19Ed729KtLrRJDavYurC8uY+TIg7kAk7 iz7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770627932; x=1771232732; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bK67bz6+ZRm2fCC4bR1rHQZob0A/Zg4DSSdjRpq2kto=; b=n4lfNJwnotgLQCXgU3YRcmobJMinGWBJS/7Gh6K6x/aCjwagq+XP9VtUipRbxVgEIG rzCgxRKBujpA+xMd/twemqHuSE8YSy/0GIk06yKmZfW+O9wm7ejjs8mWTf51oNhwbsWn FqWWURfONeQryLfPu36Lzyz5dYD30cxolXKjHpQcV0UpSkA6qyP8ikvyLKeqXDFnPAQB RPjmwryp83YE/QwPD4MK7USddvB9zAWlNhO2FCxDUjwwHRVkXbe3XY0KgLqhVPzoJtP5 2vaJqMUs6tzsF8/fZ7Tfj+FlliL7+QOOBQlX9BiWbhsC6xmXPyZ/Rp6x0V2y/NBEdlG7 /L2g== X-Forwarded-Encrypted: i=1; AJvYcCVNYgUiZ7qwKbYRPXFSFKWHyWQX0qf1+QlxqIBSU+/HjmAnKSAnu6vmRRoXznNnQ328RS2W7NRaZXjEYO4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyg9CsDjDdrsb/ewYWedbzQ7MfB+GmmAn9ZTCtAYjwusRfPbl2A 6ZKSiBIpgqUtn1gevvJsVajZXfPh6f4g9u8NOdMr1Lmu3PsuvUIOpDag X-Gm-Gg: AZuq6aLBka7LSTWpnIAcmd2fIZw79Ksxv7ofrwth364g1AO6Komoxpk0vurYaZl5Tqc 9V0F+6p0jWBY9vRWQc9yqyOliNUxKQxLBVgmiA9mW2whoXkC3NTPXYzRHIzqr2B4MR7RPkaQTSm xubvEfrmmteKvKF6Ic8+qCR3sfedXDRV29zQxbCOYfjAx6DH4gFauiUziGsiDhzTTAZhTPYF/rL uEw6IAw8t8UbVC9ESpzpNmgmrQHMxII3a+o8lmWm7gBnRqyQZLpqvoGT5N78ErMxSpUf+qb4yD7 W2UmQVYvgjqRD0LfbC1EsjDAl0MqPUi+5CB3HlVQb68JR8oOl8UtWnwBujAhiBPocwpbzEH4+b1 OzfjvBXWN3MAiQYBUWjBShf0aI+dWScAgQHkJnX5FRmyAtzZ4HkGYHAjbCvbqN/jh8PGaVTM8EY eesxaSDDg= X-Received: by 2002:a05:600c:5619:b0:477:a71c:d200 with SMTP id 5b1f17b1804b1-4831791784bmr141816525e9.11.1770627931570; Mon, 09 Feb 2026 01:05:31 -0800 (PST) Received: from luca-vm.lan ([154.61.61.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483203d606fsm90335365e9.2.2026.02.09.01.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 01:05:31 -0800 (PST) From: Luca Leonardo Scorcia To: linux-mediatek@lists.infradead.org Cc: Luca Leonardo Scorcia , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] drm/mediatek: dsi: Store driver data before invoking mipi_dsi_host_register Date: Mon, 9 Feb 2026 09:05:15 +0000 Message-ID: <20260209090516.14369-1-l.scorcia@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The call to mipi_dsi_host_register triggers a callback to mtk_dsi_bind, which uses dev_get_drvdata to retrieve the mtk_dsi struct, so this structure needs to be stored inside the driver data before invoking it. As drvdata is currently uninitialized it leads to a crash when registering the DSI DRM encoder right after acquiring the mode_config.idr_mutex, blocking all subsequent DRM operations. Fixes the following crash during mediatek-drm probe (tested on Xiaomi Smart Clock x04g): Unable to handle kernel NULL pointer dereference at virtual address 0000000000000040 [...] Modules linked in: mediatek_drm(+) drm_display_helper cec drm_client_lib drm_dma_helper drm_kms_helper panel_simple [...] Call trace: drm_mode_object_add+0x58/0x98 (P) __drm_encoder_init+0x48/0x140 drm_encoder_init+0x6c/0xa0 drm_simple_encoder_init+0x20/0x34 [drm_kms_helper] mtk_dsi_bind+0x34/0x13c [mediatek_drm] component_bind_all+0x120/0x280 mtk_drm_bind+0x284/0x67c [mediatek_drm] try_to_bring_up_aggregate_device+0x23c/0x320 __component_add+0xa4/0x198 component_add+0x14/0x20 mtk_dsi_host_attach+0x78/0x100 [mediatek_drm] mipi_dsi_attach+0x2c/0x50 panel_simple_dsi_probe+0x4c/0x9c [panel_simple] mipi_dsi_drv_probe+0x1c/0x28 really_probe+0xc0/0x3dc __driver_probe_device+0x80/0x160 driver_probe_device+0x40/0x120 __device_attach_driver+0xbc/0x17c bus_for_each_drv+0x88/0xf0 __device_attach+0x9c/0x1cc device_initial_probe+0x54/0x60 bus_probe_device+0x34/0xa0 device_add+0x5b0/0x800 mipi_dsi_device_register_full+0xdc/0x16c mipi_dsi_host_register+0xc4/0x17c mtk_dsi_probe+0x10c/0x260 [mediatek_drm] platform_probe+0x5c/0xa4 really_probe+0xc0/0x3dc __driver_probe_device+0x80/0x160 driver_probe_device+0x40/0x120 __driver_attach+0xc8/0x1f8 bus_for_each_dev+0x7c/0xe0 driver_attach+0x24/0x30 bus_add_driver+0x11c/0x240 driver_register+0x68/0x130 __platform_register_drivers+0x64/0x160 mtk_drm_init+0x24/0x1000 [mediatek_drm] do_one_initcall+0x60/0x1d0 do_init_module+0x54/0x240 load_module+0x1838/0x1dc0 init_module_from_file+0xd8/0xf0 __arm64_sys_finit_module+0x1b4/0x428 invoke_syscall.constprop.0+0x48/0xc8 do_el0_svc+0x3c/0xb8 el0_svc+0x34/0xe8 el0t_64_sync_handler+0xa0/0xe4 el0t_64_sync+0x198/0x19c Code: 52800022 941004ab 2a0003f3 37f80040 (29005a80) Reviewed-by: AngeloGioacchino Del Regno ---[ end trace 0000000000000000 ]--- Signed-off-by: Luca Leonardo Scorcia --- drivers/gpu/drm/mediatek/mtk_dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/= mtk_dsi.c index 4c2983852596..2358407b8a6b 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1232,6 +1232,8 @@ static int mtk_dsi_probe(struct platform_device *pdev) =20 dsi->host.ops =3D &mtk_dsi_ops; dsi->host.dev =3D dev; + platform_set_drvdata(pdev, dsi); + ret =3D mipi_dsi_host_register(&dsi->host); if (ret < 0) return dev_err_probe(dev, ret, "Failed to register DSI host\n"); @@ -1254,8 +1256,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) =20 init_waitqueue_head(&dsi->irq_wait_queue); =20 - platform_set_drvdata(pdev, dsi); - dsi->bridge.of_node =3D dev->of_node; dsi->bridge.type =3D DRM_MODE_CONNECTOR_DSI; =20 --=20 2.43.0