From nobody Tue Feb 10 23:53:28 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5669223C4FD for ; Mon, 9 Feb 2026 05:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770615320; cv=none; b=kc2pJDNSUz0kNuls6MmQR9J4hUT+bvmEDT/pQHNKbQTOB7r1bYiX9zF17WwaF/4EE+lMGXexbmnXlkyC2QZzg8wdScgcAv+9K+WyW5JACRk/UGGcqRLHMTzwZFy/6pISXEx8y2C++dAgWJep/hWKmoHzvDDydiVe/E5b/IW6ToI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770615320; c=relaxed/simple; bh=DQToknmhPB4uKle7SJjsL8qz4bcKmzeaxNJRfEwJ5TE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=YF2jF0ZTlkS3ekEO0VOEEIRG2JLEhHyM5vJ279jglTFfn/fL3djqatjomEugMns03hW7/DaXKo5EFuqqmv0xH5pCD6IV998fTtgJLvMs0HAnZ8a1jIl0GZC5AgG4ZuAfsLVFy6TYsCcHsqj/K7H+QDy0rauDIa6IpoTi1OOx834= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L7EwS5qd; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L7EwS5qd" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-48069a48629so37364785e9.0 for ; Sun, 08 Feb 2026 21:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770615319; x=1771220119; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YO/PiduSuQrsHeimwpiI5IjM8jDW+DYLL+NZXKmBSSM=; b=L7EwS5qdXJLOQQkR8OY4Yo8UXzqB8nEZ8eeX11GKgjBB3vrwrJQB9IHSaC3rqRfV+m +fbRRzlIkXn5muGdSyfhltr3j2/IZ1iGA5ZTs5zCO3RVo6m/gWQhMxDnFTpdAFopPGX/ k0indZcFgmS6rzhPu5WVbVXnpkfMXwB6HvhI798Q0z7hAGdzb7E5ceALniPMkQSzEdSi gACwodwSMlq/24mhvZOlYZYeYhIWC0bsmHnwe0rb8PPvw2LQPqgXF41HLN6F7S+6v7U+ /6JlRAbrfaV01au0cumDCYCPQkexRLwjguLW86dy2cq+/HZdrULacvva3phflyV3bN57 i1Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770615319; x=1771220119; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YO/PiduSuQrsHeimwpiI5IjM8jDW+DYLL+NZXKmBSSM=; b=tK5B4qlJJd6kCgkhkSOPwxrHHDHdTbDkT/kDUef9XlkzEZeUAGLe1yiltZIozqaaps mDCDNKt0eNC6gtLGHS/QjVBc/UpKkrW9BllwdfrGrecM/uA4CmloFSRV0m/kMrBm1vvW G7YvqWPCx40SSTW7tEq4MFk7e9Sy9JWzm3cbYYKxv/Nr10/yxDHGbEJErtB/12XhkzB8 SZfesTsmPqXtpoQ1xBa5MkMsWdfc4RYswMuXQ8+7slAjA4o26si4SngTIuAk2fRR8vaf 1GEWYkSUk4pZh8SfM1Tu/BrqWBf3QZMD4TQU+XoFIeClD1FKWx+CEuqxY+Qr+ti15mAg GrgA== X-Forwarded-Encrypted: i=1; AJvYcCW2wIWG0SheruGy2E8DhStsy3PHzifSG+jsiwQaUvghyir7n1tgpFfW61zs3YH9XYuaTXOlhy7R6udLZ08=@vger.kernel.org X-Gm-Message-State: AOJu0YxzlmiYPbFoAZBGTjIvAv3BsK8sh/+z8qwnI4moVWhpRVWyXTDX 7zllIETaNSrBA5rTm+aa7NNOphH8IPYEQ3i+9RzR9NTcotWMdYM0xI0j X-Gm-Gg: AZuq6aImroFWP1NfqDnaoT844CbacEkUgYzaeN1ZTaHBN3HbgO8a+jK39gCXqOya7mB 15/TIRoe+SpeuzaggMy5DFFa/VW/vifx+XwTSJTvuin8sxigaRvjm9cqrhVSw4O1NPPBh3JavYM agXZuySYza1ntQbuk3nzXVcOJ/tW+7E50aodshdGjPuMhDY3ZnJ0Jjuqnjf5SyBxPkoXrvI/I45 x+6H9szgJy2agH6MwnUp1bVg5eXn/JdwGsjOUVt8MpL+wLBH11DzajSA8oEwhHj6iy+cjf665NB uU7PqUNA9YIBIfuV/Nrsl7vnJp6ELtOwtnsGCZds2Qw/IaDAKQIK/pCpw7JNLV7AY/JiJZ/3s5v 2qQjNAKHuVzlBXE2xfMvzmcdxr0mAbbihFSvH+6nb4bF/Z4EjJAv0X5uTu5X8Hzqg+Cyt1M3KHE kao8m0RwiRltcVoolkkJwd1LnQA0OeUBDRmmbfP2WIyNsAAOUDh6BHpBmfKEmwkShiXbLmVg0= X-Received: by 2002:a05:600c:8489:b0:477:c478:46d7 with SMTP id 5b1f17b1804b1-48320216cb8mr148076135e9.22.1770615318494; Sun, 08 Feb 2026 21:35:18 -0800 (PST) Received: from localhost.localdomain (80-121-54-205.adsl.highway.telekom.at. [80.121.54.205]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483203e5b63sm135762785e9.1.2026.02.08.21.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Feb 2026 21:35:18 -0800 (PST) From: Andreas Gabriel-Platschek To: alexandre.belloni@bootlin.com Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Andreas Gabriel-Platschek Subject: [PATCH] rtc: ds1390: fix number of bytes read from RTC Date: Mon, 9 Feb 2026 06:34:39 +0100 Message-ID: <20260209053439.313825-1-andi.platschek@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The spi_write_then_read() reads 8 bytes starting from DS1390_REG_SECONDS (=3D=3D 0x01), so the last byte read would already be part of the alarm (Tenths and Hundredths of Seconds) feature. However 7 bytes are engouh -- seconds (0x01), minutes (0x02), hours (0x03), day (0x04), date (0x05), month/century (0x06) and year (0x07). Signed-off-by: Andreas Gabriel-Platschek --- drivers/rtc/rtc-ds1390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c index f46428ca77cc..f7afd6bdeb4a 100644 --- a/drivers/rtc/rtc-ds1390.c +++ b/drivers/rtc/rtc-ds1390.c @@ -134,7 +134,7 @@ static int ds1390_read_time(struct device *dev, struct = rtc_time *dt) chip->txrx_buf[0] =3D DS1390_REG_SECONDS; =20 /* do the i/o */ - status =3D spi_write_then_read(spi, chip->txrx_buf, 1, chip->txrx_buf, 8); + status =3D spi_write_then_read(spi, chip->txrx_buf, 1, chip->txrx_buf, 7); if (status !=3D 0) return status; =20 --=20 2.47.3