From nobody Mon Feb 9 12:45:35 2026 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C1ED23D7CE for ; Mon, 9 Feb 2026 05:30:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770615018; cv=none; b=eeLYtLAx+q1bHxGf8aVLaofOlAI5ZU0IgC20iv7TPr9YALl6yCz0SnCtaEjlc7S653y+u5GlV7tnjR8UaZSTX7pNJGGvsmHC9ZpdmCvyEwwoa2kpY2tnkh45YyHF1ovLnviNlNI8NDv60FUelRsENVd5cBr9QjwN8ER9ZQzYtq4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770615018; c=relaxed/simple; bh=90MB2j4CgmVye0Z+2xbcqnupOoDkQTzlkenxahCSWw4=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=dXLoL5SybZ/4yVebTFZFCamkcn9BaEmft3AKR5boiNM5p+wrph6gv33BWmB2eVMSp58usyMQauMFiq9aAVM6FsCMS/LGjQ3TG/SC5S9s03yVw83MYEHO5OjxcmSJGSK9De/UCxhFpJGhw6Bbx7DNUsPPvrwgJD8ChhX0gWoRbqg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=CYllLlqH; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="CYllLlqH" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-505aaab61d9so38008461cf.0 for ; Sun, 08 Feb 2026 21:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1770615017; x=1771219817; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N61Q8cV41adr4A+NhJ034xStLnkhNVlJ60mnC0rmS0I=; b=CYllLlqHU0F76Bp5u1HsU9g65VdG0IkzCFGqJ2P9eEFBEiFnC2V0qf7g0R1r0QPEkv 9gfDWiEyNhHSLRFgReVkFE2v6smHaqcGRlOv+bsxlGf0IRl49G7gE+cHgZA3iolSBS+3 PEgfl4yJNvbrOtlUmWkfm1Vxv9TsGyKtgwktTFU6/gVfMAnZ+QiinbyPEBNC94ohIHve 0HCwCHJcRIalShPO3GAB/lBvQxw4HkA0s7YjX+/hyaeH+b72PfH7+C/ySncFF6GR0cJV xxo5FiC60bcfbyVKE3KOZqo4QWM6FjRtz6if317ERdPelFhJZTjBUqLYIcVqzd/C3xHL sDaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770615017; x=1771219817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N61Q8cV41adr4A+NhJ034xStLnkhNVlJ60mnC0rmS0I=; b=jgXaT56Q6WIP2bdrPLKII8E9nAR8H9n2tHFrLR5UadxNPpKg2dYcHctS+8s0dsgCGC IQkze/+DHJJ40mRCRw92i91bt9tgzaKsO8Hdor467ql9zHT+1JdU7RvIWrlr95On5D27 /I4afduOydvMX2Vumy6gPjHKaPp8/4suFiFEkSI/G/UvlrspCuEQjLMEx8i5qDpYeS6c Yii0CaiqEfcs8xbOMQwFLCt0RGzc4M/gSHHXiC6qWUU6i9QPg0sAlM6N+w/vD8VdUTeG moairR++H/frGUwfklUOW6sdOVobIcArrFcq/HgTh/A9AWcQIF/lmARd+gDKME2O8Okg lFfQ== X-Forwarded-Encrypted: i=1; AJvYcCVGiPEUza3jlMn6iZyXeRo4vCe4H4bt8FEk91awdVprBFub5HqfxL7Z9r47YYmtzkNKZ0YN7p2dA4/pC7w=@vger.kernel.org X-Gm-Message-State: AOJu0YwdOT3jY9BnmvQX7AbkfVK5uXCyGySXt7cbcwzhBiyIzbAg0AXl JLR2QdMioKbxAe2SGUABZ0XIQGvf2yP4u1+1Ak/1Hjf7QscHjp5RA9UWiPINUMtvLNg= X-Gm-Gg: AZuq6aLoEp36SYj7T0LJ6Zwok/p8J8BytQys9mMBvEWe7qT7B/OYdKpeZshPGpYgbhV cNjKgXQeU1ioJ8oLSFf+vk84Ib6xiWkQtrie2BcCynzbGCTkXfay9Fh5eAVXY8lItNIu9o4N5DT /Um6ucGubPJ8IRGWLKIunWMt+SJ5Hcq/+Q19p4XyhqFRFVYp+Gq4gusAUuB/Mz0n2kNCtD0cXcd mk0sJEXCGrHjE4KxOm9/ZwHiQaHZzti3lfxAToZ+goWgH/sK1IXW8odiHzaoTxvv1D+ViBNQeG/ 55QttwBs6ytC7mOvZYd2tPjSaJv84b22fkuXzXSCfWQwE/F3XQym2wQniL1gPX/npx5oAaxGfTS 31gUcU0ZQonUgNAk1clkpxDfnPZAE33gqQcVZ5wDzcXazi6oo5zt0dfdKF7Weo41RyKLz5Vhwej pDyy55owWBDKAtlbmi4FCaIKwWHfFyfgtUU8jVXL9+pPbYjwbulIhlwZF5UFFa4ZJEAecbONLfi mWLJ97+1KuglvFSI67hIGDtYgB3g3Q= X-Received: by 2002:a05:622a:13d0:b0:501:498e:5c29 with SMTP id d75a77b69052e-506399f5ed5mr134423481cf.59.1770615017536; Sun, 08 Feb 2026 21:30:17 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-50639171cd0sm69343471cf.13.2026.02.08.21.30.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Feb 2026 21:30:17 -0800 (PST) From: Ziyi Guo To: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH] net: usb: kaweth: remove TX queue manipulation in kaweth_set_rx_mode Date: Mon, 9 Feb 2026 05:30:13 +0000 Message-Id: <20260209053013.1701134-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" kaweth_set_rx_mode(), the ndo_set_rx_mode callback, calls netif_stop_queue() and netif_wake_queue(). These are TX queue flow control functions unrelated to RX multicast configuration. The premature netif_wake_queue() can re-enable TX while tx_urb is still in-flight, leading to a double usb_submit_urb() on the same URB: kaweth_start_xmit() { netif_stop_queue(); usb_submit_urb(kaweth->tx_urb); } kaweth_set_rx_mode() { netif_stop_queue(); netif_wake_queue(); // wakes TX queue before URB is done } kaweth_start_xmit() { netif_stop_queue(); usb_submit_urb(kaweth->tx_urb); // URB submitted while active } This triggers the WARN in usb_submit_urb(): "URB submitted while active" This is a similar class of bug fixed in rtl8150 by=20 commit 958baf5eaee3 ("net: usb: Remove disruptive netif_wake_queue in rtl81= 50_set_multicast") Signed-off-by: Ziyi Guo --- drivers/net/usb/kaweth.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index c9efb7df892e..406d1bd070fa 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -765,8 +765,6 @@ static void kaweth_set_rx_mode(struct net_device *net) =20 netdev_dbg(net, "Setting Rx mode to %d\n", packet_filter_bitmap); =20 - netif_stop_queue(net); - if (net->flags & IFF_PROMISC) { packet_filter_bitmap |=3D KAWETH_PACKET_FILTER_PROMISCUOUS; } @@ -775,7 +773,6 @@ static void kaweth_set_rx_mode(struct net_device *net) } =20 kaweth->packet_filter_bitmap =3D packet_filter_bitmap; - netif_wake_queue(net); } =20 /**************************************************************** --=20 2.34.1