From nobody Wed Feb 11 01:27:01 2026 Received: from v5244.v57ae4e16.euw1.send.eu.mailgun.net (v5244.v57ae4e16.euw1.send.eu.mailgun.net [161.38.204.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 000F223D7CE for ; Mon, 9 Feb 2026 04:04:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=161.38.204.244 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770609852; cv=none; b=LimQfWeF/0pWzs493HnnYwCclNT/vlX9QlwbaQNO/QkyP06e9IN5GpV9PJL2i29pbM7LRfspcluYDW1RxKhf0FZCen83nJMeTVhy/7tqfsG25BW6xM4OuCYFru+eJe+nHCXJlNql1tv8cppKSaOBr7s2SDX6JyeHa9G11US7ToU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770609852; c=relaxed/simple; bh=w5ul6MViOpfJt+Z315j6OqUJHAeVUTaHG+zQThTFf0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YfEHzoml+Vk5oJQxCP45g0Lhpb//aDDznyAqFu/zdXvoPaCbNrnIu94cggQt76LGHY5N2BJrSPKN4kichMIXG6t+bvCed7SDYiXC/rg/FLVDa7af7SXCUJdr+r8uvN+C5AXKgALBJVn2DGBr09nTp1n3oXFtyvUxnGOoZFPnm3o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=lvkasz.us; spf=pass smtp.mailfrom=lvkasz.us; dkim=pass (1024-bit key) header.d=lvkasz.us header.i=@lvkasz.us header.b=6NN3jtWo; arc=none smtp.client-ip=161.38.204.244 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=lvkasz.us Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lvkasz.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lvkasz.us header.i=@lvkasz.us header.b="6NN3jtWo" DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=lvkasz.us; q=dns/txt; s=mta; t=1770609849; x=1770617049; h=Content-Transfer-Encoding: Content-Type: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Subject: Cc: To: To: From: From: Sender: Sender; bh=HKQeOGFpMmrwu4yHYiRCmHa7Pqx2vqHzDFG/d6in2VU=; b=6NN3jtWoZ2gZ2alLbD1RMtslUsRZ3GeZv88/4ScgmblBBCxACbY5IG335lJKXy6obW0/5q9Grn9Zbpb1luIt5+l0Xvcql5LloOY/z8cM5BI5oB0aPhhHZdd3rDolYY9T4MGjPFFTspfcY0MKk3uA2lxPnxrkNKfTjdEyq6owVEk= X-Mailgun-Sid: WyI3NGI4OSIsImxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmciLCJkYzc0YiJd Received: from msi (5.185.72.109.ipv4.public.orange.pl [5.185.72.109]) by 9fd7231a5c61cbac2e381b8639e4b8fc9d01b70453e48563643f27cc8fa9d90c with SMTP id 69895cb9017cb293c926c3b2 (version=TLS1.3, cipher=TLS_AES_128_GCM_SHA256); Mon, 09 Feb 2026 04:04:09 GMT X-Mailgun-Sending-Ip: 161.38.204.244 Sender: kernel@lvkasz.us From: =?UTF-8?q?=C5=81ukasz=20Lebiedzi=C5=84ski?= To: Lee Jones Cc: Kaustabh Chakraborty , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, =?UTF-8?q?Andr=C3=A9=20Draszik?= , =?UTF-8?q?=C5=81ukasz=20Lebiedzi=C5=84ski?= Subject: [PATCH FIX] mfd: sec-irq: fix non-constant case labels in s2mu005_irq_get_reg Date: Mon, 9 Feb 2026 05:03:58 +0100 Message-ID: <20260209040358.2123413-1-kernel@lvkasz.us> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260126-s2mu005-pmic-v2-6-78f1a75f547a@disroot.org> References: <20260126-s2mu005-pmic-v2-6-78f1a75f547a@disroot.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Case labels must be compile-time constants, but the original implementation used array element values like irqf_regs[0], causing a compilation error: drivers/mfd/sec-irq.c:218:9: error: case label does not reduce to an integer constant Replace array-based case labels with explicit S2MU005_REG_* defines for all four interrupt status and mask registers, preserving the original logic. This addresses an issue in the S2MU005 PMIC support patches [1]. Link: https://lore.kernel.org/all/20260126-s2mu005-pmic-v2-6-78f1a75f547a@d= isroot.org/#Z31drivers:mfd:sec-irq.c [1] Signed-off-by: =C5=81ukasz Lebiedzi=C5=84ski --- drivers/mfd/sec-irq.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index 44a1eb074a08..73a611ba0502 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -215,9 +215,15 @@ static unsigned int s2mu005_irq_get_reg(struct regmap_= irq_chip_data *data, }; =20 switch (base) { - case irqf_regs[0]: + case S2MU005_REG_CHGR_INT1: + case S2MU005_REG_FLED_INT1: + case S2MU005_REG_MUIC_INT1: + case S2MU005_REG_MUIC_INT2: return irqf_regs[index]; - case mask_regs[0]: + case S2MU005_REG_CHGR_INT1M: + case S2MU005_REG_FLED_INT1M: + case S2MU005_REG_MUIC_INT1M: + case S2MU005_REG_MUIC_INT2M: return mask_regs[index]; } =20 --=20 2.53.0