From nobody Tue Feb 10 14:32:16 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F1E364EBF for ; Mon, 9 Feb 2026 09:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770630370; cv=none; b=dcpnPbjBTVskqlcxS/5k7iZEAWZtHSy+3T1cGwEJyM8r+IPWv6mzrDHQGyaVcEMkhh4w6l1ZysdlfIU7SRU6wvZuoXioL5Hi0rvzZH9q4toriowxN+j5nV0jhPL3K2IU4Jf9uKCDkhVCvnJfK2veGn69SU1UKey8R/1Y5l5DU/4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770630370; c=relaxed/simple; bh=IQ0e3U+S18cU6feftl6lZUy0c6+odiSJgtdVNR0dd78=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cX1RZ0bXHYYachnn1sTfcc5FEmcjmi51z8Vls3h27+3o7bKUZu/XHiGj+KOHkBWJUi4ABd+i2JU15dwGPEQHVxxmCk4wjt2xdc9QMit115sUnWanPQESnR+0MgMwcDPry0OizNrrZVY84E2CDqXudINGkd7j4wcL5wxS0y8sZ18= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=b/EGgu0y; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ftLkY7C4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="b/EGgu0y"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ftLkY7C4" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61989eXw3229571 for ; Mon, 9 Feb 2026 09:46:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J0st88zXaPvsYHpPh6Jq0JH/VbPghzPRzWWaPLmGPLk=; b=b/EGgu0y829eziZx 3mZOEM0+soOhRJFL4sZBt2BK8DKk/+o3Flq5LUdVo2ZeO0XMyNDB6sRFD8wMTJpO MzTj/7FLYkkPxMOooN7tJRU1HBSVo1LF8+i03Uf3v3P4p21IRlY86T9HShL/Npo/ rXaYrtgHAm+ND2w2IcNEXvYMbVpDGlza42sV3qeZr32fn2aMlyq8w5o4xnaRHT5j F1GkKW5R3ujNABJ1NtB0yBbfcpHnP0LSNHU+54Dju5D+mwCDaMC8OyAyzIOs8ONK FiSOLyCPaKH7o3lRxFRtEtQAhVql9g3WxVstK/DYjaltTWpEc7yS+Gvtcwk/Ss1g y6Ys/g== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c64hnm3n4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Feb 2026 09:46:09 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c6ddf336128so3557150a12.1 for ; Mon, 09 Feb 2026 01:46:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770630369; x=1771235169; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J0st88zXaPvsYHpPh6Jq0JH/VbPghzPRzWWaPLmGPLk=; b=ftLkY7C4ZKhJeuIbhumu5OB4tAnnA6qPLUQydHINYxiOvCFtVdJQFHAllWFdPrAVjk auv9w7LBqB6caVW9sXQ3Qe3ynfG/mdYTEAp7SCW9hXLKipFg9GKErQ9M59GvJKVtKAJa 9ZnKi+8B9RnaJJzKL0BswXOQgAoI8/MZPiDpUvnlQLH96OMeZc0bVZhQ7aGWSIyXnhwn kOIk+XP2KwNXDwgDHMEG7o4KYA22QmzPPPk3sp0rAStbrNygPKyuGgt8qOI55uw1birp ZWLIjUHcYyrE/lvO52coYp3zdpLmmG/iqqQbZJEKrCarE6NT4HeKOQ3F/MuCQnIfu7aI ts3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770630369; x=1771235169; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J0st88zXaPvsYHpPh6Jq0JH/VbPghzPRzWWaPLmGPLk=; b=Am6a5U8pks2A/a/xuO6Kzfa+bUSU1c8VTMHQFJIh/R7n0b0nTjtu0QLaClwPtH78Vu QFZzEl6+7ZfV6q+dbVC2FTPdGTL23UC9YPmKHRur35LLNFi/S5/jrb6Nv9Jb+UHViclB Xk27x8cEKsxpJI4DRmU2uZt0mUXHkoQwq+TFE/ivN5cY/qeKebGZlpKVBcnh9RXVUq4a 7RJ197+S+SvRCzjVjcWur/JGU9vlMYnfX1x4CpMKcXjtpbraigO/CguXzQZCPQ0CjvVj WeA6kkmNy2SMxvrZ0cLl0DSFr3rNXq4to64czbzcfN9RFWaqBblYrgMTylI1HjdzaC9H LuFw== X-Forwarded-Encrypted: i=1; AJvYcCU4eqOjxcW1+NntRKYfKT0e0TxxS7KH6sclvib0iWLG8yJgzSC85GQGtYqqoVUHzB/gXuFbreBGwU0lXWg=@vger.kernel.org X-Gm-Message-State: AOJu0YypLEqpTd2xWIM6KnufsHc7CRaAjchr5P8z3diyijwEtrv0xKO1 V/+JiAmQn5W1gHlB3STp1L7E/vmTmNQxrduizZC2Hf9Ozse/DKv5p+VtVT9lIWlLN59FnNTVXAq csYQWUHr3yY9DV9up9WttBwlZ7VEvQVa2iIoAhR+V4FiVLA87WQ3igXj0E0V0/N0eKaE= X-Gm-Gg: AZuq6aLMPhTwFTxd4kJLXSNaqh3vDC8fQwlFn3e2nB6KYLzUnZy07g81RHaPYkj/Gna 4Frf1BaOwujpZjwznd2ZFh8CZ1Nu8RY5Nr3CbCQ+xyJb1/WguWhEFuuMyGRRz0+nkrb7h9JEii7 tVb5AlY/xj2tQdCQJQyudgpLBgAF4SRiISCn4yfzfb8gJdXjY0MNTaxeJfpt8KbvqNM5G57DbRV rCILx2X60N7Ta7EecZvFHGwFOxLQzmMbTAggJzTIYXdniv0o+cW7tz+EHVtrYnvqN4aNNngVd/J fJZKxd5bY0gVCgUA17xeOr2ZxH9eszYlFGi8tlDAgUrD2W/Vq3mw4gUpsjoyBl+E/FHnEBnwz3i ZhT8QmbveKe33LL9zk4twcI2tMKO6I3KAlmhqXnB9ekb5Cxw= X-Received: by 2002:a05:6a20:a11f:b0:35f:549a:b0b3 with SMTP id adf61e73a8af0-393acffdd84mr9834180637.23.1770630369314; Mon, 09 Feb 2026 01:46:09 -0800 (PST) X-Received: by 2002:a05:6a20:a11f:b0:35f:549a:b0b3 with SMTP id adf61e73a8af0-393acffdd84mr9834156637.23.1770630368809; Mon, 09 Feb 2026 01:46:08 -0800 (PST) Received: from hu-dikshita-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a95eedbceesm76884925ad.84.2026.02.09.01.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Feb 2026 01:46:08 -0800 (PST) From: Dikshita Agarwal Date: Mon, 09 Feb 2026 15:15:25 +0530 Subject: [PATCH 1/2] media: iris: Initialize HFI ops after firmware load in core init Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260209-iris_sc7280_gen2_support-v1-1-390000a4fa39@oss.qualcomm.com> References: <20260209-iris_sc7280_gen2_support-v1-0-390000a4fa39@oss.qualcomm.com> In-Reply-To: <20260209-iris_sc7280_gen2_support-v1-0-390000a4fa39@oss.qualcomm.com> To: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Dikshita Agarwal X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1770630362; l=3249; i=dikshita.agarwal@oss.qualcomm.com; s=20240917; h=from:subject:message-id; bh=IQ0e3U+S18cU6feftl6lZUy0c6+odiSJgtdVNR0dd78=; b=s/m2RbZgyvaMTsJCwwvf6ERBbRCqWWJ7oOIm/BvcxL0zNwWSc5ufwAjM2wqiQr9BTGUQAgPgU t3Bk/H+B6InAq12sZ2wCmZCjmM4apknhz0vVEu6nguR5t0zebHGx8zG X-Developer-Key: i=dikshita.agarwal@oss.qualcomm.com; a=ed25519; pk=EEvKY6Ar1OI5SWf44FJ1Ebo1KuQEVbbf5UNPO+UHVhM= X-Proofpoint-GUID: PE0LR_l2D1Ix0Thgv4JvOquALkSRz3cM X-Proofpoint-ORIG-GUID: PE0LR_l2D1Ix0Thgv4JvOquALkSRz3cM X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA5MDA4MSBTYWx0ZWRfXyTHF3ToZymaM 3fkIbK8z582cxOvsXda9yqwI+u1bbSUFRfIclQtncyulhpxS+PBk2FpV6/JvOx0O8T8F9hCgRYY HdghGMtf4O4ErfUbK+mIfM0V4QNQYm7OAFF2qnrfbtmaEszZVr78svo6dq6kEuBx7KGmUvOXFK5 ZoLPpEa1SoZhZxwfQCS1fUmfYKcjbjtKKi5rOuPq7g+CD+A/vAqHEu7aE4P+ndq+bZ+YftJEnzh tjJWC8CQ1nVBHLerwLFZKMhC6zKq5YTC4A86H5UVOqgAN3Fl/NlROur4bJE0ZLMc+UDjFm1LxTh /jleeX2aSzJ9CeC5G5lMvZ7J/At6DU8Ot/1wRg14xTQKX/HkyJAO7eBzGrR3RGAqcKgz4kF5vux q2EWghs+/lliWbtmG3lihF8qq+AEhu3rUlHJEW+oQUlFIVLRk9SlCc43jZorau4y5/7v8DHNkeH dVvvsJZk4SQKHQi9FTg== X-Authority-Analysis: v=2.4 cv=SNlPlevH c=1 sm=1 tr=0 ts=6989ace2 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=3tfMAF2nT37deXqZlAYA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-08_05,2026-02-09_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 phishscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602090081 The HFI command/response ops were previously initialized in probe(), but we don't have firmware loaded at probe time. Since HFI is tightly coupled to firmware, initialize the HFI ops after firmware has been successfully loaded and booted. Signed-off-by: Dikshita Agarwal Reviewed-by: Bryan O'Donoghue --- drivers/media/platform/qcom/iris/iris_core.c | 2 ++ drivers/media/platform/qcom/iris/iris_hfi_common.c | 6 ++++++ drivers/media/platform/qcom/iris/iris_hfi_common.h | 1 + drivers/media/platform/qcom/iris/iris_probe.c | 2 -- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/iris/iris_core.c b/drivers/media/p= latform/qcom/iris/iris_core.c index 8406c48d635b6eba0879396ce9f9ae2292743f09..8e4cc6d6123069dea860062f017= 2f1e4b90cfc13 100644 --- a/drivers/media/platform/qcom/iris/iris_core.c +++ b/drivers/media/platform/qcom/iris/iris_core.c @@ -75,6 +75,8 @@ int iris_core_init(struct iris_core *core) if (ret) goto error_unload_fw; =20 + iris_init_hfi_ops(core); + ret =3D iris_hfi_core_init(core); if (ret) goto error_unload_fw; diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.c b/drivers/m= edia/platform/qcom/iris/iris_hfi_common.c index 92112eb16c11048e28230a2926dfb46e3163aada..bbca17edf281a11142d7582178c= d7562be053b45 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_common.c +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.c @@ -74,6 +74,12 @@ u32 iris_hfi_get_v4l2_matrix_coefficients(u32 hfi_coeffi= cients) } } =20 +void iris_init_hfi_ops(struct iris_core *core) +{ + core->iris_platform_data->init_hfi_command_ops(core); + core->iris_platform_data->init_hfi_response_ops(core); +} + int iris_hfi_core_init(struct iris_core *core) { const struct iris_hfi_command_ops *hfi_ops =3D core->hfi_ops; diff --git a/drivers/media/platform/qcom/iris/iris_hfi_common.h b/drivers/m= edia/platform/qcom/iris/iris_hfi_common.h index 3edb5ae582b49bea2e2408c4a5cfc0a742adc05f..498a08314cdeb65b4b621e2200a= ae8685f4a025b 100644 --- a/drivers/media/platform/qcom/iris/iris_hfi_common.h +++ b/drivers/media/platform/qcom/iris/iris_hfi_common.h @@ -149,6 +149,7 @@ struct hfi_subscription_params { u32 iris_hfi_get_v4l2_color_primaries(u32 hfi_primaries); u32 iris_hfi_get_v4l2_transfer_char(u32 hfi_characterstics); u32 iris_hfi_get_v4l2_matrix_coefficients(u32 hfi_coefficients); +void iris_init_hfi_ops(struct iris_core *core); int iris_hfi_core_init(struct iris_core *core); int iris_hfi_pm_suspend(struct iris_core *core); int iris_hfi_pm_resume(struct iris_core *core); diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/= platform/qcom/iris/iris_probe.c index ddaacda523ecb9990af0dd0640196223fbcc2cab..22c7b3410710328b900fc49459c= d399aa0e89b02 100644 --- a/drivers/media/platform/qcom/iris/iris_probe.c +++ b/drivers/media/platform/qcom/iris/iris_probe.c @@ -252,8 +252,6 @@ static int iris_probe(struct platform_device *pdev) disable_irq_nosync(core->irq); =20 iris_init_ops(core); - core->iris_platform_data->init_hfi_command_ops(core); - core->iris_platform_data->init_hfi_response_ops(core); =20 ret =3D iris_init_resources(core); if (ret) --=20 2.34.1