From nobody Wed Feb 11 06:53:03 2026 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E897133FE16 for ; Sun, 8 Feb 2026 22:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770588743; cv=none; b=T0rIUwEIvnxuituGSnXi/T7wCcD8kVa6juosCOf5Kl6pgwwn82DntyvAFp6GWiH51Hw0idzV5n4MXla27NXlZfm0UMyCACWaX9SAFen95dJ1x0T/rpia1T3wS3PNKotfyRxPF+xj4CPwi+O/JRP3faJyL+ao6w9MtuAJ2i45kl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770588743; c=relaxed/simple; bh=3434Rh+P7hIVnR5FrEbOerNrTX0TkzhDFEvO1sbJk9c=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HQwts0Jt7+j2+aFBfsIJ5fN7xyll67v2sQ5cndTEcvM7fSmTIJ2miGv2Xr+caMGttcDLUg9KJ8GRRWQC4b4xD+yveilhg1rOqnRjEwZfQW1HRXgrOSxq4cEOCYYIOinnYDGp+lV1tAwIEWzKF09DeDMEzXwquQFAVK15c7KW70k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aI2aYnnT; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aI2aYnnT" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7962119ff2bso20771837b3.3 for ; Sun, 08 Feb 2026 14:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770588742; x=1771193542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5u7HvU/qv5ExBJjQqEceuf5F7enjLIIjfK/O6HizMHI=; b=aI2aYnnTLxeXyKJnvARO6m7Oi2WgVhkyJdtaL3e1SRHN7rZNQUCyh4jNvhXfNcGgy1 MMhU0vIFK/NniV6AsGUH+mAp3HjWaDfhf5p7HzqzIdspGPSPhNAUQnBLbKL19wg1xLaj GsMlxutMGo08anov3F04JZaUcZLn34ach7SqnZrNpFUUDjd2dAA/BTbPDNi8LeKirv/F ZWiquMak6O5xDQolIlgCLdCyylKvY9uB/VcLfmQUmtgThXO4eQ2TeikIe+GmGTjQSnYh H3YswUPJpNjI2pvIejPw5cuYoCWjS79Vg6KwbbpAvJxrlh5SvxrSFsf80uv9Mq8RRZw1 OH5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770588742; x=1771193542; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5u7HvU/qv5ExBJjQqEceuf5F7enjLIIjfK/O6HizMHI=; b=DM/e/M07PDSCAZfQowVs2CUWBlcxt3KstowzmSp9y3uBYZR8ft+1EBy/CuhNhHAPn0 HH7fEF8oyi69mUzcv63IpS7mxDaq13IFwLZbPkoYmnoFAMy037C/UoCwazcYXhkS8wNW GnlQejhjdYDq0VviZ+QNXGRItCkZOtmup79+utx1rNe9gG/8w54FgLmD2Caa/GKyGnXf 4GZSfMy+x2YT055Uef2gspsgBA33ijREvi0GTiP04C2/jaiGnecPO4EXYRd29zUGLvd6 0H19aTEPL7rCfOYjI0rw4nynGUEfrSoOCcgLzXjU+OCQGIpGvummozT5hlkJJ+AFBQre YRJw== X-Forwarded-Encrypted: i=1; AJvYcCVjWRvjfbO2rkJX9xb5NMTMiGa4bNMnJJC27MrNlwPAWzYWU7MQLjecjNaEQCCzg+Nzws3Aik31+peKheA=@vger.kernel.org X-Gm-Message-State: AOJu0YxdaejRrqw2XXh042xLvA/yJOg1yh8AEOH4o70aXCb7EFQFcB7G nfonCaUKKTE6AvJqplEpZqM3KOSkeU3KIhUzBgJjlEpJRmGQ0fYUP+xe X-Gm-Gg: AZuq6aLJdwjkSAR+lFTLIuxwSx8TQG+GSUxTlKA0UIgKbE2O4N90UpyNazB0PqEN6yz GtluHizF5uwiRYrHLliEblPPOe0HfyVBYihfEgIn1XHOn+pwB+fbUTUlvu2RKeSbxpbqWcdbk2W bcwbexNxbzKI5kU6HuCu5EoKxHa7WpADiuPSplJRskcDwFq/JmjnVOEPW5aYEmRH5ksEOSE3efZ Z7342SDRJc2JaxWcTjFBLSwOt4DlbchQPhpNSmrT6OM3CnZhnowvCErDHm3Zqxrz4Dq+5Ofoj3i Viequ3YCYKV6+W1+pSwvrNSCOU8eaf5MTEa+YG4iWxRC25V4NkGuQpoXzIu8836AlxXqmxTdx9R sjShhJRgD9p1yR+OVjesn4z/Mq7qIyp76T3LYDisZxgFrxMMMYzTnz0r1qh1aFXaxhkt5sLIqP5 f5FDrf+6ZzHFmUoShNiG8hs1xweOc= X-Received: by 2002:a05:690c:fd1:b0:794:d639:375 with SMTP id 00721157ae682-7952aa49d4amr94286897b3.1.1770588741821; Sun, 08 Feb 2026 14:12:21 -0800 (PST) Received: from anish-GV62VR-7RF.lan ([2603:6081:24f0:35f0:dbe3:27f9:6ac3:4647]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7952a28697fsm76164317b3.50.2026.02.08.14.12.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Feb 2026 14:12:21 -0800 (PST) From: Anish Mulay To: aahringo@redhat.com, teigland@redhat.com Cc: gfs2@lists.linux.dev, linux-kernel@vger.kernel.org, Anish Mulay Subject: [PATCH] fs: dlm: use sysfs_emit() instead of snprintf() Date: Sun, 8 Feb 2026 17:12:15 -0500 Message-ID: <20260208221215.205864-1-anishm7030@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Follow the advice in Documentation/filesystems/sysfs.rst: show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. This patch replaces snprintf() with sysfs_emit() in the lockspace show functions. Signed-off-by: Anish Mulay --- fs/dlm/lockspace.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/dlm/lockspace.c b/fs/dlm/lockspace.c index ddaa76558706..23975bb394eb 100644 --- a/fs/dlm/lockspace.c +++ b/fs/dlm/lockspace.c @@ -69,7 +69,7 @@ static ssize_t dlm_event_store(struct dlm_ls *ls, const c= har *buf, size_t len) =20 static ssize_t dlm_id_show(struct dlm_ls *ls, char *buf) { - return snprintf(buf, PAGE_SIZE, "%u\n", ls->ls_global_id); + return sysfs_emit(buf, "%u\n", ls->ls_global_id); } =20 static ssize_t dlm_id_store(struct dlm_ls *ls, const char *buf, size_t len) @@ -83,7 +83,7 @@ static ssize_t dlm_id_store(struct dlm_ls *ls, const char= *buf, size_t len) =20 static ssize_t dlm_nodir_show(struct dlm_ls *ls, char *buf) { - return snprintf(buf, PAGE_SIZE, "%u\n", dlm_no_directory(ls)); + return sysfs_emit(buf, "%u\n", dlm_no_directory(ls)); } =20 static ssize_t dlm_nodir_store(struct dlm_ls *ls, const char *buf, size_t = len) @@ -101,12 +101,12 @@ static ssize_t dlm_nodir_store(struct dlm_ls *ls, con= st char *buf, size_t len) static ssize_t dlm_recover_status_show(struct dlm_ls *ls, char *buf) { uint32_t status =3D dlm_recover_status(ls); - return snprintf(buf, PAGE_SIZE, "%x\n", status); + return sysfs_emit(buf, "%x\n", status); } =20 static ssize_t dlm_recover_nodeid_show(struct dlm_ls *ls, char *buf) { - return snprintf(buf, PAGE_SIZE, "%d\n", ls->ls_recover_nodeid); + return sysfs_emit(buf, "%d\n", ls->ls_recover_nodeid); } =20 struct dlm_attr { --=20 2.43.0