From nobody Mon Feb 9 05:38:37 2026 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C9453491C2 for ; Sun, 8 Feb 2026 11:01:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548505; cv=none; b=m7X0K65ToMBVdk5efQXr3Qxu6zQOoo+QwlitTUnYLurR/IzWy0HLH3eW2Yl1a0p3U/bJtzMk7S049Vm0H2klh3MnmJOQvr05Z66zpL242v7qOx7MT/NN0JFX3OKGuoK5uXimvy/bUuhZcm8ycJFNQRqc8Ofpl2zJRhay6ijfMEk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548505; c=relaxed/simple; bh=sEemj620/keeRq2X9JE2066xG9WSWTafhmLq/Zs3mx8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j/XXeaUYxOCg7AM0zNGp/xVKGiyMG1EQdSspY73otfCkh4AAfW2yFN8MGImL5p3puWPQspnXCdVoQYjLt+oZiQRe+jjIPy97aqLxV7CbA5vDGXuex43vNLHACzSPRhbbRW9AIkXGWiudX969+TwhVsQFtMROisP6h/vkN1HBy/w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=daturDkP; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="daturDkP" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770548504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f7Dp+NsWxeJ+rFpFbz9kz0aszq8cJ/yfUGz9S9FZgg8=; b=daturDkPXQro4kIx0hRrQcb2Q6DQ1/U9b4VIYoXRwcPzZVto29yoRjK68qhPG/JCPdlKuu E8d1Yq6qThFJh6egptCHg059z8jHi6Z4eneKGezTYrZuk+TmLNasbT85zUau8024Ob8PHD +3YskKtisFMk+HpNmpkHG/KVn+SO+xY= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 08/22] staging: rtl8723bs: core: fix line lengths in rtw_wlan_util.c Date: Sun, 8 Feb 2026 12:00:57 +0100 Message-ID: <20260208110111.46642-9-luka.gejak@linux.dev> In-Reply-To: <20260208110111.46642-1-luka.gejak@linux.dev> References: <20260208110111.46642-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Break long lines exceeding 100 characters to comply with kernel coding style. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/core/rtw_wlan_util.c | 215 ++++++++++++------ 1 file changed, 140 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/stagi= ng/rtl8723bs/core/rtw_wlan_util.c index 9284657e23c2..ed8b76ca26cc 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -334,7 +334,8 @@ void r8723bs_select_channel(struct adapter *padapter, u= nsigned char channel) mutex_unlock(&(adapter_to_dvobj(padapter)->setch_mutex)); } =20 -void set_channel_bwmode(struct adapter *padapter, unsigned char channel, u= nsigned char channel_offset, unsigned short bwmode) +void set_channel_bwmode(struct adapter *padapter, unsigned char channel, + unsigned char channel_offset, unsigned short bwmode) { u8 center_ch, chnl_offset80 =3D HAL_PRIME_CHNL_OFFSET_DONT_CARE; =20 @@ -350,7 +351,9 @@ void set_channel_bwmode(struct adapter *padapter, unsig= ned char channel, unsigne rtw_set_oper_bw(padapter, bwmode); rtw_set_oper_choffset(padapter, channel_offset); =20 - rtw_hal_set_chnl_bw(padapter, center_ch, bwmode, channel_offset, chnl_off= set80); /* set center channel */ + /* set center channel */ + rtw_hal_set_chnl_bw(padapter, center_ch, bwmode, + channel_offset, chnl_offset80); =20 mutex_unlock(&(adapter_to_dvobj(padapter)->setch_mutex)); } @@ -380,10 +383,14 @@ int is_client_associated_to_ap(struct adapter *padapt= er) pmlmeext =3D &padapter->mlmeextpriv; pmlmeinfo =3D &(pmlmeext->mlmext_info); =20 - if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x= 03) =3D=3D WIFI_FW_STATION_STATE)) - return true; - else - return _FAIL; + { + bool assoc_ok =3D pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS; + bool is_station =3D (pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_STATION_STA= TE; + + if (assoc_ok && is_station) + return true; + } + return _FAIL; } =20 int is_client_associated_to_ibss(struct adapter *padapter) @@ -391,10 +398,14 @@ int is_client_associated_to_ibss(struct adapter *pada= pter) struct mlme_ext_priv *pmlmeext =3D &padapter->mlmeextpriv; struct mlme_ext_info *pmlmeinfo =3D &(pmlmeext->mlmext_info); =20 - if ((pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS) && ((pmlmeinfo->state & 0x= 03) =3D=3D WIFI_FW_ADHOC_STATE)) - return true; - else - return _FAIL; + { + bool assoc_ok =3D pmlmeinfo->state & WIFI_FW_ASSOC_SUCCESS; + bool is_adhoc =3D (pmlmeinfo->state & 0x03) =3D=3D WIFI_FW_ADHOC_STATE; + + if (assoc_ok && is_adhoc) + return true; + } + return _FAIL; } =20 int is_IBSS_empty(struct adapter *padapter) @@ -466,7 +477,7 @@ void _write_cam(struct adapter *padapter, u8 entry, u16= ctrl, u8 *mac, u8 *key) void _clear_cam_entry(struct adapter *padapter, u8 entry) { unsigned char null_sta[] =3D {0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; - unsigned char null_key[] =3D {0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0= x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}; + unsigned char null_key[16] =3D {0}; =20 _write_cam(padapter, entry, 0, null_sta, null_key); } @@ -570,62 +581,74 @@ s16 rtw_camid_alloc(struct adapter *adapter, struct s= ta_info *sta, u8 kid) =20 mlmeinfo =3D &adapter->mlmeextpriv.mlmext_info; =20 - if ((((mlmeinfo->state & 0x03) =3D=3D WIFI_FW_AP_STATE) || ((mlmeinfo->st= ate & 0x03) =3D=3D WIFI_FW_ADHOC_STATE)) - && !sta) { - /* AP/Ad-hoc mode group key: static alloction to default key by key ID */ - if (kid > 3) { - netdev_dbg(adapter->pnetdev, - FUNC_ADPT_FMT " group key with invalid key id:%u\n", - FUNC_ADPT_ARG(adapter), kid); - rtw_warn_on(1); - goto bitmap_handle; - } - - cam_id =3D kid; - } else { - int i; - u8 *addr =3D sta ? sta->hwaddr : NULL; + { + u8 state =3D mlmeinfo->state & 0x03; + bool is_ap_or_adhoc =3D (state =3D=3D WIFI_FW_AP_STATE) || + (state =3D=3D WIFI_FW_ADHOC_STATE); =20 - if (!sta) { - if (!(mlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) { - /* bypass STA mode group key setting before connected(ex:WEP) because = bssid is not ready */ + if (is_ap_or_adhoc && !sta) { + /* AP/Ad-hoc mode group key: static alloction to default key by key ID = */ + if (kid > 3) { + netdev_dbg(adapter->pnetdev, + FUNC_ADPT_FMT " group key with invalid key id:%u\n", + FUNC_ADPT_ARG(adapter), kid); + rtw_warn_on(1); goto bitmap_handle; } =20 - addr =3D get_bssid(&adapter->mlmepriv); - } + cam_id =3D kid; + } else { + int i; + u8 *addr =3D sta ? sta->hwaddr : NULL; + + if (!sta) { + if (!(mlmeinfo->state & WIFI_FW_ASSOC_SUCCESS)) { + /* + * bypass STA mode group key setting before + * connected(ex:WEP) because bssid is not ready + */ + goto bitmap_handle; + } + + addr =3D get_bssid(&adapter->mlmepriv); + } =20 - i =3D _rtw_camid_search(adapter, addr, kid); - if (i >=3D 0) { - /* Fix issue that pairwise and group key have same key id. Pairwise key= first, group key can overwirte group only(ex: rekey) */ - if (sta || _rtw_camid_is_gk(adapter, i)) - cam_id =3D i; - else - netdev_dbg(adapter->pnetdev, - FUNC_ADPT_FMT " group key id:%u the same key id as pairwise key\n", - FUNC_ADPT_ARG(adapter), kid); - goto bitmap_handle; - } + i =3D _rtw_camid_search(adapter, addr, kid); + if (i >=3D 0) { + /* + * Fix issue that pairwise and group key have same + * key id. Pairwise key first, group key can + * overwirte group only(ex: rekey) + */ + if (sta || _rtw_camid_is_gk(adapter, i)) + cam_id =3D i; + else + netdev_dbg(adapter->pnetdev, + FUNC_ADPT_FMT " grp key:%u same as pairwise\n", + FUNC_ADPT_ARG(adapter), kid); + goto bitmap_handle; + } =20 - for (i =3D 4; i < TOTAL_CAM_ENTRY; i++) - if (!(cam_ctl->bitmap & BIT(i))) - break; + for (i =3D 4; i < TOTAL_CAM_ENTRY; i++) + if (!(cam_ctl->bitmap & BIT(i))) + break; + + if (i =3D=3D TOTAL_CAM_ENTRY) { + if (sta) + netdev_dbg(adapter->pnetdev, + FUNC_ADPT_FMT " pairwise %pM id:%u no room\n", + FUNC_ADPT_ARG(adapter), + sta->hwaddr, kid); + else + netdev_dbg(adapter->pnetdev, + FUNC_ADPT_FMT " group key id:%u no room\n", + FUNC_ADPT_ARG(adapter), kid); + rtw_warn_on(1); + goto bitmap_handle; + } =20 - if (i =3D=3D TOTAL_CAM_ENTRY) { - if (sta) - netdev_dbg(adapter->pnetdev, - FUNC_ADPT_FMT " pairwise key with %pM id:%u no room\n", - FUNC_ADPT_ARG(adapter), - sta->hwaddr, kid); - else - netdev_dbg(adapter->pnetdev, - FUNC_ADPT_FMT " group key id:%u no room\n", - FUNC_ADPT_ARG(adapter), kid); - rtw_warn_on(1); - goto bitmap_handle; + cam_id =3D i; } - - cam_id =3D i; } =20 bitmap_handle: @@ -1135,9 +1158,14 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *= pframe, u32 packet_len) if (!bssid) return true; =20 - if ((pmlmepriv->timeBcnInfoChkStart !=3D 0) && (jiffies_to_msecs(jiffies = - pmlmepriv->timeBcnInfoChkStart) > DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIO= D_IN_MS)) { - pmlmepriv->timeBcnInfoChkStart =3D 0; - pmlmepriv->NumOfBcnInfoChkFail =3D 0; + if (pmlmepriv->timeBcnInfoChkStart !=3D 0) { + unsigned long elapsed; + + elapsed =3D jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart); + if (elapsed > DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS) { + pmlmepriv->timeBcnInfoChkStart =3D 0; + pmlmepriv->NumOfBcnInfoChkFail =3D 0; + } } =20 subtype =3D GetFrameSubType(pframe) >> 4; @@ -1153,7 +1181,12 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *= pframe, u32 packet_len) =20 /* check bw and channel offset */ /* parsing HT_CAP_IE */ - p =3D rtw_get_ie(bssid->ies + _FIXED_IE_LENGTH_, WLAN_EID_HT_CAPABILITY, = &len, bssid->ie_length - _FIXED_IE_LENGTH_); + { + u8 *ies =3D bssid->ies + _FIXED_IE_LENGTH_; + uint ie_len =3D bssid->ie_length - _FIXED_IE_LENGTH_; + + p =3D rtw_get_ie(ies, WLAN_EID_HT_CAPABILITY, &len, ie_len); + } if (p && len > 0) { pht_cap =3D (struct ieee80211_ht_cap *)(p + 2); ht_cap_info =3D le16_to_cpu(pht_cap->cap_info); @@ -1161,7 +1194,12 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *= pframe, u32 packet_len) ht_cap_info =3D 0; } /* parsing HT_INFO_IE */ - p =3D rtw_get_ie(bssid->ies + _FIXED_IE_LENGTH_, WLAN_EID_HT_OPERATION, &= len, bssid->ie_length - _FIXED_IE_LENGTH_); + { + u8 *ies =3D bssid->ies + _FIXED_IE_LENGTH_; + uint ie_len =3D bssid->ie_length - _FIXED_IE_LENGTH_; + + p =3D rtw_get_ie(ies, WLAN_EID_HT_OPERATION, &len, ie_len); + } if (p && len > 0) { pht_info =3D (struct HT_info_element *)(p + 2); ht_info_infos_0 =3D pht_info->infos[0]; @@ -1180,7 +1218,12 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *= pframe, u32 packet_len) } =20 /* Checking for channel */ - p =3D rtw_get_ie(bssid->ies + _FIXED_IE_LENGTH_, WLAN_EID_DS_PARAMS, &len= , bssid->ie_length - _FIXED_IE_LENGTH_); + { + u8 *ies =3D bssid->ies + _FIXED_IE_LENGTH_; + uint ie_len =3D bssid->ie_length - _FIXED_IE_LENGTH_; + + p =3D rtw_get_ie(ies, WLAN_EID_DS_PARAMS, &len, ie_len); + } if (p) { bcn_channel =3D *(p + 2); } else {/* In 5G, some ap do not have DSSET IE checking HT info for chann= el */ @@ -1197,7 +1240,12 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *= pframe, u32 packet_len) =20 /* checking SSID */ ssid_len =3D 0; - p =3D rtw_get_ie(bssid->ies + _FIXED_IE_LENGTH_, WLAN_EID_SSID, &len, bss= id->ie_length - _FIXED_IE_LENGTH_); + { + u8 *ies =3D bssid->ies + _FIXED_IE_LENGTH_; + uint ie_len =3D bssid->ie_length - _FIXED_IE_LENGTH_; + + p =3D rtw_get_ie(ies, WLAN_EID_SSID, &len, ie_len); + } if (p) { ssid_len =3D *(p + 1); if (ssid_len > NDIS_802_11_LENGTH_SSID) @@ -1268,11 +1316,16 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 = *pframe, u32 packet_len) =20 pmlmepriv->NumOfBcnInfoChkFail++; =20 - if ((pmlmepriv->timeBcnInfoChkStart !=3D 0) && (jiffies_to_msecs(jiffies = - pmlmepriv->timeBcnInfoChkStart) <=3D DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PE= RIOD_IN_MS) - && (pmlmepriv->NumOfBcnInfoChkFail >=3D DISCONNECT_BY_CHK_BCN_FAIL_THRES= HOLD)) { - pmlmepriv->timeBcnInfoChkStart =3D 0; - pmlmepriv->NumOfBcnInfoChkFail =3D 0; - return _FAIL; + if (pmlmepriv->timeBcnInfoChkStart !=3D 0) { + unsigned long elapsed; + + elapsed =3D jiffies_to_msecs(jiffies - pmlmepriv->timeBcnInfoChkStart); + if (elapsed <=3D DISCONNECT_BY_CHK_BCN_FAIL_OBSERV_PERIOD_IN_MS && + pmlmepriv->NumOfBcnInfoChkFail >=3D DISCONNECT_BY_CHK_BCN_FAIL_THRES= HOLD) { + pmlmepriv->timeBcnInfoChkStart =3D 0; + pmlmepriv->NumOfBcnInfoChkFail =3D 0; + return _FAIL; + } } =20 return _SUCCESS; @@ -1525,7 +1578,11 @@ void update_capinfo(struct adapter *Adapter, u16 upd= ateCap) if (pmlmeext->cur_wireless_mode & (WIRELESS_11_24N)) { pmlmeinfo->slotTime =3D SHORT_SLOT_TIME; } else if (pmlmeext->cur_wireless_mode & (WIRELESS_11G)) { - if ((updateCap & cShortSlotTime) /* && (!(pMgntInfo->pHTInfo->RT2RT_HT_= Mode & RT_HT_CAP_USE_LONG_PREAMBLE)) */) + /* + * cShortSlotTime check: + * (!(pMgntInfo->pHTInfo->RT2RT_HT_Mode & RT_HT_CAP_USE_LONG_PREAMBLE)) + */ + if (updateCap & cShortSlotTime) /* Short Slot Time */ pmlmeinfo->slotTime =3D SHORT_SLOT_TIME; else @@ -1606,9 +1663,17 @@ int update_sta_support_rate(struct adapter *padapter= , u8 *pvar_ie, uint var_ie_l memcpy(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates, pIE->data, ie_len); supportRateNum =3D ie_len; =20 - pIE =3D (struct ndis_80211_var_ie *)rtw_get_ie(pvar_ie, WLAN_EID_EXT_SUPP= _RATES, &ie_len, var_ie_len); - if (pIE && (ie_len <=3D sizeof(pmlmeinfo->FW_sta_info[cam_idx].SupportedR= ates) - supportRateNum)) - memcpy((pmlmeinfo->FW_sta_info[cam_idx].SupportedRates + supportRateNum)= , pIE->data, ie_len); + { + u8 *rates =3D pmlmeinfo->FW_sta_info[cam_idx].SupportedRates; + size_t max_ext =3D sizeof(pmlmeinfo->FW_sta_info[cam_idx].SupportedRates= ) - + supportRateNum; + + pIE =3D (struct ndis_80211_var_ie *)rtw_get_ie(pvar_ie, + WLAN_EID_EXT_SUPP_RATES, + &ie_len, var_ie_len); + if (pIE && ie_len <=3D max_ext) + memcpy(rates + supportRateNum, pIE->data, ie_len); + } =20 return _SUCCESS; } --=20 2.52.0