From nobody Mon Feb 9 05:53:06 2026 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6275346AD4 for ; Sun, 8 Feb 2026 11:01:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548504; cv=none; b=WdHgJztS1pXMBDhZCbSYeiBhh3VTQBD7SI9Q4hpmXHb4AvCMk3UMCFh3tbGbbCTN0FH72W/AWY3MCINZDp4y5+TJ1C789GvrmUXrHeDlq55wJJWFwyjzEN60UKq0UHUHXdNyly45dZe68c17A9o/DAYWISxkcm+H+P5lkm6LQYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548504; c=relaxed/simple; bh=otooM0HaLz3j7/uc1lvtqnJfrSu/hhMY81f9X2yW/es=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WNONQRIDyrY1bdptq99aYljMxmIgScj14m5Nu6KT3Yaa91AnZp1mIzWJY5xEL+YPoc/NC4M1pAn1HYhasxU9eV6uFXtMk5iSdU8NCbx825HWLOuKhwI/EVZT6XNfFpSp3YiAvBHT7GQXYw7KxWDKIqyVr+16v3usmncXiu869OM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=enCcl2XP; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="enCcl2XP" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770548502; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mJxoLnymAFaTj0pfdXZKLYayb+MzEzGAG8dpIXADiA=; b=enCcl2XPhr5xjiBDYHX/rTeZp4HF6hGlZHLSm2clQzDfgzIcedt0vTq/CYU4Ilz2QkhzmN MfX/oFa4/XlGQDefIQOPRYJwyG/FSxvMSb0l+8jAyKxWTvXre0vgKqRshqs0O0HVjV8ITC VKSivyGeXpwkaBacGPeiCmPp5jhiuU8= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 05/22] staging: rtl8723bs: convert PSTA_INFO_T to struct sta_info * Date: Sun, 8 Feb 2026 12:00:54 +0100 Message-ID: <20260208110111.46642-6-luka.gejak@linux.dev> In-Reply-To: <20260208110111.46642-1-luka.gejak@linux.dev> References: <20260208110111.46642-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Replace the vendor-specific PSTA_INFO_T typedef with the standard Linux kernel type 'struct sta_info *' throughout the driver. This addresses the second TODO item: convert any remaining unusual variable types. Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/hal/odm.c | 10 +++++----- drivers/staging/rtl8723bs/hal/odm.h | 4 ++-- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 2 +- drivers/staging/rtl8723bs/hal/odm_types.h | 3 --- 4 files changed, 8 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.c b/drivers/staging/rtl8723b= s/hal/odm.c index 639b6da2302b..a22354f728c1 100644 --- a/drivers/staging/rtl8723bs/hal/odm.c +++ b/drivers/staging/rtl8723bs/hal/odm.c @@ -141,7 +141,7 @@ static void odm_CommonInfoSelfUpdate(struct dm_odm_t *p= DM_Odm) { u8 EntryCnt =3D 0; u8 i; - PSTA_INFO_T pEntry; + struct sta_info *pEntry; =20 if (*(pDM_Odm->pBandWidth) =3D=3D ODM_BW40M) { if (*(pDM_Odm->pSecChOffset) =3D=3D 1) @@ -194,7 +194,7 @@ u32 ODM_Get_Rate_Bitmap( u8 rssi_level ) { - PSTA_INFO_T pEntry; + struct sta_info *pEntry; u32 rate_bitmap =3D 0; u8 WirelessMode; =20 @@ -264,7 +264,7 @@ static void odm_RefreshRateAdaptiveMaskCE(struct dm_odm= _t *pDM_Odm) return; =20 for (i =3D 0; i < ODM_ASSOCIATE_ENTRY_NUM; i++) { - PSTA_INFO_T pstat =3D pDM_Odm->pODM_StaInfo[i]; + struct sta_info *pstat =3D pDM_Odm->pODM_StaInfo[i]; =20 if (IS_STA_VALID(pstat)) { if (is_multicast_ether_addr(pstat->hwaddr)) /* if (psta->mac_id =3D=3D= 1) */ @@ -841,7 +841,7 @@ void ODM_CmnInfoHook(struct dm_odm_t *pDM_Odm, enum odm= _cmninfo_e CmnInfo, void /* pDM_Odm->BTCoexist =3D (bool *)pValue; */ =20 /* case ODM_CMNINFO_STA_STATUS: */ - /* pDM_Odm->pODM_StaInfo[] =3D (PSTA_INFO_T)pValue; */ + /* pDM_Odm->pODM_StaInfo[] =3D (struct sta_info *)pValue; */ /* break; */ =20 /* case ODM_CMNINFO_PHY_STATUS: */ @@ -875,7 +875,7 @@ void ODM_CmnInfoPtrArrayHook( /* Dynamic call by reference pointer. */ /* */ case ODM_CMNINFO_STA_STATUS: - pDM_Odm->pODM_StaInfo[Index] =3D (PSTA_INFO_T)pValue; + pDM_Odm->pODM_StaInfo[Index] =3D (struct sta_info *)pValue; break; /* To remove the compiler warning, must add an empty default statement to= handle the other values. */ default: diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723b= s/hal/odm.h index 38830552d5bc..856d454b0181 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h +++ b/drivers/staging/rtl8723bs/hal/odm.h @@ -853,7 +853,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_St= ructure */ /* 2 Define STA info. */ /* _ODM_STA_INFO */ /* 2012/01/12 MH For MP, we need to reduce one array pointer for default= port.?? */ - PSTA_INFO_T pODM_StaInfo[ODM_ASSOCIATE_ENTRY_NUM]; + struct sta_info *pODM_StaInfo[ODM_ASSOCIATE_ENTRY_NUM]; =20 /* */ /* 2012/02/14 MH Add to share 88E ra with other SW team. */ @@ -910,7 +910,7 @@ struct dm_odm_t { /* DM_Out_Source_Dynamic_Mechanism_St= ructure */ /* u8 binitialized; for dm_initial_gain_Multi_STA use. */ /* for Antenna diversity */ /* u8 AntDivCfg; 0:OFF , 1:ON, 2:by efuse */ - /* PSTA_INFO_T RSSI_target; */ + /* struct sta_info *RSSI_target; */ =20 bool *pbDriverStopped; bool *pbDriverIsGoingToPnpSetPowerSleep; diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging= /rtl8723bs/hal/odm_HWConfig.c index 994b8c578e7a..5bb27b872052 100644 --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c @@ -256,7 +256,7 @@ static void odm_Process_RSSIForDM( u8 RSSI_max, RSSI_min, i; u32 OFDM_pkt =3D 0; u32 Weighting =3D 0; - PSTA_INFO_T pEntry; + struct sta_info *pEntry; =20 =20 if (pPktinfo->station_id =3D=3D 0xFF) diff --git a/drivers/staging/rtl8723bs/hal/odm_types.h b/drivers/staging/rt= l8723bs/hal/odm_types.h index 8168dc14e879..893fa87852d8 100644 --- a/drivers/staging/rtl8723bs/hal/odm_types.h +++ b/drivers/staging/rtl8723bs/hal/odm_types.h @@ -33,9 +33,6 @@ enum hal_status { #define ODM_ENDIAN_TYPE ODM_ENDIAN_BIG #endif =20 - #define STA_INFO_T struct sta_info - #define PSTA_INFO_T struct sta_info * - #define SET_TX_DESC_ANTSEL_A_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE= (__pTxDesc+8, 24, 1, __Value) #define SET_TX_DESC_ANTSEL_B_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE= (__pTxDesc+8, 25, 1, __Value) #define SET_TX_DESC_ANTSEL_C_88E(__pTxDesc, __Value) SET_BITS_TO_LE_4BYTE= (__pTxDesc+28, 29, 1, __Value) --=20 2.52.0