From nobody Mon Feb 9 05:52:56 2026 Received: from out-187.mta1.migadu.com (out-187.mta1.migadu.com [95.215.58.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 341B9347FE6 for ; Sun, 8 Feb 2026 11:01:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.187 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548511; cv=none; b=ADQfJBuvtg9XnweURoEapEazV1uojJuf9R5yFlkMY78Jht/64EgQrwmMHNBEVTpZr7UOrtgzTl/7uhYvZZQfPcb8j+zEwaAUe57crSg/qiQIcZUeXXap6L7izO0sh8kOozPwpqouiM49DCK850Xn3Hss0id/sX1MiVT8Kt2y1H0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770548511; c=relaxed/simple; bh=Of2SV3j9PugSpmkX4JCoDxwPxE7qRGDpDkDbZIglqcU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=AbIFt2D8e39+ytMGkDPnpptQuSTFjSDTuSIzgpIPCwPx6QHhEvT+xTolpvwG8UTyUtlKnZA64JD0a5mRzC+8RtDrX/MjVRcamuqHrxcuNjJ3CKjJlI83gojYDduY0O32t9GisAYQ8nZ5FiDSOqCigT5DCytMl0tehwnyh3cjXqE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=R8aDMfzt; arc=none smtp.client-ip=95.215.58.187 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="R8aDMfzt" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1770548509; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RXnZ5nUvJskGmnF4x//0E2NGFgo2Mnz/g8c2tUg6Nuk=; b=R8aDMfztyeuIgOHFgz71UmXJdGlC3MeiV7C1QL2VL6gGdfxVzQcfbs8x5WfJ1bPdMuZKZK lcd4/bBkJoCYn3ofS1mv4f7RA3JyF63UpKfViT9fjvDw/4pLK2j53/YVAXbBG5rkAfFYTi 3hOYY2DtiNzoEq/OEsIzlLg7wElwKZA= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luka Gejak Subject: [PATCH v3 13/22] staging: rtl8723bs: hal: fix line lengths in rtl8723b_hal_init.c Date: Sun, 8 Feb 2026 12:01:02 +0100 Message-ID: <20260208110111.46642-14-luka.gejak@linux.dev> In-Reply-To: <20260208110111.46642-1-luka.gejak@linux.dev> References: <20260208110111.46642-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Content-Type: text/plain; charset="utf-8" From: Luka Gejak Break long lines exceeding 100 characters to comply with kernel coding style. Signed-off-by: Luka Gejak --- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 64 ++++++++++++------- 1 file changed, 41 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/st= aging/rtl8723bs/hal/rtl8723b_hal_init.c index 54dbcea89491..8505909725bc 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -58,7 +58,10 @@ static int _BlockWrite(struct adapter *padapter, void *b= uffer, u32 buffSize) remainSize_p1 =3D buffSize % blockSize_p1; =20 for (i =3D 0; i < blockCount_p1; i++) { - ret =3D rtw_write32(padapter, (FW_8723B_START_ADDRESS + i * blockSize_p1= ), *((u32 *)(bufferPtr + i * blockSize_p1))); + u32 addr =3D FW_8723B_START_ADDRESS + i * blockSize_p1; + u32 data =3D *((u32 *)(bufferPtr + i * blockSize_p1)); + + ret =3D rtw_write32(padapter, addr, data); if (ret =3D=3D _FAIL) { netdev_dbg(padapter->pnetdev, "write failed at %s %d, block:%d\n", __func__, __LINE__, i); @@ -261,27 +264,34 @@ void rtl8723b_FirmwareSelfReset(struct adapter *padap= ter) struct hal_com_data *pHalData =3D GET_HAL_DATA(padapter); u8 val; u8 Delay =3D 100; + bool old_fw; =20 - if ( - !(IS_FW_81xxC(padapter) && ((pHalData->FirmwareVersion < 0x21) || (pHalD= ata->FirmwareVersion =3D=3D 0x21 && pHalData->FirmwareSubVersion < 0x01))) - ) { /* after 88C Fw v33.1 */ - /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ - rtw_write8(padapter, REG_HMETFR+3, 0x20); + /* Check for old firmware version */ + old_fw =3D IS_FW_81xxC(padapter) && + ((pHalData->FirmwareVersion < 0x21) || + (pHalData->FirmwareVersion =3D=3D 0x21 && + pHalData->FirmwareSubVersion < 0x01)); + + if (old_fw) + return; =20 + /* after 88C Fw v33.1 */ + /* 0x1cf =3D 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */ + rtw_write8(padapter, REG_HMETFR + 3, 0x20); + + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + while (val & BIT2) { + Delay--; + if (Delay =3D=3D 0) + break; + udelay(50); val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - while (val & BIT2) { - Delay--; - if (Delay =3D=3D 0) - break; - udelay(50); - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - } + } =20 - if (Delay =3D=3D 0) { - /* force firmware reset */ - val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); - rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); - } + if (Delay =3D=3D 0) { + /* force firmware reset */ + val =3D rtw_read8(padapter, REG_SYS_FUNC_EN + 1); + rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val & (~BIT2)); } } =20 @@ -998,9 +1008,13 @@ void rtl8723b_SetBeaconRelatedRegisters(struct adapte= r *padapter) rtw_write32(padapter, REG_TCR, value32); =20 /* NOTE: Fix test chip's bug (about contention windows's randomness) */ - if (check_fwstate(&padapter->mlmepriv, WIFI_ADHOC_STATE|WIFI_ADHOC_MASTER= _STATE|WIFI_AP_STATE) =3D=3D true) { - rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); - rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); + { + u16 state_mask =3D WIFI_ADHOC_STATE | WIFI_ADHOC_MASTER_STATE | WIFI_AP_= STATE; + + if (check_fwstate(&padapter->mlmepriv, state_mask)) { + rtw_write8(padapter, REG_RXTSF_OFFSET_CCK, 0x50); + rtw_write8(padapter, REG_RXTSF_OFFSET_OFDM, 0x50); + } } =20 _BeaconFunctionEnable(padapter, true, true); @@ -1653,7 +1667,9 @@ static u8 fill_txdesc_sectype(struct pkt_attrib *patt= rib) return sectype; } =20 -static void fill_txdesc_vcs_8723b(struct adapter *padapter, struct pkt_att= rib *pattrib, struct txdesc_8723b *ptxdesc) +static void fill_txdesc_vcs_8723b(struct adapter *padapter, + struct pkt_attrib *pattrib, + struct txdesc_8723b *ptxdesc) { if (pattrib->vcs_mode) { switch (pattrib->vcs_mode) { @@ -1684,7 +1700,9 @@ static void fill_txdesc_vcs_8723b(struct adapter *pad= apter, struct pkt_attrib *p } } =20 -static void fill_txdesc_phy_8723b(struct adapter *padapter, struct pkt_att= rib *pattrib, struct txdesc_8723b *ptxdesc) +static void fill_txdesc_phy_8723b(struct adapter *padapter, + struct pkt_attrib *pattrib, + struct txdesc_8723b *ptxdesc) { if (pattrib->ht_en) { ptxdesc->data_bw =3D BWMapping_8723B(padapter, pattrib); --=20 2.52.0